[INFO] cloning repository https://github.com/caperaven/crs-jsdoc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/caperaven/crs-jsdoc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaperaven%2Fcrs-jsdoc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaperaven%2Fcrs-jsdoc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 63aab3760bc5e60304c09b4c231371ac4e551234 [INFO] linting caperaven/crs-jsdoc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcaperaven%2Fcrs-jsdoc" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/caperaven/crs-jsdoc [INFO] finished tweaking git repo https://github.com/caperaven/crs-jsdoc [INFO] tweaked toml for git repo https://github.com/caperaven/crs-jsdoc written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/caperaven/crs-jsdoc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/caperaven/crs-jsdoc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f37f31e67a0dd51212648356d356e16aba94e44447ad87ffce5018d38d3fcb86 [INFO] running `Command { std: "docker" "start" "-a" "f37f31e67a0dd51212648356d356e16aba94e44447ad87ffce5018d38d3fcb86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f37f31e67a0dd51212648356d356e16aba94e44447ad87ffce5018d38d3fcb86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f37f31e67a0dd51212648356d356e16aba94e44447ad87ffce5018d38d3fcb86", kill_on_drop: false }` [INFO] [stdout] f37f31e67a0dd51212648356d356e16aba94e44447ad87ffce5018d38d3fcb86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7846512cacc4f1b62603ac3ffa77c51f06e530f1e3ef3bf0e236db2d915d93d [INFO] running `Command { std: "docker" "start" "-a" "b7846512cacc4f1b62603ac3ffa77c51f06e530f1e3ef3bf0e236db2d915d93d", kill_on_drop: false }` [INFO] [stderr] Checking crs-jsdoc v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s [INFO] [stdout] warning: the feature `let_chains` has been stable since 1.88.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(let_chains)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `let_chains` has been stable since 1.88.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(let_chains)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/args.rs:37:42 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn get_values_from_args(args: &Vec, search_arg: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - pub(crate) fn get_values_from_args(args: &Vec, search_arg: &str) -> Option { [INFO] [stdout] 37 + pub(crate) fn get_values_from_args(args: &[String], search_arg: &str) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/markdown_generator.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - self.lines.push(line.clone()); [INFO] [stdout] 58 - return; [INFO] [stdout] 57 + self.lines.push(line.clone()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/markdown_generator.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return output.join("\r"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return output.join("\r"); [INFO] [stdout] 152 + output.join("\r") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/markdown_generator.rs:65:48 [INFO] [stdout] | [INFO] [stdout] 65 | for (_index, line) in self.lines.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 65 - for (_index, line) in self.lines.iter().enumerate() { [INFO] [stdout] 65 + for line in self.lines.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/markdown_generator.rs:69:76 [INFO] [stdout] | [INFO] [stdout] 69 | if self.current_state == MarkdownGeneratorState::Parameters && line.trim().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/markdown_generator.rs:160:13 [INFO] [stdout] | [INFO] [stdout] 160 | return MarkdownGeneratorState::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return MarkdownGeneratorState::None; [INFO] [stdout] 160 + MarkdownGeneratorState::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/markdown_generator.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | / return match status { [INFO] [stdout] 164 | | MarkdownGeneratorState::None => MarkdownGeneratorState::None, [INFO] [stdout] 165 | | MarkdownGeneratorState::Comment => MarkdownGeneratorState::Comment, [INFO] [stdout] 166 | | MarkdownGeneratorState::Parameters => MarkdownGeneratorState::Parameters, [INFO] [stdout] 167 | | MarkdownGeneratorState::Example => MarkdownGeneratorState::Example [INFO] [stdout] 168 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 ~ match status { [INFO] [stdout] 164 + MarkdownGeneratorState::None => MarkdownGeneratorState::None, [INFO] [stdout] 165 + MarkdownGeneratorState::Comment => MarkdownGeneratorState::Comment, [INFO] [stdout] 166 + MarkdownGeneratorState::Parameters => MarkdownGeneratorState::Parameters, [INFO] [stdout] 167 + MarkdownGeneratorState::Example => MarkdownGeneratorState::Example [INFO] [stdout] 168 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parameters.rs:43:59 [INFO] [stdout] | [INFO] [stdout] 43 | fn param_type_from_string(param: &mut Parameters, source: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 ~ fn param_type_from_string(param: &mut Parameters, source: &str) -> String { [INFO] [stdout] 44 | param.param_type = extract_value(source, "{", "}").to_string(); [INFO] [stdout] ... [INFO] [stdout] 47 | param.param_type = "-".to_string(); [INFO] [stdout] 48 ~ return source.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/parameters.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if source.contains("{") == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!source.contains("{")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parameters.rs:55:62 [INFO] [stdout] | [INFO] [stdout] 55 | fn param_default_from_string(param: &mut Parameters, source: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 55 ~ fn param_default_from_string(param: &mut Parameters, source: &str) -> String { [INFO] [stdout] 56 | if let None = source.find("[") { [INFO] [stdout] 57 ~ return source.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/parameters.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if let None = source.find("[") { [INFO] [stdout] | -------^^^^------------------- help: try: `if source.find("[").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - process_folder(&def, ""); [INFO] [stdout] 30 - return; [INFO] [stdout] 29 + process_folder(&def, ""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 77 | save_file(&args_def, result, file); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `args_def` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if !entry.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `entry.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | let file: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `file` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 111 ~ [INFO] [stdout] 112 | [INFO] [stdout] 113 ~ let file: String = if path.is_empty() { [INFO] [stdout] 114 ~ format!("{}\\{}", folder.clone(), entry.file_name().to_str().unwrap()) [INFO] [stdout] 115 | } [INFO] [stdout] 116 | else { [INFO] [stdout] 117 ~ format!("{}\\{}\\{}", folder.clone(), path, entry.file_name().to_str().unwrap()) [INFO] [stdout] 118 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/args.rs:37:42 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn get_values_from_args(args: &Vec, search_arg: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - pub(crate) fn get_values_from_args(args: &Vec, search_arg: &str) -> Option { [INFO] [stdout] 37 + pub(crate) fn get_values_from_args(args: &[String], search_arg: &str) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/markdown_generator.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - self.lines.push(line.clone()); [INFO] [stdout] 58 - return; [INFO] [stdout] 57 + self.lines.push(line.clone()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/markdown_generator.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return output.join("\r"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return output.join("\r"); [INFO] [stdout] 152 + output.join("\r") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/markdown_generator.rs:65:48 [INFO] [stdout] | [INFO] [stdout] 65 | for (_index, line) in self.lines.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 65 - for (_index, line) in self.lines.iter().enumerate() { [INFO] [stdout] 65 + for line in self.lines.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/markdown_generator.rs:69:76 [INFO] [stdout] | [INFO] [stdout] 69 | if self.current_state == MarkdownGeneratorState::Parameters && line.trim().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/markdown_generator.rs:160:13 [INFO] [stdout] | [INFO] [stdout] 160 | return MarkdownGeneratorState::None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return MarkdownGeneratorState::None; [INFO] [stdout] 160 + MarkdownGeneratorState::None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/markdown_generator.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | / return match status { [INFO] [stdout] 164 | | MarkdownGeneratorState::None => MarkdownGeneratorState::None, [INFO] [stdout] 165 | | MarkdownGeneratorState::Comment => MarkdownGeneratorState::Comment, [INFO] [stdout] 166 | | MarkdownGeneratorState::Parameters => MarkdownGeneratorState::Parameters, [INFO] [stdout] 167 | | MarkdownGeneratorState::Example => MarkdownGeneratorState::Example [INFO] [stdout] 168 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 ~ match status { [INFO] [stdout] 164 + MarkdownGeneratorState::None => MarkdownGeneratorState::None, [INFO] [stdout] 165 + MarkdownGeneratorState::Comment => MarkdownGeneratorState::Comment, [INFO] [stdout] 166 + MarkdownGeneratorState::Parameters => MarkdownGeneratorState::Parameters, [INFO] [stdout] 167 + MarkdownGeneratorState::Example => MarkdownGeneratorState::Example [INFO] [stdout] 168 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parameters.rs:43:59 [INFO] [stdout] | [INFO] [stdout] 43 | fn param_type_from_string(param: &mut Parameters, source: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 ~ fn param_type_from_string(param: &mut Parameters, source: &str) -> String { [INFO] [stdout] 44 | param.param_type = extract_value(source, "{", "}").to_string(); [INFO] [stdout] ... [INFO] [stdout] 47 | param.param_type = "-".to_string(); [INFO] [stdout] 48 ~ return source.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/parameters.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if source.contains("{") == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!source.contains("{")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parameters.rs:55:62 [INFO] [stdout] | [INFO] [stdout] 55 | fn param_default_from_string(param: &mut Parameters, source: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 55 ~ fn param_default_from_string(param: &mut Parameters, source: &str) -> String { [INFO] [stdout] 56 | if let None = source.find("[") { [INFO] [stdout] 57 ~ return source.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/parameters.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if let None = source.find("[") { [INFO] [stdout] | -------^^^^------------------- help: try: `if source.find("[").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - process_folder(&def, ""); [INFO] [stdout] 30 - return; [INFO] [stdout] 29 + process_folder(&def, ""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 77 | save_file(&args_def, result, file); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `args_def` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if !entry.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `entry.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | let file: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `file` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 111 ~ [INFO] [stdout] 112 | [INFO] [stdout] 113 ~ let file: String = if path.is_empty() { [INFO] [stdout] 114 ~ format!("{}\\{}", folder.clone(), entry.file_name().to_str().unwrap()) [INFO] [stdout] 115 | } [INFO] [stdout] 116 | else { [INFO] [stdout] 117 ~ format!("{}\\{}\\{}", folder.clone(), path, entry.file_name().to_str().unwrap()) [INFO] [stdout] 118 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "b7846512cacc4f1b62603ac3ffa77c51f06e530f1e3ef3bf0e236db2d915d93d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7846512cacc4f1b62603ac3ffa77c51f06e530f1e3ef3bf0e236db2d915d93d", kill_on_drop: false }` [INFO] [stdout] b7846512cacc4f1b62603ac3ffa77c51f06e530f1e3ef3bf0e236db2d915d93d