[INFO] cloning repository https://github.com/c0ldch0c0l8/ch0c0l8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/c0ldch0c0l8/ch0c0l8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fc0ldch0c0l8%2Fch0c0l8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fc0ldch0c0l8%2Fch0c0l8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 12c8d1fd1fa002c3e00d972c4f4d19368c19f25e [INFO] linting c0ldch0c0l8/ch0c0l8 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fc0ldch0c0l8%2Fch0c0l8" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/c0ldch0c0l8/ch0c0l8 [INFO] finished tweaking git repo https://github.com/c0ldch0c0l8/ch0c0l8 [INFO] tweaked toml for git repo https://github.com/c0ldch0c0l8/ch0c0l8 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/c0ldch0c0l8/ch0c0l8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/c0ldch0c0l8/ch0c0l8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded async-tungstenite v0.11.0 [INFO] [stderr] Downloaded sha-1 v0.9.6 [INFO] [stderr] Downloaded tokio-macros v1.3.0 [INFO] [stderr] Downloaded tokio v1.8.1 [INFO] [stderr] Downloaded serenity v0.10.8 [INFO] [stderr] Downloaded flate2 v1.0.20 [INFO] [stderr] Downloaded hyper v0.14.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af79c1f7d76012245b0f30ebba5bd7c827956c1ba10cdfe5f39af326ca924f9a [INFO] running `Command { std: "docker" "start" "-a" "af79c1f7d76012245b0f30ebba5bd7c827956c1ba10cdfe5f39af326ca924f9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af79c1f7d76012245b0f30ebba5bd7c827956c1ba10cdfe5f39af326ca924f9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af79c1f7d76012245b0f30ebba5bd7c827956c1ba10cdfe5f39af326ca924f9a", kill_on_drop: false }` [INFO] [stdout] af79c1f7d76012245b0f30ebba5bd7c827956c1ba10cdfe5f39af326ca924f9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 67dad18cbdef640ab95f7cdcc3debde4a2b2e0ccde8485592dceeeaff66486eb [INFO] running `Command { std: "docker" "start" "-a" "67dad18cbdef640ab95f7cdcc3debde4a2b2e0ccde8485592dceeeaff66486eb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling tokio v1.8.1 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling httparse v1.4.1 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Checking http-body v0.4.2 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking cpufeatures v0.1.5 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling async-trait v0.1.50 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Compiling serenity v0.10.8 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking typemap_rev v0.1.5 [INFO] [stderr] Checking input_buffer v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking flate2 v1.0.20 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha-1 v0.9.6 [INFO] [stderr] Checking tungstenite v0.11.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Compiling tokio-macros v1.3.0 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling pin-project-internal v1.0.7 [INFO] [stderr] Compiling async-recursion v0.3.2 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking webpki-roots v0.21.1 [INFO] [stderr] Checking webpki-roots v0.20.0 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking pin-project v1.0.7 [INFO] [stderr] Checking futures v0.3.15 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking async-tungstenite v0.11.0 [INFO] [stderr] Checking h2 v0.3.3 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking hyper v0.14.10 [INFO] [stderr] Checking hyper-rustls v0.22.1 [INFO] [stderr] Checking reqwest v0.11.4 [INFO] [stderr] Checking ch0c0l8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/command_manager.rs:29:32 [INFO] [stdout] | [INFO] [stdout] 29 | commands: commands.into_iter().map(|s| {s.to_string()}).collect::>(), [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/command_manager.rs:31:44 [INFO] [stdout] | [INFO] [stdout] 31 | required_roles: required_roles.into_iter().map(|s| {s.to_string()}).collect::>() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/command_manager.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | } else if !(msg_first_char.unwrap() == '!') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(msg_first_char.unwrap() != '!')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `msg_first_char` after checking its variant with `is_none` [INFO] [stdout] --> src/command_manager.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 41 | if msg_first_char.is_none() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = msg_first_char` [INFO] [stdout] 42 | None [INFO] [stdout] 43 | } else if !(msg_first_char.unwrap() == '!') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/command_manager.rs:29:32 [INFO] [stdout] | [INFO] [stdout] 29 | commands: commands.into_iter().map(|s| {s.to_string()}).collect::>(), [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/command_manager.rs:31:44 [INFO] [stdout] | [INFO] [stdout] 31 | required_roles: required_roles.into_iter().map(|s| {s.to_string()}).collect::>() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/command_manager.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | } else if !(msg_first_char.unwrap() == '!') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(msg_first_char.unwrap() != '!')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `msg_first_char` after checking its variant with `is_none` [INFO] [stdout] --> src/command_manager.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 41 | if msg_first_char.is_none() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = msg_first_char` [INFO] [stdout] 42 | None [INFO] [stdout] 43 | } else if !(msg_first_char.unwrap() == '!') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/command_manager.rs:38:28 [INFO] [stdout] | [INFO] [stdout] 38 | let mut msg_iter = msg.content.chars().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `msg.content.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/command_manager.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | if msg_first_char.is_none() { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 42 | | None [INFO] [stdout] 43 | | } else if !(msg_first_char.unwrap() == '!') { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/command_manager.rs:43:53 [INFO] [stdout] | [INFO] [stdout] 43 | } else if !(msg_first_char.unwrap() == '!') { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 44 | | None [INFO] [stdout] 45 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/command_manager.rs:38:28 [INFO] [stdout] | [INFO] [stdout] 38 | let mut msg_iter = msg.content.chars().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `msg.content.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/command_manager.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | if msg_first_char.is_none() { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 42 | | None [INFO] [stdout] 43 | | } else if !(msg_first_char.unwrap() == '!') { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/command_manager.rs:43:53 [INFO] [stdout] | [INFO] [stdout] 43 | } else if !(msg_first_char.unwrap() == '!') { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 44 | | None [INFO] [stdout] 45 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitWhitespace<'_>` [INFO] [stdout] --> src/command_manager.rs:89:24 [INFO] [stdout] | [INFO] [stdout] 89 | let args_len = args_str.split_whitespace().into_iter().count(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `args_str.split_whitespace()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitWhitespace<'_>` [INFO] [stdout] --> src/command_manager.rs:89:24 [INFO] [stdout] | [INFO] [stdout] 89 | let args_len = args_str.split_whitespace().into_iter().count(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `args_str.split_whitespace()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if args == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if args == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.25s [INFO] running `Command { std: "docker" "inspect" "67dad18cbdef640ab95f7cdcc3debde4a2b2e0ccde8485592dceeeaff66486eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67dad18cbdef640ab95f7cdcc3debde4a2b2e0ccde8485592dceeeaff66486eb", kill_on_drop: false }` [INFO] [stdout] 67dad18cbdef640ab95f7cdcc3debde4a2b2e0ccde8485592dceeeaff66486eb