[INFO] cloning repository https://github.com/by77er/lc3-emu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/by77er/lc3-emu" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fby77er%2Flc3-emu", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fby77er%2Flc3-emu'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d35d34fabca8411f89acc8c78f27a81cbc9e29ba [INFO] linting by77er/lc3-emu against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fby77er%2Flc3-emu" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/by77er/lc3-emu [INFO] finished tweaking git repo https://github.com/by77er/lc3-emu [INFO] tweaked toml for git repo https://github.com/by77er/lc3-emu written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/by77er/lc3-emu on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/by77er/lc3-emu already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 626a3d53990ad5c22367a513770733d22c5774acb2b62fca60ab8215482b9681 [INFO] running `Command { std: "docker" "start" "-a" "626a3d53990ad5c22367a513770733d22c5774acb2b62fca60ab8215482b9681", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "626a3d53990ad5c22367a513770733d22c5774acb2b62fca60ab8215482b9681", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "626a3d53990ad5c22367a513770733d22c5774acb2b62fca60ab8215482b9681", kill_on_drop: false }` [INFO] [stdout] 626a3d53990ad5c22367a513770733d22c5774acb2b62fca60ab8215482b9681 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d0f2f47774561439cf71061812d1c921ec7821980c17672ab14af294e51a272e [INFO] running `Command { std: "docker" "start" "-a" "d0f2f47774561439cf71061812d1c921ec7821980c17672ab14af294e51a272e", kill_on_drop: false }` [INFO] [stderr] Checking lc3-emu v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | self.psr &= 0b0_111_1000_1111_1111; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0111_1000_1111_1111` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:174:14 [INFO] [stdout] | [INFO] [stdout] 174 | self.psr &= 0b0_111_1111_1111_1111; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0111_1111_1111_1111` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:206:14 [INFO] [stdout] | [INFO] [stdout] 206 | self.psr &= 0b1111_1111_1111_11_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1_1111_1111_1111_1000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:463:25 [INFO] [stdout] | [INFO] [stdout] 463 | lc3.memory.put(0x3000, 0b0001_001_010_1_01111); // ADD R1, R2, #1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_0010_1010_1111` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:472:25 [INFO] [stdout] | [INFO] [stdout] 472 | lc3.memory.put(0x3000, 0b001_001_010_0_00_011); // ADD R1, R2, R3 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b001_0010_1000_0011` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:486:25 [INFO] [stdout] | [INFO] [stdout] 486 | lc3.memory.put(0x3000, 0b0101_001_001_1_00000); // AND R1, R1, #0 ; zero R1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0010_0110_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:496:25 [INFO] [stdout] | [INFO] [stdout] 496 | lc3.memory.put(0x3000, 0b0101_001_001_0_00_001); // AND R1, R1, R1 ; do nothing [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0010_0100_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:508:25 [INFO] [stdout] | [INFO] [stdout] 508 | lc3.memory.put(0x3000, 0b0101_001_001_1_00000); // AND R1, R1, #0 ; zero R1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0010_0110_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:509:25 [INFO] [stdout] | [INFO] [stdout] 509 | lc3.memory.put(0x3001, 0b0000_110_000000101); // BRnz #5 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1100_0000_0101` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:522:32 [INFO] [stdout] | [INFO] [stdout] 522 | lc3.memory.put(0x3000, 0b1100_000_010_000000); // JMP R2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0000_1000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:534:25 [INFO] [stdout] | [INFO] [stdout] 534 | lc3.memory.put(0x3000, 0b0100_1_11111111110); // JSR #-2 ; jump back by 2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0100_1111_1111_1110` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:543:25 [INFO] [stdout] | [INFO] [stdout] 543 | lc3.memory.put(0x3000, 0b0100_0_00_010_000000); // JSRR R2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0100_0000_1000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:556:25 [INFO] [stdout] | [INFO] [stdout] 556 | lc3.memory.put(0x3000, 0b0010_010_000000001); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0010_0100_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:568:25 [INFO] [stdout] | [INFO] [stdout] 568 | lc3.memory.put(0x3000, 0b1010_010_000000001); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1010_0100_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:578:25 [INFO] [stdout] | [INFO] [stdout] 578 | lc3.memory.put(0x3000, 0b0110_010_001_000001); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0110_0100_0100_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:590:25 [INFO] [stdout] | [INFO] [stdout] 590 | lc3.memory.put(0x3000, 0b1110_010_000000010); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1110_0100_0000_0010` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:600:25 [INFO] [stdout] | [INFO] [stdout] 600 | lc3.memory.put(0x3000, 0b1001_010_001_1_11111); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1001_0100_0111_1111` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:611:25 [INFO] [stdout] | [INFO] [stdout] 611 | lc3.memory.put(0x3000, 0b0011_010_000000001); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0011_0100_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:622:25 [INFO] [stdout] | [INFO] [stdout] 622 | lc3.memory.put(0x3000, 0b1011_010_000000001); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_0100_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:634:25 [INFO] [stdout] | [INFO] [stdout] 634 | lc3.memory.put(0x3000, 0b0111_010_001_000001); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0111_0100_0100_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:646:25 [INFO] [stdout] | [INFO] [stdout] 646 | lc3.memory.put(0x3000, 0b1111_0000_00000001); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:661:25 [INFO] [stdout] | [INFO] [stdout] 661 | lc3.memory.put(0x3001, 0b001_000_000_1_00001); // add 1 to r0 to show it continued [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b001_0000_0010_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 44 | lc3.memory.put(0x3000, 0b1110_000_000000010); // LEA R0, [PC + 2] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000_0010` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | lc3.memory.put(0x3001, 0b1111_0000_00100010); // TRAP 0x22 (PUTS) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0010_0010` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 46 | lc3.memory.put(0x3002, 0b1111_0000_00100101); // TRAP 0x25 (HALT) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0010_0101` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 78 | lc3.memory.put(0x0200, 0b1010_000_000000010); // LDI R0, [PC + 2] ; load *0x203 -> *FE00 into r0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1010_0000_0000_0010` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | lc3.memory.put(0x0201, 0b0000_010_000000001); // BRz PC - 2 ; r0 == 0, nothing, retry [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0100_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:80:28 [INFO] [stdout] | [INFO] [stdout] 80 | lc3.memory.put(0x0202, 0b0000_000_000000001); // BR PC + 1 ; continue [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | lc3.memory.put(0x0204, 0b1010_000_000000001); // LDI R0, [PC + 1] ; load *0x206 -> *FE02 into r0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1010_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:83:28 [INFO] [stdout] | [INFO] [stdout] 83 | lc3.memory.put(0x0205, 0b1100_000_111_000000);// RET [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0001_1100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:87:28 [INFO] [stdout] | [INFO] [stdout] 87 | lc3.memory.put(0x0220, 0b1011_000_000000001); // STI R0, [PC + 1] ; put R0 into display reg [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:88:28 [INFO] [stdout] | [INFO] [stdout] 88 | lc3.memory.put(0x0221, 0b1100_000_111_000000);// RET [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0001_1100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:92:28 [INFO] [stdout] | [INFO] [stdout] 92 | lc3.memory.put(0x0240, 0b0001_001_111_1_00000); // ADD R1, R7, #0 ; save RET register [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_0011_1110_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:93:28 [INFO] [stdout] | [INFO] [stdout] 93 | lc3.memory.put(0x0241, 0b0001_010_000_1_00000); // ADD R2, R0, #0 ; move r0 to r2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_0100_0010_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 94 | lc3.memory.put(0x0242, 0b0110_000_010_000000); // LDR R0, [R2 + #0] ; load character to r0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0110_0000_1000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | lc3.memory.put(0x0243, 0b0000_010_000000011); // BRz PC + 3 ; if zero, go to return [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0100_0000_0011` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:96:28 [INFO] [stdout] | [INFO] [stdout] 96 | lc3.memory.put(0x0244, 0b1111_0000_00100001); // TRAP 0x21 (OUT) ; print character [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0010_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:97:28 [INFO] [stdout] | [INFO] [stdout] 97 | lc3.memory.put(0x0245, 0b0001_010_010_1_00001); // ADD R2, R2, #1 ; increment string ptr [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_0100_1010_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 98 | lc3.memory.put(0x0246, 0b0000_111_111111011); // BR PC - 5 ; go 5 back [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1111_1111_1011` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 99 | lc3.memory.put(0x0247, 0b0001_111_001_1_00000); // ADD R7, R1, #0 ; return address back to r7 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_1110_0110_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | lc3.memory.put(0x0248, 0b1100_000_111_000000); // RET [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0001_1100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:106:28 [INFO] [stdout] | [INFO] [stdout] 106 | lc3.memory.put(0x02A0, 0b0101_000_000_1_00000);// zero r0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0000_0010_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:107:28 [INFO] [stdout] | [INFO] [stdout] 107 | lc3.memory.put(0x02A1, 0b1011_000_000000001); // STI R0, [PC + 1] ; put R0 into display reg [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 108 | lc3.memory.put(0x02A2, 0b1100_000_111_000000); // RET [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0001_1100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lc3.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | if !(self.ie == 0b1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(self.ie != 0b1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/lc3.rs:161:28 [INFO] [stdout] | [INFO] [stdout] 161 | self.pc = self.memory.get(0x100 as u16 + code as u16); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `0x100_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/lc3.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | self.pc = self.memory.get(0x100 as u16 + code as u16); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `0x100_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lc3.rs:420:2 [INFO] [stdout] | [INFO] [stdout] 420 | return self.mem[index as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 420 - return self.mem[index as usize]; [INFO] [stdout] 420 + self.mem[index as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lc3.rs:444:2 [INFO] [stdout] | [INFO] [stdout] 444 | assert_eq!(false, mux(0b0101000000000000)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 444 - assert_eq!(false, mux(0b0101000000000000)); [INFO] [stdout] 444 + assert!(!mux(0b0101000000000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lc3.rs:445:2 [INFO] [stdout] | [INFO] [stdout] 445 | assert_eq!(true, mux(0b0001000000100000)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 445 - assert_eq!(true, mux(0b0001000000100000)); [INFO] [stdout] 445 + assert!(mux(0b0001000000100000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | self.psr &= 0b0_111_1000_1111_1111; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0111_1000_1111_1111` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:174:14 [INFO] [stdout] | [INFO] [stdout] 174 | self.psr &= 0b0_111_1111_1111_1111; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0111_1111_1111_1111` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lc3.rs:206:14 [INFO] [stdout] | [INFO] [stdout] 206 | self.psr &= 0b1111_1111_1111_11_000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1_1111_1111_1111_1000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 44 | lc3.memory.put(0x3000, 0b1110_000_000000010); // LEA R0, [PC + 2] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000_0010` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | lc3.memory.put(0x3001, 0b1111_0000_00100010); // TRAP 0x22 (PUTS) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0010_0010` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 46 | lc3.memory.put(0x3002, 0b1111_0000_00100101); // TRAP 0x25 (HALT) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0010_0101` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 78 | lc3.memory.put(0x0200, 0b1010_000_000000010); // LDI R0, [PC + 2] ; load *0x203 -> *FE00 into r0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1010_0000_0000_0010` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | lc3.memory.put(0x0201, 0b0000_010_000000001); // BRz PC - 2 ; r0 == 0, nothing, retry [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0100_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:80:28 [INFO] [stdout] | [INFO] [stdout] 80 | lc3.memory.put(0x0202, 0b0000_000_000000001); // BR PC + 1 ; continue [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | lc3.memory.put(0x0204, 0b1010_000_000000001); // LDI R0, [PC + 1] ; load *0x206 -> *FE02 into r0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1010_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:83:28 [INFO] [stdout] | [INFO] [stdout] 83 | lc3.memory.put(0x0205, 0b1100_000_111_000000);// RET [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0001_1100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:87:28 [INFO] [stdout] | [INFO] [stdout] 87 | lc3.memory.put(0x0220, 0b1011_000_000000001); // STI R0, [PC + 1] ; put R0 into display reg [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:88:28 [INFO] [stdout] | [INFO] [stdout] 88 | lc3.memory.put(0x0221, 0b1100_000_111_000000);// RET [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0001_1100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:92:28 [INFO] [stdout] | [INFO] [stdout] 92 | lc3.memory.put(0x0240, 0b0001_001_111_1_00000); // ADD R1, R7, #0 ; save RET register [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_0011_1110_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:93:28 [INFO] [stdout] | [INFO] [stdout] 93 | lc3.memory.put(0x0241, 0b0001_010_000_1_00000); // ADD R2, R0, #0 ; move r0 to r2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_0100_0010_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 94 | lc3.memory.put(0x0242, 0b0110_000_010_000000); // LDR R0, [R2 + #0] ; load character to r0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0110_0000_1000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | lc3.memory.put(0x0243, 0b0000_010_000000011); // BRz PC + 3 ; if zero, go to return [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0100_0000_0011` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:96:28 [INFO] [stdout] | [INFO] [stdout] 96 | lc3.memory.put(0x0244, 0b1111_0000_00100001); // TRAP 0x21 (OUT) ; print character [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0010_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:97:28 [INFO] [stdout] | [INFO] [stdout] 97 | lc3.memory.put(0x0245, 0b0001_010_010_1_00001); // ADD R2, R2, #1 ; increment string ptr [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_0100_1010_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 98 | lc3.memory.put(0x0246, 0b0000_111_111111011); // BR PC - 5 ; go 5 back [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1111_1111_1011` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 99 | lc3.memory.put(0x0247, 0b0001_111_001_1_00000); // ADD R7, R1, #0 ; return address back to r7 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_1110_0110_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | lc3.memory.put(0x0248, 0b1100_000_111_000000); // RET [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0001_1100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:106:28 [INFO] [stdout] | [INFO] [stdout] 106 | lc3.memory.put(0x02A0, 0b0101_000_000_1_00000);// zero r0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0000_0010_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:107:28 [INFO] [stdout] | [INFO] [stdout] 107 | lc3.memory.put(0x02A1, 0b1011_000_000000001); // STI R0, [PC + 1] ; put R0 into display reg [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_0000_0000_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/main.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 108 | lc3.memory.put(0x02A2, 0b1100_000_111_000000); // RET [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0001_1100_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lc3.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | if !(self.ie == 0b1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(self.ie != 0b1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/lc3.rs:161:28 [INFO] [stdout] | [INFO] [stdout] 161 | self.pc = self.memory.get(0x100 as u16 + code as u16); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `0x100_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/lc3.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | self.pc = self.memory.get(0x100 as u16 + code as u16); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `0x100_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lc3.rs:420:2 [INFO] [stdout] | [INFO] [stdout] 420 | return self.mem[index as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 420 - return self.mem[index as usize]; [INFO] [stdout] 420 + self.mem[index as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `Command { std: "docker" "inspect" "d0f2f47774561439cf71061812d1c921ec7821980c17672ab14af294e51a272e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0f2f47774561439cf71061812d1c921ec7821980c17672ab14af294e51a272e", kill_on_drop: false }` [INFO] [stdout] d0f2f47774561439cf71061812d1c921ec7821980c17672ab14af294e51a272e