[INFO] cloning repository https://github.com/busyst/rcsharp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/busyst/rcsharp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbusyst%2Frcsharp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbusyst%2Frcsharp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 04e3cfc4b8b334131098bdd9975e5a2781c56480 [INFO] linting busyst/rcsharp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbusyst%2Frcsharp" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/busyst/rcsharp [INFO] finished tweaking git repo https://github.com/busyst/rcsharp [INFO] tweaked toml for git repo https://github.com/busyst/rcsharp written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/busyst/rcsharp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/busyst/rcsharp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded logos-derive v0.15.1 [INFO] [stderr] Downloaded logos-codegen v0.15.1 [INFO] [stderr] Downloaded ordered_hash_map v0.5.0 [INFO] [stderr] Downloaded logos v0.15.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8cc45ded24684922cfa444bf622aea1168b5968f95938de93186959cb33d0c5 [INFO] running `Command { std: "docker" "start" "-a" "f8cc45ded24684922cfa444bf622aea1168b5968f95938de93186959cb33d0c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8cc45ded24684922cfa444bf622aea1168b5968f95938de93186959cb33d0c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8cc45ded24684922cfa444bf622aea1168b5968f95938de93186959cb33d0c5", kill_on_drop: false }` [INFO] [stdout] f8cc45ded24684922cfa444bf622aea1168b5968f95938de93186959cb33d0c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a7575f4418b2b75eaf070fb5c078194c9e07edd20a820e6eadfbdb6cea4d95fd [INFO] running `Command { std: "docker" "start" "-a" "a7575f4418b2b75eaf070fb5c078194c9e07edd20a820e6eadfbdb6cea4d95fd", kill_on_drop: false }` [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling rcsharp v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling logos-codegen v0.15.1 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking ordered_hash_map v0.5.0 [INFO] [stderr] Compiling syn v2.0.116 [INFO] [stderr] Compiling phf_shared v0.13.1 [INFO] [stderr] Compiling phf_generator v0.13.1 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling phf_macros v0.13.1 [INFO] [stderr] Compiling logos-derive v0.15.1 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Checking logos v0.15.1 [INFO] [stderr] Checking rcsharp_lexer v0.1.0 (/opt/rustwide/workdir/rcsharp_lexer) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LexerSymbolTable` [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | strings: Vec::new(), [INFO] [stdout] 137 | | indices: HashMap::new(), [INFO] [stdout] 138 | | } [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 133 + impl Default for LexerSymbolTable { [INFO] [stdout] 134 + fn default() -> Self { [INFO] [stdout] 135 + Self::new() [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:210:32 [INFO] [stdout] | [INFO] [stdout] 210 | Token::Hint => str.push_str("#"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('#')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:212:31 [INFO] [stdout] | [INFO] [stdout] 212 | Token::Dot => str.push_str("."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:213:34 [INFO] [stdout] | [INFO] [stdout] 213 | Token::LParen => str.push_str("("), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('(')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:214:34 [INFO] [stdout] | [INFO] [stdout] 214 | Token::RParen => str.push_str(")"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:215:33 [INFO] [stdout] | [INFO] [stdout] 215 | Token::Colon => str.push_str(":"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:216:37 [INFO] [stdout] | [INFO] [stdout] 216 | Token::LogicLess => str.push_str("<"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('<')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:219:40 [INFO] [stdout] | [INFO] [stdout] 219 | Token::LogicGreater => str.push_str(">"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('>')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:222:36 [INFO] [stdout] | [INFO] [stdout] 222 | Token::LogicNot => str.push_str("!"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('!')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:223:33 [INFO] [stdout] | [INFO] [stdout] 223 | Token::Equal => str.push_str("="), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('=')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:226:32 [INFO] [stdout] | [INFO] [stdout] 226 | Token::Plus => str.push_str("+"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('+')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:227:33 [INFO] [stdout] | [INFO] [stdout] 227 | Token::Minus => str.push_str("-"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:228:36 [INFO] [stdout] | [INFO] [stdout] 228 | Token::Multiply => str.push_str("*"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('*')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:229:34 [INFO] [stdout] | [INFO] [stdout] 229 | Token::Divide => str.push_str("/"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:230:34 [INFO] [stdout] | [INFO] [stdout] 230 | Token::Modulo => str.push_str("%"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('%')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:231:37 [INFO] [stdout] | [INFO] [stdout] 231 | Token::BinaryAnd => str.push_str("&"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('&')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:233:36 [INFO] [stdout] | [INFO] [stdout] 233 | Token::BinaryOr => str.push_str("|"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:237:40 [INFO] [stdout] | [INFO] [stdout] 237 | Token::LSquareBrace => str.push_str("["), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('[')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:238:40 [INFO] [stdout] | [INFO] [stdout] 238 | Token::RSquareBrace => str.push_str("]"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(']')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:296:24 [INFO] [stdout] | [INFO] [stdout] 296 | if let Some(_) = e.error_len() { [INFO] [stdout] | -------^^^^^^^---------------- help: try: `if e.error_len().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:359:46 [INFO] [stdout] | [INFO] [stdout] 359 | if !(char.is_alphabetic() || char.is_digit(10) || *char == '_') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:380:19 [INFO] [stdout] | [INFO] [stdout] 380 | } else if char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 16 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:391:22 [INFO] [stdout] | [INFO] [stdout] 391 | if !(char.is_digit(16) || *char == '_' || *char == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_hexdigit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:413:20 [INFO] [stdout] | [INFO] [stdout] 413 | if pk_char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `pk_char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 16 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:424:30 [INFO] [stdout] | [INFO] [stdout] 424 | if !(char.is_digit(16) || *char == '_' || *char == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_hexdigit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:466:25 [INFO] [stdout] | [INFO] [stdout] 466 | / if *char == '/' { [INFO] [stdout] 467 | | if current_char.1 == '*' { [INFO] [stdout] 468 | | multi_line_comment_end = *idx + 1; [INFO] [stdout] 469 | | break; [INFO] [stdout] 470 | | } [INFO] [stdout] 471 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 466 ~ if *char == '/' [INFO] [stdout] 467 ~ && current_char.1 == '*' { [INFO] [stdout] 468 | multi_line_comment_end = *idx + 1; [INFO] [stdout] 469 | break; [INFO] [stdout] 470 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:517:17 [INFO] [stdout] | [INFO] [stdout] 517 | / if *char == '"' { [INFO] [stdout] 518 | | if current_char.1 != '\\' { [INFO] [stdout] 519 | | string_end = *idx + 1; [INFO] [stdout] 520 | | break; [INFO] [stdout] 521 | | } [INFO] [stdout] 522 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 517 ~ if *char == '"' [INFO] [stdout] 518 ~ && current_char.1 != '\\' { [INFO] [stdout] 519 | string_end = *idx + 1; [INFO] [stdout] 520 | break; [INFO] [stdout] 521 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:546:17 [INFO] [stdout] | [INFO] [stdout] 546 | / if *char == '\'' { [INFO] [stdout] 547 | | if current_char.1 != '\\' { [INFO] [stdout] 548 | | char_end = *idx + 1; [INFO] [stdout] 549 | | break; [INFO] [stdout] 550 | | } [INFO] [stdout] 551 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ if *char == '\'' [INFO] [stdout] 547 ~ && current_char.1 != '\\' { [INFO] [stdout] 548 | char_end = *idx + 1; [INFO] [stdout] 549 | break; [INFO] [stdout] 550 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LexerSymbolTable` [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | strings: Vec::new(), [INFO] [stdout] 137 | | indices: HashMap::new(), [INFO] [stdout] 138 | | } [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 133 + impl Default for LexerSymbolTable { [INFO] [stdout] 134 + fn default() -> Self { [INFO] [stdout] 135 + Self::new() [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:210:32 [INFO] [stdout] | [INFO] [stdout] 210 | Token::Hint => str.push_str("#"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('#')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:212:31 [INFO] [stdout] | [INFO] [stdout] 212 | Token::Dot => str.push_str("."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:213:34 [INFO] [stdout] | [INFO] [stdout] 213 | Token::LParen => str.push_str("("), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('(')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:214:34 [INFO] [stdout] | [INFO] [stdout] 214 | Token::RParen => str.push_str(")"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:215:33 [INFO] [stdout] | [INFO] [stdout] 215 | Token::Colon => str.push_str(":"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:216:37 [INFO] [stdout] | [INFO] [stdout] 216 | Token::LogicLess => str.push_str("<"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('<')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:219:40 [INFO] [stdout] | [INFO] [stdout] 219 | Token::LogicGreater => str.push_str(">"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('>')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:222:36 [INFO] [stdout] | [INFO] [stdout] 222 | Token::LogicNot => str.push_str("!"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('!')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:223:33 [INFO] [stdout] | [INFO] [stdout] 223 | Token::Equal => str.push_str("="), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('=')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:226:32 [INFO] [stdout] | [INFO] [stdout] 226 | Token::Plus => str.push_str("+"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('+')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:227:33 [INFO] [stdout] | [INFO] [stdout] 227 | Token::Minus => str.push_str("-"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:228:36 [INFO] [stdout] | [INFO] [stdout] 228 | Token::Multiply => str.push_str("*"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('*')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:229:34 [INFO] [stdout] | [INFO] [stdout] 229 | Token::Divide => str.push_str("/"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:230:34 [INFO] [stdout] | [INFO] [stdout] 230 | Token::Modulo => str.push_str("%"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('%')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:231:37 [INFO] [stdout] | [INFO] [stdout] 231 | Token::BinaryAnd => str.push_str("&"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('&')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:233:36 [INFO] [stdout] | [INFO] [stdout] 233 | Token::BinaryOr => str.push_str("|"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:237:40 [INFO] [stdout] | [INFO] [stdout] 237 | Token::LSquareBrace => str.push_str("["), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('[')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:238:40 [INFO] [stdout] | [INFO] [stdout] 238 | Token::RSquareBrace => str.push_str("]"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push(']')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:296:24 [INFO] [stdout] | [INFO] [stdout] 296 | if let Some(_) = e.error_len() { [INFO] [stdout] | -------^^^^^^^---------------- help: try: `if e.error_len().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rcsharp_parser v0.1.0 (/opt/rustwide/workdir/rcsharp_parser) [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:359:46 [INFO] [stdout] | [INFO] [stdout] 359 | if !(char.is_alphabetic() || char.is_digit(10) || *char == '_') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:380:19 [INFO] [stdout] | [INFO] [stdout] 380 | } else if char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 16 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:391:22 [INFO] [stdout] | [INFO] [stdout] 391 | if !(char.is_digit(16) || *char == '_' || *char == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_hexdigit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:413:20 [INFO] [stdout] | [INFO] [stdout] 413 | if pk_char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `pk_char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 16 [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:424:30 [INFO] [stdout] | [INFO] [stdout] 424 | if !(char.is_digit(16) || *char == '_' || *char == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_hexdigit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:466:25 [INFO] [stdout] | [INFO] [stdout] 466 | / if *char == '/' { [INFO] [stdout] 467 | | if current_char.1 == '*' { [INFO] [stdout] 468 | | multi_line_comment_end = *idx + 1; [INFO] [stdout] 469 | | break; [INFO] [stdout] 470 | | } [INFO] [stdout] 471 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 466 ~ if *char == '/' [INFO] [stdout] 467 ~ && current_char.1 == '*' { [INFO] [stdout] 468 | multi_line_comment_end = *idx + 1; [INFO] [stdout] 469 | break; [INFO] [stdout] 470 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:517:17 [INFO] [stdout] | [INFO] [stdout] 517 | / if *char == '"' { [INFO] [stdout] 518 | | if current_char.1 != '\\' { [INFO] [stdout] 519 | | string_end = *idx + 1; [INFO] [stdout] 520 | | break; [INFO] [stdout] 521 | | } [INFO] [stdout] 522 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 517 ~ if *char == '"' [INFO] [stdout] 518 ~ && current_char.1 != '\\' { [INFO] [stdout] 519 | string_end = *idx + 1; [INFO] [stdout] 520 | break; [INFO] [stdout] 521 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rcsharp_lexer/src/lib.rs:546:17 [INFO] [stdout] | [INFO] [stdout] 546 | / if *char == '\'' { [INFO] [stdout] 547 | | if current_char.1 != '\\' { [INFO] [stdout] 548 | | char_end = *idx + 1; [INFO] [stdout] 549 | | break; [INFO] [stdout] 550 | | } [INFO] [stdout] 551 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ if *char == '\'' [INFO] [stdout] 547 ~ && current_char.1 != '\\' { [INFO] [stdout] 548 | char_end = *idx + 1; [INFO] [stdout] 549 | break; [INFO] [stdout] 550 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:193:25 [INFO] [stdout] | [INFO] [stdout] 193 | return Some(&x); // Inner [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:199:26 [INFO] [stdout] | [INFO] [stdout] 199 | return Some((&x, &y)); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:199:30 [INFO] [stdout] | [INFO] [stdout] 199 | return Some((&x, &y)); [INFO] [stdout] | ^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:205:26 [INFO] [stdout] | [INFO] [stdout] 205 | return Some((&x, &y)); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:205:30 [INFO] [stdout] | [INFO] [stdout] 205 | return Some((&x, &y)); [INFO] [stdout] | ^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rcsharp_parser/src/parser.rs:752:17 [INFO] [stdout] | [INFO] [stdout] 752 | / return Ok(StmtData { [INFO] [stdout] 753 | | stmt: Stmt::Block(q.into()), [INFO] [stdout] 754 | | span: start..self.cursor, [INFO] [stdout] 755 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 752 ~ Ok(StmtData { [INFO] [stdout] 753 + stmt: Stmt::Block(q.into()), [INFO] [stdout] 754 + span: start..self.cursor, [INFO] [stdout] 755 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:193:25 [INFO] [stdout] | [INFO] [stdout] 193 | return Some(&x); // Inner [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:199:26 [INFO] [stdout] | [INFO] [stdout] 199 | return Some((&x, &y)); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:199:30 [INFO] [stdout] | [INFO] [stdout] 199 | return Some((&x, &y)); [INFO] [stdout] | ^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:205:26 [INFO] [stdout] | [INFO] [stdout] 205 | return Some((&x, &y)); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rcsharp_parser/src/parser.rs:205:30 [INFO] [stdout] | [INFO] [stdout] 205 | return Some((&x, &y)); [INFO] [stdout] | ^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rcsharp_parser/src/parser.rs:752:17 [INFO] [stdout] | [INFO] [stdout] 752 | / return Ok(StmtData { [INFO] [stdout] 753 | | stmt: Stmt::Block(q.into()), [INFO] [stdout] 754 | | span: start..self.cursor, [INFO] [stdout] 755 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 752 ~ Ok(StmtData { [INFO] [stdout] 753 + stmt: Stmt::Block(q.into()), [INFO] [stdout] 754 + span: start..self.cursor, [INFO] [stdout] 755 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/compiler/structs.rs:3:36 [INFO] [stdout] | [INFO] [stdout] 3 | pub const PATH_SECTION_SEPARATOR: &'static str = "."; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/expression_compiler.rs:348:11 [INFO] [stdout] | [INFO] [stdout] 348 | } else { [INFO] [stdout] | ___________^ [INFO] [stdout] 349 | | } [INFO] [stdout] | |_________^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/compiler/structs.rs:3:36 [INFO] [stdout] | [INFO] [stdout] 3 | pub const PATH_SECTION_SEPARATOR: &'static str = "."; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/expression_compiler.rs:348:11 [INFO] [stdout] | [INFO] [stdout] 348 | } else { [INFO] [stdout] | ___________^ [INFO] [stdout] 349 | | } [INFO] [stdout] | |_________^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/base.rs:14:64 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn compile_to_file(entry_path: &str, output_path: &str) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/base.rs:43:37 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn compile(entry_path: &str) -> CompileResult<(CompilerContext, String)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/base.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | let file_id = func.file_id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `func.file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `err.call_stack.get(0)` [INFO] [stdout] --> src/compiler/base.rs:70:33 [INFO] [stdout] | [INFO] [stdout] 70 | let q = &tokens[err.call_stack.get(0).cloned().unwrap().0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `err.call_stack.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return Ok(builder.build()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return Ok(builder.build()); [INFO] [stdout] 47 + Ok(builder.build()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 59 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|(name, ptype)| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 72 | | ptype [INFO] [stdout] 73 | | .llvm_representation(&ctx.symbols) [INFO] [stdout] 74 | | .map(|x| format!("{} %{}", x, name)) [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:89:10 [INFO] [stdout] | [INFO] [stdout] 89 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:116:10 [INFO] [stdout] | [INFO] [stdout] 116 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:130:10 [INFO] [stdout] | [INFO] [stdout] 130 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|(_field_name, field_type)| field_type.llvm_representation(&ctx.symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:175:30 [INFO] [stdout] | [INFO] [stdout] 175 | .map(|x| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 176 | | x.1.with_substituted_generics(&type_map, &ctx.symbols) [INFO] [stdout] 177 | | .map(|x| x.llvm_representation(&ctx.symbols)) [INFO] [stdout] 178 | | .flatten() [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_________________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Result` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:177:34 [INFO] [stdout] | [INFO] [stdout] 177 | ... .map(|x| x.llvm_representation(&ctx.symbols)) [INFO] [stdout] | ________________________^ [INFO] [stdout] 178 | | ... .flatten() [INFO] [stdout] | |________________________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.llvm_representation(&ctx.symbols))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:177:38 [INFO] [stdout] | [INFO] [stdout] 177 | ... .map(|x| x.llvm_representation(&ctx.symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:195:10 [INFO] [stdout] | [INFO] [stdout] 195 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:203:47 [INFO] [stdout] | [INFO] [stdout] 203 | return Err(CompilerError::Generic(format!( [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 204 | | "Function 'main' was not found! Dumped all function names" [INFO] [stdout] 205 | | )) [INFO] [stdout] | |_____________^ help: consider using `.to_string()`: `"Function 'main' was not found! Dumped all function names".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:231:24 [INFO] [stdout] | [INFO] [stdout] 231 | if done.iter().any(|x| *x == index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `done.contains(&index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:276:30 [INFO] [stdout] | [INFO] [stdout] 276 | .map(|(name, ptype)| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 277 | | ptype [INFO] [stdout] 278 | | .with_substituted_generics(&type_map, &ctx.symbols) [INFO] [stdout] 279 | | .map(|x| (name.clone(), x)) [INFO] [stdout] 280 | | }) [INFO] [stdout] | |_________________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:317:20 [INFO] [stdout] | [INFO] [stdout] 317 | if done.iter().any(|x| *x == index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `done.contains(&index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:334:10 [INFO] [stdout] | [INFO] [stdout] 334 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:342:45 [INFO] [stdout] | [INFO] [stdout] 342 | return_type.substitute_generics(&ctx.symbols.alias_types(), &ctx.symbols)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ctx.symbols.alias_types()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:347:22 [INFO] [stdout] | [INFO] [stdout] 347 | .map(|(name, ptype)| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 348 | | ptype [INFO] [stdout] 349 | | .with_substituted_generics(&ctx.symbols.alias_types(), &ctx.symbols) [INFO] [stdout] 350 | | .map(|x| (name.clone(), x)) [INFO] [stdout] 351 | | }) [INFO] [stdout] | |_________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:349:52 [INFO] [stdout] | [INFO] [stdout] 349 | .with_substituted_generics(&ctx.symbols.alias_types(), &ctx.symbols) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ctx.symbols.alias_types()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:389:10 [INFO] [stdout] | [INFO] [stdout] 389 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:386:15 [INFO] [stdout] | [INFO] [stdout] 386 | body: &Box<[StmtData]>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&[StmtData]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:380:5 [INFO] [stdout] | [INFO] [stdout] 380 | / fn compile_function_base( [INFO] [stdout] 381 | | &mut self, [INFO] [stdout] 382 | | function_path: ContextPath, [INFO] [stdout] 383 | | full_function_name: &str, [INFO] [stdout] ... | [INFO] [stdout] 388 | | ctx: &mut CompilerContext, [INFO] [stdout] 389 | | ) -> CompileResult<()> { [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:395:18 [INFO] [stdout] | [INFO] [stdout] 395 | .map(|(name, ptype)| { [INFO] [stdout] | __________________^ [INFO] [stdout] 396 | | ptype [INFO] [stdout] 397 | | .llvm_representation(symbols) [INFO] [stdout] 398 | | .map(|type_str| format!("{} %{}", type_str, name)) [INFO] [stdout] 399 | | }) [INFO] [stdout] | |_____________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:424:42 [INFO] [stdout] | [INFO] [stdout] 424 | arg_type.substitute_generics(&symbols.alias_types(), symbols)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `symbols.alias_types()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:447:44 [INFO] [stdout] | [INFO] [stdout] 447 | let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 447 - let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 447 + let x = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:485:10 [INFO] [stdout] | [INFO] [stdout] 485 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:507:21 [INFO] [stdout] | [INFO] [stdout] 507 | return Ok(val.is_program_halt()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 507 - return Ok(val.is_program_halt()); [INFO] [stdout] 507 + Ok(val.is_program_halt()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:512:21 [INFO] [stdout] | [INFO] [stdout] 512 | return Err(x); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 512 - return Err(x); [INFO] [stdout] 512 + Err(x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:538:21 [INFO] [stdout] | [INFO] [stdout] 538 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return Ok(false); [INFO] [stdout] 538 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:541:21 [INFO] [stdout] | [INFO] [stdout] 541 | / return Err(( [INFO] [stdout] 542 | | self.span.clone(), [INFO] [stdout] 543 | | CompilerError::Generic("Tried to continue without loop".to_string()), [INFO] [stdout] 544 | | ) [INFO] [stdout] 545 | | .into()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 541 ~ Err(( [INFO] [stdout] 542 + self.span.clone(), [INFO] [stdout] 543 + CompilerError::Generic("Tried to continue without loop".to_string()), [INFO] [stdout] 544 + ) [INFO] [stdout] 545 + .into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:551:21 [INFO] [stdout] | [INFO] [stdout] 551 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 551 - return Ok(true); [INFO] [stdout] 551 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:554:21 [INFO] [stdout] | [INFO] [stdout] 554 | / return Err(( [INFO] [stdout] 555 | | self.span.clone(), [INFO] [stdout] 556 | | CompilerError::Generic("Tried to break without loop".to_string()), [INFO] [stdout] 557 | | ) [INFO] [stdout] 558 | | .into()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 554 ~ Err(( [INFO] [stdout] 555 + self.span.clone(), [INFO] [stdout] 556 + CompilerError::Generic("Tried to break without loop".to_string()), [INFO] [stdout] 557 + ) [INFO] [stdout] 558 + .into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:489:38 [INFO] [stdout] | [INFO] [stdout] 489 | builder.emit_comment(&comment); [INFO] [stdout] | ^^^^^^^^ help: change this to: `comment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:573:10 [INFO] [stdout] | [INFO] [stdout] 573 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:637:57 [INFO] [stdout] | [INFO] [stdout] 637 | let exit_stmts = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 637 - let exit_stmts = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 637 + let exit_stmts = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:667:48 [INFO] [stdout] | [INFO] [stdout] 667 | let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 667 - let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 667 + let x = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:695:10 [INFO] [stdout] | [INFO] [stdout] 695 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:709:55 [INFO] [stdout] | [INFO] [stdout] 709 | return Err(CompilerError::Generic(format!("TypeMismatch")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TypeMismatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:748:10 [INFO] [stdout] | [INFO] [stdout] 748 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:776:28 [INFO] [stdout] | [INFO] [stdout] 776 | Expected::Type(&variable.compiler_type()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `variable.compiler_type()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:782:31 [INFO] [stdout] | [INFO] [stdout] 782 | if !result.equal_type(&variable.compiler_type()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `variable.compiler_type()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:791:40 [INFO] [stdout] | [INFO] [stdout] 791 | CompilerError::Generic(format!("Type missmatch")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type missmatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:797:22 [INFO] [stdout] | [INFO] [stdout] 797 | .map(|x| !x.as_primitive().is_some() && !x.is_pointer()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `x.as_primitive().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:875:10 [INFO] [stdout] | [INFO] [stdout] 875 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:889:44 [INFO] [stdout] | [INFO] [stdout] 889 | let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 889 - let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 889 + let x = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:900:10 [INFO] [stdout] | [INFO] [stdout] 900 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:908:44 [INFO] [stdout] | [INFO] [stdout] 908 | let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 908 - let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 908 + let x = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compiler/passes/pass_module_loader.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | / match stmt_vec.insert(ctx.source_manager.get_file_handle(&path), parsed) { [INFO] [stdout] 111 | | Some(x) => panic!("{:?}", x), [INFO] [stdout] 112 | | None => {} [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(x) = stmt_vec.insert(ctx.source_manager.get_file_handle(&path), parsed) { panic!("{:?}", x) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_module_loader.rs:110:70 [INFO] [stdout] | [INFO] [stdout] 110 | match stmt_vec.insert(ctx.source_manager.get_file_handle(&path), parsed) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_optimizer.rs:30:60 [INFO] [stdout] | [INFO] [stdout] 30 | fn optimize_block(&mut self, body: &mut [StmtData]) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/compiler/passes/pass_optimizer.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(if *val { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 43 | | self.optimize_block(then_block)?; [INFO] [stdout] 44 | | stmt_data.stmt = Stmt::Block(then_block.clone()); [INFO] [stdout] 45 | | println!("OPT: Pruned dead ELSE branch (cond is true)"); [INFO] [stdout] ... | [INFO] [stdout] 49 | | println!("OPT: Pruned dead THEN branch (cond is false)"); [INFO] [stdout] 50 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 42 ~ return { [INFO] [stdout] 43 + let _: () = if *val { [INFO] [stdout] 44 + self.optimize_block(then_block)?; [INFO] [stdout] 45 + stmt_data.stmt = Stmt::Block(then_block.clone()); [INFO] [stdout] 46 + println!("OPT: Pruned dead ELSE branch (cond is true)"); [INFO] [stdout] 47 + } else { [INFO] [stdout] 48 + self.optimize_block(else_block)?; [INFO] [stdout] 49 + stmt_data.stmt = Stmt::Block(else_block.clone()); [INFO] [stdout] 50 + println!("OPT: Pruned dead THEN branch (cond is false)"); [INFO] [stdout] 51 + }; [INFO] [stdout] 52 + Ok(()) [INFO] [stdout] 53 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_optimizer.rs:112:74 [INFO] [stdout] | [INFO] [stdout] 112 | fn remove_unreachable_code(&mut self, body: &mut Box<[StmtData]>) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/base.rs:14:64 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn compile_to_file(entry_path: &str, output_path: &str) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | let mut static_variables: Vec<( [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 43 | | ContextPath, [INFO] [stdout] 44 | | FileID, [INFO] [stdout] 45 | | (String, rcsharp_parser::parser::ParserType, Option), [INFO] [stdout] 46 | | )> = vec![]; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:53:51 [INFO] [stdout] | [INFO] [stdout] 53 | worklist.push((full_path, file_id.clone(), body.to_vec())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:56:51 [INFO] [stdout] | [INFO] [stdout] 56 | types.push((path.clone(), file_id.clone(), x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:59:55 [INFO] [stdout] | [INFO] [stdout] 59 | functions.push((path.clone(), file_id.clone(), x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:62:51 [INFO] [stdout] | [INFO] [stdout] 62 | enums.push((path.clone(), file_id.clone(), x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | ... file_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/base.rs:43:37 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn compile(entry_path: &str) -> CompileResult<(CompilerContext, String)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/base.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | let file_id = func.file_id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `func.file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `err.call_stack.get(0)` [INFO] [stdout] --> src/compiler/base.rs:70:33 [INFO] [stdout] | [INFO] [stdout] 70 | let q = &tokens[err.call_stack.get(0).cloned().unwrap().0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `err.call_stack.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 116 | / format!( [INFO] [stdout] 117 | | "Enum '{}' must have an integer backing type", [INFO] [stdout] 118 | | parsed_enum.name [INFO] [stdout] 119 | | ) [INFO] [stdout] 120 | | .into(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 116 ~ format!( [INFO] [stdout] 117 + "Enum '{}' must have an integer backing type", [INFO] [stdout] 118 + parsed_enum.name [INFO] [stdout] 119 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return Ok(builder.build()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return Ok(builder.build()); [INFO] [stdout] 47 + Ok(builder.build()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 59 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | 0.into(), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | / if return_type.is_void() { [INFO] [stdout] 203 | | if body [INFO] [stdout] 204 | | .last() [INFO] [stdout] 205 | | .map(|x| matches!(x.stmt, Stmt::Return(..))) [INFO] [stdout] ... | [INFO] [stdout] 234 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 202 ~ if return_type.is_void() [INFO] [stdout] 203 ~ && body [INFO] [stdout] 204 | .last() [INFO] [stdout] ... [INFO] [stdout] 232 | new_body = Some(x) [INFO] [stdout] 233 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:218:48 [INFO] [stdout] | [INFO] [stdout] 218 | CompilerError::Generic(format!( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 219 | | "TCFB: Trying to return something in void function" [INFO] [stdout] 220 | | )), [INFO] [stdout] | |_________________________^ help: consider using `.to_string()`: `"TCFB: Trying to return something in void function".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:236:5 [INFO] [stdout] | [INFO] [stdout] 236 | / if let Some(x) = new_body { [INFO] [stdout] 237 | | Some(x.into_boxed_slice()) [INFO] [stdout] 238 | | } else { [INFO] [stdout] 239 | | None [INFO] [stdout] 240 | | } [INFO] [stdout] | |_____^ help: try: `new_body.map(|x| x.into_boxed_slice())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:245:6 [INFO] [stdout] | [INFO] [stdout] 245 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|(name, ptype)| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 72 | | ptype [INFO] [stdout] 73 | | .llvm_representation(&ctx.symbols) [INFO] [stdout] 74 | | .map(|x| format!("{} %{}", x, name)) [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:89:10 [INFO] [stdout] | [INFO] [stdout] 89 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/traits.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | -> CompileResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/compiler/structs.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | / if let Ok(index) = self.keys.binary_search(entry_path) { [INFO] [stdout] 24 | | Some(index) [INFO] [stdout] 25 | | } else { [INFO] [stdout] 26 | | None [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ help: replace with: `self.keys.binary_search(entry_path).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:116:10 [INFO] [stdout] | [INFO] [stdout] 116 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:130:10 [INFO] [stdout] | [INFO] [stdout] 130 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ContextPathDictionary` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/compiler/structs.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|(_field_name, field_type)| field_type.llvm_representation(&ctx.symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/compiler/structs.rs:124:1 [INFO] [stdout] | [INFO] [stdout] 124 | / impl ToString for ContextPath { [INFO] [stdout] 125 | | fn to_string(&self) -> String { [INFO] [stdout] 126 | | self.path_sections.join(PATH_SECTION_SEPARATOR) [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:175:30 [INFO] [stdout] | [INFO] [stdout] 175 | .map(|x| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 176 | | x.1.with_substituted_generics(&type_map, &ctx.symbols) [INFO] [stdout] 177 | | .map(|x| x.llvm_representation(&ctx.symbols)) [INFO] [stdout] 178 | | .flatten() [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_________________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Result` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:177:34 [INFO] [stdout] | [INFO] [stdout] 177 | ... .map(|x| x.llvm_representation(&ctx.symbols)) [INFO] [stdout] | ________________________^ [INFO] [stdout] 178 | | ... .flatten() [INFO] [stdout] | |________________________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.llvm_representation(&ctx.symbols))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:177:38 [INFO] [stdout] | [INFO] [stdout] 177 | ... .map(|x| x.llvm_representation(&ctx.symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/structs.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | / return Self { [INFO] [stdout] 190 | | context_path: ContextPath::new(concatedinated.into_boxed_slice()), [INFO] [stdout] 191 | | name: self.name.clone(), [INFO] [stdout] 192 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 ~ Self { [INFO] [stdout] 190 + context_path: ContextPath::new(concatedinated.into_boxed_slice()), [INFO] [stdout] 191 + name: self.name.clone(), [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/compiler/structs.rs:207:1 [INFO] [stdout] | [INFO] [stdout] 207 | / impl ToString for ContextPathEnd { [INFO] [stdout] 208 | | fn to_string(&self) -> String { [INFO] [stdout] 209 | | if self.context_path.path_sections.is_empty() { [INFO] [stdout] 210 | | self.name.to_string() [INFO] [stdout] ... | [INFO] [stdout] 219 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:195:10 [INFO] [stdout] | [INFO] [stdout] 195 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:203:47 [INFO] [stdout] | [INFO] [stdout] 203 | return Err(CompilerError::Generic(format!( [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 204 | | "Function 'main' was not found! Dumped all function names" [INFO] [stdout] 205 | | )) [INFO] [stdout] | |_____________^ help: consider using `.to_string()`: `"Function 'main' was not found! Dumped all function names".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:231:24 [INFO] [stdout] | [INFO] [stdout] 231 | if done.iter().any(|x| *x == index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `done.contains(&index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:276:30 [INFO] [stdout] | [INFO] [stdout] 276 | .map(|(name, ptype)| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 277 | | ptype [INFO] [stdout] 278 | | .with_substituted_generics(&type_map, &ctx.symbols) [INFO] [stdout] 279 | | .map(|x| (name.clone(), x)) [INFO] [stdout] 280 | | }) [INFO] [stdout] | |_________________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/compiler_essentials.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | / impl ToString for LLVMVal { [INFO] [stdout] 35 | | fn to_string(&self) -> String { [INFO] [stdout] 36 | | match self { [INFO] [stdout] 37 | | LLVMVal::Register(id) => format!("%tmp{}", id), [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:317:20 [INFO] [stdout] | [INFO] [stdout] 317 | if done.iter().any(|x| *x == index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `done.contains(&index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler_essentials.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 47 | LLVMVal::Void => format!("void"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"void".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler_essentials.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | LLVMVal::Null => format!("null"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"null".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:334:10 [INFO] [stdout] | [INFO] [stdout] 334 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:342:45 [INFO] [stdout] | [INFO] [stdout] 342 | return_type.substitute_generics(&ctx.symbols.alias_types(), &ctx.symbols)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ctx.symbols.alias_types()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:347:22 [INFO] [stdout] | [INFO] [stdout] 347 | .map(|(name, ptype)| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 348 | | ptype [INFO] [stdout] 349 | | .with_substituted_generics(&ctx.symbols.alias_types(), &ctx.symbols) [INFO] [stdout] 350 | | .map(|x| (name.clone(), x)) [INFO] [stdout] 351 | | }) [INFO] [stdout] | |_________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:349:52 [INFO] [stdout] | [INFO] [stdout] 349 | .with_substituted_generics(&ctx.symbols.alias_types(), &ctx.symbols) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ctx.symbols.alias_types()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:389:10 [INFO] [stdout] | [INFO] [stdout] 389 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:386:15 [INFO] [stdout] | [INFO] [stdout] 386 | body: &Box<[StmtData]>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&[StmtData]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:380:5 [INFO] [stdout] | [INFO] [stdout] 380 | / fn compile_function_base( [INFO] [stdout] 381 | | &mut self, [INFO] [stdout] 382 | | function_path: ContextPath, [INFO] [stdout] 383 | | full_function_name: &str, [INFO] [stdout] ... | [INFO] [stdout] 388 | | ctx: &mut CompilerContext, [INFO] [stdout] 389 | | ) -> CompileResult<()> { [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:395:18 [INFO] [stdout] | [INFO] [stdout] 395 | .map(|(name, ptype)| { [INFO] [stdout] | __________________^ [INFO] [stdout] 396 | | ptype [INFO] [stdout] 397 | | .llvm_representation(symbols) [INFO] [stdout] 398 | | .map(|type_str| format!("{} %{}", type_str, name)) [INFO] [stdout] 399 | | }) [INFO] [stdout] | |_____________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:117:65 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn llvm_representation(&self, symbols: &SymbolTable) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:424:42 [INFO] [stdout] | [INFO] [stdout] 424 | arg_type.substitute_generics(&symbols.alias_types(), symbols)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `symbols.alias_types()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:133:26 [INFO] [stdout] | [INFO] [stdout] 133 | .map(|param| param.llvm_representation(symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:148:26 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|arg| arg.llvm_representation_in_generic(symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:168:26 [INFO] [stdout] | [INFO] [stdout] 168 | .map(|arg| arg.llvm_representation_in_generic(symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:447:44 [INFO] [stdout] | [INFO] [stdout] 447 | let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 447 - let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 447 + let x = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:485:10 [INFO] [stdout] | [INFO] [stdout] 485 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:185:76 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn llvm_representation_in_generic(&self, symbols: &SymbolTable) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:507:21 [INFO] [stdout] | [INFO] [stdout] 507 | return Ok(val.is_program_halt()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 507 - return Ok(val.is_program_halt()); [INFO] [stdout] 507 + Ok(val.is_program_halt()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:512:21 [INFO] [stdout] | [INFO] [stdout] 512 | return Err(x); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 512 - return Err(x); [INFO] [stdout] 512 + Err(x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:538:21 [INFO] [stdout] | [INFO] [stdout] 538 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return Ok(false); [INFO] [stdout] 538 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:198:26 [INFO] [stdout] | [INFO] [stdout] 198 | .map(|arg| arg.llvm_representation_in_generic(symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:541:21 [INFO] [stdout] | [INFO] [stdout] 541 | / return Err(( [INFO] [stdout] 542 | | self.span.clone(), [INFO] [stdout] 543 | | CompilerError::Generic("Tried to continue without loop".to_string()), [INFO] [stdout] 544 | | ) [INFO] [stdout] 545 | | .into()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 541 ~ Err(( [INFO] [stdout] 542 + self.span.clone(), [INFO] [stdout] 543 + CompilerError::Generic("Tried to continue without loop".to_string()), [INFO] [stdout] 544 + ) [INFO] [stdout] 545 + .into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:551:21 [INFO] [stdout] | [INFO] [stdout] 551 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 551 - return Ok(true); [INFO] [stdout] 551 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:554:21 [INFO] [stdout] | [INFO] [stdout] 554 | / return Err(( [INFO] [stdout] 555 | | self.span.clone(), [INFO] [stdout] 556 | | CompilerError::Generic("Tried to break without loop".to_string()), [INFO] [stdout] 557 | | ) [INFO] [stdout] 558 | | .into()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 554 ~ Err(( [INFO] [stdout] 555 + self.span.clone(), [INFO] [stdout] 556 + CompilerError::Generic("Tried to break without loop".to_string()), [INFO] [stdout] 557 + ) [INFO] [stdout] 558 + .into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:489:38 [INFO] [stdout] | [INFO] [stdout] 489 | builder.emit_comment(&comment); [INFO] [stdout] | ^^^^^^^^ help: change this to: `comment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:214:10 [INFO] [stdout] | [INFO] [stdout] 214 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:226:22 [INFO] [stdout] | [INFO] [stdout] 226 | .map(|a| Self::from_parser_type(a, symbols, current_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/compiler_essentials.rs:260:18 [INFO] [stdout] | [INFO] [stdout] 260 | .expect(&format!("Generic type {} not found", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Generic type {} not found", name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:573:10 [INFO] [stdout] | [INFO] [stdout] 573 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:314:10 [INFO] [stdout] | [INFO] [stdout] 314 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/compiler_essentials.rs:319:18 [INFO] [stdout] | [INFO] [stdout] 319 | .expect(&format!("Type {} not found", glob_path.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Type {} not found", glob_path.to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:637:57 [INFO] [stdout] | [INFO] [stdout] 637 | let exit_stmts = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 637 - let exit_stmts = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 637 + let exit_stmts = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:667:48 [INFO] [stdout] | [INFO] [stdout] 667 | let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 667 - let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 667 + let x = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:695:10 [INFO] [stdout] | [INFO] [stdout] 695 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:361:10 [INFO] [stdout] | [INFO] [stdout] 361 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:366:75 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn substitute_global_aliases(&mut self, symbols: &SymbolTable) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:373:10 [INFO] [stdout] | [INFO] [stdout] 373 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:381:21 [INFO] [stdout] | [INFO] [stdout] 381 | / return Err(CompilerError::Generic(format!( [INFO] [stdout] 382 | | "Generic placeholder {} not found in substitution map", [INFO] [stdout] 383 | | name, [INFO] [stdout] 384 | | )) [INFO] [stdout] 385 | | .into()); [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 ~ Err(CompilerError::Generic(format!( [INFO] [stdout] 382 + "Generic placeholder {} not found in substitution map", [INFO] [stdout] 383 + name, [INFO] [stdout] 384 + )) [INFO] [stdout] 385 ~ .into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:709:55 [INFO] [stdout] | [INFO] [stdout] 709 | return Err(CompilerError::Generic(format!("TypeMismatch")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TypeMismatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:748:10 [INFO] [stdout] | [INFO] [stdout] 748 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:776:28 [INFO] [stdout] | [INFO] [stdout] 776 | Expected::Type(&variable.compiler_type()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `variable.compiler_type()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:782:31 [INFO] [stdout] | [INFO] [stdout] 782 | if !result.equal_type(&variable.compiler_type()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `variable.compiler_type()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:791:40 [INFO] [stdout] | [INFO] [stdout] 791 | CompilerError::Generic(format!("Type missmatch")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type missmatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:797:22 [INFO] [stdout] | [INFO] [stdout] 797 | .map(|x| !x.as_primitive().is_some() && !x.is_pointer()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `x.as_primitive().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:875:10 [INFO] [stdout] | [INFO] [stdout] 875 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/compiler_essentials.rs:608:16 [INFO] [stdout] | [INFO] [stdout] 608 | fn to_byte(&self) -> u8 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:889:44 [INFO] [stdout] | [INFO] [stdout] 889 | let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 889 - let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 889 + let x = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:900:10 [INFO] [stdout] | [INFO] [stdout] 900 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `pop_layer` doesn't need a mutable reference [INFO] [stdout] --> src/compiler/passes/pass_llvm_gen.rs:908:44 [INFO] [stdout] | [INFO] [stdout] 908 | let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 908 - let x = self.cgctx.scope.pop_layer(&mut ctx.symbols); [INFO] [stdout] 908 + let x = self.cgctx.scope.pop_layer(&ctx.symbols); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:754:9 [INFO] [stdout] | [INFO] [stdout] 754 | &self.full_path.name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.full_path.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/compiler_essentials.rs:768:16 [INFO] [stdout] | [INFO] [stdout] 768 | fn to_byte(&self) -> u8 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compiler/passes/pass_module_loader.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | / match stmt_vec.insert(ctx.source_manager.get_file_handle(&path), parsed) { [INFO] [stdout] 111 | | Some(x) => panic!("{:?}", x), [INFO] [stdout] 112 | | None => {} [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(x) = stmt_vec.insert(ctx.source_manager.get_file_handle(&path), parsed) { panic!("{:?}", x) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler/passes/pass_module_loader.rs:110:70 [INFO] [stdout] | [INFO] [stdout] 110 | match stmt_vec.insert(ctx.source_manager.get_file_handle(&path), parsed) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:863:9 [INFO] [stdout] | [INFO] [stdout] 863 | &self.full_path.name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.full_path.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_optimizer.rs:30:60 [INFO] [stdout] | [INFO] [stdout] 30 | fn optimize_block(&mut self, body: &mut [StmtData]) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/compiler/passes/pass_optimizer.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(if *val { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 43 | | self.optimize_block(then_block)?; [INFO] [stdout] 44 | | stmt_data.stmt = Stmt::Block(then_block.clone()); [INFO] [stdout] 45 | | println!("OPT: Pruned dead ELSE branch (cond is true)"); [INFO] [stdout] ... | [INFO] [stdout] 49 | | println!("OPT: Pruned dead THEN branch (cond is false)"); [INFO] [stdout] 50 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 42 ~ return { [INFO] [stdout] 43 + let _: () = if *val { [INFO] [stdout] 44 + self.optimize_block(then_block)?; [INFO] [stdout] 45 + stmt_data.stmt = Stmt::Block(then_block.clone()); [INFO] [stdout] 46 + println!("OPT: Pruned dead ELSE branch (cond is true)"); [INFO] [stdout] 47 + } else { [INFO] [stdout] 48 + self.optimize_block(else_block)?; [INFO] [stdout] 49 + stmt_data.stmt = Stmt::Block(else_block.clone()); [INFO] [stdout] 50 + println!("OPT: Pruned dead THEN branch (cond is false)"); [INFO] [stdout] 51 + }; [INFO] [stdout] 52 + Ok(()) [INFO] [stdout] 53 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:866:9 [INFO] [stdout] | [INFO] [stdout] 866 | &self.full_path.context_path() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.full_path.context_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:916:10 [INFO] [stdout] | [INFO] [stdout] 916 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_optimizer.rs:112:74 [INFO] [stdout] | [INFO] [stdout] 112 | fn remove_unreachable_code(&mut self, body: &mut Box<[StmtData]>) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:925:10 [INFO] [stdout] | [INFO] [stdout] 925 | ) -> CompileResult<(Box, Box<[CompilerType]>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:937:22 [INFO] [stdout] | [INFO] [stdout] 937 | .map(|(_, ty)| ty.with_substituted_generics(&map, symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | let mut static_variables: Vec<( [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 43 | | ContextPath, [INFO] [stdout] 44 | | FileID, [INFO] [stdout] 45 | | (String, rcsharp_parser::parser::ParserType, Option), [INFO] [stdout] 46 | | )> = vec![]; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/compiler_essentials.rs:962:16 [INFO] [stdout] | [INFO] [stdout] 962 | fn to_byte(&self) -> u8 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:53:51 [INFO] [stdout] | [INFO] [stdout] 53 | worklist.push((full_path, file_id.clone(), body.to_vec())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:56:51 [INFO] [stdout] | [INFO] [stdout] 56 | types.push((path.clone(), file_id.clone(), x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:59:55 [INFO] [stdout] | [INFO] [stdout] 59 | functions.push((path.clone(), file_id.clone(), x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:62:51 [INFO] [stdout] | [INFO] [stdout] 62 | enums.push((path.clone(), file_id.clone(), x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | ... file_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:1066:10 [INFO] [stdout] | [INFO] [stdout] 1066 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1139:9 [INFO] [stdout] | [INFO] [stdout] 1139 | return on_scope_exit; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1139 - return on_scope_exit; [INFO] [stdout] 1139 + on_scope_exit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1148:9 [INFO] [stdout] | [INFO] [stdout] 1148 | return on_scope_exit; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1148 - return on_scope_exit; [INFO] [stdout] 1148 + on_scope_exit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 116 | / format!( [INFO] [stdout] 117 | | "Enum '{}' must have an integer backing type", [INFO] [stdout] 118 | | parsed_enum.name [INFO] [stdout] 119 | | ) [INFO] [stdout] 120 | | .into(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 116 ~ format!( [INFO] [stdout] 117 + "Enum '{}' must have an integer backing type", [INFO] [stdout] 118 + parsed_enum.name [INFO] [stdout] 119 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/compiler_essentials.rs:1186:32 [INFO] [stdout] | [INFO] [stdout] 1186 | pub fn pop_layer_immutable<'a>(&self, symbols: &'a SymbolTable) -> Vec { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1186 - pub fn pop_layer_immutable<'a>(&self, symbols: &'a SymbolTable) -> Vec { [INFO] [stdout] 1186 + pub fn pop_layer_immutable(&self, symbols: &SymbolTable) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1192:9 [INFO] [stdout] | [INFO] [stdout] 1192 | return on_scope_exit; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1192 - return on_scope_exit; [INFO] [stdout] 1192 + on_scope_exit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1261:25 [INFO] [stdout] | [INFO] [stdout] 1261 | / return writeln!( [INFO] [stdout] 1262 | | f, [INFO] [stdout] 1263 | | "Unexpected character:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1264 | | &file[range.clone()], [INFO] [stdout] ... | [INFO] [stdout] 1267 | | col [INFO] [stdout] 1268 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1261 ~ writeln!( [INFO] [stdout] 1262 + f, [INFO] [stdout] 1263 + "Unexpected character:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1264 + &file[range.clone()], [INFO] [stdout] 1265 + path, [INFO] [stdout] 1266 + row + 1, [INFO] [stdout] 1267 + col [INFO] [stdout] 1268 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | 0.into(), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1293:25 [INFO] [stdout] | [INFO] [stdout] 1293 | / return writeln!( [INFO] [stdout] 1294 | | f, [INFO] [stdout] 1295 | | "Orphaned attr:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1296 | | &file[src_start..src_end], [INFO] [stdout] ... | [INFO] [stdout] 1299 | | col [INFO] [stdout] 1300 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1293 ~ writeln!( [INFO] [stdout] 1294 + f, [INFO] [stdout] 1295 + "Orphaned attr:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1296 + &file[src_start..src_end], [INFO] [stdout] 1297 + path, [INFO] [stdout] 1298 + row + 1, [INFO] [stdout] 1299 + col [INFO] [stdout] 1300 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1313:25 [INFO] [stdout] | [INFO] [stdout] 1313 | / return writeln!( [INFO] [stdout] 1314 | | f, [INFO] [stdout] 1315 | | "Expected name but found:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1316 | | &file[src_start..src_end], [INFO] [stdout] ... | [INFO] [stdout] 1319 | | col [INFO] [stdout] 1320 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1313 ~ writeln!( [INFO] [stdout] 1314 + f, [INFO] [stdout] 1315 + "Expected name but found:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1316 + &file[src_start..src_end], [INFO] [stdout] 1317 + path, [INFO] [stdout] 1318 + row + 1, [INFO] [stdout] 1319 + col [INFO] [stdout] 1320 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1333:25 [INFO] [stdout] | [INFO] [stdout] 1333 | / return writeln!( [INFO] [stdout] 1334 | | f, [INFO] [stdout] 1335 | | "Expected {} but found:{:?} (is {:?})\n\rat {}:{}:{}", [INFO] [stdout] 1336 | | expected, [INFO] [stdout] ... | [INFO] [stdout] 1341 | | col [INFO] [stdout] 1342 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1333 ~ writeln!( [INFO] [stdout] 1334 + f, [INFO] [stdout] 1335 + "Expected {} but found:{:?} (is {:?})\n\rat {}:{}:{}", [INFO] [stdout] 1336 + expected, [INFO] [stdout] 1337 + found, [INFO] [stdout] 1338 + &file[src_start..src_end], [INFO] [stdout] 1339 + path, [INFO] [stdout] 1340 + row + 1, [INFO] [stdout] 1341 + col [INFO] [stdout] 1342 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1355:25 [INFO] [stdout] | [INFO] [stdout] 1355 | / return writeln!( [INFO] [stdout] 1356 | | f, [INFO] [stdout] 1357 | | "Expected ';' but found:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1358 | | &file[src_start..src_end], [INFO] [stdout] ... | [INFO] [stdout] 1361 | | col [INFO] [stdout] 1362 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1355 ~ writeln!( [INFO] [stdout] 1356 + f, [INFO] [stdout] 1357 + "Expected ';' but found:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1358 + &file[src_start..src_end], [INFO] [stdout] 1359 + path, [INFO] [stdout] 1360 + row + 1, [INFO] [stdout] 1361 + col [INFO] [stdout] 1362 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | / if return_type.is_void() { [INFO] [stdout] 203 | | if body [INFO] [stdout] 204 | | .last() [INFO] [stdout] 205 | | .map(|x| matches!(x.stmt, Stmt::Return(..))) [INFO] [stdout] ... | [INFO] [stdout] 234 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 202 ~ if return_type.is_void() [INFO] [stdout] 203 ~ && body [INFO] [stdout] 204 | .last() [INFO] [stdout] ... [INFO] [stdout] 232 | new_body = Some(x) [INFO] [stdout] 233 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1255:35 [INFO] [stdout] | [INFO] [stdout] 1255 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1256 | | .char_indices() [INFO] [stdout] 1257 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1258 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1258 - .last() [INFO] [stdout] 1258 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/compiler_essentials.rs:1275:17 [INFO] [stdout] | [INFO] [stdout] 1275 | println!("{:?}|{:?}", range, error); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] = note: `#[warn(clippy::print_in_format_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:218:48 [INFO] [stdout] | [INFO] [stdout] 218 | CompilerError::Generic(format!( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 219 | | "TCFB: Trying to return something in void function" [INFO] [stdout] 220 | | )), [INFO] [stdout] | |_________________________^ help: consider using `.to_string()`: `"TCFB: Trying to return something in void function".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:236:5 [INFO] [stdout] | [INFO] [stdout] 236 | / if let Some(x) = new_body { [INFO] [stdout] 237 | | Some(x.into_boxed_slice()) [INFO] [stdout] 238 | | } else { [INFO] [stdout] 239 | | None [INFO] [stdout] 240 | | } [INFO] [stdout] | |_____^ help: try: `new_body.map(|x| x.into_boxed_slice())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/pass_type_check.rs:245:6 [INFO] [stdout] | [INFO] [stdout] 245 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler/passes/traits.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | -> CompileResult; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1287:35 [INFO] [stdout] | [INFO] [stdout] 1287 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1288 | | .char_indices() [INFO] [stdout] 1289 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1290 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1290 - .last() [INFO] [stdout] 1290 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/compiler/structs.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | / if let Ok(index) = self.keys.binary_search(entry_path) { [INFO] [stdout] 24 | | Some(index) [INFO] [stdout] 25 | | } else { [INFO] [stdout] 26 | | None [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ help: replace with: `self.keys.binary_search(entry_path).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1307:35 [INFO] [stdout] | [INFO] [stdout] 1307 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1308 | | .char_indices() [INFO] [stdout] 1309 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1310 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1310 - .last() [INFO] [stdout] 1310 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ContextPathDictionary` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/compiler/structs.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1327:35 [INFO] [stdout] | [INFO] [stdout] 1327 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1328 | | .char_indices() [INFO] [stdout] 1329 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1330 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1330 - .last() [INFO] [stdout] 1330 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/compiler/structs.rs:124:1 [INFO] [stdout] | [INFO] [stdout] 124 | / impl ToString for ContextPath { [INFO] [stdout] 125 | | fn to_string(&self) -> String { [INFO] [stdout] 126 | | self.path_sections.join(PATH_SECTION_SEPARATOR) [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1349:35 [INFO] [stdout] | [INFO] [stdout] 1349 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1350 | | .char_indices() [INFO] [stdout] 1351 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1352 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1352 - .last() [INFO] [stdout] 1352 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler/structs.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | / return Self { [INFO] [stdout] 190 | | context_path: ContextPath::new(concatedinated.into_boxed_slice()), [INFO] [stdout] 191 | | name: self.name.clone(), [INFO] [stdout] 192 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 ~ Self { [INFO] [stdout] 190 + context_path: ContextPath::new(concatedinated.into_boxed_slice()), [INFO] [stdout] 191 + name: self.name.clone(), [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:1395:63 [INFO] [stdout] | [INFO] [stdout] 1395 | pub fn from_function(id: usize, symbols: &SymbolTable) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/compiler/structs.rs:207:1 [INFO] [stdout] | [INFO] [stdout] 207 | / impl ToString for ContextPathEnd { [INFO] [stdout] 208 | | fn to_string(&self) -> String { [INFO] [stdout] 209 | | if self.context_path.path_sections.is_empty() { [INFO] [stdout] 210 | | self.name.to_string() [INFO] [stdout] ... | [INFO] [stdout] 219 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/compiler_essentials.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | / impl ToString for LLVMVal { [INFO] [stdout] 35 | | fn to_string(&self) -> String { [INFO] [stdout] 36 | | match self { [INFO] [stdout] 37 | | LLVMVal::Register(id) => format!("%tmp{}", id), [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler_essentials.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 47 | LLVMVal::Void => format!("void"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"void".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler_essentials.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | LLVMVal::Null => format!("null"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"null".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler_essentials.rs:1589:34 [INFO] [stdout] | [INFO] [stdout] 1589 | self.push_function_body(&format!("\tret void\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tret void\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:117:65 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn llvm_representation(&self, symbols: &SymbolTable) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:133:26 [INFO] [stdout] | [INFO] [stdout] 133 | .map(|param| param.llvm_representation(symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:1633:29 [INFO] [stdout] | [INFO] [stdout] 1633 | self.types.index_of(&fqn) [INFO] [stdout] | ^^^^ help: change this to: `fqn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:1636:33 [INFO] [stdout] | [INFO] [stdout] 1636 | self.functions.index_of(&fqn) [INFO] [stdout] | ^^^^ help: change this to: `fqn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:148:26 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|arg| arg.llvm_representation_in_generic(symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:1639:24 [INFO] [stdout] | [INFO] [stdout] 1639 | self.enums.get(&fqn) [INFO] [stdout] | ^^^^ help: change this to: `fqn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:1645:35 [INFO] [stdout] | [INFO] [stdout] 1645 | self.static_variables.get(&fqn).map(|x| (fqn, x)) [INFO] [stdout] | ^^^^ help: change this to: `fqn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:168:26 [INFO] [stdout] | [INFO] [stdout] 168 | .map(|arg| arg.llvm_representation_in_generic(symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/compiler_essentials.rs:1650:13 [INFO] [stdout] | [INFO] [stdout] 1650 | (*x).full_path = full_path; [INFO] [stdout] | ^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/compiler_essentials.rs:1660:13 [INFO] [stdout] | [INFO] [stdout] 1660 | (*x).full_path = full_path; [INFO] [stdout] | ^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/compiler_essentials.rs:1670:13 [INFO] [stdout] | [INFO] [stdout] 1670 | (*x).full_path = full_path; [INFO] [stdout] | ^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:185:76 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn llvm_representation_in_generic(&self, symbols: &SymbolTable) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:1684:10 [INFO] [stdout] | [INFO] [stdout] 1684 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:198:26 [INFO] [stdout] | [INFO] [stdout] 198 | .map(|arg| arg.llvm_representation_in_generic(symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1692:9 [INFO] [stdout] | [INFO] [stdout] 1692 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1692 - return Ok(()); [INFO] [stdout] 1692 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/compiler_essentials.rs:1685:16 [INFO] [stdout] | [INFO] [stdout] 1685 | if let Some(_) = self.static_variables.insert(&full_path, variable) { [INFO] [stdout] | -------^^^^^^^----------------------------------------------------- help: try: `if self.static_variables.insert(&full_path, variable).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:214:10 [INFO] [stdout] | [INFO] [stdout] 214 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:226:22 [INFO] [stdout] | [INFO] [stdout] 226 | .map(|a| Self::from_parser_type(a, symbols, current_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:46:6 [INFO] [stdout] | [INFO] [stdout] 46 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/compiler_essentials.rs:260:18 [INFO] [stdout] | [INFO] [stdout] 260 | .expect(&format!("Generic type {} not found", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Generic type {} not found", name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:87:6 [INFO] [stdout] | [INFO] [stdout] 87 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:314:10 [INFO] [stdout] | [INFO] [stdout] 314 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/compiler_essentials.rs:319:18 [INFO] [stdout] | [INFO] [stdout] 319 | .expect(&format!("Type {} not found", glob_path.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Type {} not found", glob_path.to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:139:6 [INFO] [stdout] | [INFO] [stdout] 139 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:361:10 [INFO] [stdout] | [INFO] [stdout] 361 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:166:6 [INFO] [stdout] | [INFO] [stdout] 166 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:366:75 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn substitute_global_aliases(&mut self, symbols: &SymbolTable) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:373:10 [INFO] [stdout] | [INFO] [stdout] 373 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:381:21 [INFO] [stdout] | [INFO] [stdout] 381 | / return Err(CompilerError::Generic(format!( [INFO] [stdout] 382 | | "Generic placeholder {} not found in substitution map", [INFO] [stdout] 383 | | name, [INFO] [stdout] 384 | | )) [INFO] [stdout] 385 | | .into()); [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 ~ Err(CompilerError::Generic(format!( [INFO] [stdout] 382 + "Generic placeholder {} not found in substitution map", [INFO] [stdout] 383 + name, [INFO] [stdout] 384 + )) [INFO] [stdout] 385 ~ .into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:202:6 [INFO] [stdout] | [INFO] [stdout] 202 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:239:6 [INFO] [stdout] | [INFO] [stdout] 239 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:267:6 [INFO] [stdout] | [INFO] [stdout] 267 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:309:6 [INFO] [stdout] | [INFO] [stdout] 309 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/compiler_essentials.rs:608:16 [INFO] [stdout] | [INFO] [stdout] 608 | fn to_byte(&self) -> u8 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:434:6 [INFO] [stdout] | [INFO] [stdout] 434 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_functions.rs:460:9 [INFO] [stdout] | [INFO] [stdout] 460 | -> CompileResult> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:754:9 [INFO] [stdout] | [INFO] [stdout] 754 | &self.full_path.name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.full_path.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/compiler_essentials.rs:768:16 [INFO] [stdout] | [INFO] [stdout] 768 | fn to_byte(&self) -> u8 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_functions.rs:545:18 [INFO] [stdout] | [INFO] [stdout] 545 | .map(|arg| match arg { [INFO] [stdout] | __________________^ [INFO] [stdout] 546 | | Expr::StringConst(s) => Ok(format!("~{{{}}}", s)), [INFO] [stdout] 547 | | _ => Err(CompilerError::Generic( [INFO] [stdout] 548 | | "asm() arg 1 (code) must be a string literal.".to_string(), [INFO] [stdout] 549 | | ) [INFO] [stdout] 550 | | .into()), [INFO] [stdout] 551 | | }) [INFO] [stdout] | |_____________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/compiler_functions.rs:559:45 [INFO] [stdout] | [INFO] [stdout] 559 | compiler.output.push_function_body(&format!( [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 560 | | "\t%asm{utvc} = call {} asm sideeffect inteldialect \"{}\", \"{}\"({})\n", [INFO] [stdout] 561 | | var_type, [INFO] [stdout] 562 | | asm_template_str, [INFO] [stdout] ... | [INFO] [stdout] 575 | | .join(", ") [INFO] [stdout] 576 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:863:9 [INFO] [stdout] | [INFO] [stdout] 863 | &self.full_path.name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.full_path.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/compiler_functions.rs:584:45 [INFO] [stdout] | [INFO] [stdout] 584 | compiler.output.push_function_body(&format!( [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 585 | | "\tstore {} {}, {}* {}\n", [INFO] [stdout] 586 | | var_type, [INFO] [stdout] 587 | | format!("%asm{utvc}"), [INFO] [stdout] 588 | | var_type, [INFO] [stdout] 589 | | var_pointer [INFO] [stdout] 590 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:866:9 [INFO] [stdout] | [INFO] [stdout] 866 | &self.full_path.context_path() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.full_path.context_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:916:10 [INFO] [stdout] | [INFO] [stdout] 916 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:925:10 [INFO] [stdout] | [INFO] [stdout] 925 | ) -> CompileResult<(Box, Box<[CompilerType]>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_essentials.rs:937:22 [INFO] [stdout] | [INFO] [stdout] 937 | .map(|(_, ty)| ty.with_substituted_generics(&map, symbols)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:81:39 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn try_get_llvm_rep(&self) -> CompileResult<&LLVMVal> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/compiler_essentials.rs:962:16 [INFO] [stdout] | [INFO] [stdout] 962 | fn to_byte(&self) -> u8 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:162:10 [INFO] [stdout] | [INFO] [stdout] 162 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:1066:10 [INFO] [stdout] | [INFO] [stdout] 1066 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/expression_compiler.rs:213:30 [INFO] [stdout] | [INFO] [stdout] 213 | .map(|x| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 214 | | x.1.with_substituted_generics(&map, self.symbols()) [INFO] [stdout] 215 | | .map(|y| (x.0.clone(), y)) [INFO] [stdout] 216 | | }) [INFO] [stdout] | |_________________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1139:9 [INFO] [stdout] | [INFO] [stdout] 1139 | return on_scope_exit; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1139 - return on_scope_exit; [INFO] [stdout] 1139 + on_scope_exit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1148:9 [INFO] [stdout] | [INFO] [stdout] 1148 | return on_scope_exit; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1148 - return on_scope_exit; [INFO] [stdout] 1148 + on_scope_exit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/compiler_essentials.rs:1186:32 [INFO] [stdout] | [INFO] [stdout] 1186 | pub fn pop_layer_immutable<'a>(&self, symbols: &'a SymbolTable) -> Vec { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1186 - pub fn pop_layer_immutable<'a>(&self, symbols: &'a SymbolTable) -> Vec { [INFO] [stdout] 1186 + pub fn pop_layer_immutable(&self, symbols: &SymbolTable) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1192:9 [INFO] [stdout] | [INFO] [stdout] 1192 | return on_scope_exit; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1192 - return on_scope_exit; [INFO] [stdout] 1192 + on_scope_exit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:282:10 [INFO] [stdout] | [INFO] [stdout] 282 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | return Err(CompilerError::Generic(format!("{:?}", name)).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return Err(CompilerError::Generic(format!("{:?}", name)).into()); [INFO] [stdout] 350 + Err(CompilerError::Generic(format!("{:?}", name)).into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:368:10 [INFO] [stdout] | [INFO] [stdout] 368 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1261:25 [INFO] [stdout] | [INFO] [stdout] 1261 | / return writeln!( [INFO] [stdout] 1262 | | f, [INFO] [stdout] 1263 | | "Unexpected character:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1264 | | &file[range.clone()], [INFO] [stdout] ... | [INFO] [stdout] 1267 | | col [INFO] [stdout] 1268 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1261 ~ writeln!( [INFO] [stdout] 1262 + f, [INFO] [stdout] 1263 + "Unexpected character:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1264 + &file[range.clone()], [INFO] [stdout] 1265 + path, [INFO] [stdout] 1266 + row + 1, [INFO] [stdout] 1267 + col [INFO] [stdout] 1268 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1293:25 [INFO] [stdout] | [INFO] [stdout] 1293 | / return writeln!( [INFO] [stdout] 1294 | | f, [INFO] [stdout] 1295 | | "Orphaned attr:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1296 | | &file[src_start..src_end], [INFO] [stdout] ... | [INFO] [stdout] 1299 | | col [INFO] [stdout] 1300 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1293 ~ writeln!( [INFO] [stdout] 1294 + f, [INFO] [stdout] 1295 + "Orphaned attr:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1296 + &file[src_start..src_end], [INFO] [stdout] 1297 + path, [INFO] [stdout] 1298 + row + 1, [INFO] [stdout] 1299 + col [INFO] [stdout] 1300 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:398:10 [INFO] [stdout] | [INFO] [stdout] 398 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:416:10 [INFO] [stdout] | [INFO] [stdout] 416 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/expression_compiler.rs:413:15 [INFO] [stdout] | [INFO] [stdout] 413 | name: &Box, [INFO] [stdout] | ^^^^^^^^^^ help: try: `&Expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1313:25 [INFO] [stdout] | [INFO] [stdout] 1313 | / return writeln!( [INFO] [stdout] 1314 | | f, [INFO] [stdout] 1315 | | "Expected name but found:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1316 | | &file[src_start..src_end], [INFO] [stdout] ... | [INFO] [stdout] 1319 | | col [INFO] [stdout] 1320 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1313 ~ writeln!( [INFO] [stdout] 1314 + f, [INFO] [stdout] 1315 + "Expected name but found:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1316 + &file[src_start..src_end], [INFO] [stdout] 1317 + path, [INFO] [stdout] 1318 + row + 1, [INFO] [stdout] 1319 + col [INFO] [stdout] 1320 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1333:25 [INFO] [stdout] | [INFO] [stdout] 1333 | / return writeln!( [INFO] [stdout] 1334 | | f, [INFO] [stdout] 1335 | | "Expected {} but found:{:?} (is {:?})\n\rat {}:{}:{}", [INFO] [stdout] 1336 | | expected, [INFO] [stdout] ... | [INFO] [stdout] 1341 | | col [INFO] [stdout] 1342 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1333 ~ writeln!( [INFO] [stdout] 1334 + f, [INFO] [stdout] 1335 + "Expected {} but found:{:?} (is {:?})\n\rat {}:{}:{}", [INFO] [stdout] 1336 + expected, [INFO] [stdout] 1337 + found, [INFO] [stdout] 1338 + &file[src_start..src_end], [INFO] [stdout] 1339 + path, [INFO] [stdout] 1340 + row + 1, [INFO] [stdout] 1341 + col [INFO] [stdout] 1342 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1355:25 [INFO] [stdout] | [INFO] [stdout] 1355 | / return writeln!( [INFO] [stdout] 1356 | | f, [INFO] [stdout] 1357 | | "Expected ';' but found:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1358 | | &file[src_start..src_end], [INFO] [stdout] ... | [INFO] [stdout] 1361 | | col [INFO] [stdout] 1362 | | ); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1355 ~ writeln!( [INFO] [stdout] 1356 + f, [INFO] [stdout] 1357 + "Expected ';' but found:{:?}\n\rat {}:{}:{}", [INFO] [stdout] 1358 + &file[src_start..src_end], [INFO] [stdout] 1359 + path, [INFO] [stdout] 1360 + row + 1, [INFO] [stdout] 1361 + col [INFO] [stdout] 1362 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1255:35 [INFO] [stdout] | [INFO] [stdout] 1255 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1256 | | .char_indices() [INFO] [stdout] 1257 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1258 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1258 - .last() [INFO] [stdout] 1258 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/compiler_essentials.rs:1275:17 [INFO] [stdout] | [INFO] [stdout] 1275 | println!("{:?}|{:?}", range, error); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] = note: `#[warn(clippy::print_in_format_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:448:10 [INFO] [stdout] | [INFO] [stdout] 448 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1287:35 [INFO] [stdout] | [INFO] [stdout] 1287 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1288 | | .char_indices() [INFO] [stdout] 1289 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1290 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1290 - .last() [INFO] [stdout] 1290 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1307:35 [INFO] [stdout] | [INFO] [stdout] 1307 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1308 | | .char_indices() [INFO] [stdout] 1309 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1310 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1310 - .last() [INFO] [stdout] 1310 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/expression_compiler.rs:495:98 [INFO] [stdout] | [INFO] [stdout] 495 | if ltype.is_pointer() && right.as_literal_number().map(|x| *x == 0).unwrap_or(false) { [INFO] [stdout] | __________________________________________________________________________________________________^ [INFO] [stdout] 496 | | } else if rtype.is_pointer() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/expression_compiler.rs:498:13 [INFO] [stdout] | [INFO] [stdout] 498 | / { [INFO] [stdout] 499 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:502:51 [INFO] [stdout] | [INFO] [stdout] 502 | return Err(CompilerError::Generic(format!("Type Missmatch")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type Missmatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1327:35 [INFO] [stdout] | [INFO] [stdout] 1327 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1328 | | .char_indices() [INFO] [stdout] 1329 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1330 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1330 - .last() [INFO] [stdout] 1330 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:548:10 [INFO] [stdout] | [INFO] [stdout] 548 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/compiler_essentials.rs:1349:35 [INFO] [stdout] | [INFO] [stdout] 1349 | let col = c [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1350 | | .char_indices() [INFO] [stdout] 1351 | | .filter(|x| x.1 == '\n') [INFO] [stdout] 1352 | | .last() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1352 - .last() [INFO] [stdout] 1352 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:557:47 [INFO] [stdout] | [INFO] [stdout] 557 | return Err(CompilerError::Generic(format!("Not Boolean")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Not Boolean".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:1395:63 [INFO] [stdout] | [INFO] [stdout] 1395 | pub fn from_function(id: usize, symbols: &SymbolTable) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:604:47 [INFO] [stdout] | [INFO] [stdout] 604 | return Err(CompilerError::Generic(format!("Not boolean")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Not boolean".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:631:10 [INFO] [stdout] | [INFO] [stdout] 631 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:654:9 [INFO] [stdout] | [INFO] [stdout] 654 | / return Ok(CompiledValue::new_value( [INFO] [stdout] 655 | | LLVMVal::Register(utvc), [INFO] [stdout] 656 | | CompilerType::Primitive(BOOL_TYPE), [INFO] [stdout] 657 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 654 ~ Ok(CompiledValue::new_value( [INFO] [stdout] 655 + LLVMVal::Register(utvc), [INFO] [stdout] 656 + CompilerType::Primitive(BOOL_TYPE), [INFO] [stdout] 657 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:665:10 [INFO] [stdout] | [INFO] [stdout] 665 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:749:9 [INFO] [stdout] | [INFO] [stdout] 749 | / return Ok(CompiledValue::new_value( [INFO] [stdout] 750 | | LLVMVal::Register(utvc), [INFO] [stdout] 751 | | result_type, [INFO] [stdout] 752 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 749 ~ Ok(CompiledValue::new_value( [INFO] [stdout] 750 + LLVMVal::Register(utvc), [INFO] [stdout] 751 + result_type, [INFO] [stdout] 752 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:760:10 [INFO] [stdout] | [INFO] [stdout] 760 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:795:9 [INFO] [stdout] | [INFO] [stdout] 795 | / return Ok(CompiledValue::new_value( [INFO] [stdout] 796 | | LLVMVal::Register(utvc), [INFO] [stdout] 797 | | result_type, [INFO] [stdout] 798 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 795 ~ Ok(CompiledValue::new_value( [INFO] [stdout] 796 + LLVMVal::Register(utvc), [INFO] [stdout] 797 + result_type, [INFO] [stdout] 798 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:805:10 [INFO] [stdout] | [INFO] [stdout] 805 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler_essentials.rs:1589:34 [INFO] [stdout] | [INFO] [stdout] 1589 | self.push_function_body(&format!("\tret void\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tret void\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:817:47 [INFO] [stdout] | [INFO] [stdout] 817 | return Err(CompilerError::Generic(format!("Type mismatch")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type mismatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:840:10 [INFO] [stdout] | [INFO] [stdout] 840 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/expression_compiler.rs:863:34 [INFO] [stdout] | [INFO] [stdout] 863 | ... .map(|x| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 864 | | ... CompilerType::from_parser_type( [INFO] [stdout] 865 | | ... x, [INFO] [stdout] 866 | | ... self.symbols(), [INFO] [stdout] ... | [INFO] [stdout] 869 | | ... }) [INFO] [stdout] | |_______________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:1633:29 [INFO] [stdout] | [INFO] [stdout] 1633 | self.types.index_of(&fqn) [INFO] [stdout] | ^^^^ help: change this to: `fqn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:1636:33 [INFO] [stdout] | [INFO] [stdout] 1636 | self.functions.index_of(&fqn) [INFO] [stdout] | ^^^^ help: change this to: `fqn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:1639:24 [INFO] [stdout] | [INFO] [stdout] 1639 | self.enums.get(&fqn) [INFO] [stdout] | ^^^^ help: change this to: `fqn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler_essentials.rs:1645:35 [INFO] [stdout] | [INFO] [stdout] 1645 | self.static_variables.get(&fqn).map(|x| (fqn, x)) [INFO] [stdout] | ^^^^ help: change this to: `fqn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/compiler_essentials.rs:1650:13 [INFO] [stdout] | [INFO] [stdout] 1650 | (*x).full_path = full_path; [INFO] [stdout] | ^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/compiler_essentials.rs:1660:13 [INFO] [stdout] | [INFO] [stdout] 1660 | (*x).full_path = full_path; [INFO] [stdout] | ^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/compiler_essentials.rs:1670:13 [INFO] [stdout] | [INFO] [stdout] 1670 | (*x).full_path = full_path; [INFO] [stdout] | ^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:947:44 [INFO] [stdout] | [INFO] [stdout] 947 | CompilerError::Generic(format!("Type missmatch")).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type missmatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_essentials.rs:1684:10 [INFO] [stdout] | [INFO] [stdout] 1684 | ) -> CompileResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler_essentials.rs:1692:9 [INFO] [stdout] | [INFO] [stdout] 1692 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1692 - return Ok(()); [INFO] [stdout] 1692 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/compiler_essentials.rs:1685:16 [INFO] [stdout] | [INFO] [stdout] 1685 | if let Some(_) = self.static_variables.insert(&full_path, variable) { [INFO] [stdout] | -------^^^^^^^----------------------------------------------------- help: try: `if self.static_variables.insert(&full_path, variable).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:46:6 [INFO] [stdout] | [INFO] [stdout] 46 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:991:10 [INFO] [stdout] | [INFO] [stdout] 991 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1065:9 [INFO] [stdout] | [INFO] [stdout] 1065 | / return Ok(CompiledValue::Value { [INFO] [stdout] 1066 | | llvm_repr: LLVMVal::Register(phi_uid), [INFO] [stdout] 1067 | | val_type: func_return_type.clone(), [INFO] [stdout] 1068 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1065 ~ Ok(CompiledValue::Value { [INFO] [stdout] 1066 + llvm_repr: LLVMVal::Register(phi_uid), [INFO] [stdout] 1067 + val_type: func_return_type.clone(), [INFO] [stdout] 1068 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/expression_compiler.rs:1018:9 [INFO] [stdout] | [INFO] [stdout] 1018 | code_gen_ctx.current_function_return_type = func_return_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `compiler::passes::pass_llvm_gen::CodeGenContext { current_function_return_type: func_return_type.clone(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/expression_compiler.rs:1017:9 [INFO] [stdout] | [INFO] [stdout] 1017 | let mut code_gen_ctx = CodeGenContext::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1011:51 [INFO] [stdout] | [INFO] [stdout] 1011 | return Err(CompilerError::Generic(format!("Type missmatch")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type missmatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:87:6 [INFO] [stdout] | [INFO] [stdout] 87 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:139:6 [INFO] [stdout] | [INFO] [stdout] 139 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:166:6 [INFO] [stdout] | [INFO] [stdout] 166 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1075:10 [INFO] [stdout] | [INFO] [stdout] 1075 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:202:6 [INFO] [stdout] | [INFO] [stdout] 202 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:239:6 [INFO] [stdout] | [INFO] [stdout] 239 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expression_compiler.rs:1133:25 [INFO] [stdout] | [INFO] [stdout] 1133 | &&LLVMVal::ConstantDecimal(0.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(&LLVMVal::ConstantDecimal(0.0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1162:55 [INFO] [stdout] | [INFO] [stdout] 1162 | return Err(CompilerError::Generic(format!( [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 1163 | | "Logical NOT can only be applied to booleans" [INFO] [stdout] 1164 | | )) [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `"Logical NOT can only be applied to booleans".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:267:6 [INFO] [stdout] | [INFO] [stdout] 267 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1185:10 [INFO] [stdout] | [INFO] [stdout] 1185 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1193:47 [INFO] [stdout] | [INFO] [stdout] 1193 | return Err(CompilerError::Generic(format!("Expected name")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expected name".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:309:6 [INFO] [stdout] | [INFO] [stdout] 309 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1223:64 [INFO] [stdout] | [INFO] [stdout] 1223 | fn compile_member_access_rvalue(&mut self, expr: &Expr) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1234:71 [INFO] [stdout] | [INFO] [stdout] 1234 | fn compile_index_rvalue(&mut self, array: &Expr, index: &Expr) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1241:9 [INFO] [stdout] | [INFO] [stdout] 1241 | / return Ok(CompiledValue::new_value( [INFO] [stdout] 1242 | | LLVMVal::Register(temp_id), [INFO] [stdout] 1243 | | ltype.clone(), [INFO] [stdout] 1244 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1241 ~ Ok(CompiledValue::new_value( [INFO] [stdout] 1242 + LLVMVal::Register(temp_id), [INFO] [stdout] 1243 + ltype.clone(), [INFO] [stdout] 1244 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1251:10 [INFO] [stdout] | [INFO] [stdout] 1251 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/compiler_functions.rs:434:6 [INFO] [stdout] | [INFO] [stdout] 434 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1268:51 [INFO] [stdout] | [INFO] [stdout] 1268 | fn compile_boolean(&mut self, value: bool) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1274:59 [INFO] [stdout] | [INFO] [stdout] 1274 | fn compile_null(&mut self, expected: Expected<'_>) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1283:60 [INFO] [stdout] | [INFO] [stdout] 1283 | fn compile_string_literal(&mut self, str_val: &str) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1297:10 [INFO] [stdout] | [INFO] [stdout] 1297 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1331:10 [INFO] [stdout] | [INFO] [stdout] 1331 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_functions.rs:460:9 [INFO] [stdout] | [INFO] [stdout] 460 | -> CompileResult> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/expression_compiler.rs:1370:24 [INFO] [stdout] | [INFO] [stdout] 1370 | return Ok(CompiledLValue::from_function(function, self.symbols())?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 1370 - return Ok(CompiledLValue::from_function(function, self.symbols())?); [INFO] [stdout] 1370 + return CompiledLValue::from_function(function, self.symbols()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/expression_compiler.rs:1388:24 [INFO] [stdout] | [INFO] [stdout] 1388 | return Ok(CompiledLValue::from_function(function, self.symbols())?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 1388 - return Ok(CompiledLValue::from_function(function, self.symbols())?); [INFO] [stdout] 1388 + return CompiledLValue::from_function(function, self.symbols()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/compiler_functions.rs:545:18 [INFO] [stdout] | [INFO] [stdout] 545 | .map(|arg| match arg { [INFO] [stdout] | __________________^ [INFO] [stdout] 546 | | Expr::StringConst(s) => Ok(format!("~{{{}}}", s)), [INFO] [stdout] 547 | | _ => Err(CompilerError::Generic( [INFO] [stdout] 548 | | "asm() arg 1 (code) must be a string literal.".to_string(), [INFO] [stdout] 549 | | ) [INFO] [stdout] 550 | | .into()), [INFO] [stdout] 551 | | }) [INFO] [stdout] | |_____________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1403:10 [INFO] [stdout] | [INFO] [stdout] 1403 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/compiler_functions.rs:559:45 [INFO] [stdout] | [INFO] [stdout] 559 | compiler.output.push_function_body(&format!( [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 560 | | "\t%asm{utvc} = call {} asm sideeffect inteldialect \"{}\", \"{}\"({})\n", [INFO] [stdout] 561 | | var_type, [INFO] [stdout] 562 | | asm_template_str, [INFO] [stdout] ... | [INFO] [stdout] 575 | | .join(", ") [INFO] [stdout] 576 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1418:55 [INFO] [stdout] | [INFO] [stdout] 1418 | return Err(CompilerError::Generic(format!("Function is not generic")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Function is not generic".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/compiler_functions.rs:584:45 [INFO] [stdout] | [INFO] [stdout] 584 | compiler.output.push_function_body(&format!( [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 585 | | "\tstore {} {}, {}* {}\n", [INFO] [stdout] 586 | | var_type, [INFO] [stdout] 587 | | format!("%asm{utvc}"), [INFO] [stdout] 588 | | var_type, [INFO] [stdout] 589 | | var_pointer [INFO] [stdout] 590 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1458:10 [INFO] [stdout] | [INFO] [stdout] 1458 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1493:17 [INFO] [stdout] | [INFO] [stdout] 1493 | / return Ok(CompiledLValue::new( [INFO] [stdout] 1494 | | LLVMVal::Register(utvc), [INFO] [stdout] 1495 | | field_type.clone(), [INFO] [stdout] 1496 | | true, [INFO] [stdout] 1497 | | )); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1493 ~ Ok(CompiledLValue::new( [INFO] [stdout] 1494 + LLVMVal::Register(utvc), [INFO] [stdout] 1495 + field_type.clone(), [INFO] [stdout] 1496 + true, [INFO] [stdout] 1497 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1526:17 [INFO] [stdout] | [INFO] [stdout] 1526 | / return Ok(CompiledLValue::new( [INFO] [stdout] 1527 | | LLVMVal::Register(utvc), [INFO] [stdout] 1528 | | field_type.clone(), [INFO] [stdout] 1529 | | true, [INFO] [stdout] 1530 | | )); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1526 ~ Ok(CompiledLValue::new( [INFO] [stdout] 1527 + LLVMVal::Register(utvc), [INFO] [stdout] 1528 + field_type.clone(), [INFO] [stdout] 1529 + true, [INFO] [stdout] 1530 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1533:17 [INFO] [stdout] | [INFO] [stdout] 1533 | / return Err(CompilerError::Generic(format!( [INFO] [stdout] 1534 | | "Cannot access member '{}' of non-struct type {:?}", [INFO] [stdout] 1535 | | member, struct_type [INFO] [stdout] 1536 | | )) [INFO] [stdout] 1537 | | .into()) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1533 ~ Err(CompilerError::Generic(format!( [INFO] [stdout] 1534 + "Cannot access member '{}' of non-struct type {:?}", [INFO] [stdout] 1535 + member, struct_type [INFO] [stdout] 1536 + )) [INFO] [stdout] 1537 + .into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/expression_compiler.rs:1482:22 [INFO] [stdout] | [INFO] [stdout] 1482 | .expect(&format!("Member {} not found inside ", member)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Member {} not found inside ", member))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1491:23 [INFO] [stdout] | [INFO] [stdout] 1491 | &[format!("i32 0"), format!("i32 {}", index)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"i32 0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1524:23 [INFO] [stdout] | [INFO] [stdout] 1524 | &[format!("i32 0"), format!("i32 {}", index)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"i32 0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:81:39 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn try_get_llvm_rep(&self) -> CompileResult<&LLVMVal> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1547:10 [INFO] [stdout] | [INFO] [stdout] 1547 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1559:55 [INFO] [stdout] | [INFO] [stdout] 1559 | return Err(CompilerError::Generic(format!( [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 1560 | | "Trying to read value outside of bound of constant array" [INFO] [stdout] 1561 | | )) [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `"Trying to read value outside of bound of constant array".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:162:10 [INFO] [stdout] | [INFO] [stdout] 162 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1573:21 [INFO] [stdout] | [INFO] [stdout] 1573 | format!("i32 0"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"i32 0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/expression_compiler.rs:213:30 [INFO] [stdout] | [INFO] [stdout] 213 | .map(|x| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 214 | | x.1.with_substituted_generics(&map, self.symbols()) [INFO] [stdout] 215 | | .map(|y| (x.0.clone(), y)) [INFO] [stdout] 216 | | }) [INFO] [stdout] | |_________________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1637:10 [INFO] [stdout] | [INFO] [stdout] 1637 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1645:47 [INFO] [stdout] | [INFO] [stdout] 1645 | return Err(CompilerError::Generic(format!("Expected name")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expected name".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1661:10 [INFO] [stdout] | [INFO] [stdout] 1661 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1677:9 [INFO] [stdout] | [INFO] [stdout] 1677 | / return Ok(CompiledLValue::new( [INFO] [stdout] 1678 | | llvm_repr.get_llvm_rep().clone(), [INFO] [stdout] 1679 | | ptype.clone(), [INFO] [stdout] 1680 | | true, [INFO] [stdout] 1681 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1677 ~ Ok(CompiledLValue::new( [INFO] [stdout] 1678 + llvm_repr.get_llvm_rep().clone(), [INFO] [stdout] 1679 + ptype.clone(), [INFO] [stdout] 1680 + true, [INFO] [stdout] 1681 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:282:10 [INFO] [stdout] | [INFO] [stdout] 282 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | return Err(CompilerError::Generic(format!("{:?}", name)).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return Err(CompilerError::Generic(format!("{:?}", name)).into()); [INFO] [stdout] 350 + Err(CompilerError::Generic(format!("{:?}", name)).into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1688:10 [INFO] [stdout] | [INFO] [stdout] 1688 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1804:9 [INFO] [stdout] | [INFO] [stdout] 1804 | return Err(CompilerError::Generic(format!("()")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1804 - return Err(CompilerError::Generic(format!("()")).into()); [INFO] [stdout] 1804 + Err(CompilerError::Generic(format!("()")).into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:368:10 [INFO] [stdout] | [INFO] [stdout] 368 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1804:43 [INFO] [stdout] | [INFO] [stdout] 1804 | return Err(CompilerError::Generic(format!("()")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"()".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:398:10 [INFO] [stdout] | [INFO] [stdout] 398 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:416:10 [INFO] [stdout] | [INFO] [stdout] 416 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/expression_compiler.rs:413:15 [INFO] [stdout] | [INFO] [stdout] 413 | name: &Box, [INFO] [stdout] | ^^^^^^^^^^ help: try: `&Expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:448:10 [INFO] [stdout] | [INFO] [stdout] 448 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/expression_compiler.rs:495:98 [INFO] [stdout] | [INFO] [stdout] 495 | if ltype.is_pointer() && right.as_literal_number().map(|x| *x == 0).unwrap_or(false) { [INFO] [stdout] | __________________________________________________________________________________________________^ [INFO] [stdout] 496 | | } else if rtype.is_pointer() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/expression_compiler.rs:498:13 [INFO] [stdout] | [INFO] [stdout] 498 | / { [INFO] [stdout] 499 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:502:51 [INFO] [stdout] | [INFO] [stdout] 502 | return Err(CompilerError::Generic(format!("Type Missmatch")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type Missmatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: order comparisons between booleans can be simplified [INFO] [stdout] --> src/expression_compiler.rs:1964:72 [INFO] [stdout] | [INFO] [stdout] 1964 | BinaryOp::Less => return Some(LLVMVal::ConstantBoolean(l < r)), [INFO] [stdout] | ^^^^^ help: try: `!l & r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: order comparisons between booleans can be simplified [INFO] [stdout] --> src/expression_compiler.rs:1966:75 [INFO] [stdout] | [INFO] [stdout] 1966 | BinaryOp::Greater => return Some(LLVMVal::ConstantBoolean(l > r)), [INFO] [stdout] | ^^^^^ help: try: `l & !r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:548:10 [INFO] [stdout] | [INFO] [stdout] 548 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:557:47 [INFO] [stdout] | [INFO] [stdout] 557 | return Err(CompilerError::Generic(format!("Not Boolean")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Not Boolean".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/expression_compiler.rs:2042:13 [INFO] [stdout] | [INFO] [stdout] 2042 | / if let Some(new_inner) = opt_e { [INFO] [stdout] 2043 | | Some(Expr::UnaryOp(*op, Box::new(new_inner))) [INFO] [stdout] 2044 | | } else { [INFO] [stdout] 2045 | | None [INFO] [stdout] 2046 | | } [INFO] [stdout] | |_____________^ help: try: `opt_e.map(|new_inner| Expr::UnaryOp(*op, Box::new(new_inner)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:604:47 [INFO] [stdout] | [INFO] [stdout] 604 | return Err(CompilerError::Generic(format!("Not boolean")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Not boolean".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:2107:6 [INFO] [stdout] | [INFO] [stdout] 2107 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:631:10 [INFO] [stdout] | [INFO] [stdout] 631 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:654:9 [INFO] [stdout] | [INFO] [stdout] 654 | / return Ok(CompiledValue::new_value( [INFO] [stdout] 655 | | LLVMVal::Register(utvc), [INFO] [stdout] 656 | | CompilerType::Primitive(BOOL_TYPE), [INFO] [stdout] 657 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 654 ~ Ok(CompiledValue::new_value( [INFO] [stdout] 655 + LLVMVal::Register(utvc), [INFO] [stdout] 656 + CompilerType::Primitive(BOOL_TYPE), [INFO] [stdout] 657 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:665:10 [INFO] [stdout] | [INFO] [stdout] 665 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:749:9 [INFO] [stdout] | [INFO] [stdout] 749 | / return Ok(CompiledValue::new_value( [INFO] [stdout] 750 | | LLVMVal::Register(utvc), [INFO] [stdout] 751 | | result_type, [INFO] [stdout] 752 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 749 ~ Ok(CompiledValue::new_value( [INFO] [stdout] 750 + LLVMVal::Register(utvc), [INFO] [stdout] 751 + result_type, [INFO] [stdout] 752 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:760:10 [INFO] [stdout] | [INFO] [stdout] 760 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:795:9 [INFO] [stdout] | [INFO] [stdout] 795 | / return Ok(CompiledValue::new_value( [INFO] [stdout] 796 | | LLVMVal::Register(utvc), [INFO] [stdout] 797 | | result_type, [INFO] [stdout] 798 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 795 ~ Ok(CompiledValue::new_value( [INFO] [stdout] 796 + LLVMVal::Register(utvc), [INFO] [stdout] 797 + result_type, [INFO] [stdout] 798 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:805:10 [INFO] [stdout] | [INFO] [stdout] 805 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:817:47 [INFO] [stdout] | [INFO] [stdout] 817 | return Err(CompilerError::Generic(format!("Type mismatch")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type mismatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:840:10 [INFO] [stdout] | [INFO] [stdout] 840 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/expression_compiler.rs:863:34 [INFO] [stdout] | [INFO] [stdout] 863 | ... .map(|x| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 864 | | ... CompilerType::from_parser_type( [INFO] [stdout] 865 | | ... x, [INFO] [stdout] 866 | | ... self.symbols(), [INFO] [stdout] ... | [INFO] [stdout] 869 | | ... }) [INFO] [stdout] | |_______________________^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:947:44 [INFO] [stdout] | [INFO] [stdout] 947 | CompilerError::Generic(format!("Type missmatch")).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type missmatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:991:10 [INFO] [stdout] | [INFO] [stdout] 991 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1065:9 [INFO] [stdout] | [INFO] [stdout] 1065 | / return Ok(CompiledValue::Value { [INFO] [stdout] 1066 | | llvm_repr: LLVMVal::Register(phi_uid), [INFO] [stdout] 1067 | | val_type: func_return_type.clone(), [INFO] [stdout] 1068 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1065 ~ Ok(CompiledValue::Value { [INFO] [stdout] 1066 + llvm_repr: LLVMVal::Register(phi_uid), [INFO] [stdout] 1067 + val_type: func_return_type.clone(), [INFO] [stdout] 1068 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/expression_compiler.rs:1018:9 [INFO] [stdout] | [INFO] [stdout] 1018 | code_gen_ctx.current_function_return_type = func_return_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `compiler::passes::pass_llvm_gen::CodeGenContext { current_function_return_type: func_return_type.clone(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/expression_compiler.rs:1017:9 [INFO] [stdout] | [INFO] [stdout] 1017 | let mut code_gen_ctx = CodeGenContext::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1011:51 [INFO] [stdout] | [INFO] [stdout] 1011 | return Err(CompilerError::Generic(format!("Type missmatch")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Type missmatch".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1075:10 [INFO] [stdout] | [INFO] [stdout] 1075 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/expression_compiler.rs:1133:25 [INFO] [stdout] | [INFO] [stdout] 1133 | &&LLVMVal::ConstantDecimal(0.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(&LLVMVal::ConstantDecimal(0.0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1162:55 [INFO] [stdout] | [INFO] [stdout] 1162 | return Err(CompilerError::Generic(format!( [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 1163 | | "Logical NOT can only be applied to booleans" [INFO] [stdout] 1164 | | )) [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `"Logical NOT can only be applied to booleans".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1185:10 [INFO] [stdout] | [INFO] [stdout] 1185 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1193:47 [INFO] [stdout] | [INFO] [stdout] 1193 | return Err(CompilerError::Generic(format!("Expected name")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expected name".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1223:64 [INFO] [stdout] | [INFO] [stdout] 1223 | fn compile_member_access_rvalue(&mut self, expr: &Expr) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1234:71 [INFO] [stdout] | [INFO] [stdout] 1234 | fn compile_index_rvalue(&mut self, array: &Expr, index: &Expr) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1241:9 [INFO] [stdout] | [INFO] [stdout] 1241 | / return Ok(CompiledValue::new_value( [INFO] [stdout] 1242 | | LLVMVal::Register(temp_id), [INFO] [stdout] 1243 | | ltype.clone(), [INFO] [stdout] 1244 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1241 ~ Ok(CompiledValue::new_value( [INFO] [stdout] 1242 + LLVMVal::Register(temp_id), [INFO] [stdout] 1243 + ltype.clone(), [INFO] [stdout] 1244 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1251:10 [INFO] [stdout] | [INFO] [stdout] 1251 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1268:51 [INFO] [stdout] | [INFO] [stdout] 1268 | fn compile_boolean(&mut self, value: bool) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1274:59 [INFO] [stdout] | [INFO] [stdout] 1274 | fn compile_null(&mut self, expected: Expected<'_>) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1283:60 [INFO] [stdout] | [INFO] [stdout] 1283 | fn compile_string_literal(&mut self, str_val: &str) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1297:10 [INFO] [stdout] | [INFO] [stdout] 1297 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1331:10 [INFO] [stdout] | [INFO] [stdout] 1331 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/expression_compiler.rs:1370:24 [INFO] [stdout] | [INFO] [stdout] 1370 | return Ok(CompiledLValue::from_function(function, self.symbols())?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 1370 - return Ok(CompiledLValue::from_function(function, self.symbols())?); [INFO] [stdout] 1370 + return CompiledLValue::from_function(function, self.symbols()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/expression_compiler.rs:1388:24 [INFO] [stdout] | [INFO] [stdout] 1388 | return Ok(CompiledLValue::from_function(function, self.symbols())?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 1388 - return Ok(CompiledLValue::from_function(function, self.symbols())?); [INFO] [stdout] 1388 + return CompiledLValue::from_function(function, self.symbols()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1403:10 [INFO] [stdout] | [INFO] [stdout] 1403 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1418:55 [INFO] [stdout] | [INFO] [stdout] 1418 | return Err(CompilerError::Generic(format!("Function is not generic")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Function is not generic".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1458:10 [INFO] [stdout] | [INFO] [stdout] 1458 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1493:17 [INFO] [stdout] | [INFO] [stdout] 1493 | / return Ok(CompiledLValue::new( [INFO] [stdout] 1494 | | LLVMVal::Register(utvc), [INFO] [stdout] 1495 | | field_type.clone(), [INFO] [stdout] 1496 | | true, [INFO] [stdout] 1497 | | )); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1493 ~ Ok(CompiledLValue::new( [INFO] [stdout] 1494 + LLVMVal::Register(utvc), [INFO] [stdout] 1495 + field_type.clone(), [INFO] [stdout] 1496 + true, [INFO] [stdout] 1497 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1526:17 [INFO] [stdout] | [INFO] [stdout] 1526 | / return Ok(CompiledLValue::new( [INFO] [stdout] 1527 | | LLVMVal::Register(utvc), [INFO] [stdout] 1528 | | field_type.clone(), [INFO] [stdout] 1529 | | true, [INFO] [stdout] 1530 | | )); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1526 ~ Ok(CompiledLValue::new( [INFO] [stdout] 1527 + LLVMVal::Register(utvc), [INFO] [stdout] 1528 + field_type.clone(), [INFO] [stdout] 1529 + true, [INFO] [stdout] 1530 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1533:17 [INFO] [stdout] | [INFO] [stdout] 1533 | / return Err(CompilerError::Generic(format!( [INFO] [stdout] 1534 | | "Cannot access member '{}' of non-struct type {:?}", [INFO] [stdout] 1535 | | member, struct_type [INFO] [stdout] 1536 | | )) [INFO] [stdout] 1537 | | .into()) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1533 ~ Err(CompilerError::Generic(format!( [INFO] [stdout] 1534 + "Cannot access member '{}' of non-struct type {:?}", [INFO] [stdout] 1535 + member, struct_type [INFO] [stdout] 1536 + )) [INFO] [stdout] 1537 + .into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/expression_compiler.rs:1482:22 [INFO] [stdout] | [INFO] [stdout] 1482 | .expect(&format!("Member {} not found inside ", member)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Member {} not found inside ", member))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1491:23 [INFO] [stdout] | [INFO] [stdout] 1491 | &[format!("i32 0"), format!("i32 {}", index)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"i32 0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1524:23 [INFO] [stdout] | [INFO] [stdout] 1524 | &[format!("i32 0"), format!("i32 {}", index)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"i32 0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1547:10 [INFO] [stdout] | [INFO] [stdout] 1547 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1559:55 [INFO] [stdout] | [INFO] [stdout] 1559 | return Err(CompilerError::Generic(format!( [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 1560 | | "Trying to read value outside of bound of constant array" [INFO] [stdout] 1561 | | )) [INFO] [stdout] | |_____________________^ help: consider using `.to_string()`: `"Trying to read value outside of bound of constant array".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1573:21 [INFO] [stdout] | [INFO] [stdout] 1573 | format!("i32 0"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"i32 0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1637:10 [INFO] [stdout] | [INFO] [stdout] 1637 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1645:47 [INFO] [stdout] | [INFO] [stdout] 1645 | return Err(CompilerError::Generic(format!("Expected name")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expected name".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1661:10 [INFO] [stdout] | [INFO] [stdout] 1661 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1677:9 [INFO] [stdout] | [INFO] [stdout] 1677 | / return Ok(CompiledLValue::new( [INFO] [stdout] 1678 | | llvm_repr.get_llvm_rep().clone(), [INFO] [stdout] 1679 | | ptype.clone(), [INFO] [stdout] 1680 | | true, [INFO] [stdout] 1681 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1677 ~ Ok(CompiledLValue::new( [INFO] [stdout] 1678 + llvm_repr.get_llvm_rep().clone(), [INFO] [stdout] 1679 + ptype.clone(), [INFO] [stdout] 1680 + true, [INFO] [stdout] 1681 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:1688:10 [INFO] [stdout] | [INFO] [stdout] 1688 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_compiler.rs:1804:9 [INFO] [stdout] | [INFO] [stdout] 1804 | return Err(CompilerError::Generic(format!("()")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1804 - return Err(CompilerError::Generic(format!("()")).into()); [INFO] [stdout] 1804 + Err(CompilerError::Generic(format!("()")).into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/expression_compiler.rs:1804:43 [INFO] [stdout] | [INFO] [stdout] 1804 | return Err(CompilerError::Generic(format!("()")).into()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"()".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: order comparisons between booleans can be simplified [INFO] [stdout] --> src/expression_compiler.rs:1964:72 [INFO] [stdout] | [INFO] [stdout] 1964 | BinaryOp::Less => return Some(LLVMVal::ConstantBoolean(l < r)), [INFO] [stdout] | ^^^^^ help: try: `!l & r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: order comparisons between booleans can be simplified [INFO] [stdout] --> src/expression_compiler.rs:1966:75 [INFO] [stdout] | [INFO] [stdout] 1966 | BinaryOp::Greater => return Some(LLVMVal::ConstantBoolean(l > r)), [INFO] [stdout] | ^^^^^ help: try: `l & !r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/expression_compiler.rs:2042:13 [INFO] [stdout] | [INFO] [stdout] 2042 | / if let Some(new_inner) = opt_e { [INFO] [stdout] 2043 | | Some(Expr::UnaryOp(*op, Box::new(new_inner))) [INFO] [stdout] 2044 | | } else { [INFO] [stdout] 2045 | | None [INFO] [stdout] 2046 | | } [INFO] [stdout] | |_____________^ help: try: `opt_e.map(|new_inner| Expr::UnaryOp(*op, Box::new(new_inner)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/expression_compiler.rs:2107:6 [INFO] [stdout] | [INFO] [stdout] 2107 | ) -> CompileResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `compiler_essentials::CompilerErrorWrapper`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.29s [INFO] running `Command { std: "docker" "inspect" "a7575f4418b2b75eaf070fb5c078194c9e07edd20a820e6eadfbdb6cea4d95fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7575f4418b2b75eaf070fb5c078194c9e07edd20a820e6eadfbdb6cea4d95fd", kill_on_drop: false }` [INFO] [stdout] a7575f4418b2b75eaf070fb5c078194c9e07edd20a820e6eadfbdb6cea4d95fd