[INFO] cloning repository https://github.com/bushrat011899/AoC2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bushrat011899/AoC2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbushrat011899%2FAoC2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbushrat011899%2FAoC2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa5d4117002195c6a7f54528ba046687cc50e4cd [INFO] linting bushrat011899/AoC2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbushrat011899%2FAoC2023" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bushrat011899/AoC2023 [INFO] finished tweaking git repo https://github.com/bushrat011899/AoC2023 [INFO] tweaked toml for git repo https://github.com/bushrat011899/AoC2023 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bushrat011899/AoC2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bushrat011899/AoC2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fdeflate v0.3.1 [INFO] [stderr] Downloaded exr v1.71.0 [INFO] [stderr] Downloaded tiff v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b502982a87d68fbada82d0cbe83bb0ece155b8f0da56e89d0a6f47c3e1841ff [INFO] running `Command { std: "docker" "start" "-a" "9b502982a87d68fbada82d0cbe83bb0ece155b8f0da56e89d0a6f47c3e1841ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b502982a87d68fbada82d0cbe83bb0ece155b8f0da56e89d0a6f47c3e1841ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b502982a87d68fbada82d0cbe83bb0ece155b8f0da56e89d0a6f47c3e1841ff", kill_on_drop: false }` [INFO] [stdout] 9b502982a87d68fbada82d0cbe83bb0ece155b8f0da56e89d0a6f47c3e1841ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1226de0d3aa876ea1b532bb3185ce511bf710f8aa17cab458270dfe2c381bc93 [INFO] running `Command { std: "docker" "start" "-a" "1226de0d3aa876ea1b532bb3185ce511bf710f8aa17cab458270dfe2c381bc93", kill_on_drop: false }` [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking fdeflate v0.3.1 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Checking clap_builder v4.4.9 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking exr v1.71.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking clap v4.4.10 [INFO] [stderr] Checking day_4 v1.0.0 (/opt/rustwide/workdir/day_4) [INFO] [stderr] Checking day_6 v1.0.0 (/opt/rustwide/workdir/day_6) [INFO] [stderr] Checking day_5 v1.0.0 (/opt/rustwide/workdir/day_5) [INFO] [stderr] Checking day_8 v1.0.0 (/opt/rustwide/workdir/day_8) [INFO] [stderr] Checking day_7 v1.0.0 (/opt/rustwide/workdir/day_7) [INFO] [stderr] Checking day_9 v1.0.0 (/opt/rustwide/workdir/day_9) [INFO] [stderr] Checking tiff v0.9.0 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> day_8/src/main.rs:163:59 [INFO] [stdout] | [INFO] [stdout] 163 | let Some(&(left, right)) = self.graph.get(&position) else { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `position` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> day_5/src/main.rs:110:10 [INFO] [stdout] | [INFO] [stdout] 110 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 111 | | Option>, [INFO] [stdout] 112 | | Option>, [INFO] [stdout] 113 | | Option>, [INFO] [stdout] 114 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> day_5/src/main.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | mapped.sort_by(|a, b| a.end.cmp(&b.end)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 301 - mapped.sort_by(|a, b| a.end.cmp(&b.end)); [INFO] [stdout] 301 + mapped.sort_by_key(|a| a.end); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> day_5/src/main.rs:110:10 [INFO] [stdout] | [INFO] [stdout] 110 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 111 | | Option>, [INFO] [stdout] 112 | | Option>, [INFO] [stdout] 113 | | Option>, [INFO] [stdout] 114 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking day_1 v1.0.0 (/opt/rustwide/workdir/day_1) [INFO] [stderr] Checking day_3 v1.0.0 (/opt/rustwide/workdir/day_3) [INFO] [stderr] Checking day_2 v1.0.0 (/opt/rustwide/workdir/day_2) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> day_8/src/main.rs:163:59 [INFO] [stdout] | [INFO] [stdout] 163 | let Some(&(left, right)) = self.graph.get(&position) else { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `position` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> day_2/src/main.rs:124:21 [INFO] [stdout] | [INFO] [stdout] 124 | .filter(|g| !g.as_ref().is_some_and(|g| !g.minimum_bag().subset(&bag))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `g.as_ref().is_none_or(|g| g.minimum_bag().subset(&bag))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> day_2/src/main.rs:102:20 [INFO] [stdout] | [INFO] [stdout] 102 | fn minimum_bag(&self) -> Dice { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 102 | fn minimum_bag(&self) -> Dice<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> day_2/src/main.rs:124:21 [INFO] [stdout] | [INFO] [stdout] 124 | .filter(|g| !g.as_ref().is_some_and(|g| !g.minimum_bag().subset(&bag))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `g.as_ref().is_none_or(|g| g.minimum_bag().subset(&bag))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> day_2/src/main.rs:102:20 [INFO] [stdout] | [INFO] [stdout] 102 | fn minimum_bag(&self) -> Dice { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 102 | fn minimum_bag(&self) -> Dice<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Checking day_11 v1.0.0 (/opt/rustwide/workdir/day_11) [INFO] [stderr] Checking day_10 v1.0.0 (/opt/rustwide/workdir/day_10) [INFO] [stderr] Checking day_12 v1.0.0 (/opt/rustwide/workdir/day_12) [INFO] [stdout] warning: method `save` is never used [INFO] [stdout] --> day_11/src/main.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 72 | impl Map { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] 73 | fn save(&self, name: &str) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day_10/src/main.rs:94:21 [INFO] [stdout] | [INFO] [stdout] 94 | let above = match above { [INFO] [stdout] | _____________________^ [INFO] [stdout] 95 | | Some(Tile::VerticalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendSouthWest) => { [INFO] [stdout] 96 | | true [INFO] [stdout] ... | [INFO] [stdout] 99 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 94 - let above = match above { [INFO] [stdout] 95 - Some(Tile::VerticalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendSouthWest) => { [INFO] [stdout] 96 - true [INFO] [stdout] 97 - } [INFO] [stdout] 98 - _ => false, [INFO] [stdout] 99 - }; [INFO] [stdout] 94 + let above = matches!(above, Some(Tile::VerticalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendSouthWest)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day_10/src/main.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | let below = match below { [INFO] [stdout] | _____________________^ [INFO] [stdout] 102 | | Some(Tile::VerticalPipe) | Some(Tile::BendNorthEast) | Some(Tile::BendNorthWest) => { [INFO] [stdout] 103 | | true [INFO] [stdout] ... | [INFO] [stdout] 106 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 101 - let below = match below { [INFO] [stdout] 102 - Some(Tile::VerticalPipe) | Some(Tile::BendNorthEast) | Some(Tile::BendNorthWest) => { [INFO] [stdout] 103 - true [INFO] [stdout] 104 - } [INFO] [stdout] 105 - _ => false, [INFO] [stdout] 106 - }; [INFO] [stdout] 101 + let below = matches!(below, Some(Tile::VerticalPipe) | Some(Tile::BendNorthEast) | Some(Tile::BendNorthWest)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day_10/src/main.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | let left = match left { [INFO] [stdout] | ____________________^ [INFO] [stdout] 109 | | Some(Tile::HorizontalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendNorthEast) => { [INFO] [stdout] 110 | | true [INFO] [stdout] ... | [INFO] [stdout] 113 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 108 - let left = match left { [INFO] [stdout] 109 - Some(Tile::HorizontalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendNorthEast) => { [INFO] [stdout] 110 - true [INFO] [stdout] 111 - } [INFO] [stdout] 112 - _ => false, [INFO] [stdout] 113 - }; [INFO] [stdout] 108 + let left = matches!(left, Some(Tile::HorizontalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendNorthEast)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day_10/src/main.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let right = match right { [INFO] [stdout] | _____________________^ [INFO] [stdout] 116 | | Some(Tile::HorizontalPipe) | Some(Tile::BendSouthWest) | Some(Tile::BendNorthWest) => { [INFO] [stdout] 117 | | true [INFO] [stdout] ... | [INFO] [stdout] 120 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 115 - let right = match right { [INFO] [stdout] 116 - Some(Tile::HorizontalPipe) | Some(Tile::BendSouthWest) | Some(Tile::BendNorthWest) => { [INFO] [stdout] 117 - true [INFO] [stdout] 118 - } [INFO] [stdout] 119 - _ => false, [INFO] [stdout] 120 - }; [INFO] [stdout] 115 + let right = matches!(right, Some(Tile::HorizontalPipe) | Some(Tile::BendSouthWest) | Some(Tile::BendNorthWest)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(usize, usize)` which implements the `Copy` trait [INFO] [stdout] --> day_10/src/main.rs:148:19 [INFO] [stdout] | [INFO] [stdout] 148 | path.push(self.start.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> day_10/src/main.rs:379:21 [INFO] [stdout] | [INFO] [stdout] 379 | / match north { [INFO] [stdout] 380 | | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] 381 | | tiles.insert(position, *fill); [INFO] [stdout] ... | [INFO] [stdout] 384 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> day_10/src/main.rs:378:29 [INFO] [stdout] | [INFO] [stdout] 378 | if let Some(north) = tiles.get(&north) { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 379 | match north { [INFO] [stdout] 380 | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> day_10/src/main.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 390 | / match south { [INFO] [stdout] 391 | | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] 392 | | tiles.insert(position, *fill); [INFO] [stdout] ... | [INFO] [stdout] 395 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> day_10/src/main.rs:389:29 [INFO] [stdout] | [INFO] [stdout] 389 | if let Some(south) = tiles.get(&south) { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 390 | match south { [INFO] [stdout] 391 | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> day_10/src/main.rs:401:21 [INFO] [stdout] | [INFO] [stdout] 401 | / match east { [INFO] [stdout] 402 | | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] 403 | | tiles.insert(position, *fill); [INFO] [stdout] ... | [INFO] [stdout] 406 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> day_10/src/main.rs:400:29 [INFO] [stdout] | [INFO] [stdout] 400 | if let Some(east) = tiles.get(&east) { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 401 | match east { [INFO] [stdout] 402 | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> day_10/src/main.rs:412:21 [INFO] [stdout] | [INFO] [stdout] 412 | / match west { [INFO] [stdout] 413 | | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] 414 | | tiles.insert(position, *fill); [INFO] [stdout] ... | [INFO] [stdout] 417 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> day_10/src/main.rs:411:29 [INFO] [stdout] | [INFO] [stdout] 411 | if let Some(west) = tiles.get(&west) { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 412 | match west { [INFO] [stdout] 413 | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> day_10/src/main.rs:423:25 [INFO] [stdout] | [INFO] [stdout] 423 | let (_, excluded) = tiles [INFO] [stdout] | _________________________^ [INFO] [stdout] 424 | | .iter() [INFO] [stdout] 425 | | .filter(|((y, x), _)| y + x == map.tiles[0].len()) [INFO] [stdout] 426 | | .filter(|(_, state)| **state != FillState::Path) [INFO] [stdout] 427 | | .next()?; [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 423 ~ let (_, excluded) = tiles [INFO] [stdout] 424 + .iter() [INFO] [stdout] 425 ~ .filter(|((y, x), _)| y + x == map.tiles[0].len()).find(|(_, state)| **state != FillState::Path)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `groups.get(0)` [INFO] [stdout] --> day_12/src/main.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 145 | while let Some(0) = groups.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `groups.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `save` is never used [INFO] [stdout] --> day_11/src/main.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 72 | impl Map { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] 73 | fn save(&self, name: &str) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day_10/src/main.rs:94:21 [INFO] [stdout] | [INFO] [stdout] 94 | let above = match above { [INFO] [stdout] | _____________________^ [INFO] [stdout] 95 | | Some(Tile::VerticalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendSouthWest) => { [INFO] [stdout] 96 | | true [INFO] [stdout] ... | [INFO] [stdout] 99 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 94 - let above = match above { [INFO] [stdout] 95 - Some(Tile::VerticalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendSouthWest) => { [INFO] [stdout] 96 - true [INFO] [stdout] 97 - } [INFO] [stdout] 98 - _ => false, [INFO] [stdout] 99 - }; [INFO] [stdout] 94 + let above = matches!(above, Some(Tile::VerticalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendSouthWest)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day_10/src/main.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | let below = match below { [INFO] [stdout] | _____________________^ [INFO] [stdout] 102 | | Some(Tile::VerticalPipe) | Some(Tile::BendNorthEast) | Some(Tile::BendNorthWest) => { [INFO] [stdout] 103 | | true [INFO] [stdout] ... | [INFO] [stdout] 106 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 101 - let below = match below { [INFO] [stdout] 102 - Some(Tile::VerticalPipe) | Some(Tile::BendNorthEast) | Some(Tile::BendNorthWest) => { [INFO] [stdout] 103 - true [INFO] [stdout] 104 - } [INFO] [stdout] 105 - _ => false, [INFO] [stdout] 106 - }; [INFO] [stdout] 101 + let below = matches!(below, Some(Tile::VerticalPipe) | Some(Tile::BendNorthEast) | Some(Tile::BendNorthWest)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day_10/src/main.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | let left = match left { [INFO] [stdout] | ____________________^ [INFO] [stdout] 109 | | Some(Tile::HorizontalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendNorthEast) => { [INFO] [stdout] 110 | | true [INFO] [stdout] ... | [INFO] [stdout] 113 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 108 - let left = match left { [INFO] [stdout] 109 - Some(Tile::HorizontalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendNorthEast) => { [INFO] [stdout] 110 - true [INFO] [stdout] 111 - } [INFO] [stdout] 112 - _ => false, [INFO] [stdout] 113 - }; [INFO] [stdout] 108 + let left = matches!(left, Some(Tile::HorizontalPipe) | Some(Tile::BendSouthEast) | Some(Tile::BendNorthEast)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> day_10/src/main.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let right = match right { [INFO] [stdout] | _____________________^ [INFO] [stdout] 116 | | Some(Tile::HorizontalPipe) | Some(Tile::BendSouthWest) | Some(Tile::BendNorthWest) => { [INFO] [stdout] 117 | | true [INFO] [stdout] ... | [INFO] [stdout] 120 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 115 - let right = match right { [INFO] [stdout] 116 - Some(Tile::HorizontalPipe) | Some(Tile::BendSouthWest) | Some(Tile::BendNorthWest) => { [INFO] [stdout] 117 - true [INFO] [stdout] 118 - } [INFO] [stdout] 119 - _ => false, [INFO] [stdout] 120 - }; [INFO] [stdout] 115 + let right = matches!(right, Some(Tile::HorizontalPipe) | Some(Tile::BendSouthWest) | Some(Tile::BendNorthWest)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(usize, usize)` which implements the `Copy` trait [INFO] [stdout] --> day_10/src/main.rs:148:19 [INFO] [stdout] | [INFO] [stdout] 148 | path.push(self.start.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `groups.get(0)` [INFO] [stdout] --> day_12/src/main.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 145 | while let Some(0) = groups.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `groups.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> day_10/src/main.rs:379:21 [INFO] [stdout] | [INFO] [stdout] 379 | / match north { [INFO] [stdout] 380 | | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] 381 | | tiles.insert(position, *fill); [INFO] [stdout] ... | [INFO] [stdout] 384 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> day_10/src/main.rs:378:29 [INFO] [stdout] | [INFO] [stdout] 378 | if let Some(north) = tiles.get(&north) { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 379 | match north { [INFO] [stdout] 380 | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> day_10/src/main.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 390 | / match south { [INFO] [stdout] 391 | | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] 392 | | tiles.insert(position, *fill); [INFO] [stdout] ... | [INFO] [stdout] 395 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> day_10/src/main.rs:389:29 [INFO] [stdout] | [INFO] [stdout] 389 | if let Some(south) = tiles.get(&south) { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 390 | match south { [INFO] [stdout] 391 | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> day_10/src/main.rs:401:21 [INFO] [stdout] | [INFO] [stdout] 401 | / match east { [INFO] [stdout] 402 | | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] 403 | | tiles.insert(position, *fill); [INFO] [stdout] ... | [INFO] [stdout] 406 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> day_10/src/main.rs:400:29 [INFO] [stdout] | [INFO] [stdout] 400 | if let Some(east) = tiles.get(&east) { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 401 | match east { [INFO] [stdout] 402 | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> day_10/src/main.rs:412:21 [INFO] [stdout] | [INFO] [stdout] 412 | / match west { [INFO] [stdout] 413 | | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] 414 | | tiles.insert(position, *fill); [INFO] [stdout] ... | [INFO] [stdout] 417 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> day_10/src/main.rs:411:29 [INFO] [stdout] | [INFO] [stdout] 411 | if let Some(west) = tiles.get(&west) { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 412 | match west { [INFO] [stdout] 413 | fill @ FillState::Left | fill @ FillState::Right => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> day_10/src/main.rs:423:25 [INFO] [stdout] | [INFO] [stdout] 423 | let (_, excluded) = tiles [INFO] [stdout] | _________________________^ [INFO] [stdout] 424 | | .iter() [INFO] [stdout] 425 | | .filter(|((y, x), _)| y + x == map.tiles[0].len()) [INFO] [stdout] 426 | | .filter(|(_, state)| **state != FillState::Path) [INFO] [stdout] 427 | | .next()?; [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 423 ~ let (_, excluded) = tiles [INFO] [stdout] 424 + .iter() [INFO] [stdout] 425 ~ .filter(|((y, x), _)| y + x == map.tiles[0].len()).find(|(_, state)| **state != FillState::Path)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.40s [INFO] running `Command { std: "docker" "inspect" "1226de0d3aa876ea1b532bb3185ce511bf710f8aa17cab458270dfe2c381bc93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1226de0d3aa876ea1b532bb3185ce511bf710f8aa17cab458270dfe2c381bc93", kill_on_drop: false }` [INFO] [stdout] 1226de0d3aa876ea1b532bb3185ce511bf710f8aa17cab458270dfe2c381bc93