[INFO] cloning repository https://github.com/busdma/ddbug_parse [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/busdma/ddbug_parse" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbusdma%2Fddbug_parse", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbusdma%2Fddbug_parse'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f3546d2f9dff7e95a654a9c3b8b747ffaa0abb00 [INFO] linting busdma/ddbug_parse against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbusdma%2Fddbug_parse" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/busdma/ddbug_parse [INFO] finished tweaking git repo https://github.com/busdma/ddbug_parse [INFO] tweaked toml for git repo https://github.com/busdma/ddbug_parse written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/busdma/ddbug_parse on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/busdma/ddbug_parse already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 82a6ae2ca2d7d0516f1e7da62ba00a7dba177c8ad041f9881e834b8d2747589f [INFO] running `Command { std: "docker" "start" "-a" "82a6ae2ca2d7d0516f1e7da62ba00a7dba177c8ad041f9881e834b8d2747589f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "82a6ae2ca2d7d0516f1e7da62ba00a7dba177c8ad041f9881e834b8d2747589f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82a6ae2ca2d7d0516f1e7da62ba00a7dba177c8ad041f9881e834b8d2747589f", kill_on_drop: false }` [INFO] [stdout] 82a6ae2ca2d7d0516f1e7da62ba00a7dba177c8ad041f9881e834b8d2747589f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bba7c82a60889607eff6615be18563e87661b7e1e35e1fe9b80dddb34b74a5df [INFO] running `Command { std: "docker" "start" "-a" "bba7c82a60889607eff6615be18563e87661b7e1e35e1fe9b80dddb34b74a5df", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking jiff v0.2.16 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking ddbug_parse v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/types.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if !self.lines.next_if(|line| line.trim() == "members:").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.lines.next_if(|line| line.trim() == "members:").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / range.as_ref().map_or(true, |SizeRange { min, max }| { [INFO] [stdout] 36 | | min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] 37 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 35 - range.as_ref().map_or(true, |SizeRange { min, max }| { [INFO] [stdout] 35 + range.as_ref().is_none_or(|SizeRange { min, max }| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 36 - min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] 36 + min.is_none_or(|m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:36:54 [INFO] [stdout] | [INFO] [stdout] 36 | min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 36 - min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] 36 + min.map_or(true, |m| s.size >= m) && max.is_none_or(|m| s.size <= m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/types.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if !self.lines.next_if(|line| line.trim() == "members:").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.lines.next_if(|line| line.trim() == "members:").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / range.as_ref().map_or(true, |SizeRange { min, max }| { [INFO] [stdout] 36 | | min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] 37 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 35 - range.as_ref().map_or(true, |SizeRange { min, max }| { [INFO] [stdout] 35 + range.as_ref().is_none_or(|SizeRange { min, max }| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 36 - min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] 36 + min.is_none_or(|m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:36:54 [INFO] [stdout] | [INFO] [stdout] 36 | min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 36 - min.map_or(true, |m| s.size >= m) && max.map_or(true, |m| s.size <= m) [INFO] [stdout] 36 + min.map_or(true, |m| s.size >= m) && max.is_none_or(|m| s.size <= m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.18s [INFO] running `Command { std: "docker" "inspect" "bba7c82a60889607eff6615be18563e87661b7e1e35e1fe9b80dddb34b74a5df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bba7c82a60889607eff6615be18563e87661b7e1e35e1fe9b80dddb34b74a5df", kill_on_drop: false }` [INFO] [stdout] bba7c82a60889607eff6615be18563e87661b7e1e35e1fe9b80dddb34b74a5df