[INFO] cloning repository https://github.com/buiducnhat/rust-todo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/buiducnhat/rust-todo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbuiducnhat%2Frust-todo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbuiducnhat%2Frust-todo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9886a72781f82294bb9ae124a501c7ed40e44333 [INFO] linting buiducnhat/rust-todo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbuiducnhat%2Frust-todo" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/buiducnhat/rust-todo [INFO] finished tweaking git repo https://github.com/buiducnhat/rust-todo [INFO] tweaked toml for git repo https://github.com/buiducnhat/rust-todo written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/buiducnhat/rust-todo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/buiducnhat/rust-todo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2fc9684c1700cfe39b0a1d92a24315949528a18c024211766fd79f7fe84c7eab [INFO] running `Command { std: "docker" "start" "-a" "2fc9684c1700cfe39b0a1d92a24315949528a18c024211766fd79f7fe84c7eab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2fc9684c1700cfe39b0a1d92a24315949528a18c024211766fd79f7fe84c7eab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fc9684c1700cfe39b0a1d92a24315949528a18c024211766fd79f7fe84c7eab", kill_on_drop: false }` [INFO] [stdout] 2fc9684c1700cfe39b0a1d92a24315949528a18c024211766fd79f7fe84c7eab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8139f9feae2b32739e662f236a0253e56038bf21ab5fdfaa6411cfa6d57625b3 [INFO] running `Command { std: "docker" "start" "-a" "8139f9feae2b32739e662f236a0253e56038bf21ab5fdfaa6411cfa6d57625b3", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking rust-todo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/db.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | if !fs::metadata(FILE_PATH).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(FILE_PATH).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/db.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | if !fs::metadata(FILE_PATH).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(FILE_PATH).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/services/task_service.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn add_task(title: &String, description: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn add_task(title: &String, description: &String) { [INFO] [stdout] 5 + pub fn add_task(title: &str, description: &String) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/services/task_service.rs:5:46 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn add_task(title: &String, description: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn add_task(title: &String, description: &String) { [INFO] [stdout] 5 + pub fn add_task(title: &String, description: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/services/task_service.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn add_task(title: &String, description: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn add_task(title: &String, description: &String) { [INFO] [stdout] 5 + pub fn add_task(title: &str, description: &String) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/services/task_service.rs:5:46 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn add_task(title: &String, description: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn add_task(title: &String, description: &String) { [INFO] [stdout] 5 + pub fn add_task(title: &String, description: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.00s [INFO] running `Command { std: "docker" "inspect" "8139f9feae2b32739e662f236a0253e56038bf21ab5fdfaa6411cfa6d57625b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8139f9feae2b32739e662f236a0253e56038bf21ab5fdfaa6411cfa6d57625b3", kill_on_drop: false }` [INFO] [stdout] 8139f9feae2b32739e662f236a0253e56038bf21ab5fdfaa6411cfa6d57625b3