[INFO] cloning repository https://github.com/bryan-pakulski/intercept [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bryan-pakulski/intercept" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbryan-pakulski%2Fintercept", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbryan-pakulski%2Fintercept'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f9676bcbe5877d4cbdaa6d464158aff1abc84f59 [INFO] linting bryan-pakulski/intercept against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbryan-pakulski%2Fintercept" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bryan-pakulski/intercept [INFO] finished tweaking git repo https://github.com/bryan-pakulski/intercept [INFO] tweaked toml for git repo https://github.com/bryan-pakulski/intercept written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bryan-pakulski/intercept on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bryan-pakulski/intercept already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pnet_base v0.35.0 [INFO] [stderr] Downloaded pnet v0.35.0 [INFO] [stderr] Downloaded clap v4.5.51 [INFO] [stderr] Downloaded pnet_macros_support v0.35.0 [INFO] [stderr] Downloaded pnet_datalink v0.35.0 [INFO] [stderr] Downloaded pnet_macros v0.35.0 [INFO] [stderr] Downloaded pnet_packet v0.35.0 [INFO] [stderr] Downloaded pnet_sys v0.35.0 [INFO] [stderr] Downloaded pnet_transport v0.35.0 [INFO] [stderr] Downloaded clap_builder v4.5.51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 363c9bc0b078c8f87bf2d77dbb87d6919b04b4b6d273e8ff8597436ad93612ee [INFO] running `Command { std: "docker" "start" "-a" "363c9bc0b078c8f87bf2d77dbb87d6919b04b4b6d273e8ff8597436ad93612ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "363c9bc0b078c8f87bf2d77dbb87d6919b04b4b6d273e8ff8597436ad93612ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "363c9bc0b078c8f87bf2d77dbb87d6919b04b4b6d273e8ff8597436ad93612ee", kill_on_drop: false }` [INFO] [stdout] 363c9bc0b078c8f87bf2d77dbb87d6919b04b4b6d273e8ff8597436ad93612ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9dfed3c3db77f4940ea9297a1007a86d61d9f8642cf36e102c332c9dc5e44cab [INFO] running `Command { std: "docker" "start" "-a" "9dfed3c3db77f4940ea9297a1007a86d61d9f8642cf36e102c332c9dc5e44cab", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Compiling pnet v0.35.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking pnet_sys v0.35.0 [INFO] [stderr] Checking pnet_base v0.35.0 [INFO] [stderr] Checking pnet_macros_support v0.35.0 [INFO] [stderr] Checking clap_builder v4.5.51 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking clap v4.5.51 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling pnet_macros v0.35.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking pnet_packet v0.35.0 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking pnet_datalink v0.35.0 [INFO] [stderr] Checking pnet_transport v0.35.0 [INFO] [stderr] Checking intercept v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> nfqueue-rs/src/lib.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> nfqueue-rs/src/message.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> nfqueue-rs/src/message.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use std; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> nfqueue-rs/src/lib.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> nfqueue-rs/src/message.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use libc; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> nfqueue-rs/src/message.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use std; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> nfqueue-rs/src/hwaddr.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return write!(out, "{}", s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return write!(out, "{}", s); [INFO] [stdout] 19 + write!(out, "{}", s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> nfqueue-rs/src/message.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 307 | / let payload = unsafe { [INFO] [stdout] 308 | | std::slice::from_raw_parts(c_ptr as *mut _, payload_len as usize) [INFO] [stdout] 309 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 310 | [INFO] [stdout] 311 | payload [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 307 ~ [INFO] [stdout] 308 | [INFO] [stdout] 309 ~ (unsafe { [INFO] [stdout] 310 + std::slice::from_raw_parts(c_ptr as *mut _, payload_len as usize) [INFO] [stdout] 311 + }) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> nfqueue-rs/src/lib.rs:272:17 [INFO] [stdout] | [INFO] [stdout] 272 | assert!(!self.cb.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.cb.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> nfqueue-rs/src/hwaddr.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return write!(out, "{}", s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return write!(out, "{}", s); [INFO] [stdout] 19 + write!(out, "{}", s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> nfqueue-rs/src/message.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 307 | / let payload = unsafe { [INFO] [stdout] 308 | | std::slice::from_raw_parts(c_ptr as *mut _, payload_len as usize) [INFO] [stdout] 309 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 310 | [INFO] [stdout] 311 | payload [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 307 ~ [INFO] [stdout] 308 | [INFO] [stdout] 309 ~ (unsafe { [INFO] [stdout] 310 + std::slice::from_raw_parts(c_ptr as *mut _, payload_len as usize) [INFO] [stdout] 311 + }) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> nfqueue-rs/src/lib.rs:272:17 [INFO] [stdout] | [INFO] [stdout] 272 | assert!(!self.cb.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.cb.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/net/mod.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 27 | impl<'a> Drop for ScopedTimer { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | / if is_sip_packet(udp_packet.payload()) { [INFO] [stdout] 108 | | if let Ok(uri) = get_uri(udp_packet.payload()) { [INFO] [stdout] 109 | | info!("INBOUND => {} => {} | {}", source, destination, uri); [INFO] [stdout] 110 | | if let Ok(modified_packet) = apply_rules_to_sip_packet( [INFO] [stdout] ... | [INFO] [stdout] 143 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 107 ~ if is_sip_packet(udp_packet.payload()) [INFO] [stdout] 108 ~ && let Ok(uri) = get_uri(udp_packet.payload()) { [INFO] [stdout] 109 | info!("INBOUND => {} => {} | {}", source, destination, uri); [INFO] [stdout] ... [INFO] [stdout] 141 | } [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | / if is_sip_packet(udp_packet.payload()) { [INFO] [stdout] 177 | | if let Ok(uri) = get_uri(udp_packet.payload()) { [INFO] [stdout] 178 | | info!("OUTBOUND => {} => {} | {}", source, destination, uri); [INFO] [stdout] 179 | | if let Ok(modified_packet) = apply_rules_to_sip_packet( [INFO] [stdout] ... | [INFO] [stdout] 212 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 176 ~ if is_sip_packet(udp_packet.payload()) [INFO] [stdout] 177 ~ && let Ok(uri) = get_uri(udp_packet.payload()) { [INFO] [stdout] 178 | info!("OUTBOUND => {} => {} | {}", source, destination, uri); [INFO] [stdout] ... [INFO] [stdout] 210 | } [INFO] [stdout] 211 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | / if let Ok(payload_str) = std::str::from_utf8(payload) { [INFO] [stdout] 221 | | if payload_str.contains("SIP/2.0") { [INFO] [stdout] 222 | | return true; [INFO] [stdout] 223 | | } [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ if let Ok(payload_str) = std::str::from_utf8(payload) [INFO] [stdout] 221 ~ && payload_str.contains("SIP/2.0") { [INFO] [stdout] 222 | return true; [INFO] [stdout] 223 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | / if let Ok(payload_str) = std::str::from_utf8(payload) { [INFO] [stdout] 230 | | if let Some(first_line) = payload_str.lines().next() { [INFO] [stdout] 231 | | return Ok(first_line.to_string()); [INFO] [stdout] 232 | | } [INFO] [stdout] 233 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 229 ~ if let Ok(payload_str) = std::str::from_utf8(payload) [INFO] [stdout] 230 ~ && let Some(first_line) = payload_str.lines().next() { [INFO] [stdout] 231 | return Ok(first_line.to_string()); [INFO] [stdout] 232 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | / if let Ok(payload_str) = std::str::from_utf8(payload) { [INFO] [stdout] 243 | | if let Ok(regex) = Regex::new(regex) { [INFO] [stdout] 244 | | if regex.is_match(payload_str) { [INFO] [stdout] 245 | | return true; [INFO] [stdout] ... | [INFO] [stdout] 248 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 242 ~ if let Ok(payload_str) = std::str::from_utf8(payload) [INFO] [stdout] 243 ~ && let Ok(regex) = Regex::new(regex) { [INFO] [stdout] 244 | if regex.is_match(payload_str) { [INFO] [stdout] 245 | return true; [INFO] [stdout] 246 | } [INFO] [stdout] 247 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | / if let Ok(regex) = Regex::new(regex) { [INFO] [stdout] 244 | | if regex.is_match(payload_str) { [INFO] [stdout] 245 | | return true; [INFO] [stdout] 246 | | } [INFO] [stdout] 247 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 243 ~ if let Ok(regex) = Regex::new(regex) [INFO] [stdout] 244 ~ && regex.is_match(payload_str) { [INFO] [stdout] 245 | return true; [INFO] [stdout] 246 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/net/mod.rs:314:5 [INFO] [stdout] | [INFO] [stdout] 314 | let final_buffer: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `final_buffer` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 314 ~ [INFO] [stdout] 315 | [INFO] [stdout] 316 ~ let final_buffer: String = if parts.len() == 2 { [INFO] [stdout] 317 ~ format!("{}\r\n\r\n{}", new_headers, body_str) [INFO] [stdout] 318 | } else { [INFO] [stdout] 319 ~ new_headers [INFO] [stdout] 320 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/net/mod.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 27 | impl<'a> Drop for ScopedTimer { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | / if is_sip_packet(udp_packet.payload()) { [INFO] [stdout] 108 | | if let Ok(uri) = get_uri(udp_packet.payload()) { [INFO] [stdout] 109 | | info!("INBOUND => {} => {} | {}", source, destination, uri); [INFO] [stdout] 110 | | if let Ok(modified_packet) = apply_rules_to_sip_packet( [INFO] [stdout] ... | [INFO] [stdout] 143 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 107 ~ if is_sip_packet(udp_packet.payload()) [INFO] [stdout] 108 ~ && let Ok(uri) = get_uri(udp_packet.payload()) { [INFO] [stdout] 109 | info!("INBOUND => {} => {} | {}", source, destination, uri); [INFO] [stdout] ... [INFO] [stdout] 141 | } [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | / if is_sip_packet(udp_packet.payload()) { [INFO] [stdout] 177 | | if let Ok(uri) = get_uri(udp_packet.payload()) { [INFO] [stdout] 178 | | info!("OUTBOUND => {} => {} | {}", source, destination, uri); [INFO] [stdout] 179 | | if let Ok(modified_packet) = apply_rules_to_sip_packet( [INFO] [stdout] ... | [INFO] [stdout] 212 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 176 ~ if is_sip_packet(udp_packet.payload()) [INFO] [stdout] 177 ~ && let Ok(uri) = get_uri(udp_packet.payload()) { [INFO] [stdout] 178 | info!("OUTBOUND => {} => {} | {}", source, destination, uri); [INFO] [stdout] ... [INFO] [stdout] 210 | } [INFO] [stdout] 211 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | / if let Ok(payload_str) = std::str::from_utf8(payload) { [INFO] [stdout] 221 | | if payload_str.contains("SIP/2.0") { [INFO] [stdout] 222 | | return true; [INFO] [stdout] 223 | | } [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ if let Ok(payload_str) = std::str::from_utf8(payload) [INFO] [stdout] 221 ~ && payload_str.contains("SIP/2.0") { [INFO] [stdout] 222 | return true; [INFO] [stdout] 223 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | / if let Ok(payload_str) = std::str::from_utf8(payload) { [INFO] [stdout] 230 | | if let Some(first_line) = payload_str.lines().next() { [INFO] [stdout] 231 | | return Ok(first_line.to_string()); [INFO] [stdout] 232 | | } [INFO] [stdout] 233 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 229 ~ if let Ok(payload_str) = std::str::from_utf8(payload) [INFO] [stdout] 230 ~ && let Some(first_line) = payload_str.lines().next() { [INFO] [stdout] 231 | return Ok(first_line.to_string()); [INFO] [stdout] 232 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | / if let Ok(payload_str) = std::str::from_utf8(payload) { [INFO] [stdout] 243 | | if let Ok(regex) = Regex::new(regex) { [INFO] [stdout] 244 | | if regex.is_match(payload_str) { [INFO] [stdout] 245 | | return true; [INFO] [stdout] ... | [INFO] [stdout] 248 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 242 ~ if let Ok(payload_str) = std::str::from_utf8(payload) [INFO] [stdout] 243 ~ && let Ok(regex) = Regex::new(regex) { [INFO] [stdout] 244 | if regex.is_match(payload_str) { [INFO] [stdout] 245 | return true; [INFO] [stdout] 246 | } [INFO] [stdout] 247 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/net/mod.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | / if let Ok(regex) = Regex::new(regex) { [INFO] [stdout] 244 | | if regex.is_match(payload_str) { [INFO] [stdout] 245 | | return true; [INFO] [stdout] 246 | | } [INFO] [stdout] 247 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 243 ~ if let Ok(regex) = Regex::new(regex) [INFO] [stdout] 244 ~ && regex.is_match(payload_str) { [INFO] [stdout] 245 | return true; [INFO] [stdout] 246 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/net/mod.rs:314:5 [INFO] [stdout] | [INFO] [stdout] 314 | let final_buffer: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `final_buffer` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 314 ~ [INFO] [stdout] 315 | [INFO] [stdout] 316 ~ let final_buffer: String = if parts.len() == 2 { [INFO] [stdout] 317 ~ format!("{}\r\n\r\n{}", new_headers, body_str) [INFO] [stdout] 318 | } else { [INFO] [stdout] 319 ~ new_headers [INFO] [stdout] 320 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.46s [INFO] running `Command { std: "docker" "inspect" "9dfed3c3db77f4940ea9297a1007a86d61d9f8642cf36e102c332c9dc5e44cab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9dfed3c3db77f4940ea9297a1007a86d61d9f8642cf36e102c332c9dc5e44cab", kill_on_drop: false }` [INFO] [stdout] 9dfed3c3db77f4940ea9297a1007a86d61d9f8642cf36e102c332c9dc5e44cab