[INFO] cloning repository https://github.com/brson/piddle [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brson/piddle" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrson%2Fpiddle", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrson%2Fpiddle'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 740fc3718248a4cfc59df356c26209eb5f321494 [INFO] linting brson/piddle against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrson%2Fpiddle" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/brson/piddle [INFO] finished tweaking git repo https://github.com/brson/piddle [INFO] tweaked toml for git repo https://github.com/brson/piddle written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/brson/piddle on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/brson/piddle already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fd-lock v3.0.0 [INFO] [stderr] Downloaded clipboard-win v4.2.1 [INFO] [stderr] Downloaded string-interner v0.13.0 [INFO] [stderr] Downloaded error-code v2.3.0 [INFO] [stderr] Downloaded minimal-lexical v0.1.2 [INFO] [stderr] Downloaded hecs v0.6.4 [INFO] [stderr] Downloaded rustyline v9.0.0 [INFO] [stderr] Downloaded nom v7.0.0 [INFO] [stderr] Downloaded nix v0.22.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 952a7ff5d1c0c36a4a045f1e97463cf52c4a26a236f794148dc1241358f20a4a [INFO] running `Command { std: "docker" "start" "-a" "952a7ff5d1c0c36a4a045f1e97463cf52c4a26a236f794148dc1241358f20a4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "952a7ff5d1c0c36a4a045f1e97463cf52c4a26a236f794148dc1241358f20a4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "952a7ff5d1c0c36a4a045f1e97463cf52c4a26a236f794148dc1241358f20a4a", kill_on_drop: false }` [INFO] [stdout] 952a7ff5d1c0c36a4a045f1e97463cf52c4a26a236f794148dc1241358f20a4a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87a02c3447298c3c8bad1023c3761ea9680e638ba962b69476058146b0734076 [INFO] running `Command { std: "docker" "start" "-a" "87a02c3447298c3c8bad1023c3761ea9680e638ba962b69476058146b0734076", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.99 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling minimal-lexical v0.1.2 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling anyhow v1.0.43 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.22.1 [INFO] [stderr] Checking fd-lock v3.0.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking hecs v0.6.4 [INFO] [stderr] Checking rustyline v9.0.0 [INFO] [stderr] Compiling structopt-derive v0.4.15 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Checking string-interner v0.13.0 [INFO] [stderr] Checking thiserror v1.0.26 [INFO] [stderr] Checking structopt v0.3.22 [INFO] [stderr] Checking piddle v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 94 | let name = function.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `function.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:96:40 [INFO] [stdout] | [INFO] [stdout] 96 | module_ctxt.fn_asts.insert(name.clone(), function.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:117:57 [INFO] [stdout] | [INFO] [stdout] 117 | let mut from_module_ctxt = compiler.modules.get_mut(&from_module) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `from_module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/compiler.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | / if name == item { [INFO] [stdout] 128 | | found_item = Some(decl.clone()); [INFO] [stdout] 129 | | break; [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ ast::Declaration::Function(ast::Function { name, .. }) [INFO] [stdout] 127 ~ if name == item => { [INFO] [stdout] 128 | found_item = Some(decl.clone()); [INFO] [stdout] 129 | break; [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compiler.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | / match decl { [INFO] [stdout] 126 | | ast::Declaration::Function(ast::Function { name, .. }) => { [INFO] [stdout] 127 | | if name == item { [INFO] [stdout] 128 | | found_item = Some(decl.clone()); [INFO] [stdout] ... | [INFO] [stdout] 132 | | _ => { } [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 125 ~ if let ast::Declaration::Function(ast::Function { name, .. }) = decl { [INFO] [stdout] 126 + if name == item { [INFO] [stdout] 127 + found_item = Some(decl.clone()); [INFO] [stdout] 128 + break; [INFO] [stdout] 129 + } [INFO] [stdout] 130 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:138:28 [INFO] [stdout] | [INFO] [stdout] 138 | let name = fn_.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `fn_.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:139:49 [INFO] [stdout] | [INFO] [stdout] 139 | from_module_ctxt.fn_asts.insert(name.clone(), fn_); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:160:57 [INFO] [stdout] | [INFO] [stdout] 160 | let mut from_module_ctxt = compiler.modules.get_mut(&from_module) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `from_module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 170 | let name = fn_.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `fn_.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:171:69 [INFO] [stdout] | [INFO] [stdout] 171 | let mut from_module_ctxt = compiler.modules.get_mut(&from_module).expect("module"); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `from_module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:172:49 [INFO] [stdout] | [INFO] [stdout] 172 | from_module_ctxt.fn_asts.insert(name.clone(), fn_.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:204:48 [INFO] [stdout] | [INFO] [stdout] 204 | let mut fn_ctxt = FunctionContext::new(name.clone(), module.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:216:32 [INFO] [stdout] | [INFO] [stdout] 216 | module_ctxt.fns.insert(name.clone(), compiled); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:233:36 [INFO] [stdout] | [INFO] [stdout] 233 | module_ctxt.fns.insert(name.clone(), compiled_fn); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:248:48 [INFO] [stdout] | [INFO] [stdout] 248 | let mut fn_ctxt = FunctionContext::new(name.clone(), other_module.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:260:38 [INFO] [stdout] | [INFO] [stdout] 260 | other_module_ctxt.fns.insert(name.clone(), compiled.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:263:32 [INFO] [stdout] | [INFO] [stdout] 263 | module_ctxt.fns.insert(name.clone(), compiled); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:310:35 [INFO] [stdout] | [INFO] [stdout] 310 | self.modules.contains_key(&module) [INFO] [stdout] | ^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:44:70 [INFO] [stdout] | [INFO] [stdout] 44 | println!("{}: {}", (tables.name)(*name), EvalDisplay(&value, tables.name)); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:105:48 [INFO] [stdout] | [INFO] [stdout] 105 | let eval = run_expression(env, &tables, *field.1)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `tables` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/require.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 61 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> src/main.rs:26:34 [INFO] [stdout] | [INFO] [stdout] 26 | let script = std::env::args().skip(1).next(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 94 | let name = function.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `function.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:96:40 [INFO] [stdout] | [INFO] [stdout] 96 | module_ctxt.fn_asts.insert(name.clone(), function.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:117:57 [INFO] [stdout] | [INFO] [stdout] 117 | let mut from_module_ctxt = compiler.modules.get_mut(&from_module) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `from_module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | drop(from_module_ctxt); [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 140 - drop(from_module_ctxt); [INFO] [stdout] 140 + let _ = from_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | drop(from_module_ctxt); [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 166 - drop(from_module_ctxt); [INFO] [stdout] 166 + let _ = from_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:173:17 [INFO] [stdout] | [INFO] [stdout] 173 | drop(from_module_ctxt); [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 173 - drop(from_module_ctxt); [INFO] [stdout] 173 + let _ = from_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | drop(module_ctxt); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 202 - drop(module_ctxt); [INFO] [stdout] 202 + let _ = module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | drop(module_ctxt); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 224 - drop(module_ctxt); [INFO] [stdout] 224 + let _ = module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/compiler.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | / if name == item { [INFO] [stdout] 128 | | found_item = Some(decl.clone()); [INFO] [stdout] 129 | | break; [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ ast::Declaration::Function(ast::Function { name, .. }) [INFO] [stdout] 127 ~ if name == item => { [INFO] [stdout] 128 | found_item = Some(decl.clone()); [INFO] [stdout] 129 | break; [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | drop(other_module_ctxt); [INFO] [stdout] | ^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 231 - drop(other_module_ctxt); [INFO] [stdout] 231 + let _ = other_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compiler.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | / match decl { [INFO] [stdout] 126 | | ast::Declaration::Function(ast::Function { name, .. }) => { [INFO] [stdout] 127 | | if name == item { [INFO] [stdout] 128 | | found_item = Some(decl.clone()); [INFO] [stdout] ... | [INFO] [stdout] 132 | | _ => { } [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 125 ~ if let ast::Declaration::Function(ast::Function { name, .. }) = decl { [INFO] [stdout] 126 + if name == item { [INFO] [stdout] 127 + found_item = Some(decl.clone()); [INFO] [stdout] 128 + break; [INFO] [stdout] 129 + } [INFO] [stdout] 130 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | drop(other_module_ctxt); [INFO] [stdout] | ^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 246 - drop(other_module_ctxt); [INFO] [stdout] 246 + let _ = other_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | drop(other_module_ctxt); [INFO] [stdout] | ^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 261 - drop(other_module_ctxt); [INFO] [stdout] 261 + let _ = other_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:138:28 [INFO] [stdout] | [INFO] [stdout] 138 | let name = fn_.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `fn_.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:139:49 [INFO] [stdout] | [INFO] [stdout] 139 | from_module_ctxt.fn_asts.insert(name.clone(), fn_); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:160:57 [INFO] [stdout] | [INFO] [stdout] 160 | let mut from_module_ctxt = compiler.modules.get_mut(&from_module) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `from_module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 170 | let name = fn_.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `fn_.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:171:69 [INFO] [stdout] | [INFO] [stdout] 171 | let mut from_module_ctxt = compiler.modules.get_mut(&from_module).expect("module"); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `from_module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:172:49 [INFO] [stdout] | [INFO] [stdout] 172 | from_module_ctxt.fn_asts.insert(name.clone(), fn_.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:204:48 [INFO] [stdout] | [INFO] [stdout] 204 | let mut fn_ctxt = FunctionContext::new(name.clone(), module.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:216:32 [INFO] [stdout] | [INFO] [stdout] 216 | module_ctxt.fns.insert(name.clone(), compiled); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:233:36 [INFO] [stdout] | [INFO] [stdout] 233 | module_ctxt.fns.insert(name.clone(), compiled_fn); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:248:48 [INFO] [stdout] | [INFO] [stdout] 248 | let mut fn_ctxt = FunctionContext::new(name.clone(), other_module.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:260:38 [INFO] [stdout] | [INFO] [stdout] 260 | other_module_ctxt.fns.insert(name.clone(), compiled.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Name` which implements the `Copy` trait [INFO] [stdout] --> src/compiler.rs:263:32 [INFO] [stdout] | [INFO] [stdout] 263 | module_ctxt.fns.insert(name.clone(), compiled); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:310:35 [INFO] [stdout] | [INFO] [stdout] 310 | self.modules.contains_key(&module) [INFO] [stdout] | ^^^^^^^ help: change this to: `module` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:44:70 [INFO] [stdout] | [INFO] [stdout] 44 | println!("{}: {}", (tables.name)(*name), EvalDisplay(&value, tables.name)); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:105:48 [INFO] [stdout] | [INFO] [stdout] 105 | let eval = run_expression(env, &tables, *field.1)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `tables` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/require.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 61 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> src/main.rs:26:34 [INFO] [stdout] | [INFO] [stdout] 26 | let script = std::env::args().skip(1).next(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | drop(from_module_ctxt); [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 140 - drop(from_module_ctxt); [INFO] [stdout] 140 + let _ = from_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | drop(from_module_ctxt); [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 166 - drop(from_module_ctxt); [INFO] [stdout] 166 + let _ = from_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:173:17 [INFO] [stdout] | [INFO] [stdout] 173 | drop(from_module_ctxt); [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 173 - drop(from_module_ctxt); [INFO] [stdout] 173 + let _ = from_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | drop(module_ctxt); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 202 - drop(module_ctxt); [INFO] [stdout] 202 + let _ = module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | drop(module_ctxt); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 224 - drop(module_ctxt); [INFO] [stdout] 224 + let _ = module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | drop(other_module_ctxt); [INFO] [stdout] | ^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 231 - drop(other_module_ctxt); [INFO] [stdout] 231 + let _ = other_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | drop(other_module_ctxt); [INFO] [stdout] | ^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 246 - drop(other_module_ctxt); [INFO] [stdout] 246 + let _ = other_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/compiler.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | drop(other_module_ctxt); [INFO] [stdout] | ^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut compiler::ModuleContext` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 261 - drop(other_module_ctxt); [INFO] [stdout] 261 + let _ = other_module_ctxt; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.50s [INFO] running `Command { std: "docker" "inspect" "87a02c3447298c3c8bad1023c3761ea9680e638ba962b69476058146b0734076", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87a02c3447298c3c8bad1023c3761ea9680e638ba962b69476058146b0734076", kill_on_drop: false }` [INFO] [stdout] 87a02c3447298c3c8bad1023c3761ea9680e638ba962b69476058146b0734076