[INFO] cloning repository https://github.com/brianirish/clark [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brianirish/clark" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrianirish%2Fclark", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrianirish%2Fclark'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] da5505587db3e93c613cd3edb55595607f3f0986 [INFO] linting brianirish/clark against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrianirish%2Fclark" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/brianirish/clark [INFO] finished tweaking git repo https://github.com/brianirish/clark [INFO] tweaked toml for git repo https://github.com/brianirish/clark written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/brianirish/clark on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/brianirish/clark already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded git2 v0.20.2 [INFO] [stderr] Downloaded libgit2-sys v0.18.2+1.9.1 [INFO] [stderr] Downloaded notify v8.1.0 [INFO] [stderr] Downloaded criterion v0.6.0 [INFO] [stderr] Downloaded clap_derive v4.5.40 [INFO] [stderr] Downloaded notify-types v2.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36e58a24637a7b3a5a0899be5cbd4bed196decd7713a6607a551c08f192487ea [INFO] running `Command { std: "docker" "start" "-a" "36e58a24637a7b3a5a0899be5cbd4bed196decd7713a6607a551c08f192487ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36e58a24637a7b3a5a0899be5cbd4bed196decd7713a6607a551c08f192487ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36e58a24637a7b3a5a0899be5cbd4bed196decd7713a6607a551c08f192487ea", kill_on_drop: false }` [INFO] [stdout] 36e58a24637a7b3a5a0899be5cbd4bed196decd7713a6607a551c08f192487ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bda1eda4bc7859adac100dd2a93068ef3c87b093dad385d6c24a4faed1547574 [INFO] running `Command { std: "docker" "start" "-a" "bda1eda4bc7859adac100dd2a93068ef3c87b093dad385d6c24a4faed1547574", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Compiling litemap v0.8.0 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling writeable v0.6.1 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Compiling yoke v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling slab v0.4.10 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling zerovec v0.11.2 [INFO] [stderr] Compiling zerotrie v0.2.2 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Compiling socket2 v0.5.10 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling cc v1.2.29 [INFO] [stderr] Compiling event-listener v5.4.0 [INFO] [stderr] Compiling tracing v0.1.41 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling crc v3.3.0 [INFO] [stderr] Compiling tokio v1.46.1 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling tinystr v0.8.1 [INFO] [stderr] Compiling potential_utf v0.1.2 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling icu_collections v2.0.0 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling icu_locale_core v2.0.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling icu_provider v2.0.0 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling icu_properties v2.0.1 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling libgit2-sys v0.18.2+1.9.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking inotify v0.11.0 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling instability v0.3.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking notify-types v2.0.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling mockall_derive v0.13.1 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking notify v8.1.0 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking fragile v2.0.1 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking proptest v1.7.0 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking criterion v0.6.0 [INFO] [stderr] Checking mockall v0.13.1 [INFO] [stderr] Checking git2 v0.20.2 [INFO] [stderr] Compiling sqlx-sqlite v0.8.6 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking clark v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MockClaudeSession` [INFO] [stdout] --> src/core/mock.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | output: Arc::new(Mutex::new(Vec::new())), [INFO] [stdout] 15 | | running: Arc::new(Mutex::new(true)), [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for MockClaudeSession { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MockClaudeSession` [INFO] [stdout] --> src/core/mock.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | output: Arc::new(Mutex::new(Vec::new())), [INFO] [stdout] 15 | | running: Arc::new(Mutex::new(true)), [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for MockClaudeSession { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MockCoordinatorSession` [INFO] [stdout] --> src/core/mock_coordinator.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | output: Arc::new(Mutex::new(Vec::new())), [INFO] [stdout] 15 | | tasks: Arc::new(Mutex::new(Vec::new())), [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for MockCoordinatorSession { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MockCoordinatorSession` [INFO] [stdout] --> src/core/mock_coordinator.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | output: Arc::new(Mutex::new(Vec::new())), [INFO] [stdout] 15 | | tasks: Arc::new(Mutex::new(Vec::new())), [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for MockCoordinatorSession { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 66 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 67 | | "worktree", [INFO] [stdout] 68 | | "add", [INFO] [stdout] 69 | | worktree_path.to_str().unwrap(), [INFO] [stdout] 70 | | &branch_name, [INFO] [stdout] 71 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 ~ .args([ [INFO] [stdout] 67 + "worktree", [INFO] [stdout] 68 + "add", [INFO] [stdout] 69 + worktree_path.to_str().unwrap(), [INFO] [stdout] 70 + &branch_name, [INFO] [stdout] 71 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:109:23 [INFO] [stdout] | [INFO] [stdout] 109 | .args(&[ [INFO] [stdout] | _______________________^ [INFO] [stdout] 110 | | "worktree", [INFO] [stdout] 111 | | "remove", [INFO] [stdout] 112 | | worktree.path.to_str().unwrap(), [INFO] [stdout] 113 | | "--force", [INFO] [stdout] 114 | | ]) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 109 ~ .args([ [INFO] [stdout] 110 + "worktree", [INFO] [stdout] 111 + "remove", [INFO] [stdout] 112 + worktree.path.to_str().unwrap(), [INFO] [stdout] 113 + "--force", [INFO] [stdout] 114 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 66 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 67 | | "worktree", [INFO] [stdout] 68 | | "add", [INFO] [stdout] 69 | | worktree_path.to_str().unwrap(), [INFO] [stdout] 70 | | &branch_name, [INFO] [stdout] 71 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 ~ .args([ [INFO] [stdout] 67 + "worktree", [INFO] [stdout] 68 + "add", [INFO] [stdout] 69 + worktree_path.to_str().unwrap(), [INFO] [stdout] 70 + &branch_name, [INFO] [stdout] 71 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:126:23 [INFO] [stdout] | [INFO] [stdout] 126 | .args(&[ [INFO] [stdout] | _______________________^ [INFO] [stdout] 127 | | "branch", [INFO] [stdout] 128 | | "-D", [INFO] [stdout] 129 | | &worktree.branch, [INFO] [stdout] 130 | | ]) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 126 ~ .args([ [INFO] [stdout] 127 + "branch", [INFO] [stdout] 128 + "-D", [INFO] [stdout] 129 + &worktree.branch, [INFO] [stdout] 130 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:146:19 [INFO] [stdout] | [INFO] [stdout] 146 | .args(&["diff", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["diff", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:109:23 [INFO] [stdout] | [INFO] [stdout] 109 | .args(&[ [INFO] [stdout] | _______________________^ [INFO] [stdout] 110 | | "worktree", [INFO] [stdout] 111 | | "remove", [INFO] [stdout] 112 | | worktree.path.to_str().unwrap(), [INFO] [stdout] 113 | | "--force", [INFO] [stdout] 114 | | ]) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 109 ~ .args([ [INFO] [stdout] 110 + "worktree", [INFO] [stdout] 111 + "remove", [INFO] [stdout] 112 + worktree.path.to_str().unwrap(), [INFO] [stdout] 113 + "--force", [INFO] [stdout] 114 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:227:27 [INFO] [stdout] | [INFO] [stdout] 227 | .args(&[ [INFO] [stdout] | ___________________________^ [INFO] [stdout] 228 | | "worktree", [INFO] [stdout] 229 | | "remove", [INFO] [stdout] 230 | | worktree.path.to_str().unwrap_or(""), [INFO] [stdout] 231 | | "--force", [INFO] [stdout] 232 | | ]) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 227 ~ .args([ [INFO] [stdout] 228 + "worktree", [INFO] [stdout] 229 + "remove", [INFO] [stdout] 230 + worktree.path.to_str().unwrap_or(""), [INFO] [stdout] 231 + "--force", [INFO] [stdout] 232 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/mod.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 18 | .args(&["rev-parse", "--is-inside-work-tree"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--is-inside-work-tree"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/mod.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .args(&["rev-parse", "--show-toplevel"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--show-toplevel"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/mod.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | .args(&["branch", "--show-current"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["branch", "--show-current"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:126:23 [INFO] [stdout] | [INFO] [stdout] 126 | .args(&[ [INFO] [stdout] | _______________________^ [INFO] [stdout] 127 | | "branch", [INFO] [stdout] 128 | | "-D", [INFO] [stdout] 129 | | &worktree.branch, [INFO] [stdout] 130 | | ]) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 126 ~ .args([ [INFO] [stdout] 127 + "branch", [INFO] [stdout] 128 + "-D", [INFO] [stdout] 129 + &worktree.branch, [INFO] [stdout] 130 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TmuxManager` [INFO] [stdout] --> src/tmux/manager.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | sessions: Arc::new(Mutex::new(Vec::new())), [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for TmuxManager { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 31 | | "new-session", [INFO] [stdout] 32 | | "-d", [INFO] [stdout] 33 | | "-s", name, [INFO] [stdout] 34 | | "-c", working_dir, [INFO] [stdout] 35 | | "-n", "claude", [INFO] [stdout] 36 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 ~ .args([ [INFO] [stdout] 31 + "new-session", [INFO] [stdout] 32 + "-d", [INFO] [stdout] 33 + "-s", name, [INFO] [stdout] 34 + "-c", working_dir, [INFO] [stdout] 35 + "-n", "claude", [INFO] [stdout] 36 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:146:19 [INFO] [stdout] | [INFO] [stdout] 146 | .args(&["diff", "HEAD"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["diff", "HEAD"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | .args(&["kill-session", "-t", name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["kill-session", "-t", name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:79:19 [INFO] [stdout] | [INFO] [stdout] 79 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 80 | | "send-keys", [INFO] [stdout] 81 | | "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 82 | | keys, [INFO] [stdout] 83 | | "Enter", [INFO] [stdout] 84 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 ~ .args([ [INFO] [stdout] 80 + "send-keys", [INFO] [stdout] 81 + "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 82 + keys, [INFO] [stdout] 83 + "Enter", [INFO] [stdout] 84 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/worktree.rs:227:27 [INFO] [stdout] | [INFO] [stdout] 227 | .args(&[ [INFO] [stdout] | ___________________________^ [INFO] [stdout] 228 | | "worktree", [INFO] [stdout] 229 | | "remove", [INFO] [stdout] 230 | | worktree.path.to_str().unwrap_or(""), [INFO] [stdout] 231 | | "--force", [INFO] [stdout] 232 | | ]) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 227 ~ .args([ [INFO] [stdout] 228 + "worktree", [INFO] [stdout] 229 + "remove", [INFO] [stdout] 230 + worktree.path.to_str().unwrap_or(""), [INFO] [stdout] 231 + "--force", [INFO] [stdout] 232 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 98 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 99 | | "capture-pane", [INFO] [stdout] 100 | | "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 101 | | "-p", [INFO] [stdout] 102 | | "-S", "-", // Capture entire history [INFO] [stdout] 103 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 ~ .args([ [INFO] [stdout] 99 + "capture-pane", [INFO] [stdout] 100 + "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 101 + "-p", [INFO] [stdout] 102 + "-S", "-", // Capture entire history [INFO] [stdout] 103 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/mod.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 18 | .args(&["rev-parse", "--is-inside-work-tree"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--is-inside-work-tree"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/mod.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .args(&["rev-parse", "--show-toplevel"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--show-toplevel"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git/mod.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | .args(&["branch", "--show-current"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["branch", "--show-current"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 118 | | "resize-pane", [INFO] [stdout] 119 | | "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 120 | | "-x", &width.to_string(), [INFO] [stdout] 121 | | "-y", &height.to_string(), [INFO] [stdout] 122 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 117 ~ .args([ [INFO] [stdout] 118 + "resize-pane", [INFO] [stdout] 119 + "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 120 + "-x", &width.to_string(), [INFO] [stdout] 121 + "-y", &height.to_string(), [INFO] [stdout] 122 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TmuxManager` [INFO] [stdout] --> src/tmux/manager.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | sessions: Arc::new(Mutex::new(Vec::new())), [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for TmuxManager { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:136:19 [INFO] [stdout] | [INFO] [stdout] 136 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 137 | | "set-option", [INFO] [stdout] 138 | | "-t", session_name, [INFO] [stdout] 139 | | option, value, [INFO] [stdout] 140 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 136 ~ .args([ [INFO] [stdout] 137 + "set-option", [INFO] [stdout] 138 + "-t", session_name, [INFO] [stdout] 139 + option, value, [INFO] [stdout] 140 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 154 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 155 | | "list-panes", [INFO] [stdout] 156 | | "-t", &format!("{}:{}", session_name, window_name), [INFO] [stdout] 157 | | "-F", "#{pane_id}", [INFO] [stdout] 158 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 154 ~ .args([ [INFO] [stdout] 155 + "list-panes", [INFO] [stdout] 156 + "-t", &format!("{}:{}", session_name, window_name), [INFO] [stdout] 157 + "-F", "#{pane_id}", [INFO] [stdout] 158 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 31 | | "new-session", [INFO] [stdout] 32 | | "-d", [INFO] [stdout] 33 | | "-s", name, [INFO] [stdout] 34 | | "-c", working_dir, [INFO] [stdout] 35 | | "-n", "claude", [INFO] [stdout] 36 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 ~ .args([ [INFO] [stdout] 31 + "new-session", [INFO] [stdout] 32 + "-d", [INFO] [stdout] 33 + "-s", name, [INFO] [stdout] 34 + "-c", working_dir, [INFO] [stdout] 35 + "-n", "claude", [INFO] [stdout] 36 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | .args(&["kill-session", "-t", name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["kill-session", "-t", name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:193:27 [INFO] [stdout] | [INFO] [stdout] 193 | .args(&["kill-session", "-t", &session_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["kill-session", "-t", &session_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:79:19 [INFO] [stdout] | [INFO] [stdout] 79 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 80 | | "send-keys", [INFO] [stdout] 81 | | "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 82 | | keys, [INFO] [stdout] 83 | | "Enter", [INFO] [stdout] 84 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 ~ .args([ [INFO] [stdout] 80 + "send-keys", [INFO] [stdout] 81 + "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 82 + keys, [INFO] [stdout] 83 + "Enter", [INFO] [stdout] 84 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 98 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 99 | | "capture-pane", [INFO] [stdout] 100 | | "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 101 | | "-p", [INFO] [stdout] 102 | | "-S", "-", // Capture entire history [INFO] [stdout] 103 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 ~ .args([ [INFO] [stdout] 99 + "capture-pane", [INFO] [stdout] 100 + "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 101 + "-p", [INFO] [stdout] 102 + "-S", "-", // Capture entire history [INFO] [stdout] 103 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 118 | | "resize-pane", [INFO] [stdout] 119 | | "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 120 | | "-x", &width.to_string(), [INFO] [stdout] 121 | | "-y", &height.to_string(), [INFO] [stdout] 122 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 117 ~ .args([ [INFO] [stdout] 118 + "resize-pane", [INFO] [stdout] 119 + "-t", &format!("{}:{}.{}", session.name, session.window, session.pane), [INFO] [stdout] 120 + "-x", &width.to_string(), [INFO] [stdout] 121 + "-y", &height.to_string(), [INFO] [stdout] 122 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:136:19 [INFO] [stdout] | [INFO] [stdout] 136 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 137 | | "set-option", [INFO] [stdout] 138 | | "-t", session_name, [INFO] [stdout] 139 | | option, value, [INFO] [stdout] 140 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 136 ~ .args([ [INFO] [stdout] 137 + "set-option", [INFO] [stdout] 138 + "-t", session_name, [INFO] [stdout] 139 + option, value, [INFO] [stdout] 140 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 154 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 155 | | "list-panes", [INFO] [stdout] 156 | | "-t", &format!("{}:{}", session_name, window_name), [INFO] [stdout] 157 | | "-F", "#{pane_id}", [INFO] [stdout] 158 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 154 ~ .args([ [INFO] [stdout] 155 + "list-panes", [INFO] [stdout] 156 + "-t", &format!("{}:{}", session_name, window_name), [INFO] [stdout] 157 + "-F", "#{pane_id}", [INFO] [stdout] 158 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tmux/manager.rs:193:27 [INFO] [stdout] | [INFO] [stdout] 193 | .args(&["kill-session", "-t", &session_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["kill-session", "-t", &session_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/ui/app.rs:703:60 [INFO] [stdout] | [INFO] [stdout] 703 | for (_idx, session) in self.sessions.iter_mut().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 703 - for (_idx, session) in self.sessions.iter_mut().enumerate() { [INFO] [stdout] 703 + for session in self.sessions.iter_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/app.rs:748:29 [INFO] [stdout] | [INFO] [stdout] 748 | / ... if waiting_approval { [INFO] [stdout] 749 | | ... session.update_state(SessionState::WaitingForApproval); [INFO] [stdout] 750 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 747 ~ SessionState::Coordinating [INFO] [stdout] 748 ~ if waiting_approval => { [INFO] [stdout] 749 | session.update_state(SessionState::WaitingForApproval); [INFO] [stdout] 750 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/core/mock.rs:41:25 [INFO] [stdout] | [INFO] [stdout] 41 | let files = vec![ [INFO] [stdout] | _________________________^ [INFO] [stdout] 42 | | "src/main.rs", [INFO] [stdout] 43 | | "src/core/session.rs", [INFO] [stdout] 44 | | "src/ui/app.rs", [INFO] [stdout] 45 | | "src/git/worktree.rs", [INFO] [stdout] 46 | | "Cargo.toml", [INFO] [stdout] 47 | | ]; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 41 ~ let files = ["src/main.rs", [INFO] [stdout] 42 + "src/core/session.rs", [INFO] [stdout] 43 + "src/ui/app.rs", [INFO] [stdout] 44 + "src/git/worktree.rs", [INFO] [stdout] 45 ~ "Cargo.toml"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/core/mock.rs:49:27 [INFO] [stdout] | [INFO] [stdout] 49 | let actions = vec![ [INFO] [stdout] | ___________________________^ [INFO] [stdout] 50 | | "Reviewing", [INFO] [stdout] 51 | | "Analyzing", [INFO] [stdout] 52 | | "Refactoring", [INFO] [stdout] 53 | | "Optimizing", [INFO] [stdout] 54 | | "Testing", [INFO] [stdout] 55 | | ]; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 49 ~ let actions = ["Reviewing", [INFO] [stdout] 50 + "Analyzing", [INFO] [stdout] 51 + "Refactoring", [INFO] [stdout] 52 + "Optimizing", [INFO] [stdout] 53 ~ "Testing"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/core/mock_coordinator.rs:47:28 [INFO] [stdout] | [INFO] [stdout] 47 | let subtasks = vec![ [INFO] [stdout] | ____________________________^ [INFO] [stdout] 48 | | "1. Refactor authentication module for better security", [INFO] [stdout] 49 | | "2. Optimize database queries in the user service", [INFO] [stdout] 50 | | "3. Add comprehensive error handling to API endpoints", [INFO] [stdout] 51 | | "4. Implement caching layer for frequently accessed data", [INFO] [stdout] 52 | | ]; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 47 ~ let subtasks = ["1. Refactor authentication module for better security", [INFO] [stdout] 48 + "2. Optimize database queries in the user service", [INFO] [stdout] 49 + "3. Add comprehensive error handling to API endpoints", [INFO] [stdout] 50 ~ "4. Implement caching layer for frequently accessed data"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/ui/app.rs:703:60 [INFO] [stdout] | [INFO] [stdout] 703 | for (_idx, session) in self.sessions.iter_mut().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 703 - for (_idx, session) in self.sessions.iter_mut().enumerate() { [INFO] [stdout] 703 + for session in self.sessions.iter_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/app.rs:748:29 [INFO] [stdout] | [INFO] [stdout] 748 | / ... if waiting_approval { [INFO] [stdout] 749 | | ... session.update_state(SessionState::WaitingForApproval); [INFO] [stdout] 750 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 747 ~ SessionState::Coordinating [INFO] [stdout] 748 ~ if waiting_approval => { [INFO] [stdout] 749 | session.update_state(SessionState::WaitingForApproval); [INFO] [stdout] 750 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/core/mock.rs:41:25 [INFO] [stdout] | [INFO] [stdout] 41 | let files = vec![ [INFO] [stdout] | _________________________^ [INFO] [stdout] 42 | | "src/main.rs", [INFO] [stdout] 43 | | "src/core/session.rs", [INFO] [stdout] 44 | | "src/ui/app.rs", [INFO] [stdout] 45 | | "src/git/worktree.rs", [INFO] [stdout] 46 | | "Cargo.toml", [INFO] [stdout] 47 | | ]; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 41 ~ let files = ["src/main.rs", [INFO] [stdout] 42 + "src/core/session.rs", [INFO] [stdout] 43 + "src/ui/app.rs", [INFO] [stdout] 44 + "src/git/worktree.rs", [INFO] [stdout] 45 ~ "Cargo.toml"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/core/mock.rs:49:27 [INFO] [stdout] | [INFO] [stdout] 49 | let actions = vec![ [INFO] [stdout] | ___________________________^ [INFO] [stdout] 50 | | "Reviewing", [INFO] [stdout] 51 | | "Analyzing", [INFO] [stdout] 52 | | "Refactoring", [INFO] [stdout] 53 | | "Optimizing", [INFO] [stdout] 54 | | "Testing", [INFO] [stdout] 55 | | ]; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 49 ~ let actions = ["Reviewing", [INFO] [stdout] 50 + "Analyzing", [INFO] [stdout] 51 + "Refactoring", [INFO] [stdout] 52 + "Optimizing", [INFO] [stdout] 53 ~ "Testing"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/core/mock_coordinator.rs:47:28 [INFO] [stdout] | [INFO] [stdout] 47 | let subtasks = vec![ [INFO] [stdout] | ____________________________^ [INFO] [stdout] 48 | | "1. Refactor authentication module for better security", [INFO] [stdout] 49 | | "2. Optimize database queries in the user service", [INFO] [stdout] 50 | | "3. Add comprehensive error handling to API endpoints", [INFO] [stdout] 51 | | "4. Implement caching layer for frequently accessed data", [INFO] [stdout] 52 | | ]; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 47 ~ let subtasks = ["1. Refactor authentication module for better security", [INFO] [stdout] 48 + "2. Optimize database queries in the user service", [INFO] [stdout] 49 + "3. Add comprehensive error handling to API endpoints", [INFO] [stdout] 50 ~ "4. Implement caching layer for frequently accessed data"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 21s [INFO] running `Command { std: "docker" "inspect" "bda1eda4bc7859adac100dd2a93068ef3c87b093dad385d6c24a4faed1547574", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bda1eda4bc7859adac100dd2a93068ef3c87b093dad385d6c24a4faed1547574", kill_on_drop: false }` [INFO] [stdout] bda1eda4bc7859adac100dd2a93068ef3c87b093dad385d6c24a4faed1547574