[INFO] cloning repository https://github.com/brentesh/agent [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brentesh/agent" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrentesh%2Fagent", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrentesh%2Fagent'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c2ff775269e3dd481fe1d9e3a42c65396a5b873f [INFO] linting brentesh/agent against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrentesh%2Fagent" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/brentesh/agent [INFO] finished tweaking git repo https://github.com/brentesh/agent [INFO] tweaked toml for git repo https://github.com/brentesh/agent written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/brentesh/agent on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/brentesh/agent already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded confy v1.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3cbe1e76df6953eaa95913311ecddb283dfd901bf2a83d7a45cceb5d495a1f04 [INFO] running `Command { std: "docker" "start" "-a" "3cbe1e76df6953eaa95913311ecddb283dfd901bf2a83d7a45cceb5d495a1f04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3cbe1e76df6953eaa95913311ecddb283dfd901bf2a83d7a45cceb5d495a1f04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cbe1e76df6953eaa95913311ecddb283dfd901bf2a83d7a45cceb5d495a1f04", kill_on_drop: false }` [INFO] [stdout] 3cbe1e76df6953eaa95913311ecddb283dfd901bf2a83d7a45cceb5d495a1f04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c8daa4d20c7cf65358eab770b932e6681fecc2041b173cd721294e64297b696 [INFO] running `Command { std: "docker" "start" "-a" "9c8daa4d20c7cf65358eab770b932e6681fecc2041b173cd721294e64297b696", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling cc v1.2.24 [INFO] [stderr] Compiling hashbrown v0.15.3 [INFO] [stderr] Compiling toml_datetime v0.6.9 [INFO] [stderr] Compiling winnow v0.7.10 [INFO] [stderr] Checking libloading v0.8.7 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Compiling wayland-sys v0.31.6 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Compiling wayland-client v0.31.10 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling indexmap v2.9.0 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Compiling xml-rs v0.8.26 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking accesskit v0.17.1 [INFO] [stderr] Compiling wayland-scanner v0.31.6 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking immutable-chunkmap v2.0.6 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling wayland-backend v0.3.10 [INFO] [stderr] Compiling openssl-sys v0.9.108 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling winit v0.30.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking accesskit_consumer v0.26.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Compiling toml_edit v0.22.26 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking epaint_default_fonts v0.31.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking toml_write v0.1.1 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking strum v0.27.1 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling enumflags2_derive v0.7.11 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling bytemuck_derive v1.9.3 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling strum_macros v0.27.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking bytemuck v1.23.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking polling v3.8.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.31.1 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking async-io v2.4.1 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking ecolor v0.31.1 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking epaint v0.31.1 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking wayland-protocols v0.32.8 [INFO] [stderr] Checking wayland-cursor v0.31.10 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking egui v0.31.1 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking enumflags2 v0.7.11 [INFO] [stderr] Checking quick-xml v0.30.0 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking egui_glow v0.31.1 [INFO] [stderr] Checking webbrowser v1.0.4 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking toml v0.8.22 [INFO] [stderr] Checking zbus_xml v4.0.0 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking confy v1.0.0 [INFO] [stderr] Checking zbus-lockstep v0.4.4 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.8 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.8 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking arboard v3.5.0 [INFO] [stderr] Compiling zbus-lockstep-macros v0.4.4 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking atspi-common v0.6.0 [INFO] [stderr] Checking atspi-proxies v0.6.0 [INFO] [stderr] Checking accesskit_atspi_common v0.10.1 [INFO] [stderr] Checking atspi-connection v0.6.0 [INFO] [stderr] Checking atspi v0.22.0 [INFO] [stderr] Checking accesskit_unix v0.13.1 [INFO] [stderr] Checking accesskit_winit v0.23.1 [INFO] [stderr] Checking egui-winit v0.31.1 [INFO] [stderr] Checking eframe v0.31.1 [INFO] [stderr] Checking agent v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `PYTMDET` contains a capitalized acronym [INFO] [stdout] --> src/api.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct PYTMDET { [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Pytmdet` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PYTMDET` contains a capitalized acronym [INFO] [stdout] --> src/api.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct PYTMDET { [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Pytmdet` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/api.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 39 | return Err(format!("No time details found for the specified dates").into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No time details found for the specified dates".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/api.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 39 | return Err(format!("No time details found for the specified dates").into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No time details found for the specified dates".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | &dates, [INFO] [stdout] | ^^^^^^ help: change this to: `dates` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | &pay_type, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `pay_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | &dates, [INFO] [stdout] | ^^^^^^ help: change this to: `dates` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | &pay_type, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `pay_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/api.rs:87:15 [INFO] [stdout] | [INFO] [stdout] 87 | pytmdets: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 87 - pytmdets: &Vec, [INFO] [stdout] 87 + pytmdets: &[PYTMDET], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/api.rs:87:15 [INFO] [stdout] | [INFO] [stdout] 87 | pytmdets: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 87 - pytmdets: &Vec, [INFO] [stdout] 87 + pytmdets: &[PYTMDET], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.find(..)` [INFO] [stdout] --> src/api.rs:92:44 [INFO] [stdout] | [INFO] [stdout] 92 | if let Some(old) = pytmdets.iter().find_map(|d| { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 93 | | if d.get_date() == Some(*date) { [INFO] [stdout] 94 | | Some(d) [INFO] [stdout] 95 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 98 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_find_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.find(..)` [INFO] [stdout] --> src/api.rs:92:44 [INFO] [stdout] | [INFO] [stdout] 92 | if let Some(old) = pytmdets.iter().find_map(|d| { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 93 | | if d.get_date() == Some(*date) { [INFO] [stdout] 94 | | Some(d) [INFO] [stdout] 95 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 98 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_find_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/api.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 112 | dates: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 112 - dates: &Vec, [INFO] [stdout] 112 + dates: &[NaiveDate], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/api.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 112 | dates: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 112 - dates: &Vec, [INFO] [stdout] 112 + dates: &[NaiveDate], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/api.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 154 | return Err(format!("No time details found to change").into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No time details found to change".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/api.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 154 | return Err(format!("No time details found to change").into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No time details found to change".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/api.rs:174:22 [INFO] [stdout] | [INFO] [stdout] 174 | fn get_body(autoids: &Vec, pay_type: &str) -> serde_json::Value { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 174 - fn get_body(autoids: &Vec, pay_type: &str) -> serde_json::Value { [INFO] [stdout] 174 + fn get_body(autoids: &[String], pay_type: &str) -> serde_json::Value { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/api.rs:174:22 [INFO] [stdout] | [INFO] [stdout] 174 | fn get_body(autoids: &Vec, pay_type: &str) -> serde_json::Value { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 174 - fn get_body(autoids: &Vec, pay_type: &str) -> serde_json::Value { [INFO] [stdout] 174 + fn get_body(autoids: &[String], pay_type: &str) -> serde_json::Value { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/gpt.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | conversation: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 ~ conversation: &[ConversationMessage], [INFO] [stdout] 44 | ) -> Result> { [INFO] [stdout] ... [INFO] [stdout] 61 | if !conversation.is_empty() { [INFO] [stdout] 62 ~ full_conversation.extend(conversation.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/gpt.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | conversation: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 ~ conversation: &[ConversationMessage], [INFO] [stdout] 44 | ) -> Result> { [INFO] [stdout] ... [INFO] [stdout] 61 | if !conversation.is_empty() { [INFO] [stdout] 62 ~ full_conversation.extend(conversation.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gpt.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | / if let Some(fc) = &msg.function_call { [INFO] [stdout] 80 | | if let serde_json::Value::Object(ref mut map) = obj { [INFO] [stdout] 81 | | map.insert( [INFO] [stdout] 82 | | "function_call".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 79 ~ if let Some(fc) = &msg.function_call [INFO] [stdout] 80 ~ && let serde_json::Value::Object(ref mut map) = obj { [INFO] [stdout] 81 | map.insert( [INFO] [stdout] ... [INFO] [stdout] 87 | ); [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gpt.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | / if let Some(fc) = &msg.function_call { [INFO] [stdout] 80 | | if let serde_json::Value::Object(ref mut map) = obj { [INFO] [stdout] 81 | | map.insert( [INFO] [stdout] 82 | | "function_call".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 79 ~ if let Some(fc) = &msg.function_call [INFO] [stdout] 80 ~ && let serde_json::Value::Object(ref mut map) = obj { [INFO] [stdout] 81 | map.insert( [INFO] [stdout] ... [INFO] [stdout] 87 | ); [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/lib.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / impl ToString for PayType { [INFO] [stdout] 39 | | fn to_string(&self) -> String { [INFO] [stdout] 40 | | format!("{:?}", self) [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/lib.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / impl ToString for PayType { [INFO] [stdout] 39 | | fn to_string(&self) -> String { [INFO] [stdout] 40 | | format!("{:?}", self) [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / return Some(format!( [INFO] [stdout] 85 | | "I set the pay type for {} from {} to {}", [INFO] [stdout] 86 | | self.date.format("%a %B %d, %Y"), [INFO] [stdout] 87 | | from, [INFO] [stdout] 88 | | to, [INFO] [stdout] 89 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 ~ Some(format!( [INFO] [stdout] 85 + "I set the pay type for {} from {} to {}", [INFO] [stdout] 86 + self.date.format("%a %B %d, %Y"), [INFO] [stdout] 87 + from, [INFO] [stdout] 88 + to, [INFO] [stdout] 89 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / return Some(format!( [INFO] [stdout] 85 | | "I set the pay type for {} from {} to {}", [INFO] [stdout] 86 | | self.date.format("%a %B %d, %Y"), [INFO] [stdout] 87 | | from, [INFO] [stdout] 88 | | to, [INFO] [stdout] 89 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 ~ Some(format!( [INFO] [stdout] 85 + "I set the pay type for {} from {} to {}", [INFO] [stdout] 86 + self.date.format("%a %B %d, %Y"), [INFO] [stdout] 87 + from, [INFO] [stdout] 88 + to, [INFO] [stdout] 89 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:118:19 [INFO] [stdout] | [INFO] [stdout] 118 | Err(e) => return Err(ExecutionError::AgentError(e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - Err(e) => return Err(ExecutionError::AgentError(e.to_string())), [INFO] [stdout] 118 + Err(e) => Err(ExecutionError::AgentError(e.to_string())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:118:19 [INFO] [stdout] | [INFO] [stdout] 118 | Err(e) => return Err(ExecutionError::AgentError(e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - Err(e) => return Err(ExecutionError::AgentError(e.to_string())), [INFO] [stdout] 118 + Err(e) => Err(ExecutionError::AgentError(e.to_string())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:119:48 [INFO] [stdout] | [INFO] [stdout] 119 | Ok(AgentResponse::Message(content)) => return Ok(ExecutionResult::Message(content)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - Ok(AgentResponse::Message(content)) => return Ok(ExecutionResult::Message(content)), [INFO] [stdout] 119 + Ok(AgentResponse::Message(content)) => Ok(ExecutionResult::Message(content)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:119:48 [INFO] [stdout] | [INFO] [stdout] 119 | Ok(AgentResponse::Message(content)) => return Ok(ExecutionResult::Message(content)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - Ok(AgentResponse::Message(content)) => return Ok(ExecutionResult::Message(content)), [INFO] [stdout] 119 + Ok(AgentResponse::Message(content)) => Ok(ExecutionResult::Message(content)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/lib.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | println!("{}", format!("Calling GPT with prompt: {}", prompt)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/lib.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | println!("{}", format!("Calling GPT with prompt: {}", prompt)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:115:57 [INFO] [stdout] | [INFO] [stdout] 115 | let gpt_result = gpt::call_gpt(&config.gpt_api_key, &prompt, conversation).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `prompt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:115:57 [INFO] [stdout] | [INFO] [stdout] 115 | let gpt_result = gpt::call_gpt(&config.gpt_api_key, &prompt, conversation).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `prompt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:159:63 [INFO] [stdout] | [INFO] [stdout] 159 | let result = api::set_pay_type(config, &dates, &pay_type, &function_call) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `function_call` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:159:63 [INFO] [stdout] | [INFO] [stdout] 159 | let result = api::set_pay_type(config, &dates, &pay_type, &function_call) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `function_call` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | / if ui [INFO] [stdout] 125 | | .add_sized([120.0, 32.0], egui::Button::new("Log In")) [INFO] [stdout] 126 | | .clicked() [INFO] [stdout] 127 | | || enter_pressed [INFO] [stdout] ... | [INFO] [stdout] 144 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ if (ui [INFO] [stdout] 125 | .add_sized([120.0, 32.0], egui::Button::new("Log In")) [INFO] [stdout] 126 | .clicked() [INFO] [stdout] 127 ~ || enter_pressed [INFO] [stdout] 128 ~ || enter_pressed) [INFO] [stdout] 129 | { [INFO] [stdout] 130 ~ && !self.username.is_empty() [INFO] [stdout] 131 | && !self.password.is_empty() [INFO] [stdout] ... [INFO] [stdout] 143 | save_config(&self.config); [INFO] [stdout] 144 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | / if ui [INFO] [stdout] 125 | | .add_sized([120.0, 32.0], egui::Button::new("Log In")) [INFO] [stdout] 126 | | .clicked() [INFO] [stdout] 127 | | || enter_pressed [INFO] [stdout] ... | [INFO] [stdout] 144 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ if (ui [INFO] [stdout] 125 | .add_sized([120.0, 32.0], egui::Button::new("Log In")) [INFO] [stdout] 126 | .clicked() [INFO] [stdout] 127 ~ || enter_pressed [INFO] [stdout] 128 ~ || enter_pressed) [INFO] [stdout] 129 | { [INFO] [stdout] 130 ~ && !self.username.is_empty() [INFO] [stdout] 131 | && !self.password.is_empty() [INFO] [stdout] ... [INFO] [stdout] 143 | save_config(&self.config); [INFO] [stdout] 144 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/main.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | / { [INFO] [stdout] 272 | | conversation = current_conversation.lock().unwrap().clone() [INFO] [stdout] 273 | | }; // lock released here [INFO] [stdout] | |______^ help: statement can be reduced to: `conversation = current_conversation.lock().unwrap().clone();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/main.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | / { [INFO] [stdout] 272 | | conversation = current_conversation.lock().unwrap().clone() [INFO] [stdout] 273 | | }; // lock released here [INFO] [stdout] | |______^ help: statement can be reduced to: `conversation = current_conversation.lock().unwrap().clone();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `Command { std: "docker" "inspect" "9c8daa4d20c7cf65358eab770b932e6681fecc2041b173cd721294e64297b696", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c8daa4d20c7cf65358eab770b932e6681fecc2041b173cd721294e64297b696", kill_on_drop: false }` [INFO] [stdout] 9c8daa4d20c7cf65358eab770b932e6681fecc2041b173cd721294e64297b696