[INFO] cloning repository https://github.com/bramvanwersch/chip-8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bramvanwersch/chip-8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbramvanwersch%2Fchip-8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbramvanwersch%2Fchip-8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bcad9f3c9394a54e682fa14efbeb7b507f7ea544 [INFO] linting bramvanwersch/chip-8 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbramvanwersch%2Fchip-8" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bramvanwersch/chip-8 [INFO] finished tweaking git repo https://github.com/bramvanwersch/chip-8 [INFO] tweaked toml for git repo https://github.com/bramvanwersch/chip-8 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bramvanwersch/chip-8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bramvanwersch/chip-8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded getrandom v0.2.12 [INFO] [stderr] Downloaded cc v1.0.88 [INFO] [stderr] Downloaded sdl2 v0.36.0 [INFO] [stderr] Downloaded sdl2-sys v0.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f6553a4742ef3d8df4bc34c18f95624eac571c1c87668e8eee7f489add1e2681 [INFO] running `Command { std: "docker" "start" "-a" "f6553a4742ef3d8df4bc34c18f95624eac571c1c87668e8eee7f489add1e2681", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f6553a4742ef3d8df4bc34c18f95624eac571c1c87668e8eee7f489add1e2681", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6553a4742ef3d8df4bc34c18f95624eac571c1c87668e8eee7f489add1e2681", kill_on_drop: false }` [INFO] [stdout] f6553a4742ef3d8df4bc34c18f95624eac571c1c87668e8eee7f489add1e2681 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7780e89185b1202bc689265e9c8637ce180d583f13addc5174bf8e45f593c761 [INFO] running `Command { std: "docker" "start" "-a" "7780e89185b1202bc689265e9c8637ce180d583f13addc5174bf8e45f593c761", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling cc v1.0.88 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chippie_ate v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drivers/input.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use sdl2; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/drivers/input.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use sdl2; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct CPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RAM` contains a capitalized acronym [INFO] [stdout] --> src/ram.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct RAM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ram` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `count` is used as a loop counter [INFO] [stdout] --> src/ram.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | for val in values { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (count, val) in values.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ram.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | if from % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `!from.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ram.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | if to % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: replace with: `!to.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/drivers/cartridge.rs:15:44 [INFO] [stdout] | [INFO] [stdout] 15 | for (index, line) in lines.flatten().enumerate(){ [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/drivers/cartridge.rs:15:38 [INFO] [stdout] | [INFO] [stdout] 15 | for (index, line) in lines.flatten().enumerate(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/drivers/cartridge.rs:16:54 [INFO] [stdout] | [INFO] [stdout] 16 | match interpreter.interpret_line(&line.trim()){ [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `line.trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/drivers/cartridge.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | compiled.write_all(&val.as_bytes()).expect("Failed to write values to file"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `val.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/interpreter.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | if line.eq("") { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `values.get(0)` [INFO] [stdout] --> src/interpreter.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | let command = match values.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `values.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/interpreter.rs:89:20 [INFO] [stdout] | [INFO] [stdout] 89 | if self.current_function != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `self.current_function.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(name).is_some()` [INFO] [stdout] --> src/interpreter.rs:96:40 [INFO] [stdout] | [INFO] [stdout] 96 | if self.definition_map.get(name).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 126 | if !self.definition_map.get(command).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.definition_map.get(command).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(command).is_some()` [INFO] [stdout] --> src/interpreter.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 126 | if !self.definition_map.get(command).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(command)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/interpreter.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | / let mut vec = Vec::new(); [INFO] [stdout] 133 | | vec.push(self.offset); [INFO] [stdout] | |______________________________________^ help: consider using the `vec![]` macro: `let vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct CPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RAM` contains a capitalized acronym [INFO] [stdout] --> src/ram.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct RAM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ram` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `count` is used as a loop counter [INFO] [stdout] --> src/ram.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | for val in values { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (count, val) in values.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ram.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | if from % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `!from.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ram.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | if to % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: replace with: `!to.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/drivers/cartridge.rs:15:44 [INFO] [stdout] | [INFO] [stdout] 15 | for (index, line) in lines.flatten().enumerate(){ [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/drivers/cartridge.rs:15:38 [INFO] [stdout] | [INFO] [stdout] 15 | for (index, line) in lines.flatten().enumerate(){ [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/drivers/cartridge.rs:16:54 [INFO] [stdout] | [INFO] [stdout] 16 | match interpreter.interpret_line(&line.trim()){ [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `line.trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/drivers/cartridge.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | compiled.write_all(&val.as_bytes()).expect("Failed to write values to file"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `val.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/interpreter.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | if line.eq("") { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `values.get(0)` [INFO] [stdout] --> src/interpreter.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | let command = match values.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `values.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/interpreter.rs:89:20 [INFO] [stdout] | [INFO] [stdout] 89 | if self.current_function != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `self.current_function.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(name).is_some()` [INFO] [stdout] --> src/interpreter.rs:96:40 [INFO] [stdout] | [INFO] [stdout] 96 | if self.definition_map.get(name).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interpreter.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 126 | if !self.definition_map.get(command).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.definition_map.get(command).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(command).is_some()` [INFO] [stdout] --> src/interpreter.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 126 | if !self.definition_map.get(command).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(command)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/interpreter.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | / let mut vec = Vec::new(); [INFO] [stdout] 133 | | vec.push(self.offset); [INFO] [stdout] | |______________________________________^ help: consider using the `vec![]` macro: `let vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/interpreter.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | / let mut values: Vec<&str> = Vec::new(); [INFO] [stdout] 228 | | values.push("0"); [INFO] [stdout] 229 | | values.push("A"); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let values: Vec<&str> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/interpreter.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | / let mut values: Vec<&str> = Vec::new(); [INFO] [stdout] 241 | | values.push("0"); [INFO] [stdout] 242 | | values.push("A"); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let values: Vec<&str> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/interpreter.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 251 | / let mut values: Vec<&str> = Vec::new(); [INFO] [stdout] 252 | | values.push("0"); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let values: Vec<&str> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/interpreter.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | / let mut values: Vec<&str> = Vec::new(); [INFO] [stdout] 261 | | values.push("0"); [INFO] [stdout] 262 | | values.push("G"); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let values: Vec<&str> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 39s [INFO] running `Command { std: "docker" "inspect" "7780e89185b1202bc689265e9c8637ce180d583f13addc5174bf8e45f593c761", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7780e89185b1202bc689265e9c8637ce180d583f13addc5174bf8e45f593c761", kill_on_drop: false }` [INFO] [stdout] 7780e89185b1202bc689265e9c8637ce180d583f13addc5174bf8e45f593c761