[INFO] cloning repository https://github.com/brainplusplus/supa-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brainplusplus/supa-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrainplusplus%2Fsupa-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrainplusplus%2Fsupa-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c7c1ae8871101a982ecaf0cd4bd962a6ed6da3f0 [INFO] linting brainplusplus/supa-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrainplusplus%2Fsupa-rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/brainplusplus/supa-rs [INFO] finished tweaking git repo https://github.com/brainplusplus/supa-rs [INFO] tweaked toml for git repo https://github.com/brainplusplus/supa-rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/brainplusplus/supa-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/brainplusplus/supa-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lzma-rs v0.3.0 [INFO] [stderr] Downloaded ppmd-rust v1.4.0 [INFO] [stderr] Downloaded inherent v1.0.13 [INFO] [stderr] Downloaded deflate64 v0.1.11 [INFO] [stderr] Downloaded axum-server v0.8.0 [INFO] [stderr] Downloaded zip v8.1.0 [INFO] [stderr] Downloaded axum-extra v0.12.5 [INFO] [stderr] Downloaded zlib-rs v0.6.2 [INFO] [stderr] Downloaded object_store v0.10.2 [INFO] [stderr] Downloaded lzma-rust2 v0.16.2 [INFO] [stderr] Downloaded pg-embed v1.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 948ec3ce8fa680754be0225ff11476171a2d9d64f845ea0a905c59db3ccdd94b [INFO] running `Command { std: "docker" "start" "-a" "948ec3ce8fa680754be0225ff11476171a2d9d64f845ea0a905c59db3ccdd94b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "948ec3ce8fa680754be0225ff11476171a2d9d64f845ea0a905c59db3ccdd94b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "948ec3ce8fa680754be0225ff11476171a2d9d64f845ea0a905c59db3ccdd94b", kill_on_drop: false }` [INFO] [stdout] 948ec3ce8fa680754be0225ff11476171a2d9d64f845ea0a905c59db3ccdd94b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a996a98ee6927e1f6ee4f17c22c6d12a90518c30a44de1e4fd4f1179f303c0f6 [INFO] running `Command { std: "docker" "start" "-a" "a996a98ee6927e1f6ee4f17c22c6d12a90518c30a44de1e4fd4f1179f303c0f6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling futures-core v0.3.32 [INFO] [stderr] Compiling aws-lc-rs v1.16.0 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling futures-sink v0.3.32 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling tinyvec v1.10.0 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling deranged v0.5.8 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Compiling slab v0.4.12 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling futures-util v0.3.32 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling tokio v1.49.0 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling home v0.5.12 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling fs-err v3.3.0 [INFO] [stderr] Checking libbz2-rs-sys v0.2.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking zlib-rs v0.6.2 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking lzma-rust2 v0.16.2 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking ppmd-rust v1.4.0 [INFO] [stderr] Checking bzip2 v0.6.1 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Checking constant_time_eq v0.4.2 [INFO] [stderr] Checking deflate64 v0.1.11 [INFO] [stderr] Checking typed-path v0.12.3 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Compiling aws-lc-sys v0.37.1 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling inherent v1.0.13 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking simple_asn1 v0.6.4 [INFO] [stderr] Compiling axum-macros v0.5.0 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling sea-query-derive v0.4.3 [INFO] [stderr] Checking zip v8.1.0 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking sea-query v0.32.7 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking jsonwebtoken v9.3.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Compiling sqlx-postgres v0.8.6 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking sea-query-binder v0.7.0 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking axum-server v0.8.0 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking pg-embed v1.0.0 [INFO] [stderr] Checking axum-extra v0.12.5 [INFO] [stderr] Checking suparust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:335:77 [INFO] [stdout] | [INFO] [stdout] 335 | let mut outer = sha2::Sha256::new(); outer.update(&o_key); outer.update(&inner_hash); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `inner_hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/api/rest.rs:168:60 [INFO] [stdout] | [INFO] [stdout] 168 | ...-> Result<(Vec, Option, Option, Vec, Vec), PostgRestError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/rest.rs:235:56 [INFO] [stdout] | [INFO] [stdout] 235 | let (sql, params_vec) = build_select(&ast).map_err(|e| PostgRestError::from(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PostgRestError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/rest.rs:264:122 [INFO] [stdout] | [INFO] [stdout] 264 | ...ap_err(|e| PostgRestError::from(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PostgRestError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/rest.rs:299:106 [INFO] [stdout] | [INFO] [stdout] 299 | ...ap_err(|e| PostgRestError::from(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PostgRestError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/rest.rs:333:99 [INFO] [stdout] | [INFO] [stdout] 333 | let (sql, params_vec) = build_delete("public", &table, &filters, opts.return_minimal).map_err(|e| PostgRestError::from(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PostgRestError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/api/auth.rs:125:1 [INFO] [stdout] | [INFO] [stdout] 125 | / async fn sign_in_user( [INFO] [stdout] 126 | | pool: &PgPool, [INFO] [stdout] 127 | | jwt_secret: &str, [INFO] [stdout] 128 | | user_id: String, [INFO] [stdout] ... | [INFO] [stdout] 133 | | email_confirmed_at: Option, [INFO] [stdout] 134 | | ) -> Result, Response> { [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 142 | .bind(&user_uuid) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:157:11 [INFO] [stdout] | [INFO] [stdout] 157 | .bind(&user_uuid) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:158:11 [INFO] [stdout] | [INFO] [stdout] 158 | .bind(&session_id) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:291:19 [INFO] [stdout] | [INFO] [stdout] 291 | .bind(&session_id) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:301:15 [INFO] [stdout] | [INFO] [stdout] 301 | .bind(&r_id) [INFO] [stdout] | ^^^^^ help: change this to: `r_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:313:11 [INFO] [stdout] | [INFO] [stdout] 313 | .bind(&user_id) [INFO] [stdout] | ^^^^^^^^ help: change this to: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:314:11 [INFO] [stdout] | [INFO] [stdout] 314 | .bind(&session_id) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:444:11 [INFO] [stdout] | [INFO] [stdout] 444 | .bind(&row_id.to_string()) // Identities string ID [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `row_id.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:445:11 [INFO] [stdout] | [INFO] [stdout] 445 | .bind(&row_id) [INFO] [stdout] | ^^^^^^^ help: change this to: `row_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api/auth.rs:472:9 [INFO] [stdout] | [INFO] [stdout] 472 | &token, [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:499:15 [INFO] [stdout] | [INFO] [stdout] 499 | .bind(&session_uuid) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `session_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:529:11 [INFO] [stdout] | [INFO] [stdout] 529 | .bind(&user_uuid) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:592:11 [INFO] [stdout] | [INFO] [stdout] 592 | .bind(&user_uuid) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/api/storage.rs:114:47 [INFO] [stdout] | [INFO] [stdout] 114 | fn sanitize_path(bucket: &str, path: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:335:77 [INFO] [stdout] | [INFO] [stdout] 335 | let mut outer = sha2::Sha256::new(); outer.update(&o_key); outer.update(&inner_hash); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `inner_hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/api/rest.rs:168:60 [INFO] [stdout] | [INFO] [stdout] 168 | ...-> Result<(Vec, Option, Option, Vec, Vec), PostgRestError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/rest.rs:235:56 [INFO] [stdout] | [INFO] [stdout] 235 | let (sql, params_vec) = build_select(&ast).map_err(|e| PostgRestError::from(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PostgRestError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/rest.rs:264:122 [INFO] [stdout] | [INFO] [stdout] 264 | ...ap_err(|e| PostgRestError::from(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PostgRestError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/rest.rs:299:106 [INFO] [stdout] | [INFO] [stdout] 299 | ...ap_err(|e| PostgRestError::from(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PostgRestError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/rest.rs:333:99 [INFO] [stdout] | [INFO] [stdout] 333 | let (sql, params_vec) = build_delete("public", &table, &filters, opts.return_minimal).map_err(|e| PostgRestError::from(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PostgRestError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/api/auth.rs:125:1 [INFO] [stdout] | [INFO] [stdout] 125 | / async fn sign_in_user( [INFO] [stdout] 126 | | pool: &PgPool, [INFO] [stdout] 127 | | jwt_secret: &str, [INFO] [stdout] 128 | | user_id: String, [INFO] [stdout] ... | [INFO] [stdout] 133 | | email_confirmed_at: Option, [INFO] [stdout] 134 | | ) -> Result, Response> { [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 142 | .bind(&user_uuid) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:157:11 [INFO] [stdout] | [INFO] [stdout] 157 | .bind(&user_uuid) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:158:11 [INFO] [stdout] | [INFO] [stdout] 158 | .bind(&session_id) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:291:19 [INFO] [stdout] | [INFO] [stdout] 291 | .bind(&session_id) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:301:15 [INFO] [stdout] | [INFO] [stdout] 301 | .bind(&r_id) [INFO] [stdout] | ^^^^^ help: change this to: `r_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/parser/filter.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | Ok((rem, f)) if rem.is_empty() => Ok(f), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 - Ok((rem, f)) if rem.is_empty() => Ok(f), [INFO] [stdout] 46 + Ok(("", f)) => Ok(f), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:313:11 [INFO] [stdout] | [INFO] [stdout] 313 | .bind(&user_id) [INFO] [stdout] | ^^^^^^^^ help: change this to: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:314:11 [INFO] [stdout] | [INFO] [stdout] 314 | .bind(&session_id) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/filter.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 141 | if !has_dot.is_some() && (matches!(op, Operator::Is | Operator::IsNot)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `has_dot.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:444:11 [INFO] [stdout] | [INFO] [stdout] 444 | .bind(&row_id.to_string()) // Identities string ID [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `row_id.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:445:11 [INFO] [stdout] | [INFO] [stdout] 445 | .bind(&row_id) [INFO] [stdout] | ^^^^^^^ help: change this to: `row_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api/auth.rs:472:9 [INFO] [stdout] | [INFO] [stdout] 472 | &token, [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:499:15 [INFO] [stdout] | [INFO] [stdout] 499 | .bind(&session_uuid) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `session_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:529:11 [INFO] [stdout] | [INFO] [stdout] 529 | .bind(&user_uuid) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/api/auth.rs:592:11 [INFO] [stdout] | [INFO] [stdout] 592 | .bind(&user_uuid) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `user_uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/api/storage.rs:114:47 [INFO] [stdout] | [INFO] [stdout] 114 | fn sanitize_path(bucket: &str, path: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/sql/builder.rs:212:36 [INFO] [stdout] | [INFO] [stdout] 212 | ins.columns(columns.iter().map(|c| Alias::new(c))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Alias::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/cli/start.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | let child = std::process::Command::new(&exe) [INFO] [stdout] | _________________^ [INFO] [stdout] 57 | | .args(["start", "--daemon-child"]) [INFO] [stdout] 58 | | .stdin(std::process::Stdio::null()) [INFO] [stdout] 59 | | .stdout(std::process::Stdio::null()) [INFO] [stdout] 60 | | .stderr(std::process::Stdio::null()) [INFO] [stdout] 61 | | .spawn() [INFO] [stdout] 62 | | .expect("Failed to spawn daemon child"); [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/parser/filter.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | Ok((rem, f)) if rem.is_empty() => Ok(f), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 - Ok((rem, f)) if rem.is_empty() => Ok(f), [INFO] [stdout] 46 + Ok(("", f)) => Ok(f), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/filter.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 141 | if !has_dot.is_some() && (matches!(op, Operator::Is | Operator::IsNot)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `has_dot.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/parser/filter.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | assert_eq!(c.negated, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 174 - assert_eq!(c.negated, false); [INFO] [stdout] 174 + assert!(!c.negated); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/parser/filter.rs:187:13 [INFO] [stdout] | [INFO] [stdout] 187 | assert_eq!(c.negated, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 187 - assert_eq!(c.negated, true); [INFO] [stdout] 187 + assert!(c.negated); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/sql/builder.rs:212:36 [INFO] [stdout] | [INFO] [stdout] 212 | ins.columns(columns.iter().map(|c| Alias::new(c))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Alias::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/cli/start.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | let child = std::process::Command::new(&exe) [INFO] [stdout] | _________________^ [INFO] [stdout] 57 | | .args(["start", "--daemon-child"]) [INFO] [stdout] 58 | | .stdin(std::process::Stdio::null()) [INFO] [stdout] 59 | | .stdout(std::process::Stdio::null()) [INFO] [stdout] 60 | | .stderr(std::process::Stdio::null()) [INFO] [stdout] 61 | | .spawn() [INFO] [stdout] 62 | | .expect("Failed to spawn daemon child"); [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.87s [INFO] running `Command { std: "docker" "inspect" "a996a98ee6927e1f6ee4f17c22c6d12a90518c30a44de1e4fd4f1179f303c0f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a996a98ee6927e1f6ee4f17c22c6d12a90518c30a44de1e4fd4f1179f303c0f6", kill_on_drop: false }` [INFO] [stdout] a996a98ee6927e1f6ee4f17c22c6d12a90518c30a44de1e4fd4f1179f303c0f6