[INFO] cloning repository https://github.com/brady-stacks/thicket [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brady-stacks/thicket" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrady-stacks%2Fthicket", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrady-stacks%2Fthicket'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9795116d5dcb9fa3fea3544fdb66568c8c3325da [INFO] linting brady-stacks/thicket against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrady-stacks%2Fthicket" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/brady-stacks/thicket [INFO] finished tweaking git repo https://github.com/brady-stacks/thicket [INFO] tweaked toml for git repo https://github.com/brady-stacks/thicket written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/brady-stacks/thicket on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/brady-stacks/thicket already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/stacks-network/stacks-core.git` [INFO] [stderr] Updating git repository `https://github.com/stx-labs/clarinet` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libsecp256k1-gen-genmult v0.3.0 [INFO] [stderr] Downloaded ripemd v0.1.3 [INFO] [stderr] Downloaded term v1.2.1 [INFO] [stderr] Downloaded servo_arc v0.3.0 [INFO] [stderr] Downloaded serdect v0.2.0 [INFO] [stderr] Downloaded sha2-asm v0.6.4 [INFO] [stderr] Downloaded slog-term v2.9.2 [INFO] [stderr] Downloaded serde_stacker v0.1.14 [INFO] [stderr] Downloaded libsecp256k1-gen-ecmult v0.3.0 [INFO] [stderr] Downloaded ego-tree v0.6.3 [INFO] [stderr] Downloaded scraper v0.19.1 [INFO] [stderr] Downloaded libsecp256k1 v0.7.2 [INFO] [stderr] Downloaded markup5ever v0.12.1 [INFO] [stderr] Downloaded libsecp256k1-core v0.3.0 [INFO] [stderr] Downloaded cssparser v0.31.2 [INFO] [stderr] Downloaded html5ever v0.27.0 [INFO] [stderr] Downloaded selectors v0.25.0 [INFO] [stderr] Downloaded ed25519-dalek v2.2.0 [INFO] [stderr] Downloaded slog v2.8.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e744caa4cd354c5f74f09089f25c485c273e8a6ae8d08fde4116779147a9caf5 [INFO] running `Command { std: "docker" "start" "-a" "e744caa4cd354c5f74f09089f25c485c273e8a6ae8d08fde4116779147a9caf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e744caa4cd354c5f74f09089f25c485c273e8a6ae8d08fde4116779147a9caf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e744caa4cd354c5f74f09089f25c485c273e8a6ae8d08fde4116779147a9caf5", kill_on_drop: false }` [INFO] [stdout] e744caa4cd354c5f74f09089f25c485c273e8a6ae8d08fde4116779147a9caf5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 455b91618b167fe66778ea91a2fac9435e094f5694e33b7573d87e41059dfd94 [INFO] running `Command { std: "docker" "start" "-a" "455b91618b167fe66778ea91a2fac9435e094f5694e33b7573d87e41059dfd94", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.37 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling sha2-asm v0.6.4 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling slog v2.8.2 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling time-macros v0.2.26 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling stacks-common v0.0.1 (https://github.com/stacks-network/stacks-core.git?rev=41bd9d0a15a08d8ab2603edf11774b0d21a616ec#41bd9d0a) [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking time v0.3.46 [INFO] [stderr] Compiling ar_archive_writer v0.5.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Compiling stacker v0.1.22 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking term v1.2.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling psm v0.1.29 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking ripemd v0.1.3 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking dtoa v1.0.11 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Checking serdect v0.2.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking slog-term v2.9.2 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Checking serde_stacker v0.1.14 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking integer-sqrt v0.1.5 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking getopts v0.2.24 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Checking ego-tree v0.6.3 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking scraper v0.19.1 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking clarity-types v0.0.1 (https://github.com/stacks-network/stacks-core.git?rev=41bd9d0a15a08d8ab2603edf11774b0d21a616ec#41bd9d0a) [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking clarity v0.0.1 (https://github.com/stacks-network/stacks-core.git?rev=41bd9d0a15a08d8ab2603edf11774b0d21a616ec#41bd9d0a) [INFO] [stderr] Checking clarity-static-cost v3.14.1 (https://github.com/stx-labs/clarinet?rev=59653687be1007ca10e079bb5485cec970a5dc59#59653687) [INFO] [stderr] Checking thicket v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/contract_processor.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/contract_processor.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/contract_processor.rs:189:45 [INFO] [stdout] | [INFO] [stdout] 189 | return Ok(clean_source_code(&trimmed)); [INFO] [stdout] | ^^^^^^^^ help: change this to: `trimmed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | / if let Some(contract_call) = json.get("contract_call") { [INFO] [stdout] 262 | | if let Some(contract_id) = contract_call.get("contract_id") { [INFO] [stdout] 263 | | if let Some(contract_id_str) = contract_id.as_str() { [INFO] [stdout] ... | [INFO] [stdout] 286 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 261 ~ if let Some(contract_call) = json.get("contract_call") [INFO] [stdout] 262 ~ && let Some(contract_id) = contract_call.get("contract_id") { [INFO] [stdout] 263 | if let Some(contract_id_str) = contract_id.as_str() { [INFO] [stdout] ... [INFO] [stdout] 284 | } [INFO] [stdout] 285 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:262:17 [INFO] [stdout] | [INFO] [stdout] 262 | / if let Some(contract_id) = contract_call.get("contract_id") { [INFO] [stdout] 263 | | if let Some(contract_id_str) = contract_id.as_str() { [INFO] [stdout] 264 | | // Format: SP3Q...9HYGY.options-vault-v13 [INFO] [stdout] 265 | | if let Some(dot_pos) = contract_id_str.find('.') { [INFO] [stdout] ... | [INFO] [stdout] 285 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 262 ~ if let Some(contract_id) = contract_call.get("contract_id") [INFO] [stdout] 263 ~ && let Some(contract_id_str) = contract_id.as_str() { [INFO] [stdout] 264 | // Format: SP3Q...9HYGY.options-vault-v13 [INFO] [stdout] ... [INFO] [stdout] 283 | } [INFO] [stdout] 284 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | / if let Ok(json) = serde_json::from_str::(script_content) { [INFO] [stdout] 302 | | if let Some(source) = find_source_in_json(&json) { [INFO] [stdout] 303 | | return Some(source); [INFO] [stdout] 304 | | } [INFO] [stdout] 305 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 301 ~ if let Ok(json) = serde_json::from_str::(script_content) [INFO] [stdout] 302 ~ && let Some(source) = find_source_in_json(&json) { [INFO] [stdout] 303 | return Some(source); [INFO] [stdout] 304 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 310 | / if let Some(start) = script_content.find("define-public") { [INFO] [stdout] 311 | | if let Some(end) = script_content[start..].rfind(")") { [INFO] [stdout] 312 | | let code = &script_content[start..start + end + 1]; [INFO] [stdout] 313 | | if code.len() > 50 { [INFO] [stdout] ... | [INFO] [stdout] 318 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 310 ~ if let Some(start) = script_content.find("define-public") [INFO] [stdout] 311 ~ && let Some(end) = script_content[start..].rfind(")") { [INFO] [stdout] 312 | let code = &script_content[start..start + end + 1]; [INFO] [stdout] ... [INFO] [stdout] 316 | } [INFO] [stdout] 317 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:329:17 [INFO] [stdout] | [INFO] [stdout] 329 | / if key == "source" || key == "sourceCode" || key == "source_code" { [INFO] [stdout] 330 | | if let Some(s) = value.as_str() { [INFO] [stdout] 331 | | return Some(s.to_string()); [INFO] [stdout] 332 | | } [INFO] [stdout] 333 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 329 ~ if (key == "source" || key == "sourceCode" || key == "source_code") { [INFO] [stdout] 330 ~ && let Some(s) = value.as_str() { [INFO] [stdout] 331 | return Some(s.to_string()); [INFO] [stdout] 332 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/contract_processor.rs:451:8 [INFO] [stdout] | [INFO] [stdout] 451 | if !cost_map.get("block_limits").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cost_map.get("block_limits").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/contract_processor.rs:189:45 [INFO] [stdout] | [INFO] [stdout] 189 | return Ok(clean_source_code(&trimmed)); [INFO] [stdout] | ^^^^^^^^ help: change this to: `trimmed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | / if let Some(contract_call) = json.get("contract_call") { [INFO] [stdout] 262 | | if let Some(contract_id) = contract_call.get("contract_id") { [INFO] [stdout] 263 | | if let Some(contract_id_str) = contract_id.as_str() { [INFO] [stdout] ... | [INFO] [stdout] 286 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 261 ~ if let Some(contract_call) = json.get("contract_call") [INFO] [stdout] 262 ~ && let Some(contract_id) = contract_call.get("contract_id") { [INFO] [stdout] 263 | if let Some(contract_id_str) = contract_id.as_str() { [INFO] [stdout] ... [INFO] [stdout] 284 | } [INFO] [stdout] 285 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:262:17 [INFO] [stdout] | [INFO] [stdout] 262 | / if let Some(contract_id) = contract_call.get("contract_id") { [INFO] [stdout] 263 | | if let Some(contract_id_str) = contract_id.as_str() { [INFO] [stdout] 264 | | // Format: SP3Q...9HYGY.options-vault-v13 [INFO] [stdout] 265 | | if let Some(dot_pos) = contract_id_str.find('.') { [INFO] [stdout] ... | [INFO] [stdout] 285 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 262 ~ if let Some(contract_id) = contract_call.get("contract_id") [INFO] [stdout] 263 ~ && let Some(contract_id_str) = contract_id.as_str() { [INFO] [stdout] 264 | // Format: SP3Q...9HYGY.options-vault-v13 [INFO] [stdout] ... [INFO] [stdout] 283 | } [INFO] [stdout] 284 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | / if let Ok(json) = serde_json::from_str::(script_content) { [INFO] [stdout] 302 | | if let Some(source) = find_source_in_json(&json) { [INFO] [stdout] 303 | | return Some(source); [INFO] [stdout] 304 | | } [INFO] [stdout] 305 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 301 ~ if let Ok(json) = serde_json::from_str::(script_content) [INFO] [stdout] 302 ~ && let Some(source) = find_source_in_json(&json) { [INFO] [stdout] 303 | return Some(source); [INFO] [stdout] 304 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 310 | / if let Some(start) = script_content.find("define-public") { [INFO] [stdout] 311 | | if let Some(end) = script_content[start..].rfind(")") { [INFO] [stdout] 312 | | let code = &script_content[start..start + end + 1]; [INFO] [stdout] 313 | | if code.len() > 50 { [INFO] [stdout] ... | [INFO] [stdout] 318 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 310 ~ if let Some(start) = script_content.find("define-public") [INFO] [stdout] 311 ~ && let Some(end) = script_content[start..].rfind(")") { [INFO] [stdout] 312 | let code = &script_content[start..start + end + 1]; [INFO] [stdout] ... [INFO] [stdout] 316 | } [INFO] [stdout] 317 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/contract_processor.rs:329:17 [INFO] [stdout] | [INFO] [stdout] 329 | / if key == "source" || key == "sourceCode" || key == "source_code" { [INFO] [stdout] 330 | | if let Some(s) = value.as_str() { [INFO] [stdout] 331 | | return Some(s.to_string()); [INFO] [stdout] 332 | | } [INFO] [stdout] 333 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 329 ~ if (key == "source" || key == "sourceCode" || key == "source_code") { [INFO] [stdout] 330 ~ && let Some(s) = value.as_str() { [INFO] [stdout] 331 | return Some(s.to_string()); [INFO] [stdout] 332 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/contract_processor.rs:451:8 [INFO] [stdout] | [INFO] [stdout] 451 | if !cost_map.get("block_limits").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cost_map.get("block_limits").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 10s [INFO] running `Command { std: "docker" "inspect" "455b91618b167fe66778ea91a2fac9435e094f5694e33b7573d87e41059dfd94", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "455b91618b167fe66778ea91a2fac9435e094f5694e33b7573d87e41059dfd94", kill_on_drop: false }` [INFO] [stdout] 455b91618b167fe66778ea91a2fac9435e094f5694e33b7573d87e41059dfd94