[INFO] cloning repository https://github.com/bpol9/rust_huffman [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bpol9/rust_huffman" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbpol9%2Frust_huffman", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbpol9%2Frust_huffman'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2efef9d84e969d27b1b14468556b9cee72897145 [INFO] linting bpol9/rust_huffman against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbpol9%2Frust_huffman" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bpol9/rust_huffman [INFO] finished tweaking git repo https://github.com/bpol9/rust_huffman [INFO] tweaked toml for git repo https://github.com/bpol9/rust_huffman written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bpol9/rust_huffman on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bpol9/rust_huffman already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c3b0ef1a38d9e9ef8598c162df9511ac43fc1477abad64757681f938d6fbab8f [INFO] running `Command { std: "docker" "start" "-a" "c3b0ef1a38d9e9ef8598c162df9511ac43fc1477abad64757681f938d6fbab8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c3b0ef1a38d9e9ef8598c162df9511ac43fc1477abad64757681f938d6fbab8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3b0ef1a38d9e9ef8598c162df9511ac43fc1477abad64757681f938d6fbab8f", kill_on_drop: false }` [INFO] [stdout] c3b0ef1a38d9e9ef8598c162df9511ac43fc1477abad64757681f938d6fbab8f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 888e68791326e02da8d22b07fc47c9f1ae15e70a5e4204aa603e9fb49778da70 [INFO] running `Command { std: "docker" "start" "-a" "888e68791326e02da8d22b07fc47c9f1ae15e70a5e4204aa603e9fb49778da70", kill_on_drop: false }` [INFO] [stderr] Checking huffman_code v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `HuffmanEncoding` is never constructed [INFO] [stdout] --> src/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct HuffmanEncoding { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HuffmanNode` is never constructed [INFO] [stdout] --> src/main.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | struct HuffmanNode { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HuffmanUnitCode` is never constructed [INFO] [stdout] --> src/main.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | struct HuffmanUnitCode { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/main.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl HuffmanEncoding { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] 24 | [INFO] [stdout] 25 | fn add_value(&mut self, value: u64, number_of_bits: u64) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | fn encode(&mut self, text: &String) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | fn get_huffman_encoding(&self, text: &String) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | fn get_encoding_from_huffman_tree(&self, tree: Rc) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | fn dfs_huffman_tree(&self, node: Rc, curr_unit_code: HuffmanUnitCode, result: &mut HashMap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | fn construct_huffman_tree(&self, text: &String) -> Rc { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | fn compute_frequencies(&self, text: &String) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | fn get_huffman_leaves(&self, text: &String) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | fn decode(&self) -> String { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 177 | fn reverse_encoding_map(&self, map: &HashMap) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_bit_zero`, `add_bit_one`, and `add_msb` are never used [INFO] [stdout] --> src/main.rs:188:8 [INFO] [stdout] | [INFO] [stdout] 187 | impl HuffmanUnitCode { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] 188 | fn add_bit_zero(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 193 | fn add_bit_one(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 198 | fn add_msb(&mut self, bit: u64) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `take_smallest` is never used [INFO] [stdout] --> src/main.rs:208:4 [INFO] [stdout] | [INFO] [stdout] 208 | fn take_smallest(first: &mut Vec, second: &mut Vec) -> HuffmanNode { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `quick_sort` is never used [INFO] [stdout] --> src/main.rs:221:4 [INFO] [stdout] | [INFO] [stdout] 221 | fn quick_sort(v: &mut [T], f: &F) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `partition` is never used [INFO] [stdout] --> src/main.rs:232:4 [INFO] [stdout] | [INFO] [stdout] 232 | fn partition(v: &mut [T], f: &F) -> usize [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 59 | let encoding = self.get_encoding_from_huffman_tree(tree); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 60 | encoding [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 59 ~ [INFO] [stdout] 60 ~ self.get_encoding_from_huffman_tree(tree) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if !node.left.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `node.left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 87 | if !node.right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `node.right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:75:27 [INFO] [stdout] | [INFO] [stdout] 75 | result.insert(node.symbol.clone().unwrap(), curr_unit_code); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node.symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 102 | while leaves.len() > 0 || intermediate_nodes.len() > 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!leaves.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:117:41 [INFO] [stdout] | [INFO] [stdout] 117 | fn compute_frequencies(&self, text: &String) -> HashMap { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 117 - fn compute_frequencies(&self, text: &String) -> HashMap { [INFO] [stdout] 117 + fn compute_frequencies(&self, text: &str) -> HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | / match rev_map.get(&unit_code) { [INFO] [stdout] 163 | | Some(&c) => { [INFO] [stdout] 164 | | result.push(c); [INFO] [stdout] 165 | | unit_code.code = 0; [INFO] [stdout] ... | [INFO] [stdout] 168 | | None => () [INFO] [stdout] 169 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 162 ~ if let Some(&c) = rev_map.get(&unit_code) { [INFO] [stdout] 163 + result.push(c); [INFO] [stdout] 164 + unit_code.code = 0; [INFO] [stdout] 165 + unit_code.number_of_bits = 0; [INFO] [stdout] 166 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `HuffmanUnitCode` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:180:27 [INFO] [stdout] | [INFO] [stdout] 180 | result.insert(code.clone(), symbol.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:180:41 [INFO] [stdout] | [INFO] [stdout] 180 | result.insert(code.clone(), symbol.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | self.code = self.code << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.code <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | self.code = self.code & mask; // set the new msb to 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.code &= mask` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | self.code = self.code | msb; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.code |= msb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 59 | let encoding = self.get_encoding_from_huffman_tree(tree); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 60 | encoding [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 59 ~ [INFO] [stdout] 60 ~ self.get_encoding_from_huffman_tree(tree) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if !node.left.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `node.left.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 87 | if !node.right.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `node.right.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:75:27 [INFO] [stdout] | [INFO] [stdout] 75 | result.insert(node.symbol.clone().unwrap(), curr_unit_code); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node.symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 102 | while leaves.len() > 0 || intermediate_nodes.len() > 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!leaves.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:117:41 [INFO] [stdout] | [INFO] [stdout] 117 | fn compute_frequencies(&self, text: &String) -> HashMap { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 117 - fn compute_frequencies(&self, text: &String) -> HashMap { [INFO] [stdout] 117 + fn compute_frequencies(&self, text: &str) -> HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | / match rev_map.get(&unit_code) { [INFO] [stdout] 163 | | Some(&c) => { [INFO] [stdout] 164 | | result.push(c); [INFO] [stdout] 165 | | unit_code.code = 0; [INFO] [stdout] ... | [INFO] [stdout] 168 | | None => () [INFO] [stdout] 169 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 162 ~ if let Some(&c) = rev_map.get(&unit_code) { [INFO] [stdout] 163 + result.push(c); [INFO] [stdout] 164 + unit_code.code = 0; [INFO] [stdout] 165 + unit_code.number_of_bits = 0; [INFO] [stdout] 166 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `HuffmanUnitCode` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:180:27 [INFO] [stdout] | [INFO] [stdout] 180 | result.insert(code.clone(), symbol.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:180:41 [INFO] [stdout] | [INFO] [stdout] 180 | result.insert(code.clone(), symbol.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*symbol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | self.code = self.code << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.code <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | self.code = self.code & mask; // set the new msb to 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.code &= mask` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | self.code = self.code | msb; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.code |= msb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `enc.data.get(0)` [INFO] [stdout] --> src/main.rs:359:20 [INFO] [stdout] | [INFO] [stdout] 359 | assert_eq!(enc.data.get(0), Some(&3)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `enc.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `enc.data.get(0)` [INFO] [stdout] --> src/main.rs:362:20 [INFO] [stdout] | [INFO] [stdout] 362 | assert_eq!(enc.data.get(0), Some(&7)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `enc.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `enc.data.get(0)` [INFO] [stdout] --> src/main.rs:367:20 [INFO] [stdout] | [INFO] [stdout] 367 | assert_eq!(enc.data.get(0), Some(&expected)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `enc.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `enc.data.get(0)` [INFO] [stdout] --> src/main.rs:370:20 [INFO] [stdout] | [INFO] [stdout] 370 | assert_eq!(enc.data.get(0), Some(&expected)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `enc.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "888e68791326e02da8d22b07fc47c9f1ae15e70a5e4204aa603e9fb49778da70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "888e68791326e02da8d22b07fc47c9f1ae15e70a5e4204aa603e9fb49778da70", kill_on_drop: false }` [INFO] [stdout] 888e68791326e02da8d22b07fc47c9f1ae15e70a5e4204aa603e9fb49778da70