[INFO] cloning repository https://github.com/bpinaya/fizzy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bpinaya/fizzy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbpinaya%2Ffizzy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbpinaya%2Ffizzy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e98a957e4c988bd93a2dc52230f74d5962cb51b3 [INFO] linting bpinaya/fizzy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbpinaya%2Ffizzy" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bpinaya/fizzy [INFO] finished tweaking git repo https://github.com/bpinaya/fizzy [INFO] tweaked toml for git repo https://github.com/bpinaya/fizzy written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bpinaya/fizzy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bpinaya/fizzy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libredox v0.1.11 [INFO] [stderr] Downloaded r2d2_sqlite v0.25.0 [INFO] [stderr] Downloaded comfy-table v7.1.3 [INFO] [stderr] Downloaded bindgen_cuda v0.1.5 [INFO] [stderr] Downloaded candle-kernels v0.7.2 [INFO] [stderr] Downloaded candle-nn v0.7.2 [INFO] [stderr] Downloaded candle-metal-kernels v0.7.2 [INFO] [stderr] Downloaded fast_image_resize v3.0.4 [INFO] [stderr] Downloaded candle-core v0.7.2 [INFO] [stderr] Downloaded candle-transformers v0.7.2 [INFO] [stderr] Downloaded cudarc v0.12.1 [INFO] [stderr] Downloaded openssl-src v300.5.4+3.5.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 170ea4120dd6621a0e88fe703b377d7af47b12057b317d006eb709f352eb4c2a [INFO] running `Command { std: "docker" "start" "-a" "170ea4120dd6621a0e88fe703b377d7af47b12057b317d006eb709f352eb4c2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "170ea4120dd6621a0e88fe703b377d7af47b12057b317d006eb709f352eb4c2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "170ea4120dd6621a0e88fe703b377d7af47b12057b317d006eb709f352eb4c2a", kill_on_drop: false }` [INFO] [stdout] 170ea4120dd6621a0e88fe703b377d7af47b12057b317d006eb709f352eb4c2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16383b289d32a38031ab2a724344c196eb206d7c38ce4b4687be256563c14984 [INFO] running `Command { std: "docker" "start" "-a" "16383b289d32a38031ab2a724344c196eb206d7c38ce4b4687be256563c14984", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Checking num-traits v0.2.19 [INFO] [stderr] Checking reborrow v0.5.5 [INFO] [stderr] Checking raw-cpuid v10.7.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling winnow v0.6.26 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Compiling zip v1.1.4 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Checking webpki-roots v1.0.4 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Compiling openssl-src v300.5.4+3.5.4 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling macro_rules_attribute-proc_macro v0.2.2 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Compiling onig_sys v69.9.1 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Compiling esaxx-rs v0.1.10 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking rayon-cond v0.3.0 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking macro_rules_attribute v0.2.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking unicode-normalization-alignments v0.1.12 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking onig v6.5.1 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling num_enum_derive v0.7.5 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling monostate-impl v0.1.18 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking monostate v0.1.18 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking dyn-stack v0.10.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking num_enum v0.7.5 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking pulp v0.18.22 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking fast_image_resize v3.0.4 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking comfy-table v7.1.3 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking safetensors v0.4.5 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_plain v1.0.2 [INFO] [stderr] Checking spm_precompiled v0.1.4 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking gemm-common v0.17.1 [INFO] [stderr] Checking gemm-f32 v0.17.1 [INFO] [stderr] Checking gemm-c32 v0.17.1 [INFO] [stderr] Checking gemm-f64 v0.17.1 [INFO] [stderr] Checking gemm-c64 v0.17.1 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking tokenizers v0.19.1 [INFO] [stderr] Checking gemm-f16 v0.17.1 [INFO] [stderr] Checking gemm v0.17.1 [INFO] [stderr] Checking candle-core v0.7.2 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking candle-nn v0.7.2 [INFO] [stderr] Checking candle-transformers v0.7.2 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking r2d2_sqlite v0.25.0 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.26 [INFO] [stderr] Checking hf-hub v0.4.3 [INFO] [stderr] Checking fizzy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/model.rs:258:5 [INFO] [stdout] | [INFO] [stdout] 258 | / /// Runs batch inference on a stack of image tensors. [INFO] [stdout] 259 | | [INFO] [stdout] | |_^ [INFO] [stdout] 260 | /// Runs batch inference on a stack of image tensors. [INFO] [stdout] 261 | pub fn get_image_embeddings_batch(&self, batch: &Tensor) -> Result>> { [INFO] [stdout] | --------------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 259 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/model.rs:258:5 [INFO] [stdout] | [INFO] [stdout] 258 | / /// Runs batch inference on a stack of image tensors. [INFO] [stdout] 259 | | [INFO] [stdout] | |_^ [INFO] [stdout] 260 | /// Runs batch inference on a stack of image tensors. [INFO] [stdout] 261 | pub fn get_image_embeddings_batch(&self, batch: &Tensor) -> Result>> { [INFO] [stdout] | --------------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 259 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/db.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | / for id_res in ids { [INFO] [stdout] 134 | | if let Ok(id) = id_res { [INFO] [stdout] 135 | | let path = PathBuf::from(&id); [INFO] [stdout] 136 | | if let Some(parent) = path.parent() { [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/db.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | / if let Ok(id) = id_res { [INFO] [stdout] 135 | | let path = PathBuf::from(&id); [INFO] [stdout] 136 | | if let Some(parent) = path.parent() { [INFO] [stdout] 137 | | let parent_str = parent.to_string_lossy().to_string(); [INFO] [stdout] ... | [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 133 ~ for id in ids.flatten() { [INFO] [stdout] 134 + let path = PathBuf::from(&id); [INFO] [stdout] 135 + if let Some(parent) = path.parent() { [INFO] [stdout] 136 + let parent_str = parent.to_string_lossy().to_string(); [INFO] [stdout] 137 + *counts.entry(parent_str).or_insert(0) += 1; [INFO] [stdout] 138 + } [INFO] [stdout] 139 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/db.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | / for row in rows { [INFO] [stdout] 165 | | if let Ok((id, mtime)) = row { [INFO] [stdout] 166 | | files.insert(id, mtime); [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/db.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 165 | / if let Ok((id, mtime)) = row { [INFO] [stdout] 166 | | files.insert(id, mtime); [INFO] [stdout] 167 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 164 ~ for (id, mtime) in rows.flatten() { [INFO] [stdout] 165 + files.insert(id, mtime); [INFO] [stdout] 166 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/index.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / for item in processed { [INFO] [stdout] 144 | | if let Some((vec, id, mtime)) = item { [INFO] [stdout] 145 | | ids.push(id); [INFO] [stdout] 146 | | vectors.push(vec); [INFO] [stdout] ... | [INFO] [stdout] 149 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/index.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | / if let Some((vec, id, mtime)) = item { [INFO] [stdout] 145 | | ids.push(id); [INFO] [stdout] 146 | | vectors.push(vec); [INFO] [stdout] 147 | | mtimes.push(mtime); [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 ~ for (vec, id, mtime) in processed.into_iter().flatten() { [INFO] [stdout] 144 + ids.push(id); [INFO] [stdout] 145 + vectors.push(vec); [INFO] [stdout] 146 + mtimes.push(mtime); [INFO] [stdout] 147 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/model.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | "clip" | _ => Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/model.rs:62:39 [INFO] [stdout] | [INFO] [stdout] 62 | std: vec![0.26862954, 0.26130258, 0.27577711], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 62 - std: vec![0.26862954, 0.26130258, 0.27577711], [INFO] [stdout] 62 + std: vec![0.26862954, 0.261_302_6, 0.27577711], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/model.rs:62:51 [INFO] [stdout] | [INFO] [stdout] 62 | std: vec![0.26862954, 0.26130258, 0.27577711], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 62 - std: vec![0.26862954, 0.26130258, 0.27577711], [INFO] [stdout] 62 + std: vec![0.26862954, 0.26130258, 0.275_777_1], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/vector.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn normalize(v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 7 - pub fn normalize(v: &mut Vec) { [INFO] [stdout] 7 + pub fn normalize(v: &mut [f32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/vector.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn add_in_place(a: &mut Vec, b: &[f32]) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - pub fn add_in_place(a: &mut Vec, b: &[f32]) { [INFO] [stdout] 17 + pub fn add_in_place(a: &mut [f32], b: &[f32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/config.rs:50:1 [INFO] [stdout] | [INFO] [stdout] 50 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | impl Default for Config { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/db.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | / for id_res in ids { [INFO] [stdout] 134 | | if let Ok(id) = id_res { [INFO] [stdout] 135 | | let path = PathBuf::from(&id); [INFO] [stdout] 136 | | if let Some(parent) = path.parent() { [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/db.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | / if let Ok(id) = id_res { [INFO] [stdout] 135 | | let path = PathBuf::from(&id); [INFO] [stdout] 136 | | if let Some(parent) = path.parent() { [INFO] [stdout] 137 | | let parent_str = parent.to_string_lossy().to_string(); [INFO] [stdout] ... | [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 133 ~ for id in ids.flatten() { [INFO] [stdout] 134 + let path = PathBuf::from(&id); [INFO] [stdout] 135 + if let Some(parent) = path.parent() { [INFO] [stdout] 136 + let parent_str = parent.to_string_lossy().to_string(); [INFO] [stdout] 137 + *counts.entry(parent_str).or_insert(0) += 1; [INFO] [stdout] 138 + } [INFO] [stdout] 139 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/db.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | / for row in rows { [INFO] [stdout] 165 | | if let Ok((id, mtime)) = row { [INFO] [stdout] 166 | | files.insert(id, mtime); [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/db.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 165 | / if let Ok((id, mtime)) = row { [INFO] [stdout] 166 | | files.insert(id, mtime); [INFO] [stdout] 167 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 164 ~ for (id, mtime) in rows.flatten() { [INFO] [stdout] 165 + files.insert(id, mtime); [INFO] [stdout] 166 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/index.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / for item in processed { [INFO] [stdout] 144 | | if let Some((vec, id, mtime)) = item { [INFO] [stdout] 145 | | ids.push(id); [INFO] [stdout] 146 | | vectors.push(vec); [INFO] [stdout] ... | [INFO] [stdout] 149 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/index.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | / if let Some((vec, id, mtime)) = item { [INFO] [stdout] 145 | | ids.push(id); [INFO] [stdout] 146 | | vectors.push(vec); [INFO] [stdout] 147 | | mtimes.push(mtime); [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 ~ for (vec, id, mtime) in processed.into_iter().flatten() { [INFO] [stdout] 144 + ids.push(id); [INFO] [stdout] 145 + vectors.push(vec); [INFO] [stdout] 146 + mtimes.push(mtime); [INFO] [stdout] 147 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/model.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | "clip" | _ => Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/model.rs:62:39 [INFO] [stdout] | [INFO] [stdout] 62 | std: vec![0.26862954, 0.26130258, 0.27577711], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 62 - std: vec![0.26862954, 0.26130258, 0.27577711], [INFO] [stdout] 62 + std: vec![0.26862954, 0.261_302_6, 0.27577711], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/model.rs:62:51 [INFO] [stdout] | [INFO] [stdout] 62 | std: vec![0.26862954, 0.26130258, 0.27577711], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 62 - std: vec![0.26862954, 0.26130258, 0.27577711], [INFO] [stdout] 62 + std: vec![0.26862954, 0.26130258, 0.275_777_1], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/vector.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn normalize(v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 7 - pub fn normalize(v: &mut Vec) { [INFO] [stdout] 7 + pub fn normalize(v: &mut [f32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/vector.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn add_in_place(a: &mut Vec, b: &[f32]) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - pub fn add_in_place(a: &mut Vec, b: &[f32]) { [INFO] [stdout] 17 + pub fn add_in_place(a: &mut [f32], b: &[f32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/index_tests.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | assert!(!(500 > *db_mtime)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(500 <= *db_mtime)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 17s [INFO] running `Command { std: "docker" "inspect" "16383b289d32a38031ab2a724344c196eb206d7c38ce4b4687be256563c14984", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16383b289d32a38031ab2a724344c196eb206d7c38ce4b4687be256563c14984", kill_on_drop: false }` [INFO] [stdout] 16383b289d32a38031ab2a724344c196eb206d7c38ce4b4687be256563c14984