[INFO] cloning repository https://github.com/born-in-autumn/Ferric-Trail [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/born-in-autumn/Ferric-Trail" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fborn-in-autumn%2FFerric-Trail", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fborn-in-autumn%2FFerric-Trail'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0653da7f4f8adbacab41c81d3a1a3612e929190f [INFO] linting born-in-autumn/Ferric-Trail against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fborn-in-autumn%2FFerric-Trail" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/born-in-autumn/Ferric-Trail [INFO] finished tweaking git repo https://github.com/born-in-autumn/Ferric-Trail [INFO] tweaked toml for git repo https://github.com/born-in-autumn/Ferric-Trail written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/born-in-autumn/Ferric-Trail on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/born-in-autumn/Ferric-Trail already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded normpath v1.3.0 [INFO] [stderr] Downloaded opener v0.8.2 [INFO] [stderr] Downloaded cc v1.2.34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58fa18841ccbaf41de208483e93546da179696d5d6d95b84cb697257c6bac468 [INFO] running `Command { std: "docker" "start" "-a" "58fa18841ccbaf41de208483e93546da179696d5d6d95b84cb697257c6bac468", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58fa18841ccbaf41de208483e93546da179696d5d6d95b84cb697257c6bac468", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58fa18841ccbaf41de208483e93546da179696d5d6d95b84cb697257c6bac468", kill_on_drop: false }` [INFO] [stdout] 58fa18841ccbaf41de208483e93546da179696d5d6d95b84cb697257c6bac468 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a418d8939b63122b71dd27229a3204c6553fe753c0d6bcac6803e6903377faad [INFO] running `Command { std: "docker" "start" "-a" "a418d8939b63122b71dd27229a3204c6553fe753c0d6bcac6803e6903377faad", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling owo-colors v4.2.2 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking bytecount v0.6.9 [INFO] [stderr] Checking testing_table v0.3.0 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking whoami v1.6.1 [INFO] [stderr] Checking clap_builder v4.5.46 [INFO] [stderr] Checking papergrid v0.17.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking opener v0.8.2 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.45 [INFO] [stderr] Compiling tabled_derive v0.11.0 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking tabled v0.20.0 [INFO] [stderr] Checking clap v4.5.46 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking oo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/core/file_list.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / for entry in read_dir { [INFO] [stdout] 54 | | if let Ok(file) = entry { [INFO] [stdout] 55 | | if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 56 | | data.push(FileEntry { [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/core/file_list.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if let Ok(file) = entry { [INFO] [stdout] 55 | | if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 56 | | data.push(FileEntry { [INFO] [stdout] 57 | | name: file.file_name().into_string().unwrap_or("unknown name".into()), [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 ~ for file in read_dir.flatten() { [INFO] [stdout] 54 + if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 55 + data.push(FileEntry { [INFO] [stdout] 56 + name: file.file_name().into_string().unwrap_or("unknown name".into()), [INFO] [stdout] 57 + len_bytes: meta.len(), [INFO] [stdout] 58 + e_type: if meta.is_file() { [INFO] [stdout] 59 + EntryType::File [INFO] [stdout] 60 + }else { [INFO] [stdout] 61 + EntryType::Dir [INFO] [stdout] 62 + }, [INFO] [stdout] 63 + modified: if let Ok(modi) = meta.modified() { [INFO] [stdout] 64 + let date: DateTime = modi.into(); [INFO] [stdout] 65 + format!("{}", date.format("%a %b %e %Y")) [INFO] [stdout] 66 + } else { [INFO] [stdout] 67 + String::default() [INFO] [stdout] 68 + } [INFO] [stdout] 69 + }); [INFO] [stdout] 70 + } [INFO] [stdout] 71 + [INFO] [stdout] 72 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/file_list.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if let Ok(file) = entry { [INFO] [stdout] 55 | | if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 56 | | data.push(FileEntry { [INFO] [stdout] 57 | | name: file.file_name().into_string().unwrap_or("unknown name".into()), [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if let Ok(file) = entry [INFO] [stdout] 55 ~ && let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 56 | data.push(FileEntry { [INFO] [stdout] ... [INFO] [stdout] 70 | }); [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/core/file_list.rs:55:48 [INFO] [stdout] | [INFO] [stdout] 55 | if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `file.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/core/file_list.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / for entry in read_dir { [INFO] [stdout] 54 | | if let Ok(file) = entry { [INFO] [stdout] 55 | | if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 56 | | data.push(FileEntry { [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/core/file_list.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if let Ok(file) = entry { [INFO] [stdout] 55 | | if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 56 | | data.push(FileEntry { [INFO] [stdout] 57 | | name: file.file_name().into_string().unwrap_or("unknown name".into()), [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 ~ for file in read_dir.flatten() { [INFO] [stdout] 54 + if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 55 + data.push(FileEntry { [INFO] [stdout] 56 + name: file.file_name().into_string().unwrap_or("unknown name".into()), [INFO] [stdout] 57 + len_bytes: meta.len(), [INFO] [stdout] 58 + e_type: if meta.is_file() { [INFO] [stdout] 59 + EntryType::File [INFO] [stdout] 60 + }else { [INFO] [stdout] 61 + EntryType::Dir [INFO] [stdout] 62 + }, [INFO] [stdout] 63 + modified: if let Ok(modi) = meta.modified() { [INFO] [stdout] 64 + let date: DateTime = modi.into(); [INFO] [stdout] 65 + format!("{}", date.format("%a %b %e %Y")) [INFO] [stdout] 66 + } else { [INFO] [stdout] 67 + String::default() [INFO] [stdout] 68 + } [INFO] [stdout] 69 + }); [INFO] [stdout] 70 + } [INFO] [stdout] 71 + [INFO] [stdout] 72 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/file_list.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if let Ok(file) = entry { [INFO] [stdout] 55 | | if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 56 | | data.push(FileEntry { [INFO] [stdout] 57 | | name: file.file_name().into_string().unwrap_or("unknown name".into()), [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if let Ok(file) = entry [INFO] [stdout] 55 ~ && let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] 56 | data.push(FileEntry { [INFO] [stdout] ... [INFO] [stdout] 70 | }); [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/core/file_list.rs:55:48 [INFO] [stdout] | [INFO] [stdout] 55 | if let Ok(meta) = fs::metadata(&file.path()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `file.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli/command.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if !alias.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `alias.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `alias` after checking its variant with `is_none` [INFO] [stdout] --> src/cli/command.rs:23:36 [INFO] [stdout] | [INFO] [stdout] 22 | if !alias.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 23 | save_alias(&name, &alias.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli/command.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if !alias.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `alias.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `alias` after checking its variant with `is_none` [INFO] [stdout] --> src/cli/command.rs:23:36 [INFO] [stdout] | [INFO] [stdout] 22 | if !alias.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 23 | save_alias(&name, &alias.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.68s [INFO] running `Command { std: "docker" "inspect" "a418d8939b63122b71dd27229a3204c6553fe753c0d6bcac6803e6903377faad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a418d8939b63122b71dd27229a3204c6553fe753c0d6bcac6803e6903377faad", kill_on_drop: false }` [INFO] [stdout] a418d8939b63122b71dd27229a3204c6553fe753c0d6bcac6803e6903377faad