[INFO] cloning repository https://github.com/bl0rk/rust_learning [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bl0rk/rust_learning" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbl0rk%2Frust_learning", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbl0rk%2Frust_learning'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3fdd98539f4c1f4c2302300e11a5f729495ac77f [INFO] linting bl0rk/rust_learning against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbl0rk%2Frust_learning" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bl0rk/rust_learning [INFO] finished tweaking git repo https://github.com/bl0rk/rust_learning [INFO] tweaked toml for git repo https://github.com/bl0rk/rust_learning written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bl0rk/rust_learning on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bl0rk/rust_learning already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2667ae88cf22bdcab1a61db43bd1de9d5c170490f64a533067a0c3ffcc8c0f21 [INFO] running `Command { std: "docker" "start" "-a" "2667ae88cf22bdcab1a61db43bd1de9d5c170490f64a533067a0c3ffcc8c0f21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2667ae88cf22bdcab1a61db43bd1de9d5c170490f64a533067a0c3ffcc8c0f21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2667ae88cf22bdcab1a61db43bd1de9d5c170490f64a533067a0c3ffcc8c0f21", kill_on_drop: false }` [INFO] [stdout] 2667ae88cf22bdcab1a61db43bd1de9d5c170490f64a533067a0c3ffcc8c0f21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01f2423687676aeecd4060a831e39c754cbf787249a646c0e49fe1556d516143 [INFO] running `Command { std: "docker" "start" "-a" "01f2423687676aeecd4060a831e39c754cbf787249a646c0e49fe1556d516143", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.142 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking general_testing v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/change_filetype.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 15 | match args.get(0) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/change_filetype.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | if !(format!(".{}", entry_path.extension().unwrap().to_str().unwrap()) == config.from) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(format!(".{}", entry_path.extension().unwrap().to_str().unwrap()) != config.from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/sorting_testing.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / for i in 0..spl.len() { [INFO] [stdout] 91 | | spl[i] = temp_vec[i].clone(); [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `spl.clone_from_slice(&temp_vec[..spl.len()]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/b_tree.rs:65:43 [INFO] [stdout] | [INFO] [stdout] 65 | if (*self.root).keys.len() == (self.order*2-1).into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(self.order*2-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/b_tree.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 90 | if root.keys.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `root.keys.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this binary expression can be simplified [INFO] [stdout] --> src/b_tree.rs:228:16 [INFO] [stdout] | [INFO] [stdout] 228 | if *k == key || *k > key { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `*k >= key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stdout] = note: `#[warn(clippy::double_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/b_tree.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | return idx; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return idx; [INFO] [stdout] 270 + idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/b_tree.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | return idx+1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 - return idx+1; [INFO] [stdout] 275 + idx+1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/b_tree.rs:282:13 [INFO] [stdout] | [INFO] [stdout] 282 | return idx; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 282 - return idx; [INFO] [stdout] 282 + idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `core::mem::swap` with a parameter derived from a raw pointer [INFO] [stdout] --> src/b_tree.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | std::mem::swap(&mut (*pred), &mut self.keys[idx]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use ptr::swap: `core::ptr::swap(pred, &mut self.keys[idx])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_ptr_to_ref [INFO] [stdout] = note: `#[warn(clippy::swap_ptr_to_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `core::mem::swap` with a parameter derived from a raw pointer [INFO] [stdout] --> src/b_tree.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | std::mem::swap(&mut (*succ), &mut self.keys[idx]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use ptr::swap: `core::ptr::swap(succ, &mut self.keys[idx])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_ptr_to_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/change_filetype.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 15 | match args.get(0) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/change_filetype.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | if !(format!(".{}", entry_path.extension().unwrap().to_str().unwrap()) == config.from) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(format!(".{}", entry_path.extension().unwrap().to_str().unwrap()) != config.from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/sorting_testing.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / for i in 0..spl.len() { [INFO] [stdout] 91 | | spl[i] = temp_vec[i].clone(); [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `spl.clone_from_slice(&temp_vec[..spl.len()]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/b_tree.rs:65:43 [INFO] [stdout] | [INFO] [stdout] 65 | if (*self.root).keys.len() == (self.order*2-1).into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(self.order*2-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/b_tree.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 90 | if root.keys.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `root.keys.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this binary expression can be simplified [INFO] [stdout] --> src/b_tree.rs:228:16 [INFO] [stdout] | [INFO] [stdout] 228 | if *k == key || *k > key { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `*k >= key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stdout] = note: `#[warn(clippy::double_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/b_tree.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | return idx; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return idx; [INFO] [stdout] 270 + idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/b_tree.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | return idx+1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 275 - return idx+1; [INFO] [stdout] 275 + idx+1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/b_tree.rs:282:13 [INFO] [stdout] | [INFO] [stdout] 282 | return idx; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 282 - return idx; [INFO] [stdout] 282 + idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `core::mem::swap` with a parameter derived from a raw pointer [INFO] [stdout] --> src/b_tree.rs:268:13 [INFO] [stdout] | [INFO] [stdout] 268 | std::mem::swap(&mut (*pred), &mut self.keys[idx]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use ptr::swap: `core::ptr::swap(pred, &mut self.keys[idx])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_ptr_to_ref [INFO] [stdout] = note: `#[warn(clippy::swap_ptr_to_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `core::mem::swap` with a parameter derived from a raw pointer [INFO] [stdout] --> src/b_tree.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | std::mem::swap(&mut (*succ), &mut self.keys[idx]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use ptr::swap: `core::ptr::swap(succ, &mut self.keys[idx])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_ptr_to_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.61s [INFO] running `Command { std: "docker" "inspect" "01f2423687676aeecd4060a831e39c754cbf787249a646c0e49fe1556d516143", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01f2423687676aeecd4060a831e39c754cbf787249a646c0e49fe1556d516143", kill_on_drop: false }` [INFO] [stdout] 01f2423687676aeecd4060a831e39c754cbf787249a646c0e49fe1556d516143