[INFO] cloning repository https://github.com/bjeanes/heroku-drain-datadog [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bjeanes/heroku-drain-datadog" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbjeanes%2Fheroku-drain-datadog", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbjeanes%2Fheroku-drain-datadog'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c07d238aa5e987449bf89e6ee9ae695b790ab1c2 [INFO] linting bjeanes/heroku-drain-datadog against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbjeanes%2Fheroku-drain-datadog" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bjeanes/heroku-drain-datadog [INFO] finished tweaking git repo https://github.com/bjeanes/heroku-drain-datadog [INFO] tweaked toml for git repo https://github.com/bjeanes/heroku-drain-datadog written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bjeanes/heroku-drain-datadog on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bjeanes/heroku-drain-datadog already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syslog_heroku v0.1.0 [INFO] [stderr] Downloaded term v0.5.1 [INFO] [stderr] Downloaded mime_guess v1.8.6 [INFO] [stderr] Downloaded stringreader v0.1.1 [INFO] [stderr] Downloaded gzip-header v0.2.0 [INFO] [stderr] Downloaded filetime v0.2.4 [INFO] [stderr] Downloaded tiny_http v0.6.1 [INFO] [stderr] Downloaded buf_redux v0.8.1 [INFO] [stderr] Downloaded rustc-demangle v0.1.11 [INFO] [stderr] Downloaded serde_json v1.0.33 [INFO] [stderr] Downloaded failure v0.1.3 [INFO] [stderr] Downloaded multipart v0.15.4 [INFO] [stderr] Downloaded failure_derive v0.1.3 [INFO] [stderr] Downloaded rouille v3.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0d8f437bea8c0edd1285549b7c98ae58cea9ef8fbb092c0efcde6b1609e251f [INFO] running `Command { std: "docker" "start" "-a" "f0d8f437bea8c0edd1285549b7c98ae58cea9ef8fbb092c0efcde6b1609e251f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0d8f437bea8c0edd1285549b7c98ae58cea9ef8fbb092c0efcde6b1609e251f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0d8f437bea8c0edd1285549b7c98ae58cea9ef8fbb092c0efcde6b1609e251f", kill_on_drop: false }` [INFO] [stdout] f0d8f437bea8c0edd1285549b7c98ae58cea9ef8fbb092c0efcde6b1609e251f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59c1fe7ac85da85470089a49322ebf9921d3b91c20c5b575a3e8f72b87821a7c [INFO] running `Command { std: "docker" "start" "-a" "59c1fe7ac85da85470089a49322ebf9921d3b91c20c5b575a3e8f72b87821a7c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Compiling rand_core v0.3.0 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Compiling autocfg v0.1.1 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Compiling memchr v2.1.2 [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Checking unicase v1.4.2 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Checking phf_shared v0.7.23 [INFO] [stderr] Compiling httparse v1.3.3 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking unicode-normalization v0.1.7 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Compiling rand_core v0.2.2 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking phf v0.7.23 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking remove_dir_all v0.5.1 [INFO] [stderr] Checking safemem v0.3.0 [INFO] [stderr] Checking rustc-demangle v0.1.11 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking gzip-header v0.2.0 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking chunked_transfer v0.3.1 [INFO] [stderr] Checking ascii v0.8.7 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Compiling syn v0.15.23 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking stringreader v0.1.1 [INFO] [stderr] Checking time v0.1.41 [INFO] [stderr] Compiling rand v0.5.5 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking num_cpus v1.9.0 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking buf_redux v0.8.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking tiny_http v0.6.1 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Checking multipart v0.15.4 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking syslog_heroku v0.1.0 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking rouille v3.0.0 [INFO] [stderr] Checking heroku-drain-datadog v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:102:28 [INFO] [stdout] | [INFO] [stdout] 102 | fn next_message(body: &mut BufRead) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 102 | fn next_message(body: &mut dyn BufRead) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | fn main() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | / router!(request, [INFO] [stdout] 15 | | (POST) (/logs/{app: String}) => { [INFO] [stdout] 16 | | handle_logs(&request, app) [INFO] [stdout] 17 | | }, [INFO] [stdout] ... | [INFO] [stdout] 21 | | }, [INFO] [stdout] 22 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | / router!(request, [INFO] [stdout] 15 | | (POST) (/logs/{app: String}) => { [INFO] [stdout] 16 | | handle_logs(&request, app) [INFO] [stdout] 17 | | }, [INFO] [stdout] ... | [INFO] [stdout] 21 | | }, [INFO] [stdout] 22 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] = note: this warning originates in the macro `router` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:16:33 [INFO] [stdout] | [INFO] [stdout] 16 | handle_logs(&request, app) [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:102:28 [INFO] [stdout] | [INFO] [stdout] 102 | fn next_message(body: &mut BufRead) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 102 | fn next_message(body: &mut dyn BufRead) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | / match body [INFO] [stdout] 63 | | .take(BODY_LIMIT.saturating_add(1) as u64) [INFO] [stdout] 64 | | .read_to_end(&mut out) [INFO] [stdout] ... | [INFO] [stdout] 67 | | _ => {} [INFO] [stdout] 68 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ if let Err(_) = body [INFO] [stdout] 63 + .take(BODY_LIMIT.saturating_add(1) as u64) [INFO] [stdout] 64 ~ .read_to_end(&mut out) { return internal_error() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:106:19 [INFO] [stdout] | [INFO] [stdout] 106 | Err(_) => return Err(ParseErr::FailedToReadMessageSize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - Err(_) => return Err(ParseErr::FailedToReadMessageSize), [INFO] [stdout] 106 + Err(_) => Err(ParseErr::FailedToReadMessageSize), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | _ => return Err(ParseErr::GenericError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 - _ => return Err(ParseErr::GenericError), [INFO] [stdout] 133 + _ => Err(ParseErr::GenericError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:135:26 [INFO] [stdout] | [INFO] [stdout] 135 | _ => return Err(ParseErr::GenericError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - _ => return Err(ParseErr::GenericError), [INFO] [stdout] 135 + _ => Err(ParseErr::GenericError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 137 | _ => return Err(ParseErr::GenericError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - _ => return Err(ParseErr::GenericError), [INFO] [stdout] 137 + _ => Err(ParseErr::GenericError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | fn main() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | / router!(request, [INFO] [stdout] 15 | | (POST) (/logs/{app: String}) => { [INFO] [stdout] 16 | | handle_logs(&request, app) [INFO] [stdout] 17 | | }, [INFO] [stdout] ... | [INFO] [stdout] 21 | | }, [INFO] [stdout] 22 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | / router!(request, [INFO] [stdout] 15 | | (POST) (/logs/{app: String}) => { [INFO] [stdout] 16 | | handle_logs(&request, app) [INFO] [stdout] 17 | | }, [INFO] [stdout] ... | [INFO] [stdout] 21 | | }, [INFO] [stdout] 22 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] = note: this warning originates in the macro `router` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:16:33 [INFO] [stdout] | [INFO] [stdout] 16 | handle_logs(&request, app) [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | / match body [INFO] [stdout] 63 | | .take(BODY_LIMIT.saturating_add(1) as u64) [INFO] [stdout] 64 | | .read_to_end(&mut out) [INFO] [stdout] ... | [INFO] [stdout] 67 | | _ => {} [INFO] [stdout] 68 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ if let Err(_) = body [INFO] [stdout] 63 + .take(BODY_LIMIT.saturating_add(1) as u64) [INFO] [stdout] 64 ~ .read_to_end(&mut out) { return internal_error() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:106:19 [INFO] [stdout] | [INFO] [stdout] 106 | Err(_) => return Err(ParseErr::FailedToReadMessageSize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - Err(_) => return Err(ParseErr::FailedToReadMessageSize), [INFO] [stdout] 106 + Err(_) => Err(ParseErr::FailedToReadMessageSize), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | _ => return Err(ParseErr::GenericError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 - _ => return Err(ParseErr::GenericError), [INFO] [stdout] 133 + _ => Err(ParseErr::GenericError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:135:26 [INFO] [stdout] | [INFO] [stdout] 135 | _ => return Err(ParseErr::GenericError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - _ => return Err(ParseErr::GenericError), [INFO] [stdout] 135 + _ => Err(ParseErr::GenericError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 137 | _ => return Err(ParseErr::GenericError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - _ => return Err(ParseErr::GenericError), [INFO] [stdout] 137 + _ => Err(ParseErr::GenericError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:160:17 [INFO] [stdout] | [INFO] [stdout] 160 | assert!(!msg3.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `msg3.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.58s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.1, multipart v0.15.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "59c1fe7ac85da85470089a49322ebf9921d3b91c20c5b575a3e8f72b87821a7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59c1fe7ac85da85470089a49322ebf9921d3b91c20c5b575a3e8f72b87821a7c", kill_on_drop: false }` [INFO] [stdout] 59c1fe7ac85da85470089a49322ebf9921d3b91c20c5b575a3e8f72b87821a7c