[INFO] cloning repository https://github.com/bivoje/hex-calculator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bivoje/hex-calculator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbivoje%2Fhex-calculator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbivoje%2Fhex-calculator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f9ee817c6cc105f8707a8a97f47608b9bdd01bf0 [INFO] linting bivoje/hex-calculator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbivoje%2Fhex-calculator" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bivoje/hex-calculator [INFO] finished tweaking git repo https://github.com/bivoje/hex-calculator [INFO] tweaked toml for git repo https://github.com/bivoje/hex-calculator written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bivoje/hex-calculator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bivoje/hex-calculator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8657f3895596320c75613ff940351f1eef531c8064ebe8bf77a2f29ee6097380 [INFO] running `Command { std: "docker" "start" "-a" "8657f3895596320c75613ff940351f1eef531c8064ebe8bf77a2f29ee6097380", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8657f3895596320c75613ff940351f1eef531c8064ebe8bf77a2f29ee6097380", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8657f3895596320c75613ff940351f1eef531c8064ebe8bf77a2f29ee6097380", kill_on_drop: false }` [INFO] [stdout] 8657f3895596320c75613ff940351f1eef531c8064ebe8bf77a2f29ee6097380 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e23458027a96e3b4e38d255f91f517b60679e6c353e736c8c31653cda681a282 [INFO] running `Command { std: "docker" "start" "-a" "e23458027a96e3b4e38d255f91f517b60679e6c353e736c8c31653cda681a282", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking hc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expr.rs:132:18 [INFO] [stdout] | [INFO] [stdout] 132 | let sign = ! cap.get(1).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `cap.get(1).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/expr.rs:338:32 [INFO] [stdout] | [INFO] [stdout] 338 | while v.last().map_or(false, |x| f(x)) { d.push(v.pop().unwrap()); } [INFO] [stdout] | ^^^^^^^^ help: replace the closure with the function itself: `&f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/expr.rs:338:9 [INFO] [stdout] | [INFO] [stdout] 338 | while v.last().map_or(false, |x| f(x)) { d.push(v.pop().unwrap()); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 338 - while v.last().map_or(false, |x| f(x)) { d.push(v.pop().unwrap()); } [INFO] [stdout] 338 + while v.last().is_some_and(|x| f(x)) { d.push(v.pop().unwrap()); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/expr.rs:591:5 [INFO] [stdout] | [INFO] [stdout] 591 | (Some(_), Some(_)) | _ => error_at(0, 0, NotEnoughOperator), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:68:35 [INFO] [stdout] | [INFO] [stdout] 68 | if succ.ok() == Some(0) { println!(""); break; } // at EOF, ctrl-D [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expr.rs:132:18 [INFO] [stdout] | [INFO] [stdout] 132 | let sign = ! cap.get(1).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `cap.get(1).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/expr.rs:338:32 [INFO] [stdout] | [INFO] [stdout] 338 | while v.last().map_or(false, |x| f(x)) { d.push(v.pop().unwrap()); } [INFO] [stdout] | ^^^^^^^^ help: replace the closure with the function itself: `&f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/expr.rs:338:9 [INFO] [stdout] | [INFO] [stdout] 338 | while v.last().map_or(false, |x| f(x)) { d.push(v.pop().unwrap()); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 338 - while v.last().map_or(false, |x| f(x)) { d.push(v.pop().unwrap()); } [INFO] [stdout] 338 + while v.last().is_some_and(|x| f(x)) { d.push(v.pop().unwrap()); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/expr.rs:591:5 [INFO] [stdout] | [INFO] [stdout] 591 | (Some(_), Some(_)) | _ => error_at(0, 0, NotEnoughOperator), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:68:35 [INFO] [stdout] | [INFO] [stdout] 68 | if succ.ok() == Some(0) { println!(""); break; } // at EOF, ctrl-D [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.78s [INFO] running `Command { std: "docker" "inspect" "e23458027a96e3b4e38d255f91f517b60679e6c353e736c8c31653cda681a282", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e23458027a96e3b4e38d255f91f517b60679e6c353e736c8c31653cda681a282", kill_on_drop: false }` [INFO] [stdout] e23458027a96e3b4e38d255f91f517b60679e6c353e736c8c31653cda681a282