[INFO] cloning repository https://github.com/bit-bots/bitbots_pathplanning_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bit-bots/bitbots_pathplanning_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbit-bots%2Fbitbots_pathplanning_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbit-bots%2Fbitbots_pathplanning_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9cd0669b6cd5709ba7d2b83b3fe816177340fbc0 [INFO] linting bit-bots/bitbots_pathplanning_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbit-bots%2Fbitbots_pathplanning_rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bit-bots/bitbots_pathplanning_rust [INFO] finished tweaking git repo https://github.com/bit-bots/bitbots_pathplanning_rust [INFO] tweaked toml for git repo https://github.com/bit-bots/bitbots_pathplanning_rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bit-bots/bitbots_pathplanning_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bit-bots/bitbots_pathplanning_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rstar v0.12.2 [INFO] [stderr] Downloaded i_key_sort v0.2.0 [INFO] [stderr] Downloaded pyo3-macros v0.24.2 [INFO] [stderr] Downloaded i_float v1.6.0 [INFO] [stderr] Downloaded i_shape v1.6.0 [INFO] [stderr] Downloaded pyo3-build-config v0.24.2 [INFO] [stderr] Downloaded pyo3-macros-backend v0.24.2 [INFO] [stderr] Downloaded i_tree v0.8.3 [INFO] [stderr] Downloaded webbrowser v1.0.5 [INFO] [stderr] Downloaded pyo3-ffi v0.24.2 [INFO] [stderr] Downloaded geographiclib-rs v0.2.5 [INFO] [stderr] Downloaded i_overlay v1.9.4 [INFO] [stderr] Downloaded geo v0.29.3 [INFO] [stderr] Downloaded robust v1.2.0 [INFO] [stderr] Downloaded spade v2.13.1 [INFO] [stderr] Downloaded earcutr v0.4.3 [INFO] [stderr] Downloaded pyo3 v0.24.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e40c28cda938383df0e563d5c5d63d8d2d2c1dbee354caec7523dda25392058 [INFO] running `Command { std: "docker" "start" "-a" "5e40c28cda938383df0e563d5c5d63d8d2d2c1dbee354caec7523dda25392058", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e40c28cda938383df0e563d5c5d63d8d2d2c1dbee354caec7523dda25392058", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e40c28cda938383df0e563d5c5d63d8d2d2c1dbee354caec7523dda25392058", kill_on_drop: false }` [INFO] [stdout] 5e40c28cda938383df0e563d5c5d63d8d2d2c1dbee354caec7523dda25392058 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7f861b83707d2241aa845516140efca92b2f0e5af19451dc0dd61c72c67b1ed [INFO] running `Command { std: "docker" "start" "-a" "f7f861b83707d2241aa845516140efca92b2f0e5af19451dc0dd61c72c67b1ed", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.13.2 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking i_key_sort v0.2.0 [INFO] [stderr] Checking robust v1.2.0 [INFO] [stderr] Checking i_tree v0.8.3 [INFO] [stderr] Checking heapless v0.8.0 [INFO] [stderr] Checking geographiclib-rs v0.2.5 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking unindent v0.2.4 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Compiling pyo3-build-config v0.24.2 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rstar v0.12.2 [INFO] [stderr] Checking spade v2.13.1 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Compiling syn v2.0.103 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking keyed_priority_queue v0.4.2 [INFO] [stderr] Compiling pyo3-ffi v0.24.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.24.2 [INFO] [stderr] Compiling pyo3 v0.24.2 [INFO] [stderr] Checking geo-types v0.7.16 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Compiling pyo3-macros v0.24.2 [INFO] [stderr] Checking i_float v1.6.0 [INFO] [stderr] Checking i_shape v1.6.0 [INFO] [stderr] Checking i_overlay v1.9.4 [INFO] [stderr] Checking geo v0.29.3 [INFO] [stderr] Checking bitbots_rust_nav v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/planner.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 101 | ... if (self.start == vertex && self.goal == successor) // Best effort backup solution, so we allow the direct connection at hi... [INFO] [stdout] | __________^ [INFO] [stdout] 102 | | ... // Also consider start and goal as inside the obstacle (at high cost if we are inside the critical area, and at low cos... [INFO] [stdout] 103 | | ... || (self.goal == successor && self.obstacle_with_margin.contains(&connection.end_point())) [INFO] [stdout] | |____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 101 - if (self.start == vertex && self.goal == successor) // Best effort backup solution, so we allow the direct connection at high cost [INFO] [stdout] 102 - // Also consider start and goal as inside the obstacle (at high cost if we are inside the critical area, and at low cost if we are inside the margin) [INFO] [stdout] 103 - || (self.goal == successor && self.obstacle_with_margin.contains(&connection.end_point())) [INFO] [stdout] 101 + if !(self.goal != successor || self.start != vertex && !self.obstacle_with_margin.contains(&connection.end_point())) [INFO] [stdout] | [INFO] [stdout] 101 - if (self.start == vertex && self.goal == successor) // Best effort backup solution, so we allow the direct connection at high cost [INFO] [stdout] 102 - // Also consider start and goal as inside the obstacle (at high cost if we are inside the critical area, and at low cost if we are inside the margin) [INFO] [stdout] 103 - || (self.goal == successor && self.obstacle_with_margin.contains(&connection.end_point())) [INFO] [stdout] 101 + if (self.obstacle_with_margin.contains(&connection.end_point()) || self.start == vertex) && self.goal == successor [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/planner.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 101 | ... if (self.start == vertex && self.goal == successor) // Best effort backup solution, so we allow the direct connection at hi... [INFO] [stdout] | __________^ [INFO] [stdout] 102 | | ... // Also consider start and goal as inside the obstacle (at high cost if we are inside the critical area, and at low cos... [INFO] [stdout] 103 | | ... || (self.goal == successor && self.obstacle_with_margin.contains(&connection.end_point())) [INFO] [stdout] | |____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 101 - if (self.start == vertex && self.goal == successor) // Best effort backup solution, so we allow the direct connection at high cost [INFO] [stdout] 102 - // Also consider start and goal as inside the obstacle (at high cost if we are inside the critical area, and at low cost if we are inside the margin) [INFO] [stdout] 103 - || (self.goal == successor && self.obstacle_with_margin.contains(&connection.end_point())) [INFO] [stdout] 101 + if !(self.goal != successor || self.start != vertex && !self.obstacle_with_margin.contains(&connection.end_point())) [INFO] [stdout] | [INFO] [stdout] 101 - if (self.start == vertex && self.goal == successor) // Best effort backup solution, so we allow the direct connection at high cost [INFO] [stdout] 102 - // Also consider start and goal as inside the obstacle (at high cost if we are inside the critical area, and at low cost if we are inside the margin) [INFO] [stdout] 103 - || (self.goal == successor && self.obstacle_with_margin.contains(&connection.end_point())) [INFO] [stdout] 101 + if (self.obstacle_with_margin.contains(&connection.end_point()) || self.start == vertex) && self.goal == successor [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.50s [INFO] running `Command { std: "docker" "inspect" "f7f861b83707d2241aa845516140efca92b2f0e5af19451dc0dd61c72c67b1ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7f861b83707d2241aa845516140efca92b2f0e5af19451dc0dd61c72c67b1ed", kill_on_drop: false }` [INFO] [stdout] f7f861b83707d2241aa845516140efca92b2f0e5af19451dc0dd61c72c67b1ed