[INFO] cloning repository https://github.com/binoyjayan/nqcc-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/binoyjayan/nqcc-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbinoyjayan%2Fnqcc-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbinoyjayan%2Fnqcc-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 549fa3a5f94d5e7c8dee13845cd63364090fc59c [INFO] linting binoyjayan/nqcc-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbinoyjayan%2Fnqcc-rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/binoyjayan/nqcc-rs [INFO] finished tweaking git repo https://github.com/binoyjayan/nqcc-rs [INFO] tweaked toml for git repo https://github.com/binoyjayan/nqcc-rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/binoyjayan/nqcc-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/binoyjayan/nqcc-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4b06014260d8b944a170d06033eb41343be90edffff77a131cdf1e4bfb85717 [INFO] running `Command { std: "docker" "start" "-a" "c4b06014260d8b944a170d06033eb41343be90edffff77a131cdf1e4bfb85717", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4b06014260d8b944a170d06033eb41343be90edffff77a131cdf1e4bfb85717", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4b06014260d8b944a170d06033eb41343be90edffff77a131cdf1e4bfb85717", kill_on_drop: false }` [INFO] [stdout] c4b06014260d8b944a170d06033eb41343be90edffff77a131cdf1e4bfb85717 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91a7d463accc24fc8f05a2df99effafe809496c385b6410f51e2f472289115b6 [INFO] running `Command { std: "docker" "start" "-a" "91a7d463accc24fc8f05a2df99effafe809496c385b6410f51e2f472289115b6", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking nqcc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scanner/mod.rs:115:35 [INFO] [stdout] | [INFO] [stdout] 115 | ... while !(self.peek() == '*' && self.peek_next() == '/') [INFO] [stdout] | _____________________________^ [INFO] [stdout] 116 | | ... && !self.is_at_end() [INFO] [stdout] | |______________________________________________^ help: try: `!(self.is_at_end() || self.peek() == '*' && self.peek_next() == '/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/scanner/mod.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | / if self.current - self.start > 1 { [INFO] [stdout] 206 | | match self.source[self.start + 1] { [INFO] [stdout] 207 | | 'n' => return self.check_keyword(2, 1, "t", TokenType::Int), [INFO] [stdout] 208 | | 'f' => return TokenType::If, [INFO] [stdout] ... | [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 204 ~ 'i' [INFO] [stdout] 205 ~ if self.current - self.start > 1 => { [INFO] [stdout] 206 | match self.source[self.start + 1] { [INFO] [stdout] ... [INFO] [stdout] 210 | } [INFO] [stdout] 211 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/scanner/mod.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | / if self.current - self.start > 1 { [INFO] [stdout] 215 | | match self.source[self.start + 1] { [INFO] [stdout] 216 | | 'o' => return self.check_keyword(2, 1, "r", TokenType::For), [INFO] [stdout] 217 | | _ => {} [INFO] [stdout] 218 | | } [INFO] [stdout] 219 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 213 ~ 'f' [INFO] [stdout] 214 ~ if self.current - self.start > 1 => { [INFO] [stdout] 215 | match self.source[self.start + 1] { [INFO] [stdout] ... [INFO] [stdout] 218 | } [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/scanner/mod.rs:215:21 [INFO] [stdout] | [INFO] [stdout] 215 | / match self.source[self.start + 1] { [INFO] [stdout] 216 | | 'o' => return self.check_keyword(2, 1, "r", TokenType::For), [INFO] [stdout] 217 | | _ => {} [INFO] [stdout] 218 | | } [INFO] [stdout] | |_____________________^ help: try: `if self.source[self.start + 1] == 'o' { return self.check_keyword(2, 1, "r", TokenType::For) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scanner/mod.rs:115:35 [INFO] [stdout] | [INFO] [stdout] 115 | ... while !(self.peek() == '*' && self.peek_next() == '/') [INFO] [stdout] | _____________________________^ [INFO] [stdout] 116 | | ... && !self.is_at_end() [INFO] [stdout] | |______________________________________________^ help: try: `!(self.is_at_end() || self.peek() == '*' && self.peek_next() == '/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/scanner/mod.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | / if self.current - self.start > 1 { [INFO] [stdout] 206 | | match self.source[self.start + 1] { [INFO] [stdout] 207 | | 'n' => return self.check_keyword(2, 1, "t", TokenType::Int), [INFO] [stdout] 208 | | 'f' => return TokenType::If, [INFO] [stdout] ... | [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 204 ~ 'i' [INFO] [stdout] 205 ~ if self.current - self.start > 1 => { [INFO] [stdout] 206 | match self.source[self.start + 1] { [INFO] [stdout] ... [INFO] [stdout] 210 | } [INFO] [stdout] 211 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/scanner/mod.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | / if self.current - self.start > 1 { [INFO] [stdout] 215 | | match self.source[self.start + 1] { [INFO] [stdout] 216 | | 'o' => return self.check_keyword(2, 1, "r", TokenType::For), [INFO] [stdout] 217 | | _ => {} [INFO] [stdout] 218 | | } [INFO] [stdout] 219 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 213 ~ 'f' [INFO] [stdout] 214 ~ if self.current - self.start > 1 => { [INFO] [stdout] 215 | match self.source[self.start + 1] { [INFO] [stdout] ... [INFO] [stdout] 218 | } [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/scanner/mod.rs:215:21 [INFO] [stdout] | [INFO] [stdout] 215 | / match self.source[self.start + 1] { [INFO] [stdout] 216 | | 'o' => return self.check_keyword(2, 1, "r", TokenType::For), [INFO] [stdout] 217 | | _ => {} [INFO] [stdout] 218 | | } [INFO] [stdout] | |_____________________^ help: try: `if self.source[self.start + 1] == 'o' { return self.check_keyword(2, 1, "r", TokenType::For) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.53s [INFO] running `Command { std: "docker" "inspect" "91a7d463accc24fc8f05a2df99effafe809496c385b6410f51e2f472289115b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91a7d463accc24fc8f05a2df99effafe809496c385b6410f51e2f472289115b6", kill_on_drop: false }` [INFO] [stdout] 91a7d463accc24fc8f05a2df99effafe809496c385b6410f51e2f472289115b6