[INFO] cloning repository https://github.com/billyvreeland/rusty-forest [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/billyvreeland/rusty-forest" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbillyvreeland%2Frusty-forest", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbillyvreeland%2Frusty-forest'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0a0fe53da300d3140300c3231d8e01c20c596b70 [INFO] linting billyvreeland/rusty-forest against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbillyvreeland%2Frusty-forest" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/billyvreeland/rusty-forest [INFO] finished tweaking git repo https://github.com/billyvreeland/rusty-forest [INFO] tweaked toml for git repo https://github.com/billyvreeland/rusty-forest written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/billyvreeland/rusty-forest on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/billyvreeland/rusty-forest already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ndarray-csv v0.4.1 [INFO] [stderr] Downloaded matrixmultiply v0.2.3 [INFO] [stderr] Downloaded ndarray v0.13.1 [INFO] [stderr] Downloaded bstr v0.2.13 [INFO] [stderr] Downloaded libc v0.2.72 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f154bd6ef92b5013c88811e97dc6c8fafde8d5eae2ad603b64a0b5c55bcaf0f0 [INFO] running `Command { std: "docker" "start" "-a" "f154bd6ef92b5013c88811e97dc6c8fafde8d5eae2ad603b64a0b5c55bcaf0f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f154bd6ef92b5013c88811e97dc6c8fafde8d5eae2ad603b64a0b5c55bcaf0f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f154bd6ef92b5013c88811e97dc6c8fafde8d5eae2ad603b64a0b5c55bcaf0f0", kill_on_drop: false }` [INFO] [stdout] f154bd6ef92b5013c88811e97dc6c8fafde8d5eae2ad603b64a0b5c55bcaf0f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4553adb1b3e54906831cc7c8f614aa409da8e5915f1752f9d9034ecf0741b07 [INFO] running `Command { std: "docker" "start" "-a" "d4553adb1b3e54906831cc7c8f614aa409da8e5915f1752f9d9034ecf0741b07", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling libc v0.2.72 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking ndarray-csv v0.4.1 [INFO] [stderr] Checking rusty-forest v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / /// [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | use std::error::Error; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Driver program to demonstrate usage of random forest [INFO] [stdout] 2 ~ //! [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/csv_io.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Helper functions for reading and writing csv files [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | use csv::{ReaderBuilder}; //, WriterBuilder}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Helper functions for reading and writing csv files [INFO] [stdout] 1 + //! Helper functions for reading and writing csv files [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/forest/tree.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | pred_val: pred_val, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pred_val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/forest/tree.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | split_val: split_val, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `split_val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / /// [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | use std::error::Error; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Driver program to demonstrate usage of random forest [INFO] [stdout] 2 ~ //! [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/csv_io.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Helper functions for reading and writing csv files [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | use csv::{ReaderBuilder}; //, WriterBuilder}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Helper functions for reading and writing csv files [INFO] [stdout] 1 + //! Helper functions for reading and writing csv files [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/forest/tree.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | pred_val: pred_val, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pred_val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/forest/tree.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | split_val: split_val, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `split_val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/forest/tree.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / if self.left.is_none() && self.right.is_none() { [INFO] [stdout] 42 | | true [INFO] [stdout] 43 | | } else { [INFO] [stdout] 44 | | false [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `self.left.is_none() && self.right.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx` is used as a loop counter [INFO] [stdout] --> src/forest/tree.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | for row in x.genrows() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx, row) in x.genrows().into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `best_split` after checking its variant with `is_none` [INFO] [stdout] --> src/forest/tree.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 82 | if best_split.is_none() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = best_split` [INFO] [stdout] ... [INFO] [stdout] 86 | let bs = best_split.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/forest/tree.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if !split_result.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `split_result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `split_result` after checking its variant with `is_none` [INFO] [stdout] --> src/forest/tree.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 104 | if !split_result.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 105 | let sr = split_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/forest/tree.rs:130:36 [INFO] [stdout] | [INFO] [stdout] 130 | let new_node = &*(current_node.left.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 130 - let new_node = &*(current_node.left.as_ref().unwrap()); [INFO] [stdout] 130 + let new_node = (current_node.left.as_ref().unwrap()); [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 130 | let new_node = &**(current_node.left.as_ref().unwrap()); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/forest/tree.rs:133:36 [INFO] [stdout] | [INFO] [stdout] 133 | let new_node = &*(current_node.right.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 133 - let new_node = &*(current_node.right.as_ref().unwrap()); [INFO] [stdout] 133 + let new_node = (current_node.right.as_ref().unwrap()); [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 133 | let new_node = &**(current_node.right.as_ref().unwrap()); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `row_idx` is used as a loop counter [INFO] [stdout] --> src/forest/tree.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | for row in x.genrows() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (row_idx, row) in x.genrows().into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/forest.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | preds = preds / self.n_trees as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preds /= self.n_trees as f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/forest/tree.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / if self.left.is_none() && self.right.is_none() { [INFO] [stdout] 42 | | true [INFO] [stdout] 43 | | } else { [INFO] [stdout] 44 | | false [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `self.left.is_none() && self.right.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx` is used as a loop counter [INFO] [stdout] --> src/forest/tree.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | for row in x.genrows() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx, row) in x.genrows().into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `best_split` after checking its variant with `is_none` [INFO] [stdout] --> src/forest/tree.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 82 | if best_split.is_none() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = best_split` [INFO] [stdout] ... [INFO] [stdout] 86 | let bs = best_split.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/forest/tree.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if !split_result.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `split_result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `split_result` after checking its variant with `is_none` [INFO] [stdout] --> src/forest/tree.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 104 | if !split_result.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 105 | let sr = split_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/forest/tree.rs:130:36 [INFO] [stdout] | [INFO] [stdout] 130 | let new_node = &*(current_node.left.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 130 - let new_node = &*(current_node.left.as_ref().unwrap()); [INFO] [stdout] 130 + let new_node = (current_node.left.as_ref().unwrap()); [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 130 | let new_node = &**(current_node.left.as_ref().unwrap()); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/forest/tree.rs:133:36 [INFO] [stdout] | [INFO] [stdout] 133 | let new_node = &*(current_node.right.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 133 - let new_node = &*(current_node.right.as_ref().unwrap()); [INFO] [stdout] 133 + let new_node = (current_node.right.as_ref().unwrap()); [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 133 | let new_node = &**(current_node.right.as_ref().unwrap()); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `row_idx` is used as a loop counter [INFO] [stdout] --> src/forest/tree.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | for row in x.genrows() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (row_idx, row) in x.genrows().into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/forest.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | preds = preds / self.n_trees as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preds /= self.n_trees as f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.79s [INFO] running `Command { std: "docker" "inspect" "d4553adb1b3e54906831cc7c8f614aa409da8e5915f1752f9d9034ecf0741b07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4553adb1b3e54906831cc7c8f614aa409da8e5915f1752f9d9034ecf0741b07", kill_on_drop: false }` [INFO] [stdout] d4553adb1b3e54906831cc7c8f614aa409da8e5915f1752f9d9034ecf0741b07