[INFO] cloning repository https://github.com/bigb4ng/retriever [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bigb4ng/retriever" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbigb4ng%2Fretriever", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbigb4ng%2Fretriever'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7a6d0fa36852058c77b730c94cacc59024413322 [INFO] linting bigb4ng/retriever against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbigb4ng%2Fretriever" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bigb4ng/retriever [INFO] finished tweaking git repo https://github.com/bigb4ng/retriever [INFO] tweaked toml for git repo https://github.com/bigb4ng/retriever written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bigb4ng/retriever on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bigb4ng/retriever already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded mockito v1.7.0 [INFO] [stderr] Downloaded windows-link v0.2.0 [INFO] [stderr] Downloaded unit-prefix v0.5.1 [INFO] [stderr] Downloaded console v0.16.1 [INFO] [stderr] Downloaded argh v0.1.13 [INFO] [stderr] Downloaded argh_shared v0.1.13 [INFO] [stderr] Downloaded argh_derive v0.1.13 [INFO] [stderr] Downloaded unicode-width v0.2.1 [INFO] [stderr] Downloaded indicatif v0.18.0 [INFO] [stderr] Downloaded rust-fuzzy-search v0.1.1 [INFO] [stderr] Downloaded windows-sys v0.61.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1775a7a1455aa2416cfd2f1b9fc9cb9994a60d92770277d7494bc63dadfb963 [INFO] running `Command { std: "docker" "start" "-a" "e1775a7a1455aa2416cfd2f1b9fc9cb9994a60d92770277d7494bc63dadfb963", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1775a7a1455aa2416cfd2f1b9fc9cb9994a60d92770277d7494bc63dadfb963", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1775a7a1455aa2416cfd2f1b9fc9cb9994a60d92770277d7494bc63dadfb963", kill_on_drop: false }` [INFO] [stdout] e1775a7a1455aa2416cfd2f1b9fc9cb9994a60d92770277d7494bc63dadfb963 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b16b492217f41944866d22e59dea8dca60b78ede37a3ac440ba2803efca01eb5 [INFO] running `Command { std: "docker" "start" "-a" "b16b492217f41944866d22e59dea8dca60b78ede37a3ac440ba2803efca01eb5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling find-msvc-tools v0.1.3 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling cc v1.2.40 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking unit-prefix v0.5.1 [INFO] [stderr] Compiling argh_shared v0.1.13 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking similar v2.7.0 [INFO] [stderr] Checking rust-fuzzy-search v0.1.1 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking console v0.16.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking indicatif v0.18.0 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling argh_derive v0.1.13 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking argh v0.1.13 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking mockito v1.7.0 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking file-retriever v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/lib.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | / let _ = retriever [INFO] [stdout] 251 | | .download_file(req, file) [INFO] [stdout] 252 | | .await [INFO] [stdout] 253 | | .expect("failed to download"); [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 250 - let _ = retriever [INFO] [stdout] 250 + retriever [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:317:21 [INFO] [stdout] | [INFO] [stdout] 317 | assert!(!download_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `download_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> examples/multi_download_example.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | let filename = url [INFO] [stdout] | ________________________________^ [INFO] [stdout] 62 | | .path_segments() [INFO] [stdout] 63 | | .expect("URL must have path segments") [INFO] [stdout] 64 | | .last() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 - .last() [INFO] [stdout] 64 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> examples/multi_download_example.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | / if let Err(e) = res { [INFO] [stdout] 92 | | eprintln!("{:?}", e) [INFO] [stdout] 93 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> examples/multi_download_example.rs:90:19 [INFO] [stdout] | [INFO] [stdout] 90 | if let Ok(res) = result { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 91 | if let Err(e) = res { [INFO] [stdout] | ^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.35s [INFO] running `Command { std: "docker" "inspect" "b16b492217f41944866d22e59dea8dca60b78ede37a3ac440ba2803efca01eb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b16b492217f41944866d22e59dea8dca60b78ede37a3ac440ba2803efca01eb5", kill_on_drop: false }` [INFO] [stdout] b16b492217f41944866d22e59dea8dca60b78ede37a3ac440ba2803efca01eb5