[INFO] cloning repository https://github.com/bichanna/fvm
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bichanna/fvm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbichanna%2Ffvm", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbichanna%2Ffvm'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] d22244e665f8c4cf44c64a289a0f21b770c60b43
[INFO] linting bichanna/fvm against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbichanna%2Ffvm" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/bichanna/fvm
[INFO] finished tweaking git repo https://github.com/bichanna/fvm
[INFO] tweaked toml for git repo https://github.com/bichanna/fvm written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/bichanna/fvm on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/bichanna/fvm already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 15d632dfdf48e0d6eeb5092a08bd691a7d9f6afb5ca909dadb722350700de67b
[INFO] running `Command { std: "docker" "start" "-a" "15d632dfdf48e0d6eeb5092a08bd691a7d9f6afb5ca909dadb722350700de67b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "15d632dfdf48e0d6eeb5092a08bd691a7d9f6afb5ca909dadb722350700de67b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "15d632dfdf48e0d6eeb5092a08bd691a7d9f6afb5ca909dadb722350700de67b", kill_on_drop: false }`
[INFO] [stdout] 15d632dfdf48e0d6eeb5092a08bd691a7d9f6afb5ca909dadb722350700de67b
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 0e8b355f840364273b6afc88e9e7d610bc69f4b2405f8df94afdbff0101555f4
[INFO] running `Command { std: "docker" "start" "-a" "0e8b355f840364273b6afc88e9e7d610bc69f4b2405f8df94afdbff0101555f4", kill_on_drop: false }`
[INFO] [stderr]     Checking fvm v0.0.1 (/opt/rustwide/workdir)
[INFO] [stdout] warning: field `symbol_table` is never read
[INFO] [stdout]   --> src/assembler/compiler.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout]  6 | pub struct Compiler<'a> {
[INFO] [stdout]    |            -------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 10 |     symbol_table: &'a SymbolTable,
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `symbol_type` is never read
[INFO] [stdout]  --> src/assembler/symbol_table.rs:5:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | pub struct Symbol {
[INFO] [stdout]   |            ------ field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 5 |     symbol_type: SymbolType,
[INFO] [stdout]   |     ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `Symbol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this lifetime isn't used in the function definition
[INFO] [stdout]   --> src/assembler/compiler.rs:16:16
[INFO] [stdout]    |
[INFO] [stdout] 16 |     pub fn new<'b>(tokens: &'a Vec<Token>, symbol_table: &'a SymbolTable) -> Compiler<'a> {
[INFO] [stdout]    |                ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/assembler/compiler.rs:33:33
[INFO] [stdout]    |
[INFO] [stdout] 33 |         while !self.is_end() && !(self.tokens.len() <= self.c + 1) {
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.tokens.len() > self.c + 1)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]    --> src/assembler/compiler.rs:232:9
[INFO] [stdout]     |
[INFO] [stdout] 232 | /         if self.tokens.len() <= self.c {
[INFO] [stdout] 233 | |             true
[INFO] [stdout] 234 | |         } else {
[INFO] [stdout] 235 | |             false
[INFO] [stdout] 236 | |         }
[INFO] [stdout]     | |_________^ help: you can reduce it to: `self.tokens.len() <= self.c`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/assembler/compiler.rs:240:30
[INFO] [stdout]     |
[INFO] [stdout] 240 |         if !self.is_end() && !(self.tokens.len() <= self.c + 1) {
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.tokens.len() > self.c + 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/assembler/lexer.rs:17:9
[INFO] [stdout]    |
[INFO] [stdout] 17 | /         match self {
[INFO] [stdout] 18 | |             Token::LabelDeclaration(_) | Token::LabelUsage(_) => true,
[INFO] [stdout] 19 | |             _ => false,
[INFO] [stdout] 20 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 17 -         match self {
[INFO] [stdout] 18 -             Token::LabelDeclaration(_) | Token::LabelUsage(_) => true,
[INFO] [stdout] 19 -             _ => false,
[INFO] [stdout] 20 -         }
[INFO] [stdout] 17 +         matches!(self, Token::LabelDeclaration(_) | Token::LabelUsage(_))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]    --> src/assembler/lexer.rs:189:9
[INFO] [stdout]     |
[INFO] [stdout] 189 | /         if self.source.len() <= self.c {
[INFO] [stdout] 190 | |             true
[INFO] [stdout] 191 | |         } else {
[INFO] [stdout] 192 | |             false
[INFO] [stdout] 193 | |         }
[INFO] [stdout]     | |_________^ help: you can reduce it to: `self.source.len() <= self.c`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/assembler/lexer.rs:197:30
[INFO] [stdout]     |
[INFO] [stdout] 197 |         if !self.is_end() && !(self.source.len() <= self.c + 1) {
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.source.len() > self.c + 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `SymbolTable`
[INFO] [stdout]   --> src/assembler/symbol_table.rs:29:5
[INFO] [stdout]    |
[INFO] [stdout] 29 | /     pub fn new() -> SymbolTable {
[INFO] [stdout] 30 | |         SymbolTable { symbols: vec![] }
[INFO] [stdout] 31 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 28 + impl Default for SymbolTable {
[INFO] [stdout] 29 +     fn default() -> Self {
[INFO] [stdout] 30 +         Self::new()
[INFO] [stdout] 31 +     }
[INFO] [stdout] 32 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this lifetime isn't used in the function definition
[INFO] [stdout]   --> src/assembler/mod.rs:23:16
[INFO] [stdout]    |
[INFO] [stdout] 23 |     pub fn new<'b>(filename: &'a str, source: &'a String) -> Self {
[INFO] [stdout]    |                ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/assembler/mod.rs:36:12
[INFO] [stdout]    |
[INFO] [stdout] 36 |         if lexer.errors.len() > 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lexer.errors.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/assembler/mod.rs:58:12
[INFO] [stdout]    |
[INFO] [stdout] 58 |         if compiler.errors.len() > 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!compiler.errors.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/assembler/mod.rs:71:17
[INFO] [stdout]    |
[INFO] [stdout] 71 | /                 match i.get_label_name() {
[INFO] [stdout] 72 | |                     Some(name) => {
[INFO] [stdout] 73 | |                         let symbol = Symbol::new(name, SymbolType::Label, c);
[INFO] [stdout] 74 | |                         self.symbols.add_symbol(symbol);
[INFO] [stdout] 75 | |                     }
[INFO] [stdout] 76 | |                     None => {}
[INFO] [stdout] 77 | |                 };
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 71 ~                 if let Some(name) = i.get_label_name() {
[INFO] [stdout] 72 +                     let symbol = Symbol::new(name, SymbolType::Label, c);
[INFO] [stdout] 73 +                     self.symbols.add_symbol(symbol);
[INFO] [stdout] 74 ~                 };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL`
[INFO] [stdout]   --> src/repl/mod.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 | /     pub fn new() -> REPL {
[INFO] [stdout] 16 | |         return REPL {
[INFO] [stdout] 17 | |             vm: VM::new(),
[INFO] [stdout] 18 | |             command_buffer: vec![],
[INFO] [stdout] 19 | |         };
[INFO] [stdout] 20 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 14 + impl Default for REPL {
[INFO] [stdout] 15 +     fn default() -> Self {
[INFO] [stdout] 16 +         Self::new()
[INFO] [stdout] 17 +     }
[INFO] [stdout] 18 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/repl/mod.rs:16:9
[INFO] [stdout]    |
[INFO] [stdout] 16 | /         return REPL {
[INFO] [stdout] 17 | |             vm: VM::new(),
[INFO] [stdout] 18 | |             command_buffer: vec![],
[INFO] [stdout] 19 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 ~         REPL {
[INFO] [stdout] 17 +             vm: VM::new(),
[INFO] [stdout] 18 +             command_buffer: vec![],
[INFO] [stdout] 19 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/repl/mod.rs:114:43
[INFO] [stdout]     |
[INFO] [stdout] 114 |             let byte = u8::from_str_radix(&hex_str, 16);
[INFO] [stdout]     |                                           ^^^^^^^^ help: change this to: `hex_str`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM`
[INFO] [stdout]   --> src/vm.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 19 | /     pub fn new() -> Self {
[INFO] [stdout] 20 | |         VM {
[INFO] [stdout] 21 | |             registers: [0; 32],
[INFO] [stdout] 22 | |             heap: vec![],
[INFO] [stdout] ...  |
[INFO] [stdout] 28 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 18 + impl Default for VM {
[INFO] [stdout] 19 +     fn default() -> Self {
[INFO] [stdout] 20 +         Self::new()
[INFO] [stdout] 21 +     }
[INFO] [stdout] 22 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `u16`
[INFO] [stdout]   --> src/vm.rs:65:30
[INFO] [stdout]    |
[INFO] [stdout] 65 |                 let number = u16::from(self.next_16_bits());
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `u16::from()`: `self.next_16_bits()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `symbol_table` is never read
[INFO] [stdout]   --> src/assembler/compiler.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout]  6 | pub struct Compiler<'a> {
[INFO] [stdout]    |            -------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 10 |     symbol_table: &'a SymbolTable,
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `symbol_type` is never read
[INFO] [stdout]  --> src/assembler/symbol_table.rs:5:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | pub struct Symbol {
[INFO] [stdout]   |            ------ field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 5 |     symbol_type: SymbolType,
[INFO] [stdout]   |     ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `Symbol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression assigns a bool literal
[INFO] [stdout]    --> src/vm.rs:130:17
[INFO] [stdout]     |
[INFO] [stdout] 130 | /                 if register1 == register2 {
[INFO] [stdout] 131 | |                     self.equal_flag = true;
[INFO] [stdout] 132 | |                 } else {
[INFO] [stdout] 133 | |                     self.equal_flag = false;
[INFO] [stdout] 134 | |                 }
[INFO] [stdout]     | |_________________^ help: you can reduce it to: `self.equal_flag = register1 == register2;`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool_assign)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this lifetime isn't used in the function definition
[INFO] [stdout]   --> src/assembler/compiler.rs:16:16
[INFO] [stdout]    |
[INFO] [stdout] 16 |     pub fn new<'b>(tokens: &'a Vec<Token>, symbol_table: &'a SymbolTable) -> Compiler<'a> {
[INFO] [stdout]    |                ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/vm.rs:187:9
[INFO] [stdout]     |
[INFO] [stdout] 187 |         return opcode;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 187 -         return opcode;
[INFO] [stdout] 187 +         opcode
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/vm.rs:194:9
[INFO] [stdout]     |
[INFO] [stdout] 194 |         return result;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 194 -         return result;
[INFO] [stdout] 194 +         result
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/vm.rs:201:9
[INFO] [stdout]     |
[INFO] [stdout] 201 |         return result;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 201 -         return result;
[INFO] [stdout] 201 +         result
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/assembler/compiler.rs:33:33
[INFO] [stdout]    |
[INFO] [stdout] 33 |         while !self.is_end() && !(self.tokens.len() <= self.c + 1) {
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.tokens.len() > self.c + 1)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]    --> src/assembler/compiler.rs:232:9
[INFO] [stdout]     |
[INFO] [stdout] 232 | /         if self.tokens.len() <= self.c {
[INFO] [stdout] 233 | |             true
[INFO] [stdout] 234 | |         } else {
[INFO] [stdout] 235 | |             false
[INFO] [stdout] 236 | |         }
[INFO] [stdout]     | |_________^ help: you can reduce it to: `self.tokens.len() <= self.c`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/assembler/compiler.rs:240:30
[INFO] [stdout]     |
[INFO] [stdout] 240 |         if !self.is_end() && !(self.tokens.len() <= self.c + 1) {
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.tokens.len() > self.c + 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/assembler/lexer.rs:17:9
[INFO] [stdout]    |
[INFO] [stdout] 17 | /         match self {
[INFO] [stdout] 18 | |             Token::LabelDeclaration(_) | Token::LabelUsage(_) => true,
[INFO] [stdout] 19 | |             _ => false,
[INFO] [stdout] 20 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 17 -         match self {
[INFO] [stdout] 18 -             Token::LabelDeclaration(_) | Token::LabelUsage(_) => true,
[INFO] [stdout] 19 -             _ => false,
[INFO] [stdout] 20 -         }
[INFO] [stdout] 17 +         matches!(self, Token::LabelDeclaration(_) | Token::LabelUsage(_))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]    --> src/assembler/lexer.rs:189:9
[INFO] [stdout]     |
[INFO] [stdout] 189 | /         if self.source.len() <= self.c {
[INFO] [stdout] 190 | |             true
[INFO] [stdout] 191 | |         } else {
[INFO] [stdout] 192 | |             false
[INFO] [stdout] 193 | |         }
[INFO] [stdout]     | |_________^ help: you can reduce it to: `self.source.len() <= self.c`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/assembler/lexer.rs:197:30
[INFO] [stdout]     |
[INFO] [stdout] 197 |         if !self.is_end() && !(self.source.len() <= self.c + 1) {
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.source.len() > self.c + 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `SymbolTable`
[INFO] [stdout]   --> src/assembler/symbol_table.rs:29:5
[INFO] [stdout]    |
[INFO] [stdout] 29 | /     pub fn new() -> SymbolTable {
[INFO] [stdout] 30 | |         SymbolTable { symbols: vec![] }
[INFO] [stdout] 31 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 28 + impl Default for SymbolTable {
[INFO] [stdout] 29 +     fn default() -> Self {
[INFO] [stdout] 30 +         Self::new()
[INFO] [stdout] 31 +     }
[INFO] [stdout] 32 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this lifetime isn't used in the function definition
[INFO] [stdout]   --> src/assembler/mod.rs:23:16
[INFO] [stdout]    |
[INFO] [stdout] 23 |     pub fn new<'b>(filename: &'a str, source: &'a String) -> Self {
[INFO] [stdout]    |                ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/assembler/mod.rs:36:12
[INFO] [stdout]    |
[INFO] [stdout] 36 |         if lexer.errors.len() > 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lexer.errors.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/assembler/mod.rs:58:12
[INFO] [stdout]    |
[INFO] [stdout] 58 |         if compiler.errors.len() > 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!compiler.errors.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/assembler/mod.rs:71:17
[INFO] [stdout]    |
[INFO] [stdout] 71 | /                 match i.get_label_name() {
[INFO] [stdout] 72 | |                     Some(name) => {
[INFO] [stdout] 73 | |                         let symbol = Symbol::new(name, SymbolType::Label, c);
[INFO] [stdout] 74 | |                         self.symbols.add_symbol(symbol);
[INFO] [stdout] 75 | |                     }
[INFO] [stdout] 76 | |                     None => {}
[INFO] [stdout] 77 | |                 };
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 71 ~                 if let Some(name) = i.get_label_name() {
[INFO] [stdout] 72 +                     let symbol = Symbol::new(name, SymbolType::Label, c);
[INFO] [stdout] 73 +                     self.symbols.add_symbol(symbol);
[INFO] [stdout] 74 ~                 };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL`
[INFO] [stdout]   --> src/repl/mod.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 | /     pub fn new() -> REPL {
[INFO] [stdout] 16 | |         return REPL {
[INFO] [stdout] 17 | |             vm: VM::new(),
[INFO] [stdout] 18 | |             command_buffer: vec![],
[INFO] [stdout] 19 | |         };
[INFO] [stdout] 20 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 14 + impl Default for REPL {
[INFO] [stdout] 15 +     fn default() -> Self {
[INFO] [stdout] 16 +         Self::new()
[INFO] [stdout] 17 +     }
[INFO] [stdout] 18 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/repl/mod.rs:16:9
[INFO] [stdout]    |
[INFO] [stdout] 16 | /         return REPL {
[INFO] [stdout] 17 | |             vm: VM::new(),
[INFO] [stdout] 18 | |             command_buffer: vec![],
[INFO] [stdout] 19 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 ~         REPL {
[INFO] [stdout] 17 +             vm: VM::new(),
[INFO] [stdout] 18 +             command_buffer: vec![],
[INFO] [stdout] 19 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/repl/mod.rs:114:43
[INFO] [stdout]     |
[INFO] [stdout] 114 |             let byte = u8::from_str_radix(&hex_str, 16);
[INFO] [stdout]     |                                           ^^^^^^^^ help: change this to: `hex_str`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM`
[INFO] [stdout]   --> src/vm.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 19 | /     pub fn new() -> Self {
[INFO] [stdout] 20 | |         VM {
[INFO] [stdout] 21 | |             registers: [0; 32],
[INFO] [stdout] 22 | |             heap: vec![],
[INFO] [stdout] ...  |
[INFO] [stdout] 28 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 18 + impl Default for VM {
[INFO] [stdout] 19 +     fn default() -> Self {
[INFO] [stdout] 20 +         Self::new()
[INFO] [stdout] 21 +     }
[INFO] [stdout] 22 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `u16`
[INFO] [stdout]   --> src/vm.rs:65:30
[INFO] [stdout]    |
[INFO] [stdout] 65 |                 let number = u16::from(self.next_16_bits());
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `u16::from()`: `self.next_16_bits()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression assigns a bool literal
[INFO] [stdout]    --> src/vm.rs:130:17
[INFO] [stdout]     |
[INFO] [stdout] 130 | /                 if register1 == register2 {
[INFO] [stdout] 131 | |                     self.equal_flag = true;
[INFO] [stdout] 132 | |                 } else {
[INFO] [stdout] 133 | |                     self.equal_flag = false;
[INFO] [stdout] 134 | |                 }
[INFO] [stdout]     | |_________________^ help: you can reduce it to: `self.equal_flag = register1 == register2;`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool_assign)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/vm.rs:187:9
[INFO] [stdout]     |
[INFO] [stdout] 187 |         return opcode;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 187 -         return opcode;
[INFO] [stdout] 187 +         opcode
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/vm.rs:194:9
[INFO] [stdout]     |
[INFO] [stdout] 194 |         return result;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 194 -         return result;
[INFO] [stdout] 194 +         result
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/vm.rs:201:9
[INFO] [stdout]     |
[INFO] [stdout] 201 |         return result;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 201 -         return result;
[INFO] [stdout] 201 +         result
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/vm.rs:320:9
[INFO] [stdout]     |
[INFO] [stdout] 320 |         assert_eq!(test_vm.equal_flag, true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 320 -         assert_eq!(test_vm.equal_flag, true);
[INFO] [stdout] 320 +         assert!(test_vm.equal_flag);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/vm.rs:323:9
[INFO] [stdout]     |
[INFO] [stdout] 323 |         assert_eq!(test_vm.equal_flag, false);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 323 -         assert_eq!(test_vm.equal_flag, false);
[INFO] [stdout] 323 +         assert!(!test_vm.equal_flag);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.42s
[INFO] running `Command { std: "docker" "inspect" "0e8b355f840364273b6afc88e9e7d610bc69f4b2405f8df94afdbff0101555f4", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0e8b355f840364273b6afc88e9e7d610bc69f4b2405f8df94afdbff0101555f4", kill_on_drop: false }`
[INFO] [stdout] 0e8b355f840364273b6afc88e9e7d610bc69f4b2405f8df94afdbff0101555f4