[INFO] cloning repository https://github.com/bens-schreiber/virtual-packet-tracer
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bens-schreiber/virtual-packet-tracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbens-schreiber%2Fvirtual-packet-tracer", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbens-schreiber%2Fvirtual-packet-tracer'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] b8087c37f073fd50078bcc154cf2996a343c8085
[INFO] linting bens-schreiber/virtual-packet-tracer against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbens-schreiber%2Fvirtual-packet-tracer" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/bens-schreiber/virtual-packet-tracer
[INFO] finished tweaking git repo https://github.com/bens-schreiber/virtual-packet-tracer
[INFO] tweaked toml for git repo https://github.com/bens-schreiber/virtual-packet-tracer written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/bens-schreiber/virtual-packet-tracer on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/bens-schreiber/virtual-packet-tracer already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded cmake v0.1.51
[INFO] [stderr]   Downloaded ahash v0.3.8
[INFO] [stderr]   Downloaded tuple_utils v0.3.0
[INFO] [stderr]   Downloaded shred v0.10.2
[INFO] [stderr]   Downloaded tynm v0.1.10
[INFO] [stderr]   Downloaded shrev v1.1.3
[INFO] [stderr]   Downloaded libloading v0.8.5
[INFO] [stderr]   Downloaded prettyplease v0.2.25
[INFO] [stderr]   Downloaded hashbrown v0.7.2
[INFO] [stderr]   Downloaded raylib v5.0.2
[INFO] [stderr]   Downloaded specs v0.16.1
[INFO] [stderr]   Downloaded hibitset v0.6.4
[INFO] [stderr]   Downloaded specs-derive v0.4.1
[INFO] [stderr]   Downloaded libc v0.2.158
[INFO] [stderr]   Downloaded bindgen v0.69.5
[INFO] [stderr]   Downloaded raylib-sys v5.0.2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] e607de26914825a390c5d8aa934531c488f79d22c16f31c5076b4ad8f846ab5d
[INFO] running `Command { std: "docker" "start" "-a" "e607de26914825a390c5d8aa934531c488f79d22c16f31c5076b4ad8f846ab5d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "e607de26914825a390c5d8aa934531c488f79d22c16f31c5076b4ad8f846ab5d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e607de26914825a390c5d8aa934531c488f79d22c16f31c5076b4ad8f846ab5d", kill_on_drop: false }`
[INFO] [stdout] e607de26914825a390c5d8aa934531c488f79d22c16f31c5076b4ad8f846ab5d
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 61a5863821ffff46ed1d69fc459b27e4a204cfd8f39fc20a8e81dab7a0f4c622
[INFO] running `Command { std: "docker" "start" "-a" "61a5863821ffff46ed1d69fc459b27e4a204cfd8f39fc20a8e81dab7a0f4c622", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.158
[INFO] [stderr]    Compiling prettyplease v0.2.25
[INFO] [stderr]    Compiling rustix v0.38.37
[INFO] [stderr]    Compiling linux-raw-sys v0.4.14
[INFO] [stderr]    Compiling bitflags v2.6.0
[INFO] [stderr]    Compiling either v1.13.0
[INFO] [stderr]    Compiling proc-macro2 v1.0.92
[INFO] [stderr]    Compiling clang-sys v1.8.1
[INFO] [stderr]    Compiling regex-syntax v0.8.4
[INFO] [stderr]    Compiling nom v7.1.3
[INFO] [stderr]    Compiling libloading v0.8.5
[INFO] [stderr]    Compiling bindgen v0.69.5
[INFO] [stderr]    Compiling hashbrown v0.7.2
[INFO] [stderr]    Compiling cc v1.2.1
[INFO] [stderr]    Compiling crossbeam-utils v0.7.2
[INFO] [stderr]    Compiling maybe-uninit v2.0.0
[INFO] [stderr]     Checking minimal-lexical v0.2.1
[INFO] [stderr]     Checking byteorder v1.5.0
[INFO] [stderr]     Checking ahash v0.3.8
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]     Checking mopa v0.2.2
[INFO] [stderr]    Compiling itertools v0.12.1
[INFO] [stderr]     Checking arrayvec v0.5.2
[INFO] [stderr]     Checking tuple_utils v0.3.0
[INFO] [stderr]     Checking shrev v1.1.3
[INFO] [stderr]     Checking hibitset v0.6.4
[INFO] [stderr]     Checking regex-automata v0.4.7
[INFO] [stderr]    Compiling quote v1.0.37
[INFO] [stderr]    Compiling cmake v0.1.51
[INFO] [stderr]    Compiling syn v2.0.89
[INFO] [stderr]     Checking crossbeam-queue v0.2.3
[INFO] [stderr]     Checking getrandom v0.2.15
[INFO] [stderr]     Checking parking_lot_core v0.9.10
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]    Compiling cexpr v0.6.0
[INFO] [stderr]     Checking parking_lot v0.12.3
[INFO] [stderr]     Checking tynm v0.1.10
[INFO] [stderr]     Checking shred v0.10.2
[INFO] [stderr]     Checking specs v0.16.1
[INFO] [stderr]     Checking regex v1.10.6
[INFO] [stderr]    Compiling which v4.4.2
[INFO] [stderr]    Compiling specs-derive v0.4.1
[INFO] [stderr]    Compiling zerocopy-derive v0.7.35
[INFO] [stderr]     Checking zerocopy v0.7.35
[INFO] [stderr]     Checking ppv-lite86 v0.2.20
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]    Compiling raylib-sys v5.0.2
[INFO] [stderr]     Checking raylib v5.0.2
[INFO] [stderr]     Checking virtual-packet-tracer v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout]    --> src/network/ethernet/interface.rs:134:29
[INFO] [stdout]     |
[INFO] [stdout] 134 |               .filter_map(|b| match EthernetFrame::from_bytes(b) {
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 135 | |                 Ok(frame) => Some(frame),
[INFO] [stdout] 136 | |                 Err(_) => None,
[INFO] [stdout] 137 | |             })
[INFO] [stdout]     | |_____________^ help: replace with: `EthernetFrame::from_bytes(b).ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]     = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/network/device/switch.rs:477:20
[INFO] [stdout]     |
[INFO] [stdout] 477 |                   if !sp
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 478 | |                     .connected_root_bid
[INFO] [stdout] 479 | |                     .is_some_and(|bid| bid == self.root_bid)
[INFO] [stdout]     | |____________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 477 ~                 if sp
[INFO] [stdout] 478 +                     .connected_root_bid.is_none_or(|bid| bid != self.root_bid)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/network/device/switch.rs:754:5
[INFO] [stdout]     |
[INFO] [stdout] 754 | /     pub fn new(
[INFO] [stdout] 755 | |         destination_address: MacAddress,
[INFO] [stdout] 756 | |         source_address: MacAddress,
[INFO] [stdout] 757 | |         config_type: bool,
[INFO] [stdout] ...   |
[INFO] [stdout] 762 | |         port: u16,
[INFO] [stdout] 763 | |     ) -> Self {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/simulation/device.rs:510:10
[INFO] [stdout]     |
[INFO] [stdout] 510 |       ) -> Vec<(
[INFO] [stdout]     |  __________^
[INFO] [stdout] 511 | |         DeviceId,
[INFO] [stdout] 512 | |         (
[INFO] [stdout] 513 | |             (Option<DeviceId>, Vec<PacketKind>),
[INFO] [stdout] 514 | |             (Option<DeviceId>, Vec<PacketKind>),
[INFO] [stdout] 515 | |         ),
[INFO] [stdout] 516 | |     )> {
[INFO] [stdout]     | |______^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]     = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression assigns a bool literal
[INFO] [stdout]    --> src/simulation/gui.rs:584:13
[INFO] [stdout]     |
[INFO] [stdout] 584 | /             if bottom_panel_bounds.check_collision_point_rec(mouse_pos) {
[INFO] [stdout] 585 | |                 self.terminal_edit_mode = true;
[INFO] [stdout] 586 | |             } else {
[INFO] [stdout] 587 | |                 self.terminal_edit_mode = false;
[INFO] [stdout] 588 | |             }
[INFO] [stdout]     | |_____________^ help: you can reduce it to: `self.terminal_edit_mode = bottom_panel_bounds.check_collision_point_rec(mouse_pos);`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool_assign)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: items after a test module
[INFO] [stdout]   --> src/main.rs:19:1
[INFO] [stdout]    |
[INFO] [stdout] 19 | mod tests {
[INFO] [stdout]    | ^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 33 | fn main() {
[INFO] [stdout]    | ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module
[INFO] [stdout]    = note: `#[warn(clippy::items_after_test_module)]` on by default
[INFO] [stdout]    = help: move the items to before the test module was defined
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout]    --> src/network/ethernet/interface.rs:134:29
[INFO] [stdout]     |
[INFO] [stdout] 134 |               .filter_map(|b| match EthernetFrame::from_bytes(b) {
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 135 | |                 Ok(frame) => Some(frame),
[INFO] [stdout] 136 | |                 Err(_) => None,
[INFO] [stdout] 137 | |             })
[INFO] [stdout]     | |_____________^ help: replace with: `EthernetFrame::from_bytes(b).ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]     = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/network/device/switch.rs:477:20
[INFO] [stdout]     |
[INFO] [stdout] 477 |                   if !sp
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 478 | |                     .connected_root_bid
[INFO] [stdout] 479 | |                     .is_some_and(|bid| bid == self.root_bid)
[INFO] [stdout]     | |____________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 477 ~                 if sp
[INFO] [stdout] 478 +                     .connected_root_bid.is_none_or(|bid| bid != self.root_bid)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/network/device/switch.rs:754:5
[INFO] [stdout]     |
[INFO] [stdout] 754 | /     pub fn new(
[INFO] [stdout] 755 | |         destination_address: MacAddress,
[INFO] [stdout] 756 | |         source_address: MacAddress,
[INFO] [stdout] 757 | |         config_type: bool,
[INFO] [stdout] ...   |
[INFO] [stdout] 762 | |         port: u16,
[INFO] [stdout] 763 | |     ) -> Self {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/simulation/device.rs:510:10
[INFO] [stdout]     |
[INFO] [stdout] 510 |       ) -> Vec<(
[INFO] [stdout]     |  __________^
[INFO] [stdout] 511 | |         DeviceId,
[INFO] [stdout] 512 | |         (
[INFO] [stdout] 513 | |             (Option<DeviceId>, Vec<PacketKind>),
[INFO] [stdout] 514 | |             (Option<DeviceId>, Vec<PacketKind>),
[INFO] [stdout] 515 | |         ),
[INFO] [stdout] 516 | |     )> {
[INFO] [stdout]     | |______^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]     = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression assigns a bool literal
[INFO] [stdout]    --> src/simulation/gui.rs:584:13
[INFO] [stdout]     |
[INFO] [stdout] 584 | /             if bottom_panel_bounds.check_collision_point_rec(mouse_pos) {
[INFO] [stdout] 585 | |                 self.terminal_edit_mode = true;
[INFO] [stdout] 586 | |             } else {
[INFO] [stdout] 587 | |                 self.terminal_edit_mode = false;
[INFO] [stdout] 588 | |             }
[INFO] [stdout]     | |_____________^ help: you can reduce it to: `self.terminal_edit_mode = bottom_panel_bounds.check_collision_point_rec(mouse_pos);`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool_assign)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]   --> src/tests/network/cable_tests.rs:17:32
[INFO] [stdout]    |
[INFO] [stdout] 17 |     EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]    |                                ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout] 17 -     EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 17 +     EthernetInterface::connect(&i1, &mut i2);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]   --> src/tests/network/cable_tests.rs:17:41
[INFO] [stdout]    |
[INFO] [stdout] 17 |     EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]    |                                         ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout] 17 -     EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 17 +     EthernetInterface::connect(&mut i1, &i2);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `bytes`
[INFO] [stdout]   --> src/tests/network/ethernet_tests.rs:26:18
[INFO] [stdout]    |
[INFO] [stdout] 26 |         for i in 0..7 {
[INFO] [stdout]    |                  ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 26 -         for i in 0..7 {
[INFO] [stdout] 26 +         for <item> in bytes.iter().take(7) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `bytes`
[INFO] [stdout]   --> src/tests/network/ethernet_tests.rs:79:18
[INFO] [stdout]    |
[INFO] [stdout] 79 |         for i in 0..7 {
[INFO] [stdout]    |                  ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 79 -         for i in 0..7 {
[INFO] [stdout] 79 +         for <item> in bytes.iter().take(7) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:133:36
[INFO] [stdout]     |
[INFO] [stdout] 133 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                    ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 133 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 133 +         EthernetInterface::connect(&i1, &mut i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:133:45
[INFO] [stdout]     |
[INFO] [stdout] 133 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 133 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 133 +         EthernetInterface::connect(&mut i1, &i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:166:36
[INFO] [stdout]     |
[INFO] [stdout] 166 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                    ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 166 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 166 +         EthernetInterface::connect(&i1, &mut i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:166:45
[INFO] [stdout]     |
[INFO] [stdout] 166 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 166 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 166 +         EthernetInterface::connect(&mut i1, &i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:210:36
[INFO] [stdout]     |
[INFO] [stdout] 210 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                    ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 210 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 210 +         EthernetInterface::connect(&i1, &mut i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:210:45
[INFO] [stdout]     |
[INFO] [stdout] 210 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 210 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 210 +         EthernetInterface::connect(&mut i1, &i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:235:36
[INFO] [stdout]     |
[INFO] [stdout] 235 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                    ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 235 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 235 +         EthernetInterface::connect(&i1, &mut i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:235:45
[INFO] [stdout]     |
[INFO] [stdout] 235 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 235 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 235 +         EthernetInterface::connect(&mut i1, &i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:310:36
[INFO] [stdout]     |
[INFO] [stdout] 310 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                    ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 310 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 310 +         EthernetInterface::connect(&i1, &mut i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]    --> src/tests/network/ethernet_tests.rs:310:45
[INFO] [stdout]     |
[INFO] [stdout] 310 |         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout]     |                                             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 310 -         EthernetInterface::connect(&mut i1, &mut i2);
[INFO] [stdout] 310 +         EthernetInterface::connect(&mut i1, &i2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]   --> src/tests/network/ipv4_interface_tests.rs:37:32
[INFO] [stdout]    |
[INFO] [stdout] 37 |     EthernetInterface::connect(&mut i1.ethernet, &mut i2.ethernet);
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout] 37 -     EthernetInterface::connect(&mut i1.ethernet, &mut i2.ethernet);
[INFO] [stdout] 37 +     EthernetInterface::connect(&i1.ethernet, &mut i2.ethernet);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `EthernetInterface::connect` doesn't need a mutable reference
[INFO] [stdout]   --> src/tests/network/ipv4_interface_tests.rs:37:50
[INFO] [stdout]    |
[INFO] [stdout] 37 |     EthernetInterface::connect(&mut i1.ethernet, &mut i2.ethernet);
[INFO] [stdout]    |                                                  ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout] 37 -     EthernetInterface::connect(&mut i1.ethernet, &mut i2.ethernet);
[INFO] [stdout] 37 +     EthernetInterface::connect(&mut i1.ethernet, &i2.ethernet);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/tests/network/switch_tests.rs:456:26
[INFO] [stdout]     |
[INFO] [stdout] 456 |   fn complete_network() -> (
[INFO] [stdout]     |  __________________________^
[INFO] [stdout] 457 | |     CableSimulator,
[INFO] [stdout] 458 | |     Switch,
[INFO] [stdout] 459 | |     Switch,
[INFO] [stdout] ...   |
[INFO] [stdout] 463 | |     (usize, usize, usize, usize, usize, usize),
[INFO] [stdout] 464 | | ) {
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/tests/network/switch_tests.rs:540:30
[INFO] [stdout]     |
[INFO] [stdout] 540 |   fn stp_complete_network() -> (
[INFO] [stdout]     |  ______________________________^
[INFO] [stdout] 541 | |     CableSimulator,
[INFO] [stdout] 542 | |     Switch,
[INFO] [stdout] 543 | |     Switch,
[INFO] [stdout] ...   |
[INFO] [stdout] 547 | |     (usize, usize, usize, usize, usize, usize),
[INFO] [stdout] 548 | | ) {
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.87s
[INFO] running `Command { std: "docker" "inspect" "61a5863821ffff46ed1d69fc459b27e4a204cfd8f39fc20a8e81dab7a0f4c622", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "61a5863821ffff46ed1d69fc459b27e4a204cfd8f39fc20a8e81dab7a0f4c622", kill_on_drop: false }`
[INFO] [stdout] 61a5863821ffff46ed1d69fc459b27e4a204cfd8f39fc20a8e81dab7a0f4c622