[INFO] cloning repository https://github.com/bennetyee/cryptoquip
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bennetyee/cryptoquip" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbennetyee%2Fcryptoquip", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbennetyee%2Fcryptoquip'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 0d742e0cb66b53672bea949f055aba4da709ebb0
[INFO] linting bennetyee/cryptoquip against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbennetyee%2Fcryptoquip" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/bennetyee/cryptoquip
[INFO] finished tweaking git repo https://github.com/bennetyee/cryptoquip
[INFO] tweaked toml for git repo https://github.com/bennetyee/cryptoquip written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/bennetyee/cryptoquip on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] cc31e06bd6f5a12d48769d382e3f9f9b3fe0be34cb70778e2e443f2c24b8366e
[INFO] running `Command { std: "docker" "start" "-a" "cc31e06bd6f5a12d48769d382e3f9f9b3fe0be34cb70778e2e443f2c24b8366e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "cc31e06bd6f5a12d48769d382e3f9f9b3fe0be34cb70778e2e443f2c24b8366e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "cc31e06bd6f5a12d48769d382e3f9f9b3fe0be34cb70778e2e443f2c24b8366e", kill_on_drop: false }`
[INFO] [stdout] cc31e06bd6f5a12d48769d382e3f9f9b3fe0be34cb70778e2e443f2c24b8366e
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 7e6f90d35eddef7bb8218b4ad95e98e1f7deb3997f69fe2e4d69ce566e707e06
[INFO] running `Command { std: "docker" "start" "-a" "7e6f90d35eddef7bb8218b4ad95e98e1f7deb3997f69fe2e4d69ce566e707e06", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking cryptoquip v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: empty lines after doc comment
[INFO] [stdout]   --> src/main.rs:6:1
[INFO] [stdout]    |
[INFO] [stdout]  6 | / /// add mappings or delete mappings and see the updated result.
[INFO] [stdout] ...  |
[INFO] [stdout] 10 | |
[INFO] [stdout]    | |_^
[INFO] [stdout] 11 |   use std::collections::HashMap;
[INFO] [stdout]    |   - the comment documents this `use` import
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]    = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]    = help: if the empty lines are unintentional, remove them
[INFO] [stdout] help: if the doc comment should not document the following item then comment it out
[INFO] [stdout]    |
[INFO] [stdout]  1 ~ // /// Cryptoquip solving tool.
[INFO] [stdout]  2 ~ // ///
[INFO] [stdout]  3 ~ // /// This program takes a "cryptoquip" -- a phrase encrypted using a
[INFO] [stdout]  4 ~ // /// simple monoalphabetic substitution cipher -- and displays it after
[INFO] [stdout]  5 ~ // /// applying a (partial) guessed transform.  The UI allows the user to
[INFO] [stdout]  6 ~ // /// add mappings or delete mappings and see the updated result.
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:83:9
[INFO] [stdout]    |
[INFO] [stdout] 83 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:163:24
[INFO] [stdout]     |
[INFO] [stdout] 163 |                     if !c.is_alphabetic() && !(expect_post && c == '.') {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(c.is_alphabetic() || expect_post && c == '.')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:131:16
[INFO] [stdout]     |
[INFO] [stdout] 131 |             if line.len() == 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/main.rs:149:29
[INFO] [stdout]     |
[INFO] [stdout] 149 |                 self.reset(&line[1..].trim());
[INFO] [stdout]     |                             ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/main.rs:148:20
[INFO] [stdout]     |
[INFO] [stdout] 148 |             } else if line.starts_with("N") {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout]     = note: `#[warn(clippy::manual_strip)]` on by default
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 148 ~             } else if let Some(<stripped>) = line.strip_prefix("N") {
[INFO] [stdout] 149 ~                 self.reset(&<stripped>.trim());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:149:28
[INFO] [stdout]     |
[INFO] [stdout] 149 |                 self.reset(&line[1..].trim());
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^ help: change this to: `line[1..].trim()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/main.rs:155:28
[INFO] [stdout]     |
[INFO] [stdout] 155 |                 let rest = line[1..].trim().to_string();
[INFO] [stdout]     |                            ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/main.rs:154:20
[INFO] [stdout]     |
[INFO] [stdout] 154 |             } else if line.starts_with("r") {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 154 ~             } else if let Some(<stripped>) = line.strip_prefix("r") {
[INFO] [stdout] 155 ~                 let rest = <stripped>.trim().to_string();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/main.rs:156:20
[INFO] [stdout]     |
[INFO] [stdout] 156 |                 if rest.len() % 2 != 0 {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^ help: replace with: `!rest.len().is_multiple_of(2)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout]     = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty lines after doc comment
[INFO] [stdout]   --> src/main.rs:6:1
[INFO] [stdout]    |
[INFO] [stdout]  6 | / /// add mappings or delete mappings and see the updated result.
[INFO] [stdout] ...  |
[INFO] [stdout] 10 | |
[INFO] [stdout]    | |_^
[INFO] [stdout] 11 |   use std::collections::HashMap;
[INFO] [stdout]    |   - the comment documents this `use` import
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]    = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]    = help: if the empty lines are unintentional, remove them
[INFO] [stdout] help: if the doc comment should not document the following item then comment it out
[INFO] [stdout]    |
[INFO] [stdout]  1 ~ // /// Cryptoquip solving tool.
[INFO] [stdout]  2 ~ // ///
[INFO] [stdout]  3 ~ // /// This program takes a "cryptoquip" -- a phrase encrypted using a
[INFO] [stdout]  4 ~ // /// simple monoalphabetic substitution cipher -- and displays it after
[INFO] [stdout]  5 ~ // /// applying a (partial) guessed transform.  The UI allows the user to
[INFO] [stdout]  6 ~ // /// add mappings or delete mappings and see the updated result.
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:83:9
[INFO] [stdout]    |
[INFO] [stdout] 83 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:163:24
[INFO] [stdout]     |
[INFO] [stdout] 163 |                     if !c.is_alphabetic() && !(expect_post && c == '.') {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(c.is_alphabetic() || expect_post && c == '.')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:131:16
[INFO] [stdout]     |
[INFO] [stdout] 131 |             if line.len() == 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/main.rs:149:29
[INFO] [stdout]     |
[INFO] [stdout] 149 |                 self.reset(&line[1..].trim());
[INFO] [stdout]     |                             ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/main.rs:148:20
[INFO] [stdout]     |
[INFO] [stdout] 148 |             } else if line.starts_with("N") {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout]     = note: `#[warn(clippy::manual_strip)]` on by default
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 148 ~             } else if let Some(<stripped>) = line.strip_prefix("N") {
[INFO] [stdout] 149 ~                 self.reset(&<stripped>.trim());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:149:28
[INFO] [stdout]     |
[INFO] [stdout] 149 |                 self.reset(&line[1..].trim());
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^ help: change this to: `line[1..].trim()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]    --> src/main.rs:155:28
[INFO] [stdout]     |
[INFO] [stdout] 155 |                 let rest = line[1..].trim().to_string();
[INFO] [stdout]     |                            ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]    --> src/main.rs:154:20
[INFO] [stdout]     |
[INFO] [stdout] 154 |             } else if line.starts_with("r") {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]     |
[INFO] [stdout] 154 ~             } else if let Some(<stripped>) = line.strip_prefix("r") {
[INFO] [stdout] 155 ~                 let rest = <stripped>.trim().to_string();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/main.rs:156:20
[INFO] [stdout]     |
[INFO] [stdout] 156 |                 if rest.len() % 2 != 0 {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^ help: replace with: `!rest.len().is_multiple_of(2)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout]     = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s
[INFO] running `Command { std: "docker" "inspect" "7e6f90d35eddef7bb8218b4ad95e98e1f7deb3997f69fe2e4d69ce566e707e06", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7e6f90d35eddef7bb8218b4ad95e98e1f7deb3997f69fe2e4d69ce566e707e06", kill_on_drop: false }`
[INFO] [stdout] 7e6f90d35eddef7bb8218b4ad95e98e1f7deb3997f69fe2e4d69ce566e707e06