[INFO] cloning repository https://github.com/benjamesfleming/smarterplaylists-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/benjamesfleming/smarterplaylists-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenjamesfleming%2Fsmarterplaylists-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenjamesfleming%2Fsmarterplaylists-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa61f2aaea7639ed61092ac700ff6b0a88d82d9b [INFO] linting benjamesfleming/smarterplaylists-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenjamesfleming%2Fsmarterplaylists-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/benjamesfleming/smarterplaylists-rs [INFO] finished tweaking git repo https://github.com/benjamesfleming/smarterplaylists-rs [INFO] tweaked toml for git repo https://github.com/benjamesfleming/smarterplaylists-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/benjamesfleming/smarterplaylists-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/benjamesfleming/smarterplaylists-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rust-embed-impl v6.8.1 [INFO] [stderr] Downloaded thiserror v2.0.14 [INFO] [stderr] Downloaded schemars_derive v1.0.4 [INFO] [stderr] Downloaded thiserror-impl v2.0.14 [INFO] [stderr] Downloaded rust-embed-utils v7.8.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.97 [INFO] [stderr] Downloaded mobc-redis v0.9.0 [INFO] [stderr] Downloaded rspotify-macros v0.15.0 [INFO] [stderr] Downloaded rspotify-http v0.15.0 [INFO] [stderr] Downloaded actix-session v0.7.2 [INFO] [stderr] Downloaded metrics v0.24.2 [INFO] [stderr] Downloaded cc v1.2.32 [INFO] [stderr] Downloaded mobc v0.9.0 [INFO] [stderr] Downloaded rspotify-model v0.15.0 [INFO] [stderr] Downloaded syn v2.0.105 [INFO] [stderr] Downloaded redis v0.28.2 [INFO] [stderr] Downloaded rust-embed v6.8.1 [INFO] [stderr] Downloaded rspotify v0.15.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9656339f581abbb8fcd03eef8f901536853be044aac0d5fb3141022349e703b5 [INFO] running `Command { std: "docker" "start" "-a" "9656339f581abbb8fcd03eef8f901536853be044aac0d5fb3141022349e703b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9656339f581abbb8fcd03eef8f901536853be044aac0d5fb3141022349e703b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9656339f581abbb8fcd03eef8f901536853be044aac0d5fb3141022349e703b5", kill_on_drop: false }` [INFO] [stdout] 9656339f581abbb8fcd03eef8f901536853be044aac0d5fb3141022349e703b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f247690677ea233134986314718556e329733be016394143ee14db65a940b59 [INFO] running `Command { std: "docker" "start" "-a" "6f247690677ea233134986314718556e329733be016394143ee14db65a940b59", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.97 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling thiserror v2.0.14 [INFO] [stderr] Compiling serde_json v1.0.142 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling cc v1.2.32 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling syn v2.0.105 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling crc v3.3.0 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling rustls v0.23.31 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling bytestring v1.4.0 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling regex-lite v0.1.6 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Checking brotli v8.0.1 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling ref-cast v1.0.24 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking metrics v0.24.2 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling rust-embed-utils v7.8.1 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking unicase v2.8.1 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking rspotify-macros v0.15.0 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.14 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling maybe-async v0.2.10 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling ref-cast-impl v1.0.24 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Compiling schemars_derive v1.0.4 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Compiling rust-embed-impl v6.8.1 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking rust-embed v6.8.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking mobc v0.9.0 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking actix-router v0.5.3 [INFO] [stderr] Checking ulid v1.2.1 [INFO] [stderr] Checking uuid v1.18.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking schemars v1.0.4 [INFO] [stderr] Checking cookie_store v0.21.1 [INFO] [stderr] Checking sqlx-core v0.8.6 [INFO] [stderr] Checking redis v0.28.2 [INFO] [stderr] Checking rspotify-model v0.15.0 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking rspotify-http v0.15.0 [INFO] [stderr] Checking actix-http v3.11.0 [INFO] [stderr] Checking rspotify v0.15.0 [INFO] [stderr] Checking sqlx-sqlite v0.8.6 [INFO] [stderr] Checking actix-web v4.11.0 [INFO] [stderr] Checking mobc-redis v0.9.0 [INFO] [stderr] Checking actix-session v0.7.2 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking smarterplaylists-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/assets.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use mime_guess; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/spotify/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use rspotify; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/assets.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use mime_guess; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/spotify/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use rspotify; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/components/sources/source_user_liked_tracks.rs:22:33 [INFO] [stdout] | [INFO] [stdout] 22 | fn execute(client: &Client, args: Self::Args, prev: Vec) -> Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev` [INFO] [stdout] --> src/components/sources/source_user_liked_tracks.rs:22:51 [INFO] [stdout] | [INFO] [stdout] 22 | fn execute(client: &Client, args: Self::Args, prev: Vec) -> Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_prev` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `TrackList` is never used [INFO] [stdout] --> src/components/mod.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | pub type TrackList = Vec; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `NonExhaustive` is never used [INFO] [stdout] --> src/components/mod.rs:21:10 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum NonExhaustive { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `unwrap` is never used [INFO] [stdout] --> src/components/mod.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl NonExhaustive { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] 27 | pub fn unwrap(self) -> T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `execute` is never used [INFO] [stdout] --> src/components/mod.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub trait Executable { [INFO] [stdout] | ---------- associated function in this trait [INFO] [stdout] ... [INFO] [stdout] 42 | fn execute(client: &Client, args: Self::Args, prev: Vec) -> Result; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `name` and `execute` are never used [INFO] [stdout] --> src/components/mod.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 79 | impl Component { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 87 | pub fn name(&self) -> &'static str { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn execute(self, client: &Client, prev: Vec) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | / components![ [INFO] [stdout] 113 | | // Sources [INFO] [stdout] 114 | | ("source:artist_top_tracks", "Artist's top tracks", ArtistTopTracks), [INFO] [stdout] 115 | | ("source:album", "Album tracks", Album), [INFO] [stdout] ... | [INFO] [stdout] 121 | | ("filter:dedup_track", "Deduplicate tracks by ID", DeduplicateTrack) [INFO] [stdout] 122 | | ]; [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `components` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Op` is never used [INFO] [stdout] --> src/controller.rs:18:10 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum Op { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Constraint` is never constructed [INFO] [stdout] --> src/controller.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | struct Constraint { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Cache` is never used [INFO] [stdout] --> src/controller.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub type Cache = Arc>>; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Batch` is never used [INFO] [stdout] --> src/controller.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 33 | pub type Batch = Vec; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Schedule` is never used [INFO] [stdout] --> src/controller.rs:34:10 [INFO] [stdout] | [INFO] [stdout] 34 | pub type Schedule = Vec; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Edge` is never used [INFO] [stdout] --> src/controller.rs:38:10 [INFO] [stdout] | [INFO] [stdout] 38 | pub type Edge = (uuid::Uuid, uuid::Uuid); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserDefinedFlow` is never constructed [INFO] [stdout] --> src/controller.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct UserDefinedFlow { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `build_schedule`, `execute`, and `execute_batch` are never used [INFO] [stdout] --> src/controller.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 46 | impl UserDefinedFlow { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 71 | fn build_schedule(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 179 | pub fn execute(&self) -> Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 187 | pub fn execute_batch(&self, batch: &Batch, cache: &Cache) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/components/sources/source_user_liked_tracks.rs:22:33 [INFO] [stdout] | [INFO] [stdout] 22 | fn execute(client: &Client, args: Self::Args, prev: Vec) -> Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev` [INFO] [stdout] --> src/components/sources/source_user_liked_tracks.rs:22:51 [INFO] [stdout] | [INFO] [stdout] 22 | fn execute(client: &Client, args: Self::Args, prev: Vec) -> Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_prev` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/cache.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | RedisPoolError(mobc::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/cache.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | RedisCMDError(mobc_redis::redis::RedisError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/cache.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | RedisClientError(mobc_redis::redis::RedisError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Redis` [INFO] [stdout] --> src/cache.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / pub enum Error { [INFO] [stdout] 22 | | #[display(fmt = "could not get redis connection from pool : {}", _0)] [INFO] [stdout] 23 | | RedisPoolError(mobc::Error), [INFO] [stdout] 24 | | #[display(fmt = "error executing redis command: {}", _0)] [INFO] [stdout] ... | [INFO] [stdout] 27 | | RedisClientError(mobc_redis::redis::RedisError), [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/cache.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if username != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!username.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `cache::Error` [INFO] [stdout] --> src/cache.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | Error::RedisPoolError(e).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::RedisPoolError(e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache.rs:76:37 [INFO] [stdout] | [INFO] [stdout] 76 | let mut con: RedisCon = get_con(&pool).await?; [INFO] [stdout] | ^^^^^ help: change this to: `pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cache.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | if reset == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!reset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cache.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if exists == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `exists` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an outer doc comment and does not apply to the parent module or crate [INFO] [stdout] --> src/components/sources/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | ///! Sources take user-defined arguments and return TrackLists [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments [INFO] [stdout] = note: `#[warn(clippy::suspicious_doc_comments)]` on by default [INFO] [stdout] help: use an inner doc comment to document the parent module or crate [INFO] [stdout] | [INFO] [stdout] 1 - ///! Sources take user-defined arguments and return TrackLists [INFO] [stdout] 1 + //! Sources take user-defined arguments and return TrackLists [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/controller.rs:194:47 [INFO] [stdout] | [INFO] [stdout] 194 | let result_cache = Arc::clone(&cache); [INFO] [stdout] | ^^^^^^ help: change this to: `cache` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handlers/auth.rs:45:15 [INFO] [stdout] | [INFO] [stdout] 45 | .bind(&spotify_user.id.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `spotify_user.id.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handlers/auth.rs:69:23 [INFO] [stdout] | [INFO] [stdout] 69 | .bind(&spotify_user.id.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `spotify_user.id.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/models.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | impl Into for Token { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 89 ~ impl From for String { [INFO] [stdout] 90 ~ fn from(val: Token) -> Self { [INFO] [stdout] 91 ~ serde_json::to_string(&val.0).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/spotify/mod.rs:57:37 [INFO] [stdout] | [INFO] [stdout] 57 | match spotify.request_token(&code) { [INFO] [stdout] | ^^^^^ help: change this to: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `unwrap` is never used [INFO] [stdout] --> src/components/mod.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl NonExhaustive { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] 27 | pub fn unwrap(self) -> T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `name` and `execute` are never used [INFO] [stdout] --> src/components/mod.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 79 | impl Component { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 87 | pub fn name(&self) -> &'static str { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn execute(self, client: &Client, prev: Vec) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | / components![ [INFO] [stdout] 113 | | // Sources [INFO] [stdout] 114 | | ("source:artist_top_tracks", "Artist's top tracks", ArtistTopTracks), [INFO] [stdout] 115 | | ("source:album", "Album tracks", Album), [INFO] [stdout] ... | [INFO] [stdout] 121 | | ("filter:dedup_track", "Deduplicate tracks by ID", DeduplicateTrack) [INFO] [stdout] 122 | | ]; [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `components` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Op` is never used [INFO] [stdout] --> src/controller.rs:18:10 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum Op { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Constraint` is never constructed [INFO] [stdout] --> src/controller.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | struct Constraint { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Cache` is never used [INFO] [stdout] --> src/controller.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | pub type Cache = Arc>>; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `execute` and `execute_batch` are never used [INFO] [stdout] --> src/controller.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 46 | impl UserDefinedFlow { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 179 | pub fn execute(&self) -> Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 187 | pub fn execute_batch(&self, batch: &Batch, cache: &Cache) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/cache.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | RedisPoolError(mobc::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/cache.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | RedisCMDError(mobc_redis::redis::RedisError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/cache.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | RedisClientError(mobc_redis::redis::RedisError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Redis` [INFO] [stdout] --> src/cache.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / pub enum Error { [INFO] [stdout] 22 | | #[display(fmt = "could not get redis connection from pool : {}", _0)] [INFO] [stdout] 23 | | RedisPoolError(mobc::Error), [INFO] [stdout] 24 | | #[display(fmt = "error executing redis command: {}", _0)] [INFO] [stdout] ... | [INFO] [stdout] 27 | | RedisClientError(mobc_redis::redis::RedisError), [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/cache.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if username != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!username.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `cache::Error` [INFO] [stdout] --> src/cache.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | Error::RedisPoolError(e).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::RedisPoolError(e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache.rs:76:37 [INFO] [stdout] | [INFO] [stdout] 76 | let mut con: RedisCon = get_con(&pool).await?; [INFO] [stdout] | ^^^^^ help: change this to: `pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cache.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | if reset == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!reset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cache.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if exists == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `exists` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/components/filters/filter_dedup_artist.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / let mut tracklist = Vec::new(); [INFO] [stdout] 96 | | [INFO] [stdout] 97 | | // Track 1 - Artist A [INFO] [stdout] 98 | | tracklist.push(create_test_track("track1", vec!["artistA"])); [INFO] [stdout] ... | [INFO] [stdout] 110 | | tracklist.push(create_test_track("track5", vec!["artistB"])); [INFO] [stdout] | |_____________________________________________________________________^ help: consider using the `vec![]` macro: `let tracklist = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/components/filters/filter_dedup_artist.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | / let mut tracklist = Vec::new(); [INFO] [stdout] 129 | | [INFO] [stdout] 130 | | // Track 1 - Primary Artist A (with secondary B) [INFO] [stdout] 131 | | tracklist.push(create_test_track("track1", vec!["artistA", "artistB"])); [INFO] [stdout] ... | [INFO] [stdout] 143 | | tracklist.push(create_test_track("track4", vec!["artistB"])); [INFO] [stdout] | |_____________________________________________________________________^ help: consider using the `vec![]` macro: `let tracklist = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/components/filters/filter_dedup_artist.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | / let mut tracklist = Vec::new(); [INFO] [stdout] 174 | | tracklist.push(create_test_track("track1", vec![])); [INFO] [stdout] | |____________________________________________________________^ help: consider using the `vec![]` macro: `let tracklist = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/components/filters/filter_dedup_track.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / let mut tracklist = Vec::new(); [INFO] [stdout] 99 | | [INFO] [stdout] 100 | | // Unique track 1 [INFO] [stdout] 101 | | tracklist.push(create_test_track("track1", vec!["artistA"])); [INFO] [stdout] ... | [INFO] [stdout] 113 | | tracklist.push(create_test_track("track2", vec!["artistB"])); [INFO] [stdout] | |_____________________________________________________________________^ help: consider using the `vec![]` macro: `let tracklist = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an outer doc comment and does not apply to the parent module or crate [INFO] [stdout] --> src/components/sources/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | ///! Sources take user-defined arguments and return TrackLists [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments [INFO] [stdout] = note: `#[warn(clippy::suspicious_doc_comments)]` on by default [INFO] [stdout] help: use an inner doc comment to document the parent module or crate [INFO] [stdout] | [INFO] [stdout] 1 - ///! Sources take user-defined arguments and return TrackLists [INFO] [stdout] 1 + //! Sources take user-defined arguments and return TrackLists [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/controller.rs:194:47 [INFO] [stdout] | [INFO] [stdout] 194 | let result_cache = Arc::clone(&cache); [INFO] [stdout] | ^^^^^^ help: change this to: `cache` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/controller.rs:266:58 [INFO] [stdout] | [INFO] [stdout] 266 | let flow: UserDefinedFlow = serde_yaml::from_str(&TEST_YAML).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `TEST_YAML` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/controller.rs:273:58 [INFO] [stdout] | [INFO] [stdout] 273 | let flow: UserDefinedFlow = serde_yaml::from_str(&TEST_YAML).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `TEST_YAML` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handlers/auth.rs:45:15 [INFO] [stdout] | [INFO] [stdout] 45 | .bind(&spotify_user.id.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `spotify_user.id.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handlers/auth.rs:69:23 [INFO] [stdout] | [INFO] [stdout] 69 | .bind(&spotify_user.id.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `spotify_user.id.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/models.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | impl Into for Token { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 89 ~ impl From for String { [INFO] [stdout] 90 ~ fn from(val: Token) -> Self { [INFO] [stdout] 91 ~ serde_json::to_string(&val.0).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/spotify/mod.rs:57:37 [INFO] [stdout] | [INFO] [stdout] 57 | match spotify.request_token(&code) { [INFO] [stdout] | ^^^^^ help: change this to: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `Command { std: "docker" "inspect" "6f247690677ea233134986314718556e329733be016394143ee14db65a940b59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f247690677ea233134986314718556e329733be016394143ee14db65a940b59", kill_on_drop: false }` [INFO] [stdout] 6f247690677ea233134986314718556e329733be016394143ee14db65a940b59