[INFO] cloning repository https://github.com/belfz/sidera [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/belfz/sidera" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbelfz%2Fsidera", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbelfz%2Fsidera'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7f2927df5d4bfceafaa66d5c33153d4c3010f5fe [INFO] linting belfz/sidera against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbelfz%2Fsidera" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/belfz/sidera [INFO] finished tweaking git repo https://github.com/belfz/sidera [INFO] tweaked toml for git repo https://github.com/belfz/sidera written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/belfz/sidera on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/belfz/sidera already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6b7816408de60c9751dcce9c7f3ea80d448c49f890ab849b814158a0b4e4337 [INFO] running `Command { std: "docker" "start" "-a" "e6b7816408de60c9751dcce9c7f3ea80d448c49f890ab849b814158a0b4e4337", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6b7816408de60c9751dcce9c7f3ea80d448c49f890ab849b814158a0b4e4337", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6b7816408de60c9751dcce9c7f3ea80d448c49f890ab849b814158a0b4e4337", kill_on_drop: false }` [INFO] [stdout] e6b7816408de60c9751dcce9c7f3ea80d448c49f890ab849b814158a0b4e4337 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 760a7dc4ee050e78f551c919dd8b62bc14f5e0fd8d9c947fda49fd87d6b55c13 [INFO] running `Command { std: "docker" "start" "-a" "760a7dc4ee050e78f551c919dd8b62bc14f5e0fd8d9c947fda49fd87d6b55c13", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.115 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling built v0.8.0 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking avif-serialize v0.8.8 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking jiff v0.2.20 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Checking rustix v1.1.3 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking tempfile v3.25.0 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking simba v0.9.1 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking nalgebra v0.33.2 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking astro-core v0.1.0 (/opt/rustwide/workdir/crates/astro-core) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/astro-core/src/alignment.rs:176:34 [INFO] [stdout] | [INFO] [stdout] 176 | fn estimate_translation(matches: &[((f64, f64), (f64, f64))]) -> Transform { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/astro-core/src/alignment.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 197 | matches: &[((f64, f64), (f64, f64))], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/astro-core/src/alignment.rs:347:5 [INFO] [stdout] | [INFO] [stdout] 347 | votes.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 347 - votes.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 347 + votes.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/astro-core/src/alignment.rs:373:14 [INFO] [stdout] | [INFO] [stdout] 373 | matches: &[((f64, f64), (f64, f64))], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/astro-core/src/alignment.rs:502:37 [INFO] [stdout] | [INFO] [stdout] 502 | fn estimate_homography_dlt(matches: &[((f64, f64), (f64, f64))]) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> crates/astro-core/src/alignment.rs:525:16 [INFO] [stdout] | [INFO] [stdout] 525 | a_data[row1 * 9 + 0] = -tx; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider reducing it to: `(row1 * 9)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/astro-core/src/alignment.rs:176:34 [INFO] [stdout] | [INFO] [stdout] 176 | fn estimate_translation(matches: &[((f64, f64), (f64, f64))]) -> Transform { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/astro-core/src/alignment.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 197 | matches: &[((f64, f64), (f64, f64))], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> crates/astro-core/src/bayer.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 27 | | match s.trim().to_uppercase().as_str() { [INFO] [stdout] 28 | | "RGGB" => Some(BayerPattern::RGGB), [INFO] [stdout] 29 | | "BGGR" => Some(BayerPattern::BGGR), [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/astro-core/src/alignment.rs:347:5 [INFO] [stdout] | [INFO] [stdout] 347 | votes.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 347 - votes.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 347 + votes.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/astro-core/src/alignment.rs:373:14 [INFO] [stdout] | [INFO] [stdout] 373 | matches: &[((f64, f64), (f64, f64))], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> crates/astro-core/src/alignment.rs:502:37 [INFO] [stdout] | [INFO] [stdout] 502 | fn estimate_homography_dlt(matches: &[((f64, f64), (f64, f64))]) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> crates/astro-core/src/alignment.rs:525:16 [INFO] [stdout] | [INFO] [stdout] 525 | a_data[row1 * 9 + 0] = -tx; [INFO] [stdout] | ^^^^^^^^^^^^ help: consider reducing it to: `(row1 * 9)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> crates/astro-core/src/bayer.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 27 | | match s.trim().to_uppercase().as_str() { [INFO] [stdout] 28 | | "RGGB" => Some(BayerPattern::RGGB), [INFO] [stdout] 29 | | "BGGR" => Some(BayerPattern::BGGR), [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> crates/astro-core/src/fits_io.rs:104:28 [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(end) = raw[1..].find('\'') { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> crates/astro-core/src/fits_io.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | if raw.starts_with('\'') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 102 ~ if let Some() = raw.strip_prefix('\'') { [INFO] [stdout] 103 | // Find the closing quote [INFO] [stdout] 104 ~ if let Some(end) = .find('\'') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `grid` [INFO] [stdout] --> crates/astro-core/src/gradient.rs:48:22 [INFO] [stdout] | [INFO] [stdout] 48 | for c in 0..ch { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 48 - for c in 0..ch { [INFO] [stdout] 48 + for (c, ) in grid.iter_mut().enumerate().take(ch) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `grid` [INFO] [stdout] --> crates/astro-core/src/gradient.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 72 | for c in 0..ch { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 72 - for c in 0..ch { [INFO] [stdout] 72 + for (c, ) in grid.iter().enumerate().take(ch) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> crates/astro-core/src/histogram.rs:311:23 [INFO] [stdout] | [INFO] [stdout] 311 | let midtones = if normalized_median >= 0.001 && normalized_median <= 0.999 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.001..=0.999).contains(&normalized_median)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> crates/astro-core/src/fits_io.rs:104:28 [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(end) = raw[1..].find('\'') { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> crates/astro-core/src/fits_io.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | if raw.starts_with('\'') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 102 ~ if let Some() = raw.strip_prefix('\'') { [INFO] [stdout] 103 | // Find the closing quote [INFO] [stdout] 104 ~ if let Some(end) = .find('\'') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/astro-core/src/stacking.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 124 | if n % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `n.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> crates/astro-core/src/stacking.rs:132:37 [INFO] [stdout] | [INFO] [stdout] 132 | fn stack_sigma_clipped_mean(values: &mut Vec, kappa: f64, max_iterations: usize) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 132 ~ fn stack_sigma_clipped_mean(values: &mut [f32], kappa: f64, max_iterations: usize) -> f32 { [INFO] [stdout] 133 | if values.len() <= 2 { [INFO] [stdout] ... [INFO] [stdout] 136 | [INFO] [stdout] 137 ~ let mut working: Vec = values.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> crates/astro-core/src/stacking.rs:177:39 [INFO] [stdout] | [INFO] [stdout] 177 | fn stack_sigma_clipped_median(values: &mut Vec, kappa: f64, max_iterations: usize) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 177 ~ fn stack_sigma_clipped_median(values: &mut [f32], kappa: f64, max_iterations: usize) -> f32 { [INFO] [stdout] 178 | if values.len() <= 2 { [INFO] [stdout] ... [INFO] [stdout] 181 | [INFO] [stdout] 182 ~ let mut working: Vec = values.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `grid` [INFO] [stdout] --> crates/astro-core/src/gradient.rs:48:22 [INFO] [stdout] | [INFO] [stdout] 48 | for c in 0..ch { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 48 - for c in 0..ch { [INFO] [stdout] 48 + for (c, ) in grid.iter_mut().enumerate().take(ch) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `grid` [INFO] [stdout] --> crates/astro-core/src/gradient.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 72 | for c in 0..ch { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 72 - for c in 0..ch { [INFO] [stdout] 72 + for (c, ) in grid.iter().enumerate().take(ch) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> crates/astro-core/src/star_detection.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 145 | let grid_w = (w + grid - 1) / grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(grid)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> crates/astro-core/src/star_detection.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 146 | let grid_h = (h + grid - 1) / grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `h.div_ceil(grid)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> crates/astro-core/src/star_detection.rs:199:32 [INFO] [stdout] | [INFO] [stdout] 199 | fn sigma_clipped_stats(values: &mut Vec, clip_sigma: f64, iterations: usize) -> (f64, f64) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 199 ~ fn sigma_clipped_stats(values: &mut [f64], clip_sigma: f64, iterations: usize) -> (f64, f64) { [INFO] [stdout] 200 | if values.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 204 | values.sort_by(|a, b| a.partial_cmp(b).unwrap()); [INFO] [stdout] 205 ~ let mut working = values.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/astro-core/src/lib.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | / impl Default for Pipeline { [INFO] [stdout] 36 | | fn default() -> Self { [INFO] [stdout] 37 | | Pipeline { [INFO] [stdout] 38 | | bias_paths: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 23 + #[derive(Default)] [INFO] [stdout] 24 | pub struct Pipeline { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> crates/astro-core/src/histogram.rs:311:23 [INFO] [stdout] | [INFO] [stdout] 311 | let midtones = if normalized_median >= 0.001 && normalized_median <= 0.999 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.001..=0.999).contains(&normalized_median)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> crates/astro-core/src/lib.rs:399:15 [INFO] [stdout] | [INFO] [stdout] 399 | path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 399 - path: &PathBuf, [INFO] [stdout] 399 + path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `channel_medians` [INFO] [stdout] --> crates/astro-core/src/lib.rs:543:14 [INFO] [stdout] | [INFO] [stdout] 543 | for c in 0..image.channels.min(3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 543 - for c in 0..image.channels.min(3) { [INFO] [stdout] 543 + for (c, ) in channel_medians.iter().enumerate().take(image.channels.min(3)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/astro-core/src/stacking.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 124 | if n % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `n.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> crates/astro-core/src/stacking.rs:132:37 [INFO] [stdout] | [INFO] [stdout] 132 | fn stack_sigma_clipped_mean(values: &mut Vec, kappa: f64, max_iterations: usize) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 132 ~ fn stack_sigma_clipped_mean(values: &mut [f32], kappa: f64, max_iterations: usize) -> f32 { [INFO] [stdout] 133 | if values.len() <= 2 { [INFO] [stdout] ... [INFO] [stdout] 136 | [INFO] [stdout] 137 ~ let mut working: Vec = values.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> crates/astro-core/src/stacking.rs:177:39 [INFO] [stdout] | [INFO] [stdout] 177 | fn stack_sigma_clipped_median(values: &mut Vec, kappa: f64, max_iterations: usize) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 177 ~ fn stack_sigma_clipped_median(values: &mut [f32], kappa: f64, max_iterations: usize) -> f32 { [INFO] [stdout] 178 | if values.len() <= 2 { [INFO] [stdout] ... [INFO] [stdout] 181 | [INFO] [stdout] 182 ~ let mut working: Vec = values.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> crates/astro-core/src/star_detection.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 145 | let grid_w = (w + grid - 1) / grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(grid)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> crates/astro-core/src/star_detection.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 146 | let grid_h = (h + grid - 1) / grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `h.div_ceil(grid)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> crates/astro-core/src/star_detection.rs:199:32 [INFO] [stdout] | [INFO] [stdout] 199 | fn sigma_clipped_stats(values: &mut Vec, clip_sigma: f64, iterations: usize) -> (f64, f64) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 199 ~ fn sigma_clipped_stats(values: &mut [f64], clip_sigma: f64, iterations: usize) -> (f64, f64) { [INFO] [stdout] 200 | if values.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 204 | values.sort_by(|a, b| a.partial_cmp(b).unwrap()); [INFO] [stdout] 205 ~ let mut working = values.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> crates/astro-core/src/lib.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | / impl Default for Pipeline { [INFO] [stdout] 36 | | fn default() -> Self { [INFO] [stdout] 37 | | Pipeline { [INFO] [stdout] 38 | | bias_paths: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 23 + #[derive(Default)] [INFO] [stdout] 24 | pub struct Pipeline { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking astro-cli v0.1.0 (/opt/rustwide/workdir/crates/astro-cli) [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> crates/astro-core/src/lib.rs:399:15 [INFO] [stdout] | [INFO] [stdout] 399 | path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 399 - path: &PathBuf, [INFO] [stdout] 399 + path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `channel_medians` [INFO] [stdout] --> crates/astro-core/src/lib.rs:543:14 [INFO] [stdout] | [INFO] [stdout] 543 | for c in 0..image.channels.min(3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 543 - for c in 0..image.channels.min(3) { [INFO] [stdout] 543 + for (c, ) in channel_medians.iter().enumerate().take(image.channels.min(3)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/astro-core/examples/test_align.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | .filter(|e| e.path().extension().map_or(false, |ext| ext == "fits")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 23 - .filter(|e| e.path().extension().map_or(false, |ext| ext == "fits")) [INFO] [stdout] 23 + .filter(|e| e.path().extension().is_some_and(|ext| ext == "fits")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::cmp::Ordering` [INFO] [stdout] --> crates/astro-core/examples/inspect_fits.rs:52:27 [INFO] [stdout] | [INFO] [stdout] 52 | sorted.sort_by(|a, b| a.partial_cmp(b).unwrap().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `a.partial_cmp(b).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::cmp::Ordering` [INFO] [stdout] --> crates/astro-core/examples/inspect_fits.rs:95:36 [INFO] [stdout] | [INFO] [stdout] 95 | ch_vals.sort_by(|a, b| a.partial_cmp(b).unwrap().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `a.partial_cmp(b).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> crates/astro-core/examples/test_stars.rs:26:45 [INFO] [stdout] | [INFO] [stdout] 26 | let mut vals: Vec = calibrated.data.iter().copied().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/astro-core/examples/test_pipeline.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | .filter(|e| e.path().extension().map_or(false, |ext| ext == "fits")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 17 - .filter(|e| e.path().extension().map_or(false, |ext| ext == "fits")) [INFO] [stdout] 17 + .filter(|e| e.path().extension().is_some_and(|ext| ext == "fits")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/astro-core/examples/test_pipeline.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | .filter(|e| e.path().extension().map_or(false, |ext| ext == "fits")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 25 - .filter(|e| e.path().extension().map_or(false, |ext| ext == "fits")) [INFO] [stdout] 25 + .filter(|e| e.path().extension().is_some_and(|ext| ext == "fits")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> crates/astro-core/examples/test_pipeline.rs:60:49 [INFO] [stdout] | [INFO] [stdout] 60 | let mut vals: Vec = result.data.iter().copied().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 43.35s [INFO] running `Command { std: "docker" "inspect" "760a7dc4ee050e78f551c919dd8b62bc14f5e0fd8d9c947fda49fd87d6b55c13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "760a7dc4ee050e78f551c919dd8b62bc14f5e0fd8d9c947fda49fd87d6b55c13", kill_on_drop: false }` [INFO] [stdout] 760a7dc4ee050e78f551c919dd8b62bc14f5e0fd8d9c947fda49fd87d6b55c13