[INFO] cloning repository https://github.com/bauom/evalcraft [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bauom/evalcraft" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbauom%2Fevalcraft", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbauom%2Fevalcraft'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 28393f41dda3a07703175056ba948992225e4783 [INFO] linting bauom/evalcraft against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbauom%2Fevalcraft" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bauom/evalcraft [INFO] finished tweaking git repo https://github.com/bauom/evalcraft [INFO] tweaked toml for git repo https://github.com/bauom/evalcraft written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bauom/evalcraft on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bauom/evalcraft already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded async-convert v1.0.0 [INFO] [stderr] Downloaded iso8601 v0.6.3 [INFO] [stderr] Downloaded async-openai v0.23.4 [INFO] [stderr] Downloaded jsonschema v0.18.3 [INFO] [stderr] Downloaded fraction v0.15.3 [INFO] [stderr] Downloaded cc v1.2.45 [INFO] [stderr] Downloaded sqlparser v0.52.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a4d2d78f7957d2210a1703e6dbcd55cb194d09530ebd90c21d53412edcf52e22 [INFO] running `Command { std: "docker" "start" "-a" "a4d2d78f7957d2210a1703e6dbcd55cb194d09530ebd90c21d53412edcf52e22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a4d2d78f7957d2210a1703e6dbcd55cb194d09530ebd90c21d53412edcf52e22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4d2d78f7957d2210a1703e6dbcd55cb194d09530ebd90c21d53412edcf52e22", kill_on_drop: false }` [INFO] [stdout] a4d2d78f7957d2210a1703e6dbcd55cb194d09530ebd90c21d53412edcf52e22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d25fb727824c808076c7cc147b99d66b523e1aa466b888aff3eb741a075d59aa [INFO] running `Command { std: "docker" "start" "-a" "d25fb727824c808076c7cc147b99d66b523e1aa466b888aff3eb741a075d59aa", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.45 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Checking rustls-pki-types v1.13.0 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking bytecount v0.6.9 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking testing_table v0.3.0 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking num-cmp v0.1.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking papergrid v0.17.0 [INFO] [stderr] Checking sqlparser v0.52.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking rustls-native-certs v0.8.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking eventsource-stream v0.2.3 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking iso8601 v0.6.3 [INFO] [stderr] Checking fraction v0.15.3 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tabled_derive v0.11.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking async-convert v1.0.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tabled v0.20.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.51 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking evalcraft-types v0.1.0 (/opt/rustwide/workdir/crates/evalcraft-types) [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking evalcraft-store v0.1.0 (/opt/rustwide/workdir/crates/evalcraft-store) [INFO] [stderr] Checking hyper v1.8.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking jsonschema v0.18.3 [INFO] [stderr] Checking reqwest-eventsource v0.6.0 [INFO] [stderr] Checking async-openai v0.23.4 [INFO] [stderr] Checking evalcraft-core v0.1.0 (/opt/rustwide/workdir/crates/evalcraft-core) [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> crates/evalcraft-core/src/datasource.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | / Ok(fs::read_to_string(path) [INFO] [stdout] 85 | | .await [INFO] [stdout] 86 | | .with_context(|| format!("Failed to read {:?}", path))?) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 84 ~ fs::read_to_string(path) [INFO] [stdout] 85 | .await [INFO] [stdout] 86 ~ .with_context(|| format!("Failed to read {:?}", path)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EvalBuilder` [INFO] [stdout] --> crates/evalcraft-core/src/runner.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | data_source: None, [INFO] [stdout] 22 | | task: None, [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for EvalBuilder { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/evalcraft-core/src/runner.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 144 | let stream = stream::iter(cases.into_iter()).map(move |case| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/stream/iter.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 144 - let stream = stream::iter(cases.into_iter()).map(move |case| { [INFO] [stdout] 144 + let stream = stream::iter(cases).map(move |case| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> crates/evalcraft-core/src/scorers/sql.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | fn to_dialect(&self) -> Box { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking evalcraft-cli v0.1.0 (/opt/rustwide/workdir/crates/evalcraft-cli) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:81:14 [INFO] [stdout] | [INFO] [stdout] 81 | cmd.args(&["--examples", "--tests"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--examples", "--tests"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:81:14 [INFO] [stdout] | [INFO] [stdout] 81 | cmd.args(&["--examples", "--tests"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--examples", "--tests"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 84 | cmd.args(&["--features", "evalcraft-core/persistence"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--features", "evalcraft-core/persistence"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 84 | cmd.args(&["--features", "evalcraft-core/persistence"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--features", "evalcraft-core/persistence"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:139:33 [INFO] [stdout] | [INFO] [stdout] 139 | .filter(|p| p.extension().map_or(false, |ext| ext == "rs" || ext == "toml")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 139 - .filter(|p| p.extension().map_or(false, |ext| ext == "rs" || ext == "toml")) [INFO] [stdout] 139 + .filter(|p| p.extension().is_some_and(|ext| ext == "rs" || ext == "toml")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:146:31 [INFO] [stdout] | [INFO] [stdout] 146 | while let Ok(_) = rx.recv_timeout(Duration::from_millis(100)) {} [INFO] [stdout] | ----------^^^^^---------------------------------------------- help: try: `while rx.recv_timeout(Duration::from_millis(100)).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:139:33 [INFO] [stdout] | [INFO] [stdout] 139 | .filter(|p| p.extension().map_or(false, |ext| ext == "rs" || ext == "toml")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 139 - .filter(|p| p.extension().map_or(false, |ext| ext == "rs" || ext == "toml")) [INFO] [stdout] 139 + .filter(|p| p.extension().is_some_and(|ext| ext == "rs" || ext == "toml")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:146:31 [INFO] [stdout] | [INFO] [stdout] 146 | while let Ok(_) = rx.recv_timeout(Duration::from_millis(100)) {} [INFO] [stdout] | ----------^^^^^---------------------------------------------- help: try: `while rx.recv_timeout(Duration::from_millis(100)).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 180 | if file_path.to_str().map_or(false, |p| p.contains("examples/")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 180 - if file_path.to_str().map_or(false, |p| p.contains("examples/")) { [INFO] [stdout] 180 + if file_path.to_str().is_some_and(|p| p.contains("examples/")) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 180 | if file_path.to_str().map_or(false, |p| p.contains("examples/")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 180 - if file_path.to_str().map_or(false, |p| p.contains("examples/")) { [INFO] [stdout] 180 + if file_path.to_str().is_some_and(|p| p.contains("examples/")) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if file_path.to_str().map_or(false, |p| p.contains("tests/")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 188 - if file_path.to_str().map_or(false, |p| p.contains("tests/")) { [INFO] [stdout] 188 + if file_path.to_str().is_some_and(|p| p.contains("tests/")) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if file_path.to_str().map_or(false, |p| p.contains("tests/")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 188 - if file_path.to_str().map_or(false, |p| p.contains("tests/")) { [INFO] [stdout] 188 + if file_path.to_str().is_some_and(|p| p.contains("tests/")) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:212:14 [INFO] [stdout] | [INFO] [stdout] 212 | cmd.args(&["--example", test_name]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--example", test_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:215:14 [INFO] [stdout] | [INFO] [stdout] 215 | cmd.args(&["--features", "evalcraft-core/persistence"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--features", "evalcraft-core/persistence"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:212:14 [INFO] [stdout] | [INFO] [stdout] 212 | cmd.args(&["--example", test_name]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--example", test_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/evalcraft-cli/src/main.rs:215:14 [INFO] [stdout] | [INFO] [stdout] 215 | cmd.args(&["--features", "evalcraft-core/persistence"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--features", "evalcraft-core/persistence"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> crates/evalcraft-core/../../examples/test_example.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `evalcraft_core::*` [INFO] [stdout] --> crates/evalcraft-core/../../examples/test_example.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use evalcraft_core::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::json` [INFO] [stdout] --> crates/evalcraft-core/../../examples/test_example.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use serde_json::json; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `outer.get(0)` [INFO] [stdout] --> crates/evalcraft-core/../../examples/localhost_llm.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | .and_then(|outer| outer.get(0)) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `outer.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `emb_outer.get(0)` [INFO] [stdout] --> crates/evalcraft-core/../../examples/localhost_llm.rs:45:39 [INFO] [stdout] | [INFO] [stdout] 45 | .and_then(|emb_outer| emb_outer.get(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `emb_outer.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `traces` [INFO] [stdout] --> crates/evalcraft-core/src/trace.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | let (_, traces) = scope_traces(async { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_traces` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> crates/evalcraft-core/src/datasource.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | / Ok(fs::read_to_string(path) [INFO] [stdout] 85 | | .await [INFO] [stdout] 86 | | .with_context(|| format!("Failed to read {:?}", path))?) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 84 ~ fs::read_to_string(path) [INFO] [stdout] 85 | .await [INFO] [stdout] 86 ~ .with_context(|| format!("Failed to read {:?}", path)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EvalBuilder` [INFO] [stdout] --> crates/evalcraft-core/src/runner.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | data_source: None, [INFO] [stdout] 22 | | task: None, [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for EvalBuilder { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/evalcraft-core/src/runner.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 144 | let stream = stream::iter(cases.into_iter()).map(move |case| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/stream/iter.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 144 - let stream = stream::iter(cases.into_iter()).map(move |case| { [INFO] [stdout] 144 + let stream = stream::iter(cases).map(move |case| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> crates/evalcraft-core/src/scorers/sql.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | fn to_dialect(&self) -> Box { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `Command { std: "docker" "inspect" "d25fb727824c808076c7cc147b99d66b523e1aa466b888aff3eb741a075d59aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d25fb727824c808076c7cc147b99d66b523e1aa466b888aff3eb741a075d59aa", kill_on_drop: false }` [INFO] [stdout] d25fb727824c808076c7cc147b99d66b523e1aa466b888aff3eb741a075d59aa