[INFO] cloning repository https://github.com/basicallygit/cee-project-manager [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/basicallygit/cee-project-manager" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbasicallygit%2Fcee-project-manager", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbasicallygit%2Fcee-project-manager'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 70d633b070ac4ace579723ad09a949729cf26196 [INFO] linting basicallygit/cee-project-manager against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbasicallygit%2Fcee-project-manager" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/basicallygit/cee-project-manager [INFO] finished tweaking git repo https://github.com/basicallygit/cee-project-manager [INFO] tweaked toml for git repo https://github.com/basicallygit/cee-project-manager written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/basicallygit/cee-project-manager on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/basicallygit/cee-project-manager already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded console v0.15.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] baf0720817a2e900bcc8186b8ec0d091d3b3fa18b2f0c09563630d882463b1f9 [INFO] running `Command { std: "docker" "start" "-a" "baf0720817a2e900bcc8186b8ec0d091d3b3fa18b2f0c09563630d882463b1f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "baf0720817a2e900bcc8186b8ec0d091d3b3fa18b2f0c09563630d882463b1f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "baf0720817a2e900bcc8186b8ec0d091d3b3fa18b2f0c09563630d882463b1f9", kill_on_drop: false }` [INFO] [stdout] baf0720817a2e900bcc8186b8ec0d091d3b3fa18b2f0c09563630d882463b1f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cecd347731269fb5e5bdd8007dcc3b0a387efa3aec948f38f7efa7e86bb7db0f [INFO] running `Command { std: "docker" "start" "-a" "cecd347731269fb5e5bdd8007dcc3b0a387efa3aec948f38f7efa7e86bb7db0f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking console v0.15.1 [INFO] [stderr] Checking cee v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/configparser/mod.rs:16:29 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn get_value(file_line: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - pub fn get_value(file_line: &String) -> String { [INFO] [stdout] 16 + pub fn get_value(file_line: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/configparser/mod.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / for line in lines { [INFO] [stdout] 39 | | if let Ok(linecontents) = line { [INFO] [stdout] 40 | | [INFO] [stdout] 41 | | if linecontents.starts_with("LANG") { [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/configparser/mod.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / if let Ok(linecontents) = line { [INFO] [stdout] 40 | | [INFO] [stdout] 41 | | if linecontents.starts_with("LANG") { [INFO] [stdout] 42 | | LANGUAGE = get_value(&linecontents); [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 ~ for linecontents in lines.flatten() { [INFO] [stdout] 39 + [INFO] [stdout] 40 + if linecontents.starts_with("LANG") { [INFO] [stdout] 41 + LANGUAGE = get_value(&linecontents); [INFO] [stdout] 42 + } else if linecontents.starts_with("C_COMPILER") { [INFO] [stdout] 43 + CC = get_value(&linecontents); [INFO] [stdout] 44 + } else if linecontents.starts_with("CPP_COMPILER") { [INFO] [stdout] 45 + CPPC = get_value(&linecontents); [INFO] [stdout] 46 + } else if linecontents.starts_with("RELEASE_FLAGS") { [INFO] [stdout] 47 + RFLGS = get_value(&linecontents); [INFO] [stdout] 48 + } else if linecontents.starts_with("DEBUG_OUTPUT_FILE") { [INFO] [stdout] 49 + DBOF = get_value(&linecontents); [INFO] [stdout] 50 + } else if linecontents.starts_with("RELEASE_OUTPUT_FILE") { [INFO] [stdout] 51 + RLOF = get_value(&linecontents); [INFO] [stdout] 52 + } else if linecontents.starts_with("INPUT_SOURCE_FILE") { [INFO] [stdout] 53 + INPF = get_value(&linecontents); [INFO] [stdout] 54 + } else if linecontents.starts_with("VERS") { [INFO] [stdout] 55 + VERS = get_value(&linecontents); [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 126 | if !metadata("cee.conf").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("cee.conf").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | if !metadata("bin").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("bin").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if !metadata("bin/debug").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("bin/debug").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if !metadata("bin/release").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("bin/release").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / if argc >= 4 { [INFO] [stdout] 46 | | if argv[2] == "-l" || argv[2] == "--lang" { [INFO] [stdout] 47 | | let langflag = &argv[3].to_lowercase(); [INFO] [stdout] 48 | | if langflag == "cpp" { [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if argc >= 4 [INFO] [stdout] 46 ~ && (argv[2] == "-l" || argv[2] == "--lang") { [INFO] [stdout] 47 | let langflag = &argv[3].to_lowercase(); [INFO] [stdout] ... [INFO] [stdout] 54 | } [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | / if argc >= 5 { [INFO] [stdout] 87 | | if argv[3] == "-l" || argv[3] == "--lang" { [INFO] [stdout] 88 | | let langflag = argv[4].to_lowercase(); [INFO] [stdout] 89 | | if langflag == "cpp" || langflag == "c" { [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 86 ~ if argc >= 5 [INFO] [stdout] 87 ~ && (argv[3] == "-l" || argv[3] == "--lang") { [INFO] [stdout] 88 | let langflag = argv[4].to_lowercase(); [INFO] [stdout] ... [INFO] [stdout] 95 | } [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/configparser/mod.rs:16:29 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn get_value(file_line: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - pub fn get_value(file_line: &String) -> String { [INFO] [stdout] 16 + pub fn get_value(file_line: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/configparser/mod.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / for line in lines { [INFO] [stdout] 39 | | if let Ok(linecontents) = line { [INFO] [stdout] 40 | | [INFO] [stdout] 41 | | if linecontents.starts_with("LANG") { [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/configparser/mod.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / if let Ok(linecontents) = line { [INFO] [stdout] 40 | | [INFO] [stdout] 41 | | if linecontents.starts_with("LANG") { [INFO] [stdout] 42 | | LANGUAGE = get_value(&linecontents); [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 ~ for linecontents in lines.flatten() { [INFO] [stdout] 39 + [INFO] [stdout] 40 + if linecontents.starts_with("LANG") { [INFO] [stdout] 41 + LANGUAGE = get_value(&linecontents); [INFO] [stdout] 42 + } else if linecontents.starts_with("C_COMPILER") { [INFO] [stdout] 43 + CC = get_value(&linecontents); [INFO] [stdout] 44 + } else if linecontents.starts_with("CPP_COMPILER") { [INFO] [stdout] 45 + CPPC = get_value(&linecontents); [INFO] [stdout] 46 + } else if linecontents.starts_with("RELEASE_FLAGS") { [INFO] [stdout] 47 + RFLGS = get_value(&linecontents); [INFO] [stdout] 48 + } else if linecontents.starts_with("DEBUG_OUTPUT_FILE") { [INFO] [stdout] 49 + DBOF = get_value(&linecontents); [INFO] [stdout] 50 + } else if linecontents.starts_with("RELEASE_OUTPUT_FILE") { [INFO] [stdout] 51 + RLOF = get_value(&linecontents); [INFO] [stdout] 52 + } else if linecontents.starts_with("INPUT_SOURCE_FILE") { [INFO] [stdout] 53 + INPF = get_value(&linecontents); [INFO] [stdout] 54 + } else if linecontents.starts_with("VERS") { [INFO] [stdout] 55 + VERS = get_value(&linecontents); [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 126 | if !metadata("cee.conf").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("cee.conf").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | if !metadata("bin").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("bin").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if !metadata("bin/debug").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("bin/debug").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if !metadata("bin/release").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("bin/release").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `argv` [INFO] [stdout] --> src/main.rs:150:30 [INFO] [stdout] | [INFO] [stdout] 150 | for i in 3..argc { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 150 - for i in 3..argc { [INFO] [stdout] 150 + for in argv.iter().take(argc).skip(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | cmd_line_args.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `cmd_line_args.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `argv` [INFO] [stdout] --> src/main.rs:157:26 [INFO] [stdout] | [INFO] [stdout] 157 | for i in 2..argc { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 157 - for i in 2..argc { [INFO] [stdout] 157 + for in argv.iter().take(argc).skip(2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:159:21 [INFO] [stdout] | [INFO] [stdout] 159 | cmd_line_args.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `cmd_line_args.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/main.rs:172:26 [INFO] [stdout] | [INFO] [stdout] 172 | let output = Command::new(&compiler) [INFO] [stdout] | __________________________^ [INFO] [stdout] 173 | | .arg(format!("{}.{}", config.INPUT_SRC_FILE, config.LANG)) [INFO] [stdout] 174 | | .arg("-o") [INFO] [stdout] 175 | | .arg(format!("{}.{}", config.RELEASE_OUT_FILE, binary_extension)) [INFO] [stdout] 176 | | .args(releaseflags) [INFO] [stdout] 177 | | .stdout(Stdio::piped()) [INFO] [stdout] 178 | | .output().ok().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | |_________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 178 - .output().ok().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] 178 + .output().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:178:32 [INFO] [stdout] | [INFO] [stdout] 178 | ...().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / if argc >= 4 { [INFO] [stdout] 46 | | if argv[2] == "-l" || argv[2] == "--lang" { [INFO] [stdout] 47 | | let langflag = &argv[3].to_lowercase(); [INFO] [stdout] 48 | | if langflag == "cpp" { [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if argc >= 4 [INFO] [stdout] 46 ~ && (argv[2] == "-l" || argv[2] == "--lang") { [INFO] [stdout] 47 | let langflag = &argv[3].to_lowercase(); [INFO] [stdout] ... [INFO] [stdout] 54 | } [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/main.rs:193:26 [INFO] [stdout] | [INFO] [stdout] 193 | let output = Command::new(&compiler) [INFO] [stdout] | __________________________^ [INFO] [stdout] 194 | | .arg(format!("{}.{}", config.INPUT_SRC_FILE, config.LANG)) [INFO] [stdout] 195 | | .arg("-o") [INFO] [stdout] 196 | | .arg(format!("{}.{}", config.DEBUG_OUT_FILE, binary_extension)) [INFO] [stdout] 197 | | .output().ok().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | |_________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 197 - .output().ok().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] 197 + .output().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:197:32 [INFO] [stdout] | [INFO] [stdout] 197 | ...().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:219:16 [INFO] [stdout] | [INFO] [stdout] 219 | if cmd_line_args != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd_line_args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | / if argc >= 5 { [INFO] [stdout] 87 | | if argv[3] == "-l" || argv[3] == "--lang" { [INFO] [stdout] 88 | | let langflag = argv[4].to_lowercase(); [INFO] [stdout] 89 | | if langflag == "cpp" || langflag == "c" { [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 86 ~ if argc >= 5 [INFO] [stdout] 87 ~ && (argv[3] == "-l" || argv[3] == "--lang") { [INFO] [stdout] 88 | let langflag = argv[4].to_lowercase(); [INFO] [stdout] ... [INFO] [stdout] 95 | } [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `argv` [INFO] [stdout] --> src/main.rs:150:30 [INFO] [stdout] | [INFO] [stdout] 150 | for i in 3..argc { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 150 - for i in 3..argc { [INFO] [stdout] 150 + for in argv.iter().take(argc).skip(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | cmd_line_args.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `cmd_line_args.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `argv` [INFO] [stdout] --> src/main.rs:157:26 [INFO] [stdout] | [INFO] [stdout] 157 | for i in 2..argc { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 157 - for i in 2..argc { [INFO] [stdout] 157 + for in argv.iter().take(argc).skip(2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:159:21 [INFO] [stdout] | [INFO] [stdout] 159 | cmd_line_args.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `cmd_line_args.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/main.rs:172:26 [INFO] [stdout] | [INFO] [stdout] 172 | let output = Command::new(&compiler) [INFO] [stdout] | __________________________^ [INFO] [stdout] 173 | | .arg(format!("{}.{}", config.INPUT_SRC_FILE, config.LANG)) [INFO] [stdout] 174 | | .arg("-o") [INFO] [stdout] 175 | | .arg(format!("{}.{}", config.RELEASE_OUT_FILE, binary_extension)) [INFO] [stdout] 176 | | .args(releaseflags) [INFO] [stdout] 177 | | .stdout(Stdio::piped()) [INFO] [stdout] 178 | | .output().ok().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | |_________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 178 - .output().ok().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] 178 + .output().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:178:32 [INFO] [stdout] | [INFO] [stdout] 178 | ...().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/main.rs:193:26 [INFO] [stdout] | [INFO] [stdout] 193 | let output = Command::new(&compiler) [INFO] [stdout] | __________________________^ [INFO] [stdout] 194 | | .arg(format!("{}.{}", config.INPUT_SRC_FILE, config.LANG)) [INFO] [stdout] 195 | | .arg("-o") [INFO] [stdout] 196 | | .arg(format!("{}.{}", config.DEBUG_OUT_FILE, binary_extension)) [INFO] [stdout] 197 | | .output().ok().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | |_________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 197 - .output().ok().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] 197 + .output().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:197:32 [INFO] [stdout] | [INFO] [stdout] 197 | ...().expect(format!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("{} {}", error, style("building failed, do you have your compiler in your PATH variable?").color256(208)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:219:16 [INFO] [stdout] | [INFO] [stdout] 219 | if cmd_line_args != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmd_line_args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.05s [INFO] running `Command { std: "docker" "inspect" "cecd347731269fb5e5bdd8007dcc3b0a387efa3aec948f38f7efa7e86bb7db0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cecd347731269fb5e5bdd8007dcc3b0a387efa3aec948f38f7efa7e86bb7db0f", kill_on_drop: false }` [INFO] [stdout] cecd347731269fb5e5bdd8007dcc3b0a387efa3aec948f38f7efa7e86bb7db0f