[INFO] cloning repository https://github.com/bajrangCoder/file_manager [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bajrangCoder/file_manager" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FbajrangCoder%2Ffile_manager", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FbajrangCoder%2Ffile_manager'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b9cc8950aaf66113c1d6c484513d443a3b9d36b0 [INFO] linting bajrangCoder/file_manager against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FbajrangCoder%2Ffile_manager" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bajrangCoder/file_manager [INFO] finished tweaking git repo https://github.com/bajrangCoder/file_manager [INFO] tweaked toml for git repo https://github.com/bajrangCoder/file_manager written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bajrangCoder/file_manager on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bajrangCoder/file_manager already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wayland-sys v0.31.4 [INFO] [stderr] Downloaded wayland-cursor v0.31.5 [INFO] [stderr] Downloaded wayland-client v0.31.5 [INFO] [stderr] Downloaded egui_glium v0.26.3 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.3 [INFO] [stderr] Downloaded async-executor v1.13.0 [INFO] [stderr] Downloaded webbrowser v1.0.1 [INFO] [stderr] Downloaded xml-rs v0.8.21 [INFO] [stderr] Downloaded bytemuck v1.17.1 [INFO] [stderr] Downloaded cc v1.1.15 [INFO] [stderr] Downloaded wayland-backend v0.3.6 [INFO] [stderr] Downloaded wayland-scanner v0.31.4 [INFO] [stderr] Downloaded mime_guess2 v2.0.5 [INFO] [stderr] Downloaded wayland-protocols v0.32.3 [INFO] [stderr] Downloaded owned_ttf_parser v0.24.0 [INFO] [stderr] Downloaded quick-xml v0.34.0 [INFO] [stderr] Downloaded arboard v3.4.0 [INFO] [stderr] Downloaded ab_glyph v0.2.28 [INFO] [stderr] Downloaded async-trait v0.1.82 [INFO] [stderr] Downloaded rustix v0.38.35 [INFO] [stderr] Downloaded glium v0.34.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b8f8d5d696c4761824b4de1366d7bc055ca961958a13591946f1a59c852b169 [INFO] running `Command { std: "docker" "start" "-a" "0b8f8d5d696c4761824b4de1366d7bc055ca961958a13591946f1a59c852b169", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b8f8d5d696c4761824b4de1366d7bc055ca961958a13591946f1a59c852b169", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b8f8d5d696c4761824b4de1366d7bc055ca961958a13591946f1a59c852b169", kill_on_drop: false }` [INFO] [stdout] 0b8f8d5d696c4761824b4de1366d7bc055ca961958a13591946f1a59c852b169 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bed9524b1fd47aea088cc1399d91aa9fd886337148d7d16b057d7476377e01c [INFO] running `Command { std: "docker" "start" "-a" "8bed9524b1fd47aea088cc1399d91aa9fd886337148d7d16b057d7476377e01c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling wayland-sys v0.31.4 [INFO] [stderr] Compiling quick-xml v0.34.0 [INFO] [stderr] Compiling wayland-client v0.31.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking ttf-parser v0.24.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling xml-rs v0.8.21 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Compiling winit v0.29.15 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling wayland-scanner v0.31.4 [INFO] [stderr] Compiling glutin-winit v0.4.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Compiling glutin_glx_sys v0.5.0 [INFO] [stderr] Compiling glutin_egl_sys v0.6.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-once-cell v0.5.3 [INFO] [stderr] Compiling wayland-backend v0.3.6 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling mime_guess2 v2.0.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Compiling glium v0.34.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking webbrowser v1.0.1 [INFO] [stderr] Checking owned_ttf_parser v0.24.0 [INFO] [stderr] Checking webbrowser v0.8.15 [INFO] [stderr] Checking ab_glyph v0.2.28 [INFO] [stderr] Checking takeable-option v0.5.0 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling async-trait v0.1.82 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling enumn v0.1.14 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Checking glutin v0.31.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking ecolor v0.26.2 [INFO] [stderr] Checking emath v0.26.2 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking wayland-cursor v0.31.5 [INFO] [stderr] Checking wayland-protocols v0.32.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking arboard v3.4.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking accesskit v0.12.3 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking epaint v0.26.2 [INFO] [stderr] Checking ecolor v0.28.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.3 [INFO] [stderr] Checking accesskit_consumer v0.16.1 [INFO] [stderr] Checking egui v0.26.2 [INFO] [stderr] Checking epaint v0.28.1 [INFO] [stderr] Checking smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking sctk-adwaita v0.8.3 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking egui v0.28.1 [INFO] [stderr] Checking egui-winit v0.26.2 [INFO] [stderr] Checking atspi-common v0.3.0 [INFO] [stderr] Checking egui_glow v0.28.1 [INFO] [stderr] Checking egui_extras v0.28.1 [INFO] [stderr] Checking atspi-proxies v0.3.0 [INFO] [stderr] Checking atspi-connection v0.3.0 [INFO] [stderr] Checking egui_glium v0.26.3 [INFO] [stderr] Checking atspi v0.19.0 [INFO] [stderr] Checking accesskit_unix v0.6.2 [INFO] [stderr] Checking accesskit_winit v0.16.1 [INFO] [stderr] Checking egui-winit v0.28.1 [INFO] [stderr] Checking eframe v0.28.1 [INFO] [stderr] Checking file_manager v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | / for entry in entries { [INFO] [stdout] 32 | | if let Ok(entry) = entry { [INFO] [stdout] 33 | | let file_type = entry.file_type().unwrap(); [INFO] [stdout] 34 | | let name = entry.file_name().into_string().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | / if let Ok(entry) = entry { [INFO] [stdout] 33 | | let file_type = entry.file_type().unwrap(); [INFO] [stdout] 34 | | let name = entry.file_name().into_string().unwrap(); [INFO] [stdout] 35 | | self.entries.push(FileEntry { [INFO] [stdout] ... | [INFO] [stdout] 63 | | }); [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ for entry in entries.flatten() { [INFO] [stdout] 32 + let file_type = entry.file_type().unwrap(); [INFO] [stdout] 33 + let name = entry.file_name().into_string().unwrap(); [INFO] [stdout] 34 + self.entries.push(FileEntry { [INFO] [stdout] 35 + name, [INFO] [stdout] 36 + is_dir: file_type.is_dir(), [INFO] [stdout] 37 + size: if file_type.is_dir() { [INFO] [stdout] 38 + fs::read_dir(entry.path()) [INFO] [stdout] 39 + .map(|entries| entries.count()) [INFO] [stdout] 40 + .unwrap_or(0) as u64 [INFO] [stdout] 41 + } else { [INFO] [stdout] 42 + entry.metadata().map(|m| m.len()).unwrap_or(0) [INFO] [stdout] 43 + }, [INFO] [stdout] 44 + modified: entry [INFO] [stdout] 45 + .metadata() [INFO] [stdout] 46 + .and_then(|m| m.modified()) [INFO] [stdout] 47 + .map(|t| { [INFO] [stdout] 48 + let datetime: chrono::DateTime = t.into(); [INFO] [stdout] 49 + let now = chrono::Local::now(); [INFO] [stdout] 50 + let today = now.date_naive(); [INFO] [stdout] 51 + let yesterday = today.pred_opt(); [INFO] [stdout] 52 + [INFO] [stdout] 53 + if datetime.date_naive() == today { [INFO] [stdout] 54 + format!("Today at {}", datetime.format("%H:%M")) [INFO] [stdout] 55 + } else if Some(datetime.date_naive()) == yesterday { [INFO] [stdout] 56 + format!("Yesterday at {}", datetime.format("%H:%M")) [INFO] [stdout] 57 + } else { [INFO] [stdout] 58 + datetime.format("%d/%m/%Y at %H:%M").to_string() [INFO] [stdout] 59 + } [INFO] [stdout] 60 + }) [INFO] [stdout] 61 + .unwrap_or_else(|_| String::from("Unknown")), [INFO] [stdout] 62 + }); [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | / for entry in entries { [INFO] [stdout] 32 | | if let Ok(entry) = entry { [INFO] [stdout] 33 | | let file_type = entry.file_type().unwrap(); [INFO] [stdout] 34 | | let name = entry.file_name().into_string().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | / if let Ok(entry) = entry { [INFO] [stdout] 33 | | let file_type = entry.file_type().unwrap(); [INFO] [stdout] 34 | | let name = entry.file_name().into_string().unwrap(); [INFO] [stdout] 35 | | self.entries.push(FileEntry { [INFO] [stdout] ... | [INFO] [stdout] 63 | | }); [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ for entry in entries.flatten() { [INFO] [stdout] 32 + let file_type = entry.file_type().unwrap(); [INFO] [stdout] 33 + let name = entry.file_name().into_string().unwrap(); [INFO] [stdout] 34 + self.entries.push(FileEntry { [INFO] [stdout] 35 + name, [INFO] [stdout] 36 + is_dir: file_type.is_dir(), [INFO] [stdout] 37 + size: if file_type.is_dir() { [INFO] [stdout] 38 + fs::read_dir(entry.path()) [INFO] [stdout] 39 + .map(|entries| entries.count()) [INFO] [stdout] 40 + .unwrap_or(0) as u64 [INFO] [stdout] 41 + } else { [INFO] [stdout] 42 + entry.metadata().map(|m| m.len()).unwrap_or(0) [INFO] [stdout] 43 + }, [INFO] [stdout] 44 + modified: entry [INFO] [stdout] 45 + .metadata() [INFO] [stdout] 46 + .and_then(|m| m.modified()) [INFO] [stdout] 47 + .map(|t| { [INFO] [stdout] 48 + let datetime: chrono::DateTime = t.into(); [INFO] [stdout] 49 + let now = chrono::Local::now(); [INFO] [stdout] 50 + let today = now.date_naive(); [INFO] [stdout] 51 + let yesterday = today.pred_opt(); [INFO] [stdout] 52 + [INFO] [stdout] 53 + if datetime.date_naive() == today { [INFO] [stdout] 54 + format!("Today at {}", datetime.format("%H:%M")) [INFO] [stdout] 55 + } else if Some(datetime.date_naive()) == yesterday { [INFO] [stdout] 56 + format!("Yesterday at {}", datetime.format("%H:%M")) [INFO] [stdout] 57 + } else { [INFO] [stdout] 58 + datetime.format("%d/%m/%Y at %H:%M").to_string() [INFO] [stdout] 59 + } [INFO] [stdout] 60 + }) [INFO] [stdout] 61 + .unwrap_or_else(|_| String::from("Unknown")), [INFO] [stdout] 62 + }); [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | self.entries.sort_by(|a, b| b.is_dir.cmp(&a.is_dir)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 - self.entries.sort_by(|a, b| b.is_dir.cmp(&a.is_dir)); [INFO] [stdout] 66 + self.entries.sort_by_key(|b| std::cmp::Reverse(b.is_dir)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | self.entries.sort_by(|a, b| b.is_dir.cmp(&a.is_dir)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 - self.entries.sort_by(|a, b| b.is_dir.cmp(&a.is_dir)); [INFO] [stdout] 66 + self.entries.sort_by_key(|b| std::cmp::Reverse(b.is_dir)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:124:33 [INFO] [stdout] | [INFO] [stdout] 124 | / ... if nme_lbl.clicked() { [INFO] [stdout] 125 | | ... if entry.is_dir { [INFO] [stdout] 126 | | ... clicked_dir = Some(self.current_dir.join(&entry.name)); [INFO] [stdout] 127 | | ... } [INFO] [stdout] 128 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ if nme_lbl.clicked() [INFO] [stdout] 125 ~ && entry.is_dir { [INFO] [stdout] 126 | clicked_dir = Some(self.current_dir.join(&entry.name)); [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | / ... if nme_lbl.double_clicked() { [INFO] [stdout] 131 | | ... if !entry.is_dir { [INFO] [stdout] 132 | | ... println!("Opening file: {}", entry.name); [INFO] [stdout] 133 | | ... let result = open_file(&self.current_dir, &entry.name); [INFO] [stdout] ... | [INFO] [stdout] 138 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 130 ~ if nme_lbl.double_clicked() [INFO] [stdout] 131 ~ && !entry.is_dir { [INFO] [stdout] 132 | println!("Opening file: {}", entry.name); [INFO] [stdout] ... [INFO] [stdout] 136 | } [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:144:46 [INFO] [stdout] | [INFO] [stdout] 144 | ... ui.label(format!("{}", format_file_size(entry.size))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `format_file_size(entry.size).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:124:33 [INFO] [stdout] | [INFO] [stdout] 124 | / ... if nme_lbl.clicked() { [INFO] [stdout] 125 | | ... if entry.is_dir { [INFO] [stdout] 126 | | ... clicked_dir = Some(self.current_dir.join(&entry.name)); [INFO] [stdout] 127 | | ... } [INFO] [stdout] 128 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ if nme_lbl.clicked() [INFO] [stdout] 125 ~ && entry.is_dir { [INFO] [stdout] 126 | clicked_dir = Some(self.current_dir.join(&entry.name)); [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:185:27 [INFO] [stdout] | [INFO] [stdout] 185 | fn open_file(current_dir: &PathBuf, file_name: &str) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 185 - fn open_file(current_dir: &PathBuf, file_name: &str) -> std::io::Result<()> { [INFO] [stdout] 185 + fn open_file(current_dir: &Path, file_name: &str) -> std::io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | / ... if nme_lbl.double_clicked() { [INFO] [stdout] 131 | | ... if !entry.is_dir { [INFO] [stdout] 132 | | ... println!("Opening file: {}", entry.name); [INFO] [stdout] 133 | | ... let result = open_file(&self.current_dir, &entry.name); [INFO] [stdout] ... | [INFO] [stdout] 138 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 130 ~ if nme_lbl.double_clicked() [INFO] [stdout] 131 ~ && !entry.is_dir { [INFO] [stdout] 132 | println!("Opening file: {}", entry.name); [INFO] [stdout] ... [INFO] [stdout] 136 | } [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:144:46 [INFO] [stdout] | [INFO] [stdout] 144 | ... ui.label(format!("{}", format_file_size(entry.size))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `format_file_size(entry.size).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:185:27 [INFO] [stdout] | [INFO] [stdout] 185 | fn open_file(current_dir: &PathBuf, file_name: &str) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 185 - fn open_file(current_dir: &PathBuf, file_name: &str) -> std::io::Result<()> { [INFO] [stdout] 185 + fn open_file(current_dir: &Path, file_name: &str) -> std::io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `Command { std: "docker" "inspect" "8bed9524b1fd47aea088cc1399d91aa9fd886337148d7d16b057d7476377e01c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bed9524b1fd47aea088cc1399d91aa9fd886337148d7d16b057d7476377e01c", kill_on_drop: false }` [INFO] [stdout] 8bed9524b1fd47aea088cc1399d91aa9fd886337148d7d16b057d7476377e01c