[INFO] cloning repository https://github.com/baasman/cakecutter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/baasman/cakecutter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbaasman%2Fcakecutter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbaasman%2Fcakecutter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eadaf69fe44a527bcd7de7b5312a33fa89d4eb79 [INFO] linting baasman/cakecutter against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbaasman%2Fcakecutter" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/baasman/cakecutter [INFO] finished tweaking git repo https://github.com/baasman/cakecutter [INFO] tweaked toml for git repo https://github.com/baasman/cakecutter written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/baasman/cakecutter on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/baasman/cakecutter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded yash-fnmatch v1.1.1 [INFO] [stderr] Downloaded clap v4.5.21 [INFO] [stderr] Downloaded colog v1.3.0 [INFO] [stderr] Downloaded thiserror-impl v2.0.5 [INFO] [stderr] Downloaded thiserror v2.0.5 [INFO] [stderr] Downloaded clap_builder v4.5.21 [INFO] [stderr] Downloaded libc v0.2.164 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c38cd9deb766a6ea7579aa061be843eef100a5fb30b9344490db7e96dc4485a [INFO] running `Command { std: "docker" "start" "-a" "8c38cd9deb766a6ea7579aa061be843eef100a5fb30b9344490db7e96dc4485a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c38cd9deb766a6ea7579aa061be843eef100a5fb30b9344490db7e96dc4485a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c38cd9deb766a6ea7579aa061be843eef100a5fb30b9344490db7e96dc4485a", kill_on_drop: false }` [INFO] [stdout] 8c38cd9deb766a6ea7579aa061be843eef100a5fb30b9344490db7e96dc4485a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 951d5e1435b24f4abc49c605e79c07c531fd1fbe9a2ebc9c037add1d519bad6c [INFO] running `Command { std: "docker" "start" "-a" "951d5e1435b24f4abc49c605e79c07c531fd1fbe9a2ebc9c037add1d519bad6c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling libc v0.2.164 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking bstr v1.11.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling rustix v0.38.41 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling cc v1.2.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking clap_lex v0.7.3 [INFO] [stderr] Compiling thiserror v2.0.5 [INFO] [stderr] Checking clap_builder v4.5.21 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fastrand v2.2.0 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Checking tempfile v3.14.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking globset v0.4.15 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking ignore v0.4.23 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking colog v1.3.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling thiserror-impl v2.0.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling pest v2.7.14 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Compiling pest_meta v2.7.14 [INFO] [stderr] Checking yash-fnmatch v1.1.1 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking clap v4.5.21 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Compiling pest_generator v2.7.14 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Compiling pest_derive v2.7.14 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking cakecutter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `debug`, `error`, and `trace` [INFO] [stdout] --> src/main.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `env` [INFO] [stdout] --> src/main.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{env, path::PathBuf}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `debug`, `error`, `trace`, and `warn` [INFO] [stdout] --> src/cakecutter.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `os::unix::process` [INFO] [stdout] --> src/cakecutter.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | os::unix::process, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/cakecutter.rs:82:7 [INFO] [stdout] | [INFO] [stdout] 82 | } else { [INFO] [stdout] | _______^ [INFO] [stdout] 83 | | } [INFO] [stdout] | |_____^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/generate.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::template::{self, Template}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clap::builder::Str` [INFO] [stdout] --> src/generate.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use clap::builder::Str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/template.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | path::{Path, PathBuf}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clap::parser::Values` [INFO] [stdout] --> src/template.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use clap::parser::Values; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `debug`, `error`, `info`, `trace`, and `warn` [INFO] [stdout] --> src/template.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `template_loc` [INFO] [stdout] --> src/cakecutter.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | let template_loc = &path; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_template_loc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `no_input` [INFO] [stdout] --> src/cakecutter.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | no_input: bool, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_no_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `skip_of_file_exists` [INFO] [stdout] --> src/generate.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | skip_of_file_exists: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_skip_of_file_exists` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `delete_project_on_failure` [INFO] [stdout] --> src/generate.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | let delete_project_on_failure = true && !keep_project_on_failure; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_delete_project_on_failure` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `RepoDir` is never used [INFO] [stdout] --> src/template.rs:60:10 [INFO] [stdout] | [INFO] [stdout] 60 | pub enum RepoDir { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `should_cleanup_dir` is never used [INFO] [stdout] --> src/template.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl Template { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 104 | pub fn should_cleanup_dir(&self, template: &TemplateType) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/cakecutter.rs:31:53 [INFO] [stdout] | [INFO] [stdout] 31 | template_data = Template::new(template, PathBuf::from(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/cakecutter.rs:41:53 [INFO] [stdout] | [INFO] [stdout] 41 | template_data = Template::new(template, PathBuf::from(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/cakecutter.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | if let None = template_data.template.get(&key) { [INFO] [stdout] | -------^^^^----------------------------------- help: try: `if template_data.template.get(&key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/cakecutter.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 81 | if replay { [INFO] [stdout] | _______________^ [INFO] [stdout] 82 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/cakecutter.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/generate.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / for entry in dir_entries { [INFO] [stdout] 19 | | if let Ok(entry) = entry { [INFO] [stdout] 20 | | let file_type = entry.file_type().unwrap(); [INFO] [stdout] 21 | | if file_type.is_dir() { [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/generate.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / if let Ok(entry) = entry { [INFO] [stdout] 20 | | let file_type = entry.file_type().unwrap(); [INFO] [stdout] 21 | | if file_type.is_dir() { [INFO] [stdout] 22 | | let file_name = entry.file_name(); [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 ~ for entry in dir_entries.flatten() { [INFO] [stdout] 19 + let file_type = entry.file_type().unwrap(); [INFO] [stdout] 20 + if file_type.is_dir() { [INFO] [stdout] 21 + let file_name = entry.file_name(); [INFO] [stdout] 22 + let dir_name = file_name.to_str().unwrap(); [INFO] [stdout] 23 + if dir_name.contains("cakecutter") && dir_name.starts_with('{') { [INFO] [stdout] 24 + return Some(dir_name.to_owned()); [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/generate.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | --------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 39 | rendered_dir [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 38 ~ [INFO] [stdout] 39 ~ name_template.render(&temp_id, &context).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generate.rs:38:45 [INFO] [stdout] | [INFO] [stdout] 38 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `temp_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generate.rs:38:55 [INFO] [stdout] | [INFO] [stdout] 38 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generate.rs:51:49 [INFO] [stdout] | [INFO] [stdout] 51 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `temp_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generate.rs:51:59 [INFO] [stdout] | [INFO] [stdout] 51 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generate.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return Ok(final_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return Ok(final_dir); [INFO] [stdout] 88 + Ok(final_dir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generate.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / return Err(Box::new(GenerateFilesError::IoError(std::io::Error::new( [INFO] [stdout] 91 | | std::io::ErrorKind::Other, [INFO] [stdout] 92 | | "Unable to find the directory to create", [INFO] [stdout] 93 | | )))); [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ Err(Box::new(GenerateFilesError::IoError(std::io::Error::new( [INFO] [stdout] 91 + std::io::ErrorKind::Other, [INFO] [stdout] 92 + "Unable to find the directory to create", [INFO] [stdout] 93 ~ )))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/generate.rs:90:57 [INFO] [stdout] | [INFO] [stdout] 90 | return Err(Box::new(GenerateFilesError::IoError(std::io::Error::new( [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 91 | | std::io::ErrorKind::Other, [INFO] [stdout] 92 | | "Unable to find the directory to create", [INFO] [stdout] 93 | | )))); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 90 ~ return Err(Box::new(GenerateFilesError::IoError(std::io::Error::other( [INFO] [stdout] 91 ~ "Unable to find the directory to create", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/generate.rs:138:37 [INFO] [stdout] | [INFO] [stdout] 138 | let delete_project_on_failure = true && !keep_project_on_failure; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 138 - let delete_project_on_failure = true && !keep_project_on_failure; [INFO] [stdout] 138 + let delete_project_on_failure = !keep_project_on_failure; [INFO] [stdout] | [INFO] [stdout] 138 - let delete_project_on_failure = true && !keep_project_on_failure; [INFO] [stdout] 138 + let delete_project_on_failure = !keep_project_on_failure; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/generate.rs:151:28 [INFO] [stdout] | [INFO] [stdout] 151 | if let Ok(_) = ret { [INFO] [stdout] | -------^^^^^------ help: try: `if ret.is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/template.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 12 | fn is_zip_file(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn is_zip_file(path: &PathBuf) -> bool { [INFO] [stdout] 12 + fn is_zip_file(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/template.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / path.extension() [INFO] [stdout] 14 | | .map_or(false, |ext| ext.eq_ignore_ascii_case("zip")) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 14 - .map_or(false, |ext| ext.eq_ignore_ascii_case("zip")) [INFO] [stdout] 14 + .is_some_and(|ext| ext.eq_ignore_ascii_case("zip")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/template.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / match parsed_url.scheme() { [INFO] [stdout] 20 | | "http" | "https" | "git" | "ssh" => true, [INFO] [stdout] 21 | | _ => false, [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 19 - match parsed_url.scheme() { [INFO] [stdout] 20 - "http" | "https" | "git" | "ssh" => true, [INFO] [stdout] 21 - _ => false, [INFO] [stdout] 22 - } [INFO] [stdout] 19 + matches!(parsed_url.scheme(), "http" | "https" | "git" | "ssh") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/template.rs:101:44 [INFO] [stdout] | [INFO] [stdout] 101 | self.abbreviations = abbreviations.unwrap_or(HashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `debug`, `error`, and `trace` [INFO] [stdout] --> src/main.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `env` [INFO] [stdout] --> src/main.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{env, path::PathBuf}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `debug`, `error`, `trace`, and `warn` [INFO] [stdout] --> src/cakecutter.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `os::unix::process` [INFO] [stdout] --> src/cakecutter.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | os::unix::process, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/cakecutter.rs:82:7 [INFO] [stdout] | [INFO] [stdout] 82 | } else { [INFO] [stdout] | _______^ [INFO] [stdout] 83 | | } [INFO] [stdout] | |_____^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/generate.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::template::{self, Template}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clap::builder::Str` [INFO] [stdout] --> src/generate.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use clap::builder::Str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/template.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | path::{Path, PathBuf}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clap::parser::Values` [INFO] [stdout] --> src/template.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use clap::parser::Values; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `debug`, `error`, `info`, `trace`, and `warn` [INFO] [stdout] --> src/template.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use log::{debug, error, info, trace, warn}; [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/generate.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | name_template.add_raw_template(temp_id, rel_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 37 | let _ = name_template.add_raw_template(temp_id, rel_path); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/generate.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | name_template.add_raw_template(temp_id, &unren_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 50 | let _ = name_template.add_raw_template(temp_id, &unren_dir); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `template_loc` [INFO] [stdout] --> src/cakecutter.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | let template_loc = &path; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_template_loc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `no_input` [INFO] [stdout] --> src/cakecutter.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | no_input: bool, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_no_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `skip_of_file_exists` [INFO] [stdout] --> src/generate.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | skip_of_file_exists: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_skip_of_file_exists` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `delete_project_on_failure` [INFO] [stdout] --> src/generate.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | let delete_project_on_failure = true && !keep_project_on_failure; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_delete_project_on_failure` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `RepoDir` is never used [INFO] [stdout] --> src/template.rs:60:10 [INFO] [stdout] | [INFO] [stdout] 60 | pub enum RepoDir { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `should_cleanup_dir` is never used [INFO] [stdout] --> src/template.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl Template { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 104 | pub fn should_cleanup_dir(&self, template: &TemplateType) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/cakecutter.rs:31:53 [INFO] [stdout] | [INFO] [stdout] 31 | template_data = Template::new(template, PathBuf::from(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/cakecutter.rs:41:53 [INFO] [stdout] | [INFO] [stdout] 41 | template_data = Template::new(template, PathBuf::from(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/cakecutter.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | if let None = template_data.template.get(&key) { [INFO] [stdout] | -------^^^^----------------------------------- help: try: `if template_data.template.get(&key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/cakecutter.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 81 | if replay { [INFO] [stdout] | _______________^ [INFO] [stdout] 82 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/cakecutter.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/generate.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / for entry in dir_entries { [INFO] [stdout] 19 | | if let Ok(entry) = entry { [INFO] [stdout] 20 | | let file_type = entry.file_type().unwrap(); [INFO] [stdout] 21 | | if file_type.is_dir() { [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/generate.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / if let Ok(entry) = entry { [INFO] [stdout] 20 | | let file_type = entry.file_type().unwrap(); [INFO] [stdout] 21 | | if file_type.is_dir() { [INFO] [stdout] 22 | | let file_name = entry.file_name(); [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 ~ for entry in dir_entries.flatten() { [INFO] [stdout] 19 + let file_type = entry.file_type().unwrap(); [INFO] [stdout] 20 + if file_type.is_dir() { [INFO] [stdout] 21 + let file_name = entry.file_name(); [INFO] [stdout] 22 + let dir_name = file_name.to_str().unwrap(); [INFO] [stdout] 23 + if dir_name.contains("cakecutter") && dir_name.starts_with('{') { [INFO] [stdout] 24 + return Some(dir_name.to_owned()); [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/generate.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | --------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 39 | rendered_dir [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 38 ~ [INFO] [stdout] 39 ~ name_template.render(&temp_id, &context).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generate.rs:38:45 [INFO] [stdout] | [INFO] [stdout] 38 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `temp_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generate.rs:38:55 [INFO] [stdout] | [INFO] [stdout] 38 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generate.rs:51:49 [INFO] [stdout] | [INFO] [stdout] 51 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `temp_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/generate.rs:51:59 [INFO] [stdout] | [INFO] [stdout] 51 | let rendered_dir = name_template.render(&temp_id, &context).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generate.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return Ok(final_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return Ok(final_dir); [INFO] [stdout] 88 + Ok(final_dir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generate.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / return Err(Box::new(GenerateFilesError::IoError(std::io::Error::new( [INFO] [stdout] 91 | | std::io::ErrorKind::Other, [INFO] [stdout] 92 | | "Unable to find the directory to create", [INFO] [stdout] 93 | | )))); [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ Err(Box::new(GenerateFilesError::IoError(std::io::Error::new( [INFO] [stdout] 91 + std::io::ErrorKind::Other, [INFO] [stdout] 92 + "Unable to find the directory to create", [INFO] [stdout] 93 ~ )))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/generate.rs:90:57 [INFO] [stdout] | [INFO] [stdout] 90 | return Err(Box::new(GenerateFilesError::IoError(std::io::Error::new( [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 91 | | std::io::ErrorKind::Other, [INFO] [stdout] 92 | | "Unable to find the directory to create", [INFO] [stdout] 93 | | )))); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 90 ~ return Err(Box::new(GenerateFilesError::IoError(std::io::Error::other( [INFO] [stdout] 91 ~ "Unable to find the directory to create", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/generate.rs:138:37 [INFO] [stdout] | [INFO] [stdout] 138 | let delete_project_on_failure = true && !keep_project_on_failure; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 138 - let delete_project_on_failure = true && !keep_project_on_failure; [INFO] [stdout] 138 + let delete_project_on_failure = !keep_project_on_failure; [INFO] [stdout] | [INFO] [stdout] 138 - let delete_project_on_failure = true && !keep_project_on_failure; [INFO] [stdout] 138 + let delete_project_on_failure = !keep_project_on_failure; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/generate.rs:151:28 [INFO] [stdout] | [INFO] [stdout] 151 | if let Ok(_) = ret { [INFO] [stdout] | -------^^^^^------ help: try: `if ret.is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/template.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 12 | fn is_zip_file(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn is_zip_file(path: &PathBuf) -> bool { [INFO] [stdout] 12 + fn is_zip_file(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/template.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / path.extension() [INFO] [stdout] 14 | | .map_or(false, |ext| ext.eq_ignore_ascii_case("zip")) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 14 - .map_or(false, |ext| ext.eq_ignore_ascii_case("zip")) [INFO] [stdout] 14 + .is_some_and(|ext| ext.eq_ignore_ascii_case("zip")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/template.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / match parsed_url.scheme() { [INFO] [stdout] 20 | | "http" | "https" | "git" | "ssh" => true, [INFO] [stdout] 21 | | _ => false, [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 19 - match parsed_url.scheme() { [INFO] [stdout] 20 - "http" | "https" | "git" | "ssh" => true, [INFO] [stdout] 21 - _ => false, [INFO] [stdout] 22 - } [INFO] [stdout] 19 + matches!(parsed_url.scheme(), "http" | "https" | "git" | "ssh") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/template.rs:101:44 [INFO] [stdout] | [INFO] [stdout] 101 | self.abbreviations = abbreviations.unwrap_or(HashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/generate.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | name_template.add_raw_template(temp_id, rel_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 37 | let _ = name_template.add_raw_template(temp_id, rel_path); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/generate.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | name_template.add_raw_template(temp_id, &unren_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 50 | let _ = name_template.add_raw_template(temp_id, &unren_dir); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 46s [INFO] running `Command { std: "docker" "inspect" "951d5e1435b24f4abc49c605e79c07c531fd1fbe9a2ebc9c037add1d519bad6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "951d5e1435b24f4abc49c605e79c07c531fd1fbe9a2ebc9c037add1d519bad6c", kill_on_drop: false }` [INFO] [stdout] 951d5e1435b24f4abc49c605e79c07c531fd1fbe9a2ebc9c037add1d519bad6c