[INFO] cloning repository https://github.com/azmr/simtfl-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/azmr/simtfl-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazmr%2Fsimtfl-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazmr%2Fsimtfl-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa68bd3bb06362a9f3c1ac30088b3efbf213a027 [INFO] linting azmr/simtfl-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazmr%2Fsimtfl-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/azmr/simtfl-rs [INFO] finished tweaking git repo https://github.com/azmr/simtfl-rs [INFO] tweaked toml for git repo https://github.com/azmr/simtfl-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/azmr/simtfl-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/azmr/simtfl-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0fdfc089571f1a2860171caa994f44ccdf2b41abb96090337b3b83110212df50 [INFO] running `Command { std: "docker" "start" "-a" "0fdfc089571f1a2860171caa994f44ccdf2b41abb96090337b3b83110212df50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0fdfc089571f1a2860171caa994f44ccdf2b41abb96090337b3b83110212df50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fdfc089571f1a2860171caa994f44ccdf2b41abb96090337b3b83110212df50", kill_on_drop: false }` [INFO] [stdout] 0fdfc089571f1a2860171caa994f44ccdf2b41abb96090337b3b83110212df50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2dd954539c64af831ed4ff52ca2ee6828b9df8d72a7a20a3beed50eb1032179f [INFO] running `Command { std: "docker" "start" "-a" "2dd954539c64af831ed4ff52ca2ee6828b9df8d72a7a20a3beed50eb1032179f", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.18 [INFO] [stderr] Compiling getrandom v0.3.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rand_core v0.9.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_pcg v0.9.0 [INFO] [stderr] Checking rand v0.9.0 [INFO] [stderr] Checking simtfl-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | //! although this isn't ideal. [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 72 | //! although this isn't ideal. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/lib.rs:353:42 [INFO] [stdout] | [INFO] [stdout] 353 | for (i, cmp_evt) in (&self.evts).into_iter().enumerate().rev() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:449:23 [INFO] [stdout] | [INFO] [stdout] 449 | sha256.update(&last_finalized_block); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `last_finalized_block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:450:73 [INFO] [stdout] | [INFO] [stdout] 450 | let finalized_block_hash : Sha256Hash = sha256.finalize_fixed().try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `GenericArray, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 450 - let finalized_block_hash : Sha256Hash = sha256.finalize_fixed().try_into().unwrap(); [INFO] [stdout] 450 + let finalized_block_hash : Sha256Hash = sha256.finalize_fixed().into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/lib.rs:453:9 [INFO] [stdout] | [INFO] [stdout] 453 | / let mut finalized_blocks : Vec:: = Vec::new(); [INFO] [stdout] 454 | | finalized_blocks.push(HashAtTime { hash: finalized_block_hash }); // time: SimTime { t:0 } [INFO] [stdout] | |_________________________________________________________________________^ help: consider using the `vec![]` macro: `let finalized_blocks: Vec:: = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 482 | if ! (self.at_idx < self.evts.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.at_idx >= self.evts.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 535 - return true; [INFO] [stdout] 535 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:633:27 [INFO] [stdout] | [INFO] [stdout] 633 | sha256.update(&self.node.last_finalized_block_hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.node.last_finalized_block_hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:634:27 [INFO] [stdout] | [INFO] [stdout] 634 | sha256.update(&self.node.best_next_block_hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.node.best_next_block_hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:639:27 [INFO] [stdout] | [INFO] [stdout] 639 | sha256.update(&mined_block); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mined_block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:641:73 [INFO] [stdout] | [INFO] [stdout] 641 | let mined_block_hash : Sha256Hash = sha256.finalize_fixed().try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `GenericArray, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 641 - let mined_block_hash : Sha256Hash = sha256.finalize_fixed().try_into().unwrap(); [INFO] [stdout] 641 + let mined_block_hash : Sha256Hash = sha256.finalize_fixed().into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | //! although this isn't ideal. [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 72 | //! although this isn't ideal. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/lib.rs:353:42 [INFO] [stdout] | [INFO] [stdout] 353 | for (i, cmp_evt) in (&self.evts).into_iter().enumerate().rev() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:449:23 [INFO] [stdout] | [INFO] [stdout] 449 | sha256.update(&last_finalized_block); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `last_finalized_block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:450:73 [INFO] [stdout] | [INFO] [stdout] 450 | let finalized_block_hash : Sha256Hash = sha256.finalize_fixed().try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `GenericArray, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 450 - let finalized_block_hash : Sha256Hash = sha256.finalize_fixed().try_into().unwrap(); [INFO] [stdout] 450 + let finalized_block_hash : Sha256Hash = sha256.finalize_fixed().into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/lib.rs:453:9 [INFO] [stdout] | [INFO] [stdout] 453 | / let mut finalized_blocks : Vec:: = Vec::new(); [INFO] [stdout] 454 | | finalized_blocks.push(HashAtTime { hash: finalized_block_hash }); // time: SimTime { t:0 } [INFO] [stdout] | |_________________________________________________________________________^ help: consider using the `vec![]` macro: `let finalized_blocks: Vec:: = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 482 | if ! (self.at_idx < self.evts.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.at_idx >= self.evts.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 535 - return true; [INFO] [stdout] 535 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:633:27 [INFO] [stdout] | [INFO] [stdout] 633 | sha256.update(&self.node.last_finalized_block_hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.node.last_finalized_block_hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:634:27 [INFO] [stdout] | [INFO] [stdout] 634 | sha256.update(&self.node.best_next_block_hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.node.best_next_block_hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:639:27 [INFO] [stdout] | [INFO] [stdout] 639 | sha256.update(&mined_block); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mined_block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:641:73 [INFO] [stdout] | [INFO] [stdout] 641 | let mined_block_hash : Sha256Hash = sha256.finalize_fixed().try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `GenericArray, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 641 - let mined_block_hash : Sha256Hash = sha256.finalize_fixed().try_into().unwrap(); [INFO] [stdout] 641 + let mined_block_hash : Sha256Hash = sha256.finalize_fixed().into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.26s [INFO] running `Command { std: "docker" "inspect" "2dd954539c64af831ed4ff52ca2ee6828b9df8d72a7a20a3beed50eb1032179f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2dd954539c64af831ed4ff52ca2ee6828b9df8d72a7a20a3beed50eb1032179f", kill_on_drop: false }` [INFO] [stdout] 2dd954539c64af831ed4ff52ca2ee6828b9df8d72a7a20a3beed50eb1032179f