[INFO] cloning repository https://github.com/aziis98/icfp-2018 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aziis98/icfp-2018" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faziis98%2Ficfp-2018", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faziis98%2Ficfp-2018'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 45807c0791ab0bc5a01192ac2c08a2af5859b427 [INFO] linting aziis98/icfp-2018 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faziis98%2Ficfp-2018" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aziis98/icfp-2018 [INFO] finished tweaking git repo https://github.com/aziis98/icfp-2018 [INFO] tweaked toml for git repo https://github.com/aziis98/icfp-2018 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aziis98/icfp-2018 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aziis98/icfp-2018 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 82e20ebf7c4990ecf6929774a7eec96f1b8b5d1c3be16c7eb5abcbcd99a925f3 [INFO] running `Command { std: "docker" "start" "-a" "82e20ebf7c4990ecf6929774a7eec96f1b8b5d1c3be16c7eb5abcbcd99a925f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "82e20ebf7c4990ecf6929774a7eec96f1b8b5d1c3be16c7eb5abcbcd99a925f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82e20ebf7c4990ecf6929774a7eec96f1b8b5d1c3be16c7eb5abcbcd99a925f3", kill_on_drop: false }` [INFO] [stdout] 82e20ebf7c4990ecf6929774a7eec96f1b8b5d1c3be16c7eb5abcbcd99a925f3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6810e64c4a8bce727d6a48834024db1ebe4df4718cfaa690234f8815fded19c2 [INFO] running `Command { std: "docker" "start" "-a" "6810e64c4a8bce727d6a48834024db1ebe4df4718cfaa690234f8815fded19c2", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking icfp-2018 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/nmms/state.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | type Trace = Vec>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 8 | type Trace = Vec>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/nmms/state.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | type Trace = Vec>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 8 | type Trace = Vec>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bot_bid` [INFO] [stdout] --> src/nmms/state.rs:29:28 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn find_bot(&self, bot_bid: BID) -> Box { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bot_bid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/nmms/bot/commands.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 42 | fn execute(&mut self, state: &mut State) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bot_bid` [INFO] [stdout] --> src/nmms/state.rs:29:28 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn find_bot(&self, bot_bid: BID) -> Box { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bot_bid` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/nmms/bot/commands.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 42 | fn execute(&mut self, state: &mut State) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/nmms/bot/commands.rs:237:27 [INFO] [stdout] | [INFO] [stdout] 237 | fn execute(&mut self, state: &mut State) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/nmms/bot/commands.rs:237:27 [INFO] [stdout] | [INFO] [stdout] 237 | fn execute(&mut self, state: &mut State) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nmms/mod.rs:224:7 [INFO] [stdout] | [INFO] [stdout] 224 | for mut voxel_byte in &self.voxels { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nmms/mod.rs:224:7 [INFO] [stdout] | [INFO] [stdout] 224 | for mut voxel_byte in &self.voxels { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nmms/bot/commands.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if bot.pos.x != 0 || bot.pos.y != 0 || bot.pos.y != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 - if bot.pos.x != 0 || bot.pos.y != 0 || bot.pos.y != 0 { [INFO] [stdout] 22 + if !(bot.pos.x == 0 && bot.pos.y == 0) { [INFO] [stdout] | [INFO] [stdout] 22 - if bot.pos.x != 0 || bot.pos.y != 0 || bot.pos.y != 0 { [INFO] [stdout] 22 + if bot.pos.x != 0 || bot.pos.y != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nmms/bot/commands.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if bot.pos.x != 0 || bot.pos.y != 0 || bot.pos.y != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 - if bot.pos.x != 0 || bot.pos.y != 0 || bot.pos.y != 0 { [INFO] [stdout] 22 + if !(bot.pos.x == 0 && bot.pos.y == 0) { [INFO] [stdout] | [INFO] [stdout] 22 - if bot.pos.x != 0 || bot.pos.y != 0 || bot.pos.y != 0 { [INFO] [stdout] 22 + if bot.pos.x != 0 || bot.pos.y != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/nmms/bot/commands.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 154 | if self.bot.seeds.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.bot.seeds.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/nmms/bot/commands.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 154 | if self.bot.seeds.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.bot.seeds.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:86:4 [INFO] [stdout] | [INFO] [stdout] 86 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return true; [INFO] [stdout] 86 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:88:4 [INFO] [stdout] | [INFO] [stdout] 88 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return true; [INFO] [stdout] 88 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:90:4 [INFO] [stdout] | [INFO] [stdout] 90 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return true; [INFO] [stdout] 90 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/nmms/mod.rs:85:51 [INFO] [stdout] | [INFO] [stdout] 85 | if self.dx == 0 && self.dy == 0 && self.dz != 0 { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 86 | | return true; [INFO] [stdout] 87 | | } else if self.dx == 0 && self.dy != 0 && self.dz == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/nmms/mod.rs:87:58 [INFO] [stdout] | [INFO] [stdout] 87 | } else if self.dx == 0 && self.dy != 0 && self.dz == 0 { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 88 | | return true; [INFO] [stdout] 89 | | } else if self.dx != 0 && self.dy == 0 && self.dz == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/nmms/mod.rs:87:58 [INFO] [stdout] | [INFO] [stdout] 87 | } else if self.dx == 0 && self.dy != 0 && self.dz == 0 { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 88 | | return true; [INFO] [stdout] 89 | | } else if self.dx != 0 && self.dy == 0 && self.dz == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/nmms/mod.rs:89:58 [INFO] [stdout] | [INFO] [stdout] 89 | } else if self.dx != 0 && self.dy == 0 && self.dz == 0 { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 90 | | return true; [INFO] [stdout] 91 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return true; [INFO] [stdout] 101 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return false; [INFO] [stdout] 103 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/nmms/mod.rs:100:4 [INFO] [stdout] | [INFO] [stdout] 100 | / if self.mlen() <= 5 { [INFO] [stdout] 101 | | return true; [INFO] [stdout] 102 | | } else { [INFO] [stdout] 103 | | return false; [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `return self.mlen() <= 5` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return true; [INFO] [stdout] 115 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return false; [INFO] [stdout] 117 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/nmms/mod.rs:114:4 [INFO] [stdout] | [INFO] [stdout] 114 | / if self.mlen() <= 15 { [INFO] [stdout] 115 | | return true; [INFO] [stdout] 116 | | } else { [INFO] [stdout] 117 | | return false; [INFO] [stdout] 118 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `return self.mlen() <= 15` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:86:4 [INFO] [stdout] | [INFO] [stdout] 86 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return true; [INFO] [stdout] 86 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:88:4 [INFO] [stdout] | [INFO] [stdout] 88 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return true; [INFO] [stdout] 88 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:90:4 [INFO] [stdout] | [INFO] [stdout] 90 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return true; [INFO] [stdout] 90 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/nmms/mod.rs:85:51 [INFO] [stdout] | [INFO] [stdout] 85 | if self.dx == 0 && self.dy == 0 && self.dz != 0 { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 86 | | return true; [INFO] [stdout] 87 | | } else if self.dx == 0 && self.dy != 0 && self.dz == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/nmms/mod.rs:87:58 [INFO] [stdout] | [INFO] [stdout] 87 | } else if self.dx == 0 && self.dy != 0 && self.dz == 0 { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 88 | | return true; [INFO] [stdout] 89 | | } else if self.dx != 0 && self.dy == 0 && self.dz == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/nmms/mod.rs:87:58 [INFO] [stdout] | [INFO] [stdout] 87 | } else if self.dx == 0 && self.dy != 0 && self.dz == 0 { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 88 | | return true; [INFO] [stdout] 89 | | } else if self.dx != 0 && self.dy == 0 && self.dz == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/nmms/mod.rs:89:58 [INFO] [stdout] | [INFO] [stdout] 89 | } else if self.dx != 0 && self.dy == 0 && self.dz == 0 { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 90 | | return true; [INFO] [stdout] 91 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return true; [INFO] [stdout] 101 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return false; [INFO] [stdout] 103 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/nmms/mod.rs:100:4 [INFO] [stdout] | [INFO] [stdout] 100 | / if self.mlen() <= 5 { [INFO] [stdout] 101 | | return true; [INFO] [stdout] 102 | | } else { [INFO] [stdout] 103 | | return false; [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `return self.mlen() <= 5` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return true; [INFO] [stdout] 115 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return false; [INFO] [stdout] 117 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/nmms/mod.rs:114:4 [INFO] [stdout] | [INFO] [stdout] 114 | / if self.mlen() <= 15 { [INFO] [stdout] 115 | | return true; [INFO] [stdout] 116 | | } else { [INFO] [stdout] 117 | | return false; [INFO] [stdout] 118 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `return self.mlen() <= 15` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:268:3 [INFO] [stdout] | [INFO] [stdout] 268 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return true; [INFO] [stdout] 268 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nmms/mod.rs:268:3 [INFO] [stdout] | [INFO] [stdout] 268 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return true; [INFO] [stdout] 268 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s [INFO] running `Command { std: "docker" "inspect" "6810e64c4a8bce727d6a48834024db1ebe4df4718cfaa690234f8815fded19c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6810e64c4a8bce727d6a48834024db1ebe4df4718cfaa690234f8815fded19c2", kill_on_drop: false }` [INFO] [stdout] 6810e64c4a8bce727d6a48834024db1ebe4df4718cfaa690234f8815fded19c2