[INFO] cloning repository https://github.com/axialabsresearch/frost-protocol [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/axialabsresearch/frost-protocol" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faxialabsresearch%2Ffrost-protocol", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faxialabsresearch%2Ffrost-protocol'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f47149c951fceed446754fc35c6b3045849a22ab [INFO] linting axialabsresearch/frost-protocol against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faxialabsresearch%2Ffrost-protocol" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/axialabsresearch/frost-protocol [INFO] removed 0 missing tests [INFO] finished tweaking git repo https://github.com/axialabsresearch/frost-protocol [INFO] tweaked toml for git repo https://github.com/axialabsresearch/frost-protocol written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/axialabsresearch/frost-protocol on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 524 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding hickory-proto v0.25.0-alpha.5 (available: v0.25.2) [INFO] [stderr] Adding hickory-resolver v0.25.0-alpha.5 (available: v0.25.2) [INFO] [stderr] Adding libp2p v0.55.0 (available: v0.56.0) [INFO] [stderr] Adding libp2p-kad v0.47.0 (available: v0.48.0) [INFO] [stderr] Adding libp2p-swarm-derive v0.35.0 (available: v0.35.1) [INFO] [stderr] Adding lru v0.14.0 (available: v0.16.3) [INFO] [stderr] Adding metrics v0.20.1 (available: v0.24.3) [INFO] [stderr] Adding metrics-exporter-prometheus v0.11.0 (available: v0.18.1) [INFO] [stderr] Adding mockall v0.11.4 (available: v0.14.0) [INFO] [stderr] Adding opentelemetry v0.30.0 (available: v0.31.0) [INFO] [stderr] Adding opentelemetry_sdk v0.30.0 (available: v0.31.0) [INFO] [stderr] Adding rand v0.9.2 (available: v0.10.0) [INFO] [stderr] Adding reqwest v0.12.28 (available: v0.13.2) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] [stderr] Adding tracing-opentelemetry v0.31.0 (available: v0.32.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded test-log v0.2.19 [INFO] [stderr] Downloaded data-encoding-macro-internal v0.1.17 [INFO] [stderr] Downloaded test-log-macros v0.2.19 [INFO] [stderr] Downloaded if-addrs v0.15.0 [INFO] [stderr] Downloaded lru v0.14.0 [INFO] [stderr] Downloaded libp2p-identify v0.46.0 [INFO] [stderr] Downloaded libp2p-ping v0.46.0 [INFO] [stderr] Downloaded traitobject v0.1.1 [INFO] [stderr] Downloaded netlink-packet-core v0.8.1 [INFO] [stderr] Downloaded error v0.1.9 [INFO] [stderr] Downloaded libp2p-allow-block-list v0.5.0 [INFO] [stderr] Downloaded libp2p-connection-limits v0.5.0 [INFO] [stderr] Downloaded libp2p-mdns v0.47.0 [INFO] [stderr] Downloaded libp2p-request-response v0.28.0 [INFO] [stderr] Downloaded libp2p-autonat v0.14.0 [INFO] [stderr] Downloaded libp2p v0.55.0 [INFO] [stderr] Downloaded libp2p-swarm v0.46.0 [INFO] [stderr] Downloaded hickory-resolver v0.25.0-alpha.5 [INFO] [stderr] Downloaded libp2p-gossipsub v0.48.0 [INFO] [stderr] Downloaded libp2p-kad v0.47.0 [INFO] [stderr] Downloaded tracing-subscriber v0.3.23 [INFO] [stderr] Downloaded opentelemetry_sdk v0.30.0 [INFO] [stderr] Downloaded tracing-opentelemetry v0.31.0 [INFO] [stderr] Downloaded netlink-packet-route v0.28.0 [INFO] [stderr] Downloaded tinyvec v1.11.0 [INFO] [stderr] Downloaded moka v0.12.14 [INFO] [stderr] Downloaded rtnetlink v0.20.0 [INFO] [stderr] Downloaded libp2p-websocket v0.45.1 [INFO] [stderr] Downloaded libp2p-core v0.43.2 [INFO] [stderr] Downloaded libp2p-tcp v0.43.0 [INFO] [stderr] Downloaded igd-next v0.15.1 [INFO] [stderr] Downloaded resolv-conf v0.7.6 [INFO] [stderr] Downloaded libp2p-dns v0.43.0 [INFO] [stderr] Downloaded libp2p-noise v0.46.1 [INFO] [stderr] Downloaded libp2p-quic v0.12.0 [INFO] [stderr] Downloaded hickory-proto v0.25.0-alpha.5 [INFO] [stderr] Downloaded yamux v0.13.10 [INFO] [stderr] Downloaded asn1_der v0.7.7 [INFO] [stderr] Downloaded libp2p-identity v0.2.13 [INFO] [stderr] Downloaded metrics-util v0.14.0 [INFO] [stderr] Downloaded libp2p-dcutr v0.13.0 [INFO] [stderr] Downloaded libp2p-metrics v0.16.0 [INFO] [stderr] Downloaded libp2p-tls v0.6.2 [INFO] [stderr] Downloaded libp2p-relay v0.19.0 [INFO] [stderr] Downloaded netlink-proto v0.12.0 [INFO] [stderr] Downloaded libp2p-upnp v0.4.0 [INFO] [stderr] Downloaded libp2p-yamux v0.47.0 [INFO] [stderr] Downloaded const-str v0.4.3 [INFO] [stderr] Downloaded metrics v0.20.1 [INFO] [stderr] Downloaded libp2p-pnet v0.26.0 [INFO] [stderr] Downloaded netlink-sys v0.8.8 [INFO] [stderr] Downloaded if-watch v3.2.2 [INFO] [stderr] Downloaded match-lookup v0.1.2 [INFO] [stderr] Downloaded base256emoji v1.0.2 [INFO] [stderr] Downloaded data-encoding-macro v0.1.19 [INFO] [stderr] Downloaded multibase v0.9.2 [INFO] [stderr] Downloaded quanta v0.10.1 [INFO] [stderr] Downloaded metrics-exporter-prometheus v0.11.0 [INFO] [stderr] Downloaded opentelemetry v0.30.0 [INFO] [stderr] Downloaded metrics-macros v0.6.0 [INFO] [stderr] Downloaded portable-atomic v0.3.20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b456be0d893e7afbba94b4dc3f5e8ecc2c36bbfff03e63278366fb0bf0132855 [INFO] running `Command { std: "docker" "start" "-a" "b456be0d893e7afbba94b4dc3f5e8ecc2c36bbfff03e63278366fb0bf0132855", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b456be0d893e7afbba94b4dc3f5e8ecc2c36bbfff03e63278366fb0bf0132855", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b456be0d893e7afbba94b4dc3f5e8ecc2c36bbfff03e63278366fb0bf0132855", kill_on_drop: false }` [INFO] [stdout] b456be0d893e7afbba94b4dc3f5e8ecc2c36bbfff03e63278366fb0bf0132855 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae0f9bdf5bfc503735b2e379c25fd409d710283290ff02b85334af8932ecba5c [INFO] running `Command { std: "docker" "start" "-a" "ae0f9bdf5bfc503735b2e379c25fd409d710283290ff02b85334af8932ecba5c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking unsigned-varint v0.8.0 [INFO] [stderr] Compiling data-encoding v2.10.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Compiling match-lookup v0.1.2 [INFO] [stderr] Checking const-str v0.4.3 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking asn1_der v0.7.7 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking multihash v0.19.3 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Compiling libp2p-swarm-derive v0.35.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling portable-atomic v1.13.1 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking base256emoji v1.0.2 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking netlink-packet-core v0.8.1 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling winnow v1.0.0 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.17 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling toml_datetime v1.0.1+spec-1.1.0 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking tinyvec v1.11.0 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling enum-as-inner v0.6.1 [INFO] [stderr] Checking data-encoding-macro v0.1.19 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking multibase v0.9.2 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling prometheus-client v0.22.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling portable-atomic v0.3.20 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling snow v0.9.6 [INFO] [stderr] Compiling prometheus-client-derive-encode v0.4.2 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Compiling metrics v0.20.1 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking dtoa v1.0.11 [INFO] [stderr] Checking uint v0.10.0 [INFO] [stderr] Compiling const_format_proc_macros v0.2.34 [INFO] [stderr] Checking raw-cpuid v10.7.0 [INFO] [stderr] Compiling parity-scale-codec v3.7.5 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking getrandom v0.4.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling toml_parser v1.0.10+spec-1.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking netlink-packet-route v0.28.0 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Compiling toml_edit v0.25.5+spec-1.1.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking asynchronous-codec v0.7.0 [INFO] [stderr] Checking futures-bounded v0.2.4 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking moka v0.12.14 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking quick-protobuf-codec v0.3.1 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Checking multistream-select v0.13.0 [INFO] [stderr] Checking rw-stream-sink v0.4.0 [INFO] [stderr] Compiling proc-macro-crate v3.5.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking keccak v0.1.6 [INFO] [stderr] Checking resolv-conf v0.7.6 [INFO] [stderr] Checking hex_fmt v0.3.0 [INFO] [stderr] Checking tracing-subscriber v0.3.23 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking yamux v0.13.10 [INFO] [stderr] Checking soketto v0.8.1 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking k256 v0.13.4 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking yamux v0.12.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking const_format v0.2.35 [INFO] [stderr] Checking quanta v0.10.1 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking opentelemetry v0.30.0 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.3 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Compiling parity-scale-codec-derive v3.7.5 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Checking predicates-core v1.0.10 [INFO] [stderr] Checking byte-slice-cast v1.2.3 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling scale-info-derive v2.11.6 [INFO] [stderr] Checking libp2p-identity v0.2.13 [INFO] [stderr] Checking libp2p-pnet v0.26.0 [INFO] [stderr] Checking indexmap v1.9.3 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking multiaddr v0.18.2 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Checking traitobject v0.1.1 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking error v0.1.9 [INFO] [stderr] Checking predicates-tree v1.0.13 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking petgraph v0.8.3 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking lru v0.14.0 [INFO] [stderr] Compiling test-log-macros v0.2.19 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking libp2p-core v0.43.2 [INFO] [stderr] Checking fragile v2.0.1 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking proptest v1.10.0 [INFO] [stderr] Checking test-log v0.2.19 [INFO] [stderr] Compiling metrics-macros v0.6.0 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking libp2p-yamux v0.47.0 [INFO] [stderr] Checking libp2p-noise v0.46.1 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking metrics-util v0.14.0 [INFO] [stderr] Checking scale-info v2.11.6 [INFO] [stderr] Checking libp2p-swarm v0.46.0 [INFO] [stderr] Checking netlink-sys v0.8.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking hickory-proto v0.25.0-alpha.5 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking netlink-proto v0.12.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking opentelemetry_sdk v0.30.0 [INFO] [stderr] Checking tokio-test v0.4.5 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking rtnetlink v0.20.0 [INFO] [stderr] Checking futures-rustls v0.26.0 [INFO] [stderr] Checking libp2p-kad v0.47.0 [INFO] [stderr] Checking libp2p-relay v0.19.0 [INFO] [stderr] Checking libp2p-request-response v0.28.0 [INFO] [stderr] Checking libp2p-ping v0.46.0 [INFO] [stderr] Checking libp2p-identify v0.46.0 [INFO] [stderr] Checking libp2p-gossipsub v0.48.0 [INFO] [stderr] Checking libp2p-dcutr v0.13.0 [INFO] [stderr] Checking libp2p-allow-block-list v0.5.0 [INFO] [stderr] Checking libp2p-websocket v0.45.1 [INFO] [stderr] Checking if-watch v3.2.2 [INFO] [stderr] Checking libp2p-connection-limits v0.5.0 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking libp2p-tcp v0.43.0 [INFO] [stderr] Checking libp2p-autonat v0.14.0 [INFO] [stderr] Checking metrics-exporter-prometheus v0.11.0 [INFO] [stderr] Checking hickory-resolver v0.25.0-alpha.5 [INFO] [stderr] Checking libp2p-mdns v0.47.0 [INFO] [stderr] Checking tracing-opentelemetry v0.31.0 [INFO] [stderr] Checking libp2p-dns v0.43.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking libp2p-metrics v0.16.0 [INFO] [stderr] Checking libp2p v0.55.0 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking frost-protocol v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/extensions/traits.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / /// Result type for extension operations [INFO] [stdout] 22 | | //pub type ExtensionResult = Result; [INFO] [stdout] 23 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub trait Extension: Send + Sync { [INFO] [stdout] | ------------------- the attribute applies to this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/extensions/traits.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / /// Result type for extension operations [INFO] [stdout] 22 | | //pub type ExtensionResult = Result; [INFO] [stdout] 23 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub trait Extension: Send + Sync { [INFO] [stdout] | ------------------- the attribute applies to this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `metrics` is never read [INFO] [stdout] --> src/network/retry.rs:158:21 [INFO] [stdout] | [INFO] [stdout] 158 | metrics.successful_retries += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `metrics` is never read [INFO] [stdout] --> src/network/retry.rs:158:21 [INFO] [stdout] | [INFO] [stdout] 158 | metrics.successful_retries += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/message/types.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | / impl Default for MessagePriority { [INFO] [stdout] 34 | | fn default() -> Self { [INFO] [stdout] 35 | | Self::Normal [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub enum MessagePriority { [INFO] [stdout] 28 | Low, [INFO] [stdout] 29 ~ #[default] [INFO] [stdout] 30 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/message/types.rs:174:5 [INFO] [stdout] | [INFO] [stdout] 174 | / pub fn new_chain_message( [INFO] [stdout] 175 | | msg_type: MessageType, [INFO] [stdout] 176 | | payload: Vec, [INFO] [stdout] 177 | | source: String, [INFO] [stdout] ... | [INFO] [stdout] 184 | | proof_metadata: Option, [INFO] [stdout] 185 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/message/validation.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | / if !result.is_valid { [INFO] [stdout] 183 | | if !result.rules_failed.is_empty() { [INFO] [stdout] 184 | | return Err(MessageError::ValidationFailed( [INFO] [stdout] 185 | | result.rules_failed[0].reason.clone() [INFO] [stdout] ... | [INFO] [stdout] 188 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 182 ~ if !result.is_valid [INFO] [stdout] 183 ~ && !result.rules_failed.is_empty() { [INFO] [stdout] 184 | return Err(MessageError::ValidationFailed( [INFO] [stdout] 185 | result.rules_failed[0].reason.clone() [INFO] [stdout] 186 | ).into()); [INFO] [stdout] 187 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BasicValidationPipeline` [INFO] [stdout] --> src/message/validation.rs:269:5 [INFO] [stdout] | [INFO] [stdout] 269 | / pub fn new() -> Self { [INFO] [stdout] 270 | | Self { [INFO] [stdout] 271 | | transformers: Vec::new(), [INFO] [stdout] 272 | | } [INFO] [stdout] 273 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 268 + impl Default for BasicValidationPipeline { [INFO] [stdout] 269 + fn default() -> Self { [INFO] [stdout] 270 + Self::new() [INFO] [stdout] 271 + } [INFO] [stdout] 272 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/message/validation.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | / if !result.is_valid { [INFO] [stdout] 309 | | if !result.rules_failed.is_empty() { [INFO] [stdout] 310 | | return Err(MessageError::ValidationFailed( [INFO] [stdout] 311 | | result.rules_failed[0].reason.clone() [INFO] [stdout] ... | [INFO] [stdout] 314 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 308 ~ if !result.is_valid [INFO] [stdout] 309 ~ && !result.rules_failed.is_empty() { [INFO] [stdout] 310 | return Err(MessageError::ValidationFailed( [INFO] [stdout] 311 | result.rules_failed[0].reason.clone() [INFO] [stdout] 312 | ).into()); [INFO] [stdout] 313 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ProofRegistry` [INFO] [stdout] --> src/state/proof.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 267 | / pub fn new() -> Self { [INFO] [stdout] 268 | | Self { [INFO] [stdout] 269 | | generators: DashMap::new(), [INFO] [stdout] 270 | | verifiers: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 265 + impl Default for ProofRegistry { [INFO] [stdout] 266 + fn default() -> Self { [INFO] [stdout] 267 + Self::new() [INFO] [stdout] 268 + } [INFO] [stdout] 269 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/state/types.rs:74:1 [INFO] [stdout] | [INFO] [stdout] 74 | / impl Default for BlockRef { [INFO] [stdout] 75 | | fn default() -> Self { [INFO] [stdout] 76 | | Self { [INFO] [stdout] 77 | | chain_id: ChainId::default(), [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 40 + #[derive(Default)] [INFO] [stdout] 41 | pub struct BlockRef { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/state/types.rs:92:1 [INFO] [stdout] | [INFO] [stdout] 92 | / impl Default for StateRoot { [INFO] [stdout] 93 | | fn default() -> Self { [INFO] [stdout] 94 | | Self { [INFO] [stdout] 95 | | block_ref: BlockRef::default(), [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 86 + #[derive(Default)] [INFO] [stdout] 87 | pub struct StateRoot { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/state/cache.rs:155:10 [INFO] [stdout] | [INFO] [stdout] 155 | ) -> Result<(), ProofError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 160 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `state::error::ProofError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RevocationRegistry` [INFO] [stdout] --> src/state/revocation.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | / pub fn new() -> Self { [INFO] [stdout] 61 | | Self { [INFO] [stdout] 62 | | revoked_proofs: DashSet::new(), [INFO] [stdout] 63 | | revocation_history: Vec::new(), [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for RevocationRegistry { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/state/revocation.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | ) -> Result<(), ProofError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 160 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `state::error::ProofError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/state/revocation.rs:116:10 [INFO] [stdout] | [INFO] [stdout] 116 | ) -> Result<(), ProofError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 160 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `state::error::ProofError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/network/discovery.rs:248:17 [INFO] [stdout] | [INFO] [stdout] 248 | / if !self.known_peers.contains(&peer) { [INFO] [stdout] 249 | | self.known_peers.insert(peer); [INFO] [stdout] 250 | | if let Err(e) = self.event_tx.send(P2PEvent::PeerConnected(peer)).await { [INFO] [stdout] 251 | | return Err(NetworkError::EventSendFailed(e.to_string()).into()); [INFO] [stdout] 252 | | } [INFO] [stdout] 253 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ KademliaEvent::RoutingUpdated { peer, .. } [INFO] [stdout] 247 | // Update routing table [INFO] [stdout] 248 ~ if !self.known_peers.contains(&peer) => { [INFO] [stdout] 249 | self.known_peers.insert(peer); [INFO] [stdout] ... [INFO] [stdout] 252 | } [INFO] [stdout] 253 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/message/types.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | / impl Default for MessagePriority { [INFO] [stdout] 34 | | fn default() -> Self { [INFO] [stdout] 35 | | Self::Normal [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub enum MessagePriority { [INFO] [stdout] 28 | Low, [INFO] [stdout] 29 ~ #[default] [INFO] [stdout] 30 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/message/types.rs:174:5 [INFO] [stdout] | [INFO] [stdout] 174 | / pub fn new_chain_message( [INFO] [stdout] 175 | | msg_type: MessageType, [INFO] [stdout] 176 | | payload: Vec, [INFO] [stdout] 177 | | source: String, [INFO] [stdout] ... | [INFO] [stdout] 184 | | proof_metadata: Option, [INFO] [stdout] 185 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/message/validation.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | / if !result.is_valid { [INFO] [stdout] 183 | | if !result.rules_failed.is_empty() { [INFO] [stdout] 184 | | return Err(MessageError::ValidationFailed( [INFO] [stdout] 185 | | result.rules_failed[0].reason.clone() [INFO] [stdout] ... | [INFO] [stdout] 188 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 182 ~ if !result.is_valid [INFO] [stdout] 183 ~ && !result.rules_failed.is_empty() { [INFO] [stdout] 184 | return Err(MessageError::ValidationFailed( [INFO] [stdout] 185 | result.rules_failed[0].reason.clone() [INFO] [stdout] 186 | ).into()); [INFO] [stdout] 187 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BasicValidationPipeline` [INFO] [stdout] --> src/message/validation.rs:269:5 [INFO] [stdout] | [INFO] [stdout] 269 | / pub fn new() -> Self { [INFO] [stdout] 270 | | Self { [INFO] [stdout] 271 | | transformers: Vec::new(), [INFO] [stdout] 272 | | } [INFO] [stdout] 273 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 268 + impl Default for BasicValidationPipeline { [INFO] [stdout] 269 + fn default() -> Self { [INFO] [stdout] 270 + Self::new() [INFO] [stdout] 271 + } [INFO] [stdout] 272 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/message/validation.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | / if !result.is_valid { [INFO] [stdout] 309 | | if !result.rules_failed.is_empty() { [INFO] [stdout] 310 | | return Err(MessageError::ValidationFailed( [INFO] [stdout] 311 | | result.rules_failed[0].reason.clone() [INFO] [stdout] ... | [INFO] [stdout] 314 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 308 ~ if !result.is_valid [INFO] [stdout] 309 ~ && !result.rules_failed.is_empty() { [INFO] [stdout] 310 | return Err(MessageError::ValidationFailed( [INFO] [stdout] 311 | result.rules_failed[0].reason.clone() [INFO] [stdout] 312 | ).into()); [INFO] [stdout] 313 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network/pool.rs:220:14 [INFO] [stdout] | [INFO] [stdout] 220 | .or_insert_with(PeerMetrics::default); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ProofRegistry` [INFO] [stdout] --> src/state/proof.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 267 | / pub fn new() -> Self { [INFO] [stdout] 268 | | Self { [INFO] [stdout] 269 | | generators: DashMap::new(), [INFO] [stdout] 270 | | verifiers: DashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 265 + impl Default for ProofRegistry { [INFO] [stdout] 266 + fn default() -> Self { [INFO] [stdout] 267 + Self::new() [INFO] [stdout] 268 + } [INFO] [stdout] 269 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/network/retry.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | / match &error { [INFO] [stdout] 164 | | Error::Network(err_str) => { [INFO] [stdout] 165 | | let network_error = NetworkError::ConnectionFailed(err_str.clone()); [INFO] [stdout] 166 | | if policy.should_retry(&network_error, attempt).await { [INFO] [stdout] ... | [INFO] [stdout] 173 | | _ => {} [INFO] [stdout] 174 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 163 ~ if let Error::Network(err_str) = &error { [INFO] [stdout] 164 + let network_error = NetworkError::ConnectionFailed(err_str.clone()); [INFO] [stdout] 165 + if policy.should_retry(&network_error, attempt).await { [INFO] [stdout] 166 + let delay = policy.get_delay(attempt).await; [INFO] [stdout] 167 + tokio::time::sleep(delay).await; [INFO] [stdout] 168 + last_error = Some(error); [INFO] [stdout] 169 + continue; [INFO] [stdout] 170 + } [INFO] [stdout] 171 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/state/types.rs:74:1 [INFO] [stdout] | [INFO] [stdout] 74 | / impl Default for BlockRef { [INFO] [stdout] 75 | | fn default() -> Self { [INFO] [stdout] 76 | | Self { [INFO] [stdout] 77 | | chain_id: ChainId::default(), [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 40 + #[derive(Default)] [INFO] [stdout] 41 | pub struct BlockRef { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/state/types.rs:92:1 [INFO] [stdout] | [INFO] [stdout] 92 | / impl Default for StateRoot { [INFO] [stdout] 93 | | fn default() -> Self { [INFO] [stdout] 94 | | Self { [INFO] [stdout] 95 | | block_ref: BlockRef::default(), [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 86 + #[derive(Default)] [INFO] [stdout] 87 | pub struct StateRoot { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NodeIdentity` [INFO] [stdout] --> src/network/p2p.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / pub fn new() -> Self { [INFO] [stdout] 91 | | let keypair = identity::Keypair::generate_ed25519(); [INFO] [stdout] 92 | | let peer_id = PeerId::from(keypair.public()); [INFO] [stdout] 93 | | Self { peer_id, keypair } [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 88 + impl Default for NodeIdentity { [INFO] [stdout] 89 + fn default() -> Self { [INFO] [stdout] 90 + Self::new() [INFO] [stdout] 91 + } [INFO] [stdout] 92 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/network/p2p.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 176 | swarm: Arc::new(RwLock::new(swarm)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>>` is not `Send` and `Sync` as `RwLock>` is not `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `RwLock>` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/network/p2p.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | let mut swarm = self.swarm.write(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/network/p2p.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | / tokio::select! { [INFO] [stdout] 222 | | event = swarm.select_next_some() => { [INFO] [stdout] 223 | | self.handle_swarm_event(event).await?; [INFO] [stdout] | | ^^^^^ [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FromSwarm<'_>` which implements the `Copy` trait [INFO] [stdout] --> src/network/p2p.rs:267:34 [INFO] [stdout] | [INFO] [stdout] 267 | self.ping.on_swarm_event(event.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FromSwarm<'_>` which implements the `Copy` trait [INFO] [stdout] --> src/network/p2p.rs:268:38 [INFO] [stdout] | [INFO] [stdout] 268 | self.identify.on_swarm_event(event.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FromSwarm<'_>` which implements the `Copy` trait [INFO] [stdout] --> src/network/p2p.rs:269:33 [INFO] [stdout] | [INFO] [stdout] 269 | self.kad.on_swarm_event(event.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/state/cache.rs:155:10 [INFO] [stdout] | [INFO] [stdout] 155 | ) -> Result<(), ProofError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 160 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `state::error::ProofError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultStrategy` [INFO] [stdout] --> src/routing/strategy.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / pub fn new() -> Self { [INFO] [stdout] 34 | | Self { [INFO] [stdout] 35 | | route_cache: HashMap::new(), [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 31 + impl Default for DefaultStrategy { [INFO] [stdout] 32 + fn default() -> Self { [INFO] [stdout] 33 + Self::new() [INFO] [stdout] 34 + } [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/routing/strategy.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / impl PartialOrd for Distance { [INFO] [stdout] 147 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 148 | | other.0.partial_cmp(&self.0) [INFO] [stdout] 149 | | } [INFO] [stdout] 150 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 147 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 148 - other.0.partial_cmp(&self.0) [INFO] [stdout] 149 - } [INFO] [stdout] 147 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/routing/strategy.rs:231:18 [INFO] [stdout] | [INFO] [stdout] 231 | route_cache: RwLock>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RevocationRegistry` [INFO] [stdout] --> src/state/revocation.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | / pub fn new() -> Self { [INFO] [stdout] 61 | | Self { [INFO] [stdout] 62 | | revoked_proofs: DashSet::new(), [INFO] [stdout] 63 | | revocation_history: Vec::new(), [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for RevocationRegistry { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/state/revocation.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | ) -> Result<(), ProofError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 160 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `state::error::ProofError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/state/revocation.rs:116:10 [INFO] [stdout] | [INFO] [stdout] 116 | ) -> Result<(), ProofError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 160 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `state::error::ProofError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/routing/topology.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | score.min(1.0).max(0.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `score.clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/routing/topology.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | score.min(1.0).max(0.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `score.clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ChainMetricsAggregator` [INFO] [stdout] --> src/metrics/chain_metrics.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | / pub fn new() -> Self { [INFO] [stdout] 147 | | Self { [INFO] [stdout] 148 | | collectors: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] 149 | | } [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 145 + impl Default for ChainMetricsAggregator { [INFO] [stdout] 146 + fn default() -> Self { [INFO] [stdout] 147 + Self::new() [INFO] [stdout] 148 + } [INFO] [stdout] 149 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DependencyResolver` [INFO] [stdout] --> src/extensions/dependency.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> Self { [INFO] [stdout] 14 | | Self { [INFO] [stdout] 15 | | dependency_graph: Graph::new(), [INFO] [stdout] 16 | | node_indices: HashMap::new(), [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for DependencyResolver { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ExtensionRegistry` [INFO] [stdout] --> src/extensions/registry.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / pub fn new() -> Self { [INFO] [stdout] 49 | | Self { [INFO] [stdout] 50 | | extensions: RwLock::new(HashMap::new()), [INFO] [stdout] 51 | | version_counter: AtomicU64::new(0), [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 46 + impl Default for ExtensionRegistry { [INFO] [stdout] 47 + fn default() -> Self { [INFO] [stdout] 48 + Self::new() [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultExtensionManager` [INFO] [stdout] --> src/extensions/manager.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Self { [INFO] [stdout] 37 | | Self { [INFO] [stdout] 38 | | registry: Arc::new(ExtensionRegistry::new()), [INFO] [stdout] 39 | | dependency_graph: RwLock::new(HashMap::new()), [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 34 + impl Default for DefaultExtensionManager { [INFO] [stdout] 35 + fn default() -> Self { [INFO] [stdout] 36 + Self::new() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/extensions/manager.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 51 | if !self.registry.get_extension(&dep_id).await?.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.registry.get_extension(&dep_id).await?.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/extensions/manager.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | / if !visited.contains(id) { [INFO] [stdout] 75 | | if self.has_cycle(id, &graph, &mut visited, &mut stack).await? { [INFO] [stdout] 76 | | return Err(anyhow!("Dependency cycle detected")); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if !visited.contains(id) [INFO] [stdout] 75 ~ && self.has_cycle(id, &graph, &mut visited, &mut stack).await? { [INFO] [stdout] 76 | return Err(anyhow!("Dependency cycle detected")); [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/network/discovery.rs:248:17 [INFO] [stdout] | [INFO] [stdout] 248 | / if !self.known_peers.contains(&peer) { [INFO] [stdout] 249 | | self.known_peers.insert(peer); [INFO] [stdout] 250 | | if let Err(e) = self.event_tx.send(P2PEvent::PeerConnected(peer)).await { [INFO] [stdout] 251 | | return Err(NetworkError::EventSendFailed(e.to_string()).into()); [INFO] [stdout] 252 | | } [INFO] [stdout] 253 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ KademliaEvent::RoutingUpdated { peer, .. } [INFO] [stdout] 247 | // Update routing table [INFO] [stdout] 248 ~ if !self.known_peers.contains(&peer) => { [INFO] [stdout] 249 | self.known_peers.insert(peer); [INFO] [stdout] ... [INFO] [stdout] 252 | } [INFO] [stdout] 253 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/network/backpressure.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | async fn try_acquire(&self) -> Result { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 105 | async fn try_acquire(&self) -> Result> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network/pool.rs:220:14 [INFO] [stdout] | [INFO] [stdout] 220 | .or_insert_with(PeerMetrics::default); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/network/retry.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | / match &error { [INFO] [stdout] 164 | | Error::Network(err_str) => { [INFO] [stdout] 165 | | let network_error = NetworkError::ConnectionFailed(err_str.clone()); [INFO] [stdout] 166 | | if policy.should_retry(&network_error, attempt).await { [INFO] [stdout] ... | [INFO] [stdout] 173 | | _ => {} [INFO] [stdout] 174 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 163 ~ if let Error::Network(err_str) = &error { [INFO] [stdout] 164 + let network_error = NetworkError::ConnectionFailed(err_str.clone()); [INFO] [stdout] 165 + if policy.should_retry(&network_error, attempt).await { [INFO] [stdout] 166 + let delay = policy.get_delay(attempt).await; [INFO] [stdout] 167 + tokio::time::sleep(delay).await; [INFO] [stdout] 168 + last_error = Some(error); [INFO] [stdout] 169 + continue; [INFO] [stdout] 170 + } [INFO] [stdout] 171 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NodeIdentity` [INFO] [stdout] --> src/network/p2p.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / pub fn new() -> Self { [INFO] [stdout] 91 | | let keypair = identity::Keypair::generate_ed25519(); [INFO] [stdout] 92 | | let peer_id = PeerId::from(keypair.public()); [INFO] [stdout] 93 | | Self { peer_id, keypair } [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 88 + impl Default for NodeIdentity { [INFO] [stdout] 89 + fn default() -> Self { [INFO] [stdout] 90 + Self::new() [INFO] [stdout] 91 + } [INFO] [stdout] 92 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/network/p2p.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 176 | swarm: Arc::new(RwLock::new(swarm)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>>` is not `Send` and `Sync` as `RwLock>` is not `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `RwLock>` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/network/p2p.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | let mut swarm = self.swarm.write(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/network/p2p.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | / tokio::select! { [INFO] [stdout] 222 | | event = swarm.select_next_some() => { [INFO] [stdout] 223 | | self.handle_swarm_event(event).await?; [INFO] [stdout] | | ^^^^^ [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FromSwarm<'_>` which implements the `Copy` trait [INFO] [stdout] --> src/network/p2p.rs:267:34 [INFO] [stdout] | [INFO] [stdout] 267 | self.ping.on_swarm_event(event.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FromSwarm<'_>` which implements the `Copy` trait [INFO] [stdout] --> src/network/p2p.rs:268:38 [INFO] [stdout] | [INFO] [stdout] 268 | self.identify.on_swarm_event(event.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FromSwarm<'_>` which implements the `Copy` trait [INFO] [stdout] --> src/network/p2p.rs:269:33 [INFO] [stdout] | [INFO] [stdout] 269 | self.kad.on_swarm_event(event.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultStrategy` [INFO] [stdout] --> src/routing/strategy.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / pub fn new() -> Self { [INFO] [stdout] 34 | | Self { [INFO] [stdout] 35 | | route_cache: HashMap::new(), [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 31 + impl Default for DefaultStrategy { [INFO] [stdout] 32 + fn default() -> Self { [INFO] [stdout] 33 + Self::new() [INFO] [stdout] 34 + } [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/routing/strategy.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / impl PartialOrd for Distance { [INFO] [stdout] 147 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 148 | | other.0.partial_cmp(&self.0) [INFO] [stdout] 149 | | } [INFO] [stdout] 150 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 147 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 148 - other.0.partial_cmp(&self.0) [INFO] [stdout] 149 - } [INFO] [stdout] 147 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/routing/strategy.rs:231:18 [INFO] [stdout] | [INFO] [stdout] 231 | route_cache: RwLock>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/routing/topology.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | score.min(1.0).max(0.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `score.clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/routing/topology.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | score.min(1.0).max(0.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `score.clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ChainMetricsAggregator` [INFO] [stdout] --> src/metrics/chain_metrics.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | / pub fn new() -> Self { [INFO] [stdout] 147 | | Self { [INFO] [stdout] 148 | | collectors: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] 149 | | } [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 145 + impl Default for ChainMetricsAggregator { [INFO] [stdout] 146 + fn default() -> Self { [INFO] [stdout] 147 + Self::new() [INFO] [stdout] 148 + } [INFO] [stdout] 149 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DependencyResolver` [INFO] [stdout] --> src/extensions/dependency.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> Self { [INFO] [stdout] 14 | | Self { [INFO] [stdout] 15 | | dependency_graph: Graph::new(), [INFO] [stdout] 16 | | node_indices: HashMap::new(), [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for DependencyResolver { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ExtensionRegistry` [INFO] [stdout] --> src/extensions/registry.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / pub fn new() -> Self { [INFO] [stdout] 49 | | Self { [INFO] [stdout] 50 | | extensions: RwLock::new(HashMap::new()), [INFO] [stdout] 51 | | version_counter: AtomicU64::new(0), [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 46 + impl Default for ExtensionRegistry { [INFO] [stdout] 47 + fn default() -> Self { [INFO] [stdout] 48 + Self::new() [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultExtensionManager` [INFO] [stdout] --> src/extensions/manager.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Self { [INFO] [stdout] 37 | | Self { [INFO] [stdout] 38 | | registry: Arc::new(ExtensionRegistry::new()), [INFO] [stdout] 39 | | dependency_graph: RwLock::new(HashMap::new()), [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 34 + impl Default for DefaultExtensionManager { [INFO] [stdout] 35 + fn default() -> Self { [INFO] [stdout] 36 + Self::new() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/extensions/manager.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 51 | if !self.registry.get_extension(&dep_id).await?.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.registry.get_extension(&dep_id).await?.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/extensions/manager.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | / if !visited.contains(id) { [INFO] [stdout] 75 | | if self.has_cycle(id, &graph, &mut visited, &mut stack).await? { [INFO] [stdout] 76 | | return Err(anyhow!("Dependency cycle detected")); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if !visited.contains(id) [INFO] [stdout] 75 ~ && self.has_cycle(id, &graph, &mut visited, &mut stack).await? { [INFO] [stdout] 76 | return Err(anyhow!("Dependency cycle detected")); [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/network/backpressure.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | async fn try_acquire(&self) -> Result { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 105 | async fn try_acquire(&self) -> Result> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/unit/extensions/mod.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | config.finality_timeout = Duration::from_secs(30); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::finality::verifier::FinalityConfig { finality_timeout: Duration::from_secs(30), min_confirmations: 6, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | let mut config = FinalityConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | config.finality_timeout = Duration::from_secs(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::finality::verifier::FinalityConfig { finality_timeout: Duration::from_secs(1), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | let mut config = FinalityConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | config.max_entries = 2; // Small cache for testing eviction [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_entries: 2, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | config.max_entries = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_entries: 2, eviction_policy: EvictionPolicy::LRU, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | config.max_size_bytes = 1024; // Small size limit [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_size_bytes: 1024, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/unit/state/proof_test.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(proof.proof.data.len() > 0, "Proof data should not be empty"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!proof.proof.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 74 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 74 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:106:20 [INFO] [stdout] | [INFO] [stdout] 106 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 106 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 106 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:143:20 [INFO] [stdout] | [INFO] [stdout] 143 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 143 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 143 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:85:21 [INFO] [stdout] | [INFO] [stdout] 85 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 85 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 85 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 103 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 103 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 121 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 121 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | config.finality_timeout = Duration::from_secs(30); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::finality::verifier::FinalityConfig { finality_timeout: Duration::from_secs(30), min_confirmations: 6, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | let mut config = FinalityConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | config.finality_timeout = Duration::from_secs(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::finality::verifier::FinalityConfig { finality_timeout: Duration::from_secs(1), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | let mut config = FinalityConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | config.max_entries = 2; // Small cache for testing eviction [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_entries: 2, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | config.max_entries = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_entries: 2, eviction_policy: EvictionPolicy::LRU, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | config.max_size_bytes = 1024; // Small size limit [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_size_bytes: 1024, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/unit/state/proof_test.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(proof.proof.data.len() > 0, "Proof data should not be empty"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!proof.proof.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 74 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 74 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:106:20 [INFO] [stdout] | [INFO] [stdout] 106 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 106 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 106 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:143:20 [INFO] [stdout] | [INFO] [stdout] 143 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 143 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 143 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:85:21 [INFO] [stdout] | [INFO] [stdout] 85 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 85 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 85 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 103 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 103 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 121 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 121 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | config.finality_timeout = Duration::from_secs(30); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::finality::verifier::FinalityConfig { finality_timeout: Duration::from_secs(30), min_confirmations: 6, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | let mut config = FinalityConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | config.finality_timeout = Duration::from_secs(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::finality::verifier::FinalityConfig { finality_timeout: Duration::from_secs(1), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/finality/verifier_test.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | let mut config = FinalityConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | config.max_entries = 2; // Small cache for testing eviction [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_entries: 2, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | config.max_entries = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_entries: 2, eviction_policy: EvictionPolicy::LRU, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> tests/unit/state/cache_test.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | config.max_size_bytes = 1024; // Small size limit [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `frost_protocol::state::cache::CacheConfig { max_size_bytes: 1024, enable_metrics: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> tests/unit/state/cache_test.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | let mut config = CacheConfig::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/unit/state/proof_test.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(proof.proof.data.len() > 0, "Proof data should not be empty"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!proof.proof.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 74 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 74 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:106:20 [INFO] [stdout] | [INFO] [stdout] 106 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 106 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 106 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/proof_test.rs:143:20 [INFO] [stdout] | [INFO] [stdout] 143 | let verifier = TestProofVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 143 - let verifier = TestProofVerifier::default(); [INFO] [stdout] 143 + let verifier = TestProofVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:85:21 [INFO] [stdout] | [INFO] [stdout] 85 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 85 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 85 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 103 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 103 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/unit/state/transition_test.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | let validator = TestTransitionVerifier::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 121 - let validator = TestTransitionVerifier::default(); [INFO] [stdout] 121 + let validator = TestTransitionVerifier; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 13s [INFO] running `Command { std: "docker" "inspect" "ae0f9bdf5bfc503735b2e379c25fd409d710283290ff02b85334af8932ecba5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae0f9bdf5bfc503735b2e379c25fd409d710283290ff02b85334af8932ecba5c", kill_on_drop: false }` [INFO] [stdout] ae0f9bdf5bfc503735b2e379c25fd409d710283290ff02b85334af8932ecba5c