[INFO] cloning repository https://github.com/aucker/google-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aucker/google-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faucker%2Fgoogle-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faucker%2Fgoogle-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cbdcaa38db8b744f24db4c9738f33813fd649955 [INFO] linting aucker/google-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faucker%2Fgoogle-rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aucker/google-rust [INFO] finished tweaking git repo https://github.com/aucker/google-rust [INFO] tweaked toml for git repo https://github.com/aucker/google-rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aucker/google-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aucker/google-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1a7ff1745d1d9fdcb90b84e86d3fb511643da53fe09463291375b79be2a3933 [INFO] running `Command { std: "docker" "start" "-a" "e1a7ff1745d1d9fdcb90b84e86d3fb511643da53fe09463291375b79be2a3933", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1a7ff1745d1d9fdcb90b84e86d3fb511643da53fe09463291375b79be2a3933", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1a7ff1745d1d9fdcb90b84e86d3fb511643da53fe09463291375b79be2a3933", kill_on_drop: false }` [INFO] [stdout] e1a7ff1745d1d9fdcb90b84e86d3fb511643da53fe09463291375b79be2a3933 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bec139dfbd61a8bd3892c9c0a487cdbd7a5f99d632fd428418fec2dbfa43aef3 [INFO] running `Command { std: "docker" "start" "-a" "bec139dfbd61a8bd3892c9c0a487cdbd7a5f99d632fd428418fec2dbfa43aef3", kill_on_drop: false }` [INFO] [stderr] Checking google-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | if (a == 1 && b == 1) || (a == 1 && b == 2) || (a == 2 && b == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 - if (a == 1 && b == 1) || (a == 1 && b == 2) || (a == 2 && b == 1) { [INFO] [stdout] 19 + if !(a != 1 || b != 1 && b != 2) || (a == 2 && b == 1) { [INFO] [stdout] | [INFO] [stdout] 19 - if (a == 1 && b == 1) || (a == 1 && b == 2) || (a == 2 && b == 1) { [INFO] [stdout] 19 + if (b == 2 || b == 1) && a == 1 || (a == 2 && b == 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:19:83 [INFO] [stdout] | [INFO] [stdout] 19 | if (a == 1 && b == 1) || (a == 1 && b == 2) || (a == 2 && b == 1) { [INFO] [stdout] | ___________________________________________________________________________________^ [INFO] [stdout] 20 | | print!("."); [INFO] [stdout] 21 | | } else if a % 2 == 0 && b % 2 == 0 { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:21:52 [INFO] [stdout] | [INFO] [stdout] 21 | } else if a % 2 == 0 && b % 2 == 0 { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 22 | | print!("."); [INFO] [stdout] 23 | | } else if a % 2 == 0 && b % 2 == 1 { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | if (a == 1 && b == 1) || (a == 1 && b == 2) || (a == 2 && b == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 - if (a == 1 && b == 1) || (a == 1 && b == 2) || (a == 2 && b == 1) { [INFO] [stdout] 19 + if !(a != 1 || b != 1 && b != 2) || (a == 2 && b == 1) { [INFO] [stdout] | [INFO] [stdout] 19 - if (a == 1 && b == 1) || (a == 1 && b == 2) || (a == 2 && b == 1) { [INFO] [stdout] 19 + if (b == 2 || b == 1) && a == 1 || (a == 2 && b == 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:19:83 [INFO] [stdout] | [INFO] [stdout] 19 | if (a == 1 && b == 1) || (a == 1 && b == 2) || (a == 2 && b == 1) { [INFO] [stdout] | ___________________________________________________________________________________^ [INFO] [stdout] 20 | | print!("."); [INFO] [stdout] 21 | | } else if a % 2 == 0 && b % 2 == 0 { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:21:52 [INFO] [stdout] | [INFO] [stdout] 21 | } else if a % 2 == 0 && b % 2 == 0 { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 22 | | print!("."); [INFO] [stdout] 23 | | } else if a % 2 == 0 && b % 2 == 1 { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `Command { std: "docker" "inspect" "bec139dfbd61a8bd3892c9c0a487cdbd7a5f99d632fd428418fec2dbfa43aef3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bec139dfbd61a8bd3892c9c0a487cdbd7a5f99d632fd428418fec2dbfa43aef3", kill_on_drop: false }` [INFO] [stdout] bec139dfbd61a8bd3892c9c0a487cdbd7a5f99d632fd428418fec2dbfa43aef3