[INFO] cloning repository https://github.com/askolds11/pizerocamera [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/askolds11/pizerocamera" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faskolds11%2Fpizerocamera", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faskolds11%2Fpizerocamera'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b52d8f0aab575dc4fb471a69b0a5ac52364ee7d0 [INFO] linting askolds11/pizerocamera against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faskolds11%2Fpizerocamera" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-1-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/askolds11/pizerocamera [INFO] finished tweaking git repo https://github.com/askolds11/pizerocamera [INFO] tweaked toml for git repo https://github.com/askolds11/pizerocamera written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/askolds11/pizerocamera on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/askolds11/pizerocamera already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pest_generator v2.8.1 [INFO] [stderr] Downloaded rumqttc v0.25.1 [INFO] [stderr] Downloaded pest_derive v2.8.1 [INFO] [stderr] Downloaded pest_meta v2.8.1 [INFO] [stderr] Downloaded numpy v0.27.1 [INFO] [stderr] Downloaded jpeg-encoder v0.6.1 [INFO] [stderr] Downloaded reqwest v0.12.27 [INFO] [stderr] Downloaded serde_json v1.0.146 [INFO] [stderr] Downloaded openssl-src v300.5.1+3.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0d7b99b4d192bf7acdcece90e40a42e25a05ac13969edf4b287539da45f10e66 [INFO] running `Command { std: "docker" "start" "-a" "0d7b99b4d192bf7acdcece90e40a42e25a05ac13969edf4b287539da45f10e66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0d7b99b4d192bf7acdcece90e40a42e25a05ac13969edf4b287539da45f10e66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d7b99b4d192bf7acdcece90e40a42e25a05ac13969edf4b287539da45f10e66", kill_on_drop: false }` [INFO] [stdout] 0d7b99b4d192bf7acdcece90e40a42e25a05ac13969edf4b287539da45f10e66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] adab77e58f3cf8c4fde814c7099a968eb6e46138f2e2101224f0812102d6277d [INFO] running `Command { std: "docker" "start" "-a" "adab77e58f3cf8c4fde814c7099a968eb6e46138f2e2101224f0812102d6277d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling pyo3-build-config v0.27.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling cc v1.2.29 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Compiling openssl-src v300.5.1+3.5.1 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling pest v2.8.1 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Compiling pyo3-ffi v0.27.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.27.2 [INFO] [stderr] Compiling serde_json v1.0.146 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling pyo3 v0.27.2 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling pest_meta v2.8.1 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Compiling pest_generator v2.8.1 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking rustix v1.0.7 [INFO] [stderr] Checking toml_parser v1.0.4 [INFO] [stderr] Checking erased-serde v0.4.6 [INFO] [stderr] Compiling pest_derive v2.8.1 [INFO] [stderr] Compiling numpy v0.27.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking serde_spanned v1.0.3 [INFO] [stderr] Checking toml_datetime v0.7.3 [INFO] [stderr] Checking arraydeque v0.5.1 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking yaml-rust2 v0.10.4 [INFO] [stderr] Checking ndarray v0.16.1 [INFO] [stderr] Checking ron v0.12.0 [INFO] [stderr] Checking toml v0.9.8 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking serde-untagged v0.1.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rust-ini v0.21.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Compiling pyo3-macros v0.27.2 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking self-replace v1.5.0 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking hyper-util v0.1.15 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Checking config v0.15.19 [INFO] [stderr] Checking jpeg-encoder v0.6.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking rumqttc v0.25.1 [INFO] [stderr] Checking reqwest v0.12.27 [INFO] [stderr] Checking pizerocamera v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/functions/camera.rs:22:44 [INFO] [stdout] | [INFO] [stdout] 22 | pub const STILL_CAMERA_CONTROLS_FILENAME: &'static str = "controls_still.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/functions/camera.rs:23:44 [INFO] [stdout] | [INFO] [stdout] 23 | pub const VIDEO_CAMERA_CONTROLS_FILENAME: &'static str = "controls_video.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:34:26 [INFO] [stdout] | [INFO] [stdout] 34 | pub const MYAPPVERSION: &'static str = concat!("[MYAPPVERSION:", env!("CARGO_PKG_VERSION"), "]"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/functions/camera.rs:22:44 [INFO] [stdout] | [INFO] [stdout] 22 | pub const STILL_CAMERA_CONTROLS_FILENAME: &'static str = "controls_still.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/functions/camera.rs:23:44 [INFO] [stdout] | [INFO] [stdout] 23 | pub const VIDEO_CAMERA_CONTROLS_FILENAME: &'static str = "controls_video.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:34:26 [INFO] [stdout] | [INFO] [stdout] 34 | pub const MYAPPVERSION: &'static str = concat!("[MYAPPVERSION:", env!("CARGO_PKG_VERSION"), "]"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `stop` is never used [INFO] [stdout] --> src/camera/python_camera.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl CameraService { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 171 | pub fn stop(&self, py: Python) -> PyResult<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `ControlConfig` is never used [INFO] [stdout] --> src/camera/controls.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum ControlConfig { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/functions/requests/camera.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | GetControls(CameraMode), [INFO] [stdout] | ----------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CameraRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 32 - GetControls(CameraMode), [INFO] [stdout] 32 + GetControls(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/camera/python_camera.rs:62:53 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn capture(&self, py: Python, time: u64) -> PyResult<(Vec, u16, u16, HashMap)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `stop` is never used [INFO] [stdout] --> src/camera/python_camera.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl CameraService { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 171 | pub fn stop(&self, py: Python) -> PyResult<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `ControlConfig` is never used [INFO] [stdout] --> src/camera/controls.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum ControlConfig { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/functions/requests/camera.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | GetControls(CameraMode), [INFO] [stdout] | ----------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CameraRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 32 - GetControls(CameraMode), [INFO] [stdout] 32 + GetControls(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/camera/python_camera.rs:62:53 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn capture(&self, py: Python, time: u64) -> PyResult<(Vec, u16, u16, HashMap)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/camera/controls.rs:220:55 [INFO] [stdout] | [INFO] [stdout] 220 | let get_triplet = |obj: Bound<'py, PyAny>| -> Result< [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 221 | | (Bound<'py, PyAny>, Bound<'py, PyAny>, Bound<'py, PyAny>), [INFO] [stdout] 222 | | anyhow::Error, [INFO] [stdout] 223 | | > { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:235:41 [INFO] [stdout] | [INFO] [stdout] 235 | let save_result = take_picture_save(&base_settings, &request, &jpeg_buf, &metadata).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:235:57 [INFO] [stdout] | [INFO] [stdout] 235 | let save_result = take_picture_save(&base_settings, &request, &jpeg_buf, &metadata).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | &base_settings, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | &request, [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 331 | &http_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/functions/camera.rs:390:17 [INFO] [stdout] | [INFO] [stdout] 390 | |py| -> PyResult<(Vec, u16, u16, HashMap)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:411:20 [INFO] [stdout] | [INFO] [stdout] 411 | file.write_all(&bytes).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/functions/ntp.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|x| SuccessWrapper::success(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `SuccessWrapper::success` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/functions/status.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 17 | let camera_mode = (&camera_service.camera_mode).clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `camera_service.camera_mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:94:32 [INFO] [stdout] | [INFO] [stdout] 94 | let update_result = update(&base_settings, &http_client).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:94:48 [INFO] [stdout] | [INFO] [stdout] 94 | let update_result = update(&base_settings, &http_client).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/functions/mod.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / pub async fn handle_notification( [INFO] [stdout] 27 | | base_settings: &BaseSettings, [INFO] [stdout] 28 | | settings: &Settings, [INFO] [stdout] 29 | | mqtt_client: &AsyncClient, [INFO] [stdout] ... | [INFO] [stdout] 34 | | wall_nanoseconds: Option, [INFO] [stdout] 35 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | handle_ntp(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:38:36 [INFO] [stdout] | [INFO] [stdout] 38 | handle_ntp(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | handle_ntp(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:38:61 [INFO] [stdout] | [INFO] [stdout] 38 | handle_ntp(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^ help: change this to: `publish` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | .send_if_err(&base_settings, &mqtt_client, &settings.ntp_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:40:42 [INFO] [stdout] | [INFO] [stdout] 40 | .send_if_err(&base_settings, &mqtt_client, &settings.ntp_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | &base_settings, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | &settings, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | &mqtt_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | &http_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | &publish, [INFO] [stdout] | ^^^^^^^^ help: change this to: `publish` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 53 | .send_if_err(&base_settings, &mqtt_client, &settings.camera_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:53:38 [INFO] [stdout] | [INFO] [stdout] 53 | .send_if_err(&base_settings, &mqtt_client, &settings.camera_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | &base_settings, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | &mqtt_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | &http_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | &should_restart, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `should_restart` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | &publish, [INFO] [stdout] | ^^^^^^^^ help: change this to: `publish` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 65 | .send_if_err(&base_settings, &mqtt_client, &base_settings.update_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:65:38 [INFO] [stdout] | [INFO] [stdout] 65 | .send_if_err(&base_settings, &mqtt_client, &base_settings.update_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/camera/controls.rs:220:55 [INFO] [stdout] | [INFO] [stdout] 220 | let get_triplet = |obj: Bound<'py, PyAny>| -> Result< [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 221 | | (Bound<'py, PyAny>, Bound<'py, PyAny>, Bound<'py, PyAny>), [INFO] [stdout] 222 | | anyhow::Error, [INFO] [stdout] 223 | | > { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | handle_command(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:68:40 [INFO] [stdout] | [INFO] [stdout] 68 | handle_command(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | handle_command(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:68:65 [INFO] [stdout] | [INFO] [stdout] 68 | handle_command(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^ help: change this to: `publish` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | .send_if_err(&base_settings, &mqtt_client, &settings.command_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:70:42 [INFO] [stdout] | [INFO] [stdout] 70 | .send_if_err(&base_settings, &mqtt_client, &settings.command_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:73:23 [INFO] [stdout] | [INFO] [stdout] 73 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 73 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:73:50 [INFO] [stdout] | [INFO] [stdout] 73 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:73:64 [INFO] [stdout] | [INFO] [stdout] 73 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `camera_service` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | .send_if_err(&base_settings, &mqtt_client, &settings.status_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:75:42 [INFO] [stdout] | [INFO] [stdout] 75 | .send_if_err(&base_settings, &mqtt_client, &settings.status_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/startup.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | if p.topic == &base_settings.update_topic { [INFO] [stdout] | ^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `base_settings.update_topic` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/startup.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | if !tokio::fs::metadata("photos").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tokio::fs::metadata("photos").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 118 | .subscribe_to_all(&base_settings, &settings) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:125:30 [INFO] [stdout] | [INFO] [stdout] 125 | read_camera_controls(&base_settings, &mqtt_client, STILL_CAMERA_CONTROLS_FILENAME).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:125:46 [INFO] [stdout] | [INFO] [stdout] 125 | read_camera_controls(&base_settings, &mqtt_client, STILL_CAMERA_CONTROLS_FILENAME).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:127:30 [INFO] [stdout] | [INFO] [stdout] 127 | read_camera_controls(&base_settings, &mqtt_client, VIDEO_CAMERA_CONTROLS_FILENAME).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:127:46 [INFO] [stdout] | [INFO] [stdout] 127 | read_camera_controls(&base_settings, &mqtt_client, VIDEO_CAMERA_CONTROLS_FILENAME).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:144:46 [INFO] [stdout] | [INFO] [stdout] 144 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:147:14 [INFO] [stdout] | [INFO] [stdout] 147 | sync_ntp(&base_settings, &settings, &mqtt_client, &NtpRequest::Step) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:147:41 [INFO] [stdout] | [INFO] [stdout] 147 | sync_ntp(&base_settings, &settings, &mqtt_client, &NtpRequest::Step) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/startup.rs:167:22 [INFO] [stdout] | [INFO] [stdout] 167 | .map_err(|e| anyhow::Error::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `anyhow::Error::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:168:26 [INFO] [stdout] | [INFO] [stdout] 168 | .send_if_err(&base_settings, &mqtt_client, "error") [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:168:42 [INFO] [stdout] | [INFO] [stdout] 168 | .send_if_err(&base_settings, &mqtt_client, "error") [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/startup.rs:172:26 [INFO] [stdout] | [INFO] [stdout] 172 | .map_err(|e| anyhow::Error::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `anyhow::Error::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:173:30 [INFO] [stdout] | [INFO] [stdout] 173 | .send_if_err(&base_settings, &mqtt_client, "error") [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:173:46 [INFO] [stdout] | [INFO] [stdout] 173 | .send_if_err(&base_settings, &mqtt_client, "error") [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/updater/update_error.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / pub enum UpdateError { [INFO] [stdout] 6 | | #[error(transparent)] [INFO] [stdout] 7 | | IoError(#[from] std::io::Error), [INFO] [stdout] 8 | | #[error(transparent)] [INFO] [stdout] ... | [INFO] [stdout] 11 | | HttpError(#[from] HttpError), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/utils/mqtt_utils.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 117 | format!("{}/{}", topic, pi_zero_id.chars().nth(0).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `pi_zero_id.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:235:41 [INFO] [stdout] | [INFO] [stdout] 235 | let save_result = take_picture_save(&base_settings, &request, &jpeg_buf, &metadata).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:235:57 [INFO] [stdout] | [INFO] [stdout] 235 | let save_result = take_picture_save(&base_settings, &request, &jpeg_buf, &metadata).await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | &base_settings, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | &request, [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 331 | &http_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/functions/camera.rs:390:17 [INFO] [stdout] | [INFO] [stdout] 390 | |py| -> PyResult<(Vec, u16, u16, HashMap)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/camera.rs:411:20 [INFO] [stdout] | [INFO] [stdout] 411 | file.write_all(&bytes).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/functions/ntp.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|x| SuccessWrapper::success(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `SuccessWrapper::success` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/functions/status.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 17 | let camera_mode = (&camera_service.camera_mode).clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `camera_service.camera_mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:94:32 [INFO] [stdout] | [INFO] [stdout] 94 | let update_result = update(&base_settings, &http_client).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:94:48 [INFO] [stdout] | [INFO] [stdout] 94 | let update_result = update(&base_settings, &http_client).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/functions/mod.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / pub async fn handle_notification( [INFO] [stdout] 27 | | base_settings: &BaseSettings, [INFO] [stdout] 28 | | settings: &Settings, [INFO] [stdout] 29 | | mqtt_client: &AsyncClient, [INFO] [stdout] ... | [INFO] [stdout] 34 | | wall_nanoseconds: Option, [INFO] [stdout] 35 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | handle_ntp(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:38:36 [INFO] [stdout] | [INFO] [stdout] 38 | handle_ntp(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | handle_ntp(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:38:61 [INFO] [stdout] | [INFO] [stdout] 38 | handle_ntp(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^ help: change this to: `publish` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | .send_if_err(&base_settings, &mqtt_client, &settings.ntp_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:40:42 [INFO] [stdout] | [INFO] [stdout] 40 | .send_if_err(&base_settings, &mqtt_client, &settings.ntp_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | &base_settings, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | &settings, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | &mqtt_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | &http_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | &publish, [INFO] [stdout] | ^^^^^^^^ help: change this to: `publish` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 53 | .send_if_err(&base_settings, &mqtt_client, &settings.camera_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:53:38 [INFO] [stdout] | [INFO] [stdout] 53 | .send_if_err(&base_settings, &mqtt_client, &settings.camera_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | &base_settings, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | &mqtt_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | &http_client, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | &should_restart, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `should_restart` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | &publish, [INFO] [stdout] | ^^^^^^^^ help: change this to: `publish` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 65 | .send_if_err(&base_settings, &mqtt_client, &base_settings.update_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:65:38 [INFO] [stdout] | [INFO] [stdout] 65 | .send_if_err(&base_settings, &mqtt_client, &base_settings.update_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | handle_command(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:68:40 [INFO] [stdout] | [INFO] [stdout] 68 | handle_command(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | handle_command(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:68:65 [INFO] [stdout] | [INFO] [stdout] 68 | handle_command(&base_settings, &settings, &mqtt_client, &publish) [INFO] [stdout] | ^^^^^^^^ help: change this to: `publish` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | .send_if_err(&base_settings, &mqtt_client, &settings.command_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:70:42 [INFO] [stdout] | [INFO] [stdout] 70 | .send_if_err(&base_settings, &mqtt_client, &settings.command_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:73:23 [INFO] [stdout] | [INFO] [stdout] 73 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 73 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:73:50 [INFO] [stdout] | [INFO] [stdout] 73 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:73:64 [INFO] [stdout] | [INFO] [stdout] 73 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `camera_service` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | .send_if_err(&base_settings, &mqtt_client, &settings.status_topic) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/mod.rs:75:42 [INFO] [stdout] | [INFO] [stdout] 75 | .send_if_err(&base_settings, &mqtt_client, &settings.status_topic) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/startup.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | if p.topic == &base_settings.update_topic { [INFO] [stdout] | ^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `base_settings.update_topic` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/startup.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | if !tokio::fs::metadata("photos").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tokio::fs::metadata("photos").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 118 | .subscribe_to_all(&base_settings, &settings) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:125:30 [INFO] [stdout] | [INFO] [stdout] 125 | read_camera_controls(&base_settings, &mqtt_client, STILL_CAMERA_CONTROLS_FILENAME).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:125:46 [INFO] [stdout] | [INFO] [stdout] 125 | read_camera_controls(&base_settings, &mqtt_client, STILL_CAMERA_CONTROLS_FILENAME).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:127:30 [INFO] [stdout] | [INFO] [stdout] 127 | read_camera_controls(&base_settings, &mqtt_client, VIDEO_CAMERA_CONTROLS_FILENAME).await; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:127:46 [INFO] [stdout] | [INFO] [stdout] 127 | read_camera_controls(&base_settings, &mqtt_client, VIDEO_CAMERA_CONTROLS_FILENAME).await; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:144:46 [INFO] [stdout] | [INFO] [stdout] 144 | handle_status(&base_settings, &settings, &mqtt_client, &camera_service) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:147:14 [INFO] [stdout] | [INFO] [stdout] 147 | sync_ntp(&base_settings, &settings, &mqtt_client, &NtpRequest::Step) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:147:41 [INFO] [stdout] | [INFO] [stdout] 147 | sync_ntp(&base_settings, &settings, &mqtt_client, &NtpRequest::Step) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/startup.rs:167:22 [INFO] [stdout] | [INFO] [stdout] 167 | .map_err(|e| anyhow::Error::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `anyhow::Error::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:168:26 [INFO] [stdout] | [INFO] [stdout] 168 | .send_if_err(&base_settings, &mqtt_client, "error") [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:168:42 [INFO] [stdout] | [INFO] [stdout] 168 | .send_if_err(&base_settings, &mqtt_client, "error") [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/startup.rs:172:26 [INFO] [stdout] | [INFO] [stdout] 172 | .map_err(|e| anyhow::Error::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `anyhow::Error::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:173:30 [INFO] [stdout] | [INFO] [stdout] 173 | .send_if_err(&base_settings, &mqtt_client, "error") [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `base_settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/startup.rs:173:46 [INFO] [stdout] | [INFO] [stdout] 173 | .send_if_err(&base_settings, &mqtt_client, "error") [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `mqtt_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/updater/update_error.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / pub enum UpdateError { [INFO] [stdout] 6 | | #[error(transparent)] [INFO] [stdout] 7 | | IoError(#[from] std::io::Error), [INFO] [stdout] 8 | | #[error(transparent)] [INFO] [stdout] ... | [INFO] [stdout] 11 | | HttpError(#[from] HttpError), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/utils/mqtt_utils.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 117 | format!("{}/{}", topic, pi_zero_id.chars().nth(0).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `pi_zero_id.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 16s [INFO] running `Command { std: "docker" "inspect" "adab77e58f3cf8c4fde814c7099a968eb6e46138f2e2101224f0812102d6277d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "adab77e58f3cf8c4fde814c7099a968eb6e46138f2e2101224f0812102d6277d", kill_on_drop: false }` [INFO] [stdout] adab77e58f3cf8c4fde814c7099a968eb6e46138f2e2101224f0812102d6277d