[INFO] cloning repository https://github.com/asim-shrestha/webboy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/asim-shrestha/webboy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasim-shrestha%2Fwebboy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasim-shrestha%2Fwebboy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5fe22e4697a383f41def15be436d026bfd135a43 [INFO] linting asim-shrestha/webboy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fasim-shrestha%2Fwebboy" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/asim-shrestha/webboy [INFO] finished tweaking git repo https://github.com/asim-shrestha/webboy [INFO] tweaked toml for git repo https://github.com/asim-shrestha/webboy written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/asim-shrestha/webboy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/asim-shrestha/webboy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9c02ad7ec237d2b016a3e3de6b7f3d833dca5e78f72ebc29c7b07ece389d57be [INFO] running `Command { std: "docker" "start" "-a" "9c02ad7ec237d2b016a3e3de6b7f3d833dca5e78f72ebc29c7b07ece389d57be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c02ad7ec237d2b016a3e3de6b7f3d833dca5e78f72ebc29c7b07ece389d57be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c02ad7ec237d2b016a3e3de6b7f3d833dca5e78f72ebc29c7b07ece389d57be", kill_on_drop: false }` [INFO] [stdout] 9c02ad7ec237d2b016a3e3de6b7f3d833dca5e78f72ebc29c7b07ece389d57be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9db89d30b4ac2bbbe9f5f092d6e20f59bf2331ad7d72b4a7bb8edf07e0dc40a [INFO] running `Command { std: "docker" "start" "-a" "f9db89d30b4ac2bbbe9f5f092d6e20f59bf2331ad7d72b4a7bb8edf07e0dc40a", kill_on_drop: false }` [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Compiling miniquad v0.4.8 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling macroquad_macro v0.1.8 [INFO] [stderr] Checking quad-rand v0.2.3 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking fontdue v0.9.3 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking macroquad v0.4.14 [INFO] [stderr] Checking webboy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/ppu.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / /// You can only have 40 sprites per game and 10 a single line [INFO] [stdout] 12 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 16 | struct Palette { [INFO] [stdout] | -------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 12 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/input.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / /// Thus you only need 6 bits [INFO] [stdout] 10 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11 | pub struct Input<'a> { [INFO] [stdout] | ---------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Eight buttons so you'd need 8 bits but instead they [INFO] [stdout] 2 ~ //! Look at the buttons as two columns with four buttons each [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Up Select [INFO] [stdout] 5 ~ //! Down Start [INFO] [stdout] 6 ~ //! Left B [INFO] [stdout] 7 ~ //! Right A [INFO] [stdout] 8 ~ //! [INFO] [stdout] 9 ~ //! Thus you only need 6 bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/instruction.rs:1699:31 [INFO] [stdout] | [INFO] [stdout] 1699 | assert_eq!(cpu.registers.f, 0b01010_0000, "Zero and half carry flag should be set. Full carry is ignored"); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `0b0_1010_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/ppu.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / /// You can only have 40 sprites per game and 10 a single line [INFO] [stdout] 12 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 16 | struct Palette { [INFO] [stdout] | -------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 12 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/ppu.rs:280:48 [INFO] [stdout] | [INFO] [stdout] 280 | assert_eq!(ram.unblocked_read(STAT_ADDRESS), 0b01111_0001); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider: `0b0_1111_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/input.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / /// Thus you only need 6 bits [INFO] [stdout] 10 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11 | pub struct Input<'a> { [INFO] [stdout] | ---------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Eight buttons so you'd need 8 bits but instead they [INFO] [stdout] 2 ~ //! Look at the buttons as two columns with four buttons each [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Up Select [INFO] [stdout] 5 ~ //! Down Start [INFO] [stdout] 6 ~ //! Left B [INFO] [stdout] 7 ~ //! Right A [INFO] [stdout] 8 ~ //! [INFO] [stdout] 9 ~ //! Thus you only need 6 bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tile` [INFO] [stdout] --> src/ppu.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 215 | fn get_tile_color(tile: Tile) -> [[u8; 8]; 8] { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_tile` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DoubleSpeed` is never constructed [INFO] [stdout] --> src/cpu.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 17 | enum Mode { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 21 | DoubleSpeed, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `FollowingBytesOps` is never used [INFO] [stdout] --> src/cpu/instruction.rs:42:7 [INFO] [stdout] | [INFO] [stdout] 42 | trait FollowingBytesOps { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `dec_sp` is never used [INFO] [stdout] --> src/cpu/instruction.rs:1278:5 [INFO] [stdout] | [INFO] [stdout] 47 | impl CPU { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 1278 | fn dec_sp(&mut self, _: Instruction) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `UPPER_NIBBLE_MASK` is never used [INFO] [stdout] --> src/cpu/carry.rs:1:7 [INFO] [stdout] | [INFO] [stdout] 1 | const UPPER_NIBBLE_MASK: u8 = 0xF0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Palette` is never constructed [INFO] [stdout] --> src/palette.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | struct Palette { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_palette` is never used [INFO] [stdout] --> src/palette.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn get_palette(palette_register: u8) -> Palette { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Palette` is never constructed [INFO] [stdout] --> src/ppu.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | struct Palette { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Tilemap` is never constructed [INFO] [stdout] --> src/ppu.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | struct Tilemap<'a> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Layers` is never constructed [INFO] [stdout] --> src/ppu.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | struct Layers<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DOTS_PER_M_CYCLE_DOUBLE_SPEED` is never used [INFO] [stdout] --> src/ppu.rs:45:7 [INFO] [stdout] | [INFO] [stdout] 45 | const DOTS_PER_M_CYCLE_DOUBLE_SPEED: usize = 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DOTS_PER_60_FPS_FRAME` is never used [INFO] [stdout] --> src/ppu.rs:46:7 [INFO] [stdout] | [INFO] [stdout] 46 | const DOTS_PER_60_FPS_FRAME: usize = 70_224; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Tile` is never used [INFO] [stdout] --> src/ppu.rs:52:6 [INFO] [stdout] | [INFO] [stdout] 52 | type Tile<'a> = &'a [[u8; 8]; 8]; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `background_fifo` and `object_fifo` are never read [INFO] [stdout] --> src/ppu.rs:67:2 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct PPU { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 67 | background_fifo: [u8; 16], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 68 | object_fifo: [u8; 16], [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `DotsTaken` is never used [INFO] [stdout] --> src/ppu.rs:73:6 [INFO] [stdout] | [INFO] [stdout] 73 | type DotsTaken = u8; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `handle_oam_scan`, `handle_pixel_fetch`, `get_tile`, `get_tile_map_start`, `sleep`, and `get_tile_color` are never used [INFO] [stdout] --> src/ppu.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 76 | impl PPU { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 185 | fn handle_oam_scan(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 193 | fn handle_pixel_fetch(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | fn get_tile(&mut self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 201 | fn get_tile_map_start(&mut self, ram: &Ram) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 210 | fn sleep(&mut self) -> DotsTaken { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 215 | fn get_tile_color(tile: Tile) -> [[u8; 8]; 8] { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Input` is never constructed [INFO] [stdout] --> src/input.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Input<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_pressed` is never used [INFO] [stdout] --> src/input.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn is_pressed() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `M_CYCLES_TO_CLOCK_CYCLES` is never used [INFO] [stdout] --> src/timer.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const M_CYCLES_TO_CLOCK_CYCLES: u16 = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/cpu/instruction.rs:50:2 [INFO] [stdout] | [INFO] [stdout] 50 | / pub fn new() -> Self { [INFO] [stdout] 51 | | CPU { [INFO] [stdout] 52 | | registers: Registers::new(), [INFO] [stdout] 53 | | ram: Ram::new(), [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 47 + impl Default for CPU { [INFO] [stdout] 48 + fn default() -> Self { [INFO] [stdout] 49 + Self::new() [INFO] [stdout] 50 + } [INFO] [stdout] 51 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:487:3 [INFO] [stdout] | [INFO] [stdout] 487 | self.registers.a = self.registers.a ^ value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:517:3 [INFO] [stdout] | [INFO] [stdout] 517 | self.registers.a = self.registers.a | value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a |= value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i16::abs()` to u16 [INFO] [stdout] --> src/cpu/instruction.rs:1253:35 [INFO] [stdout] | [INFO] [stdout] 1253 | self.registers.pc.wrapping_sub(offset.abs() as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `offset.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/cpu/instruction.rs:1299:27 [INFO] [stdout] | [INFO] [stdout] 1299 | if self.ime == Ime::Set { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 1300 | | self.mode = Mode::LowPower; [INFO] [stdout] 1301 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/cpu/instruction.rs:1304:50 [INFO] [stdout] | [INFO] [stdout] 1304 | else if self.ram.pending_interrupt().is_none() { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 1305 | | self.mode = Mode::LowPower; [INFO] [stdout] 1306 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:1373:2 [INFO] [stdout] | [INFO] [stdout] 1373 | LEFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:1374:2 [INFO] [stdout] | [INFO] [stdout] 1374 | RIGHT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Registers` [INFO] [stdout] --> src/cpu/register.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / pub fn new() -> Self { [INFO] [stdout] 31 | | Registers { [INFO] [stdout] 32 | | a: 0, [INFO] [stdout] 33 | | f: 0, [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for Registers { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Ram` [INFO] [stdout] --> src/ram.rs:31:2 [INFO] [stdout] | [INFO] [stdout] 31 | / pub fn new() -> Self { [INFO] [stdout] 32 | | Self { [INFO] [stdout] 33 | | data: [0; TWO_TO_THE_16], [INFO] [stdout] 34 | | dma_requested: false, [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 30 + impl Default for Ram { [INFO] [stdout] 31 + fn default() -> Self { [INFO] [stdout] 32 + Self::new() [INFO] [stdout] 33 + } [INFO] [stdout] 34 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/ram.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | if self.dma_requested && (address < 0xFF80 || address > 0xFFFE) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0xFF80..=0xFFFE).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ram.rs:59:6 [INFO] [stdout] | [INFO] [stdout] 59 | if address >= 0x8000 && address <= 0x97FF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x8000..=0x97FF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PPU` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct PPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ppu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/ppu.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | work_stack: VecDeque<(fn() -> (), fn() -> ())>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:164:41 [INFO] [stdout] | [INFO] [stdout] 164 | if (prev_status & 0b0100_0000) > 0 && !(prev_lyc_equals_ly > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prev_lyc_equals_ly <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DMA` [INFO] [stdout] --> src/dma.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> Self { [INFO] [stdout] 14 | | Self { [INFO] [stdout] 15 | | current_index: 0, [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for DMA { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/test_cpu.rs:54:24 [INFO] [stdout] | [INFO] [stdout] 54 | assert_expected(&cpu, &test); [INFO] [stdout] | ^^^^^ help: change this to: `test` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instruction` [INFO] [stdout] --> src/cpu/instruction.rs:1682:8 [INFO] [stdout] | [INFO] [stdout] 1682 | let (instruction, op) = cpu.get_operation(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instruction` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tile` [INFO] [stdout] --> src/ppu.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 215 | fn get_tile_color(tile: Tile) -> [[u8; 8]; 8] { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_tile` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DoubleSpeed` is never constructed [INFO] [stdout] --> src/cpu.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 17 | enum Mode { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 21 | DoubleSpeed, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `FollowingBytesOps` is never used [INFO] [stdout] --> src/cpu/instruction.rs:42:7 [INFO] [stdout] | [INFO] [stdout] 42 | trait FollowingBytesOps { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `dec_sp` is never used [INFO] [stdout] --> src/cpu/instruction.rs:1278:5 [INFO] [stdout] | [INFO] [stdout] 47 | impl CPU { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 1278 | fn dec_sp(&mut self, _: Instruction) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_tma_edge_case` is never used [INFO] [stdout] --> src/cpu/instruction.rs:2545:5 [INFO] [stdout] | [INFO] [stdout] 2545 | fn test_tma_edge_case() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `UPPER_NIBBLE_MASK` is never used [INFO] [stdout] --> src/cpu/carry.rs:1:7 [INFO] [stdout] | [INFO] [stdout] 1 | const UPPER_NIBBLE_MASK: u8 = 0xF0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Palette` is never constructed [INFO] [stdout] --> src/ppu.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | struct Palette { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Tilemap` is never constructed [INFO] [stdout] --> src/ppu.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | struct Tilemap<'a> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Layers` is never constructed [INFO] [stdout] --> src/ppu.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | struct Layers<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DOTS_PER_M_CYCLE_DOUBLE_SPEED` is never used [INFO] [stdout] --> src/ppu.rs:45:7 [INFO] [stdout] | [INFO] [stdout] 45 | const DOTS_PER_M_CYCLE_DOUBLE_SPEED: usize = 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DOTS_PER_60_FPS_FRAME` is never used [INFO] [stdout] --> src/ppu.rs:46:7 [INFO] [stdout] | [INFO] [stdout] 46 | const DOTS_PER_60_FPS_FRAME: usize = 70_224; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Tile` is never used [INFO] [stdout] --> src/ppu.rs:52:6 [INFO] [stdout] | [INFO] [stdout] 52 | type Tile<'a> = &'a [[u8; 8]; 8]; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `background_fifo` and `object_fifo` are never read [INFO] [stdout] --> src/ppu.rs:67:2 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct PPU { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 67 | background_fifo: [u8; 16], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 68 | object_fifo: [u8; 16], [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `DotsTaken` is never used [INFO] [stdout] --> src/ppu.rs:73:6 [INFO] [stdout] | [INFO] [stdout] 73 | type DotsTaken = u8; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `handle_oam_scan`, `handle_pixel_fetch`, `get_tile`, `get_tile_map_start`, `sleep`, and `get_tile_color` are never used [INFO] [stdout] --> src/ppu.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 76 | impl PPU { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 185 | fn handle_oam_scan(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 193 | fn handle_pixel_fetch(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 197 | fn get_tile(&mut self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 201 | fn get_tile_map_start(&mut self, ram: &Ram) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 210 | fn sleep(&mut self) -> DotsTaken { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 215 | fn get_tile_color(tile: Tile) -> [[u8; 8]; 8] { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Input` is never constructed [INFO] [stdout] --> src/input.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Input<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_pressed` is never used [INFO] [stdout] --> src/input.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn is_pressed() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `M_CYCLES_TO_CLOCK_CYCLES` is never used [INFO] [stdout] --> src/timer.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const M_CYCLES_TO_CLOCK_CYCLES: u16 = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/cpu/instruction.rs:50:2 [INFO] [stdout] | [INFO] [stdout] 50 | / pub fn new() -> Self { [INFO] [stdout] 51 | | CPU { [INFO] [stdout] 52 | | registers: Registers::new(), [INFO] [stdout] 53 | | ram: Ram::new(), [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 47 + impl Default for CPU { [INFO] [stdout] 48 + fn default() -> Self { [INFO] [stdout] 49 + Self::new() [INFO] [stdout] 50 + } [INFO] [stdout] 51 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:487:3 [INFO] [stdout] | [INFO] [stdout] 487 | self.registers.a = self.registers.a ^ value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:517:3 [INFO] [stdout] | [INFO] [stdout] 517 | self.registers.a = self.registers.a | value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a |= value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i16::abs()` to u16 [INFO] [stdout] --> src/cpu/instruction.rs:1253:35 [INFO] [stdout] | [INFO] [stdout] 1253 | self.registers.pc.wrapping_sub(offset.abs() as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `offset.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/cpu/instruction.rs:1299:27 [INFO] [stdout] | [INFO] [stdout] 1299 | if self.ime == Ime::Set { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 1300 | | self.mode = Mode::LowPower; [INFO] [stdout] 1301 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/cpu/instruction.rs:1304:50 [INFO] [stdout] | [INFO] [stdout] 1304 | else if self.ram.pending_interrupt().is_none() { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 1305 | | self.mode = Mode::LowPower; [INFO] [stdout] 1306 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:1373:2 [INFO] [stdout] | [INFO] [stdout] 1373 | LEFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:1374:2 [INFO] [stdout] | [INFO] [stdout] 1374 | RIGHT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/cpu/instruction.rs:1473:31 [INFO] [stdout] | [INFO] [stdout] 1473 | assert_eq!(cpu.registers.a, 0 + 1, "The carry bit should not have been added"); [INFO] [stdout] | ^^^^^ help: consider reducing it to: `1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Registers` [INFO] [stdout] --> src/cpu/register.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / pub fn new() -> Self { [INFO] [stdout] 31 | | Registers { [INFO] [stdout] 32 | | a: 0, [INFO] [stdout] 33 | | f: 0, [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for Registers { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Ram` [INFO] [stdout] --> src/ram.rs:31:2 [INFO] [stdout] | [INFO] [stdout] 31 | / pub fn new() -> Self { [INFO] [stdout] 32 | | Self { [INFO] [stdout] 33 | | data: [0; TWO_TO_THE_16], [INFO] [stdout] 34 | | dma_requested: false, [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 30 + impl Default for Ram { [INFO] [stdout] 31 + fn default() -> Self { [INFO] [stdout] 32 + Self::new() [INFO] [stdout] 33 + } [INFO] [stdout] 34 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/ram.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | if self.dma_requested && (address < 0xFF80 || address > 0xFFFE) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0xFF80..=0xFFFE).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ram.rs:59:6 [INFO] [stdout] | [INFO] [stdout] 59 | if address >= 0x8000 && address <= 0x97FF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x8000..=0x97FF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PPU` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct PPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ppu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/ppu.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | work_stack: VecDeque<(fn() -> (), fn() -> ())>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:164:41 [INFO] [stdout] | [INFO] [stdout] 164 | if (prev_status & 0b0100_0000) > 0 && !(prev_lyc_equals_ly > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(prev_lyc_equals_ly <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DMA` [INFO] [stdout] --> src/dma.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> Self { [INFO] [stdout] 14 | | Self { [INFO] [stdout] 15 | | current_index: 0, [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for DMA { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/dma.rs:57:3 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(ram.dma_requested(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 57 - assert_eq!(ram.dma_requested(), false); [INFO] [stdout] 57 + assert!(!ram.dma_requested()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/dma.rs:64:3 [INFO] [stdout] | [INFO] [stdout] 64 | assert_eq!(ram.dma_requested(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 64 - assert_eq!(ram.dma_requested(), true); [INFO] [stdout] 64 + assert!(ram.dma_requested()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/dma.rs:74:3 [INFO] [stdout] | [INFO] [stdout] 74 | assert_eq!(ram.dma_requested(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 74 - assert_eq!(ram.dma_requested(), true); [INFO] [stdout] 74 + assert!(ram.dma_requested()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/dma.rs:78:3 [INFO] [stdout] | [INFO] [stdout] 78 | assert_eq!(ram.dma_requested(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 78 - assert_eq!(ram.dma_requested(), false); [INFO] [stdout] 78 + assert!(!ram.dma_requested()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.97s [INFO] running `Command { std: "docker" "inspect" "f9db89d30b4ac2bbbe9f5f092d6e20f59bf2331ad7d72b4a7bb8edf07e0dc40a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9db89d30b4ac2bbbe9f5f092d6e20f59bf2331ad7d72b4a7bb8edf07e0dc40a", kill_on_drop: false }` [INFO] [stdout] f9db89d30b4ac2bbbe9f5f092d6e20f59bf2331ad7d72b4a7bb8edf07e0dc40a