[INFO] cloning repository https://github.com/arthrp/game-of-life-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/arthrp/game-of-life-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farthrp%2Fgame-of-life-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farthrp%2Fgame-of-life-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] add80100f5b681e6a4134d8ac8f8944a5e0513c8 [INFO] linting arthrp/game-of-life-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farthrp%2Fgame-of-life-rs" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/arthrp/game-of-life-rs [INFO] finished tweaking git repo https://github.com/arthrp/game-of-life-rs [INFO] tweaked toml for git repo https://github.com/arthrp/game-of-life-rs written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/arthrp/game-of-life-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/arthrp/game-of-life-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b644432e5f777c75399fda86b997eec35e8302c2b67a707cc9a49547a47d0789 [INFO] running `Command { std: "docker" "start" "-a" "b644432e5f777c75399fda86b997eec35e8302c2b67a707cc9a49547a47d0789", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b644432e5f777c75399fda86b997eec35e8302c2b67a707cc9a49547a47d0789", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b644432e5f777c75399fda86b997eec35e8302c2b67a707cc9a49547a47d0789", kill_on_drop: false }` [INFO] [stdout] b644432e5f777c75399fda86b997eec35e8302c2b67a707cc9a49547a47d0789 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e19497a439f88aa50c27e489afc5b49316474738ad15d458a6f47083bef2f04f [INFO] running `Command { std: "docker" "start" "-a" "e19497a439f88aa50c27e489afc5b49316474738ad15d458a6f47083bef2f04f", kill_on_drop: false }` [INFO] [stderr] Checking game-of-life v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/game_of_life.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game_of_life.rs:59:38 [INFO] [stdout] | [INFO] [stdout] 59 | new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 59 - new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] 59 + new_board[x][y] = if !(!cell && n != 3 || n != 2 && n != 3) { true } else { false }; [INFO] [stdout] | [INFO] [stdout] 59 - new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] 59 + new_board[x][y] = if (n == 3 || n == 2) && (n == 3 || cell) { true } else { false }; [INFO] [stdout] | [INFO] [stdout] 59 - new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] 59 + new_board[x][y] = if n == 3 || cell && n == 2 { true } else { false }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `new_board` [INFO] [stdout] --> src/game_of_life.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | for y in 0..HEIGHT { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 54 - for y in 0..HEIGHT { [INFO] [stdout] 54 + for (y, ) in new_board.iter_mut().enumerate().take(HEIGHT) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `new_board` [INFO] [stdout] --> src/game_of_life.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | for x in 0..WIDTH { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 55 - for x in 0..WIDTH { [INFO] [stdout] 55 + for (x, ) in new_board.iter_mut().enumerate().take(WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/game_of_life.rs:59:35 [INFO] [stdout] | [INFO] [stdout] 59 | new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(cell && (n == 2 || n == 3)) || (!cell && n == 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/game_of_life.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game_of_life.rs:59:38 [INFO] [stdout] | [INFO] [stdout] 59 | new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 59 - new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] 59 + new_board[x][y] = if !(!cell && n != 3 || n != 2 && n != 3) { true } else { false }; [INFO] [stdout] | [INFO] [stdout] 59 - new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] 59 + new_board[x][y] = if (n == 3 || n == 2) && (n == 3 || cell) { true } else { false }; [INFO] [stdout] | [INFO] [stdout] 59 - new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] 59 + new_board[x][y] = if n == 3 || cell && n == 2 { true } else { false }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `new_board` [INFO] [stdout] --> src/game_of_life.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | for y in 0..HEIGHT { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 54 - for y in 0..HEIGHT { [INFO] [stdout] 54 + for (y, ) in new_board.iter_mut().enumerate().take(HEIGHT) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `new_board` [INFO] [stdout] --> src/game_of_life.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | for x in 0..WIDTH { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 55 - for x in 0..WIDTH { [INFO] [stdout] 55 + for (x, ) in new_board.iter_mut().enumerate().take(WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/game_of_life.rs:59:35 [INFO] [stdout] | [INFO] [stdout] 59 | new_board[x][y] = if (cell && (n == 2 || n == 3)) || (!cell && n == 3) { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(cell && (n == 2 || n == 3)) || (!cell && n == 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s [INFO] running `Command { std: "docker" "inspect" "e19497a439f88aa50c27e489afc5b49316474738ad15d458a6f47083bef2f04f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e19497a439f88aa50c27e489afc5b49316474738ad15d458a6f47083bef2f04f", kill_on_drop: false }` [INFO] [stdout] e19497a439f88aa50c27e489afc5b49316474738ad15d458a6f47083bef2f04f