[INFO] cloning repository https://github.com/arthrp/broken-keyboard-rs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/arthrp/broken-keyboard-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farthrp%2Fbroken-keyboard-rs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farthrp%2Fbroken-keyboard-rs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 8de75e63fdf9f3a448bd90ca75f02afb5c6965e1
[INFO] linting arthrp/broken-keyboard-rs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farthrp%2Fbroken-keyboard-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/arthrp/broken-keyboard-rs
[INFO] finished tweaking git repo https://github.com/arthrp/broken-keyboard-rs
[INFO] tweaked toml for git repo https://github.com/arthrp/broken-keyboard-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/arthrp/broken-keyboard-rs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/arthrp/broken-keyboard-rs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 752a8d660d4b88d364026c7e984df4d976f7f7de8c8e0640eb3636e53f9fed57
[INFO] running `Command { std: "docker" "start" "-a" "752a8d660d4b88d364026c7e984df4d976f7f7de8c8e0640eb3636e53f9fed57", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "752a8d660d4b88d364026c7e984df4d976f7f7de8c8e0640eb3636e53f9fed57", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "752a8d660d4b88d364026c7e984df4d976f7f7de8c8e0640eb3636e53f9fed57", kill_on_drop: false }`
[INFO] [stdout] 752a8d660d4b88d364026c7e984df4d976f7f7de8c8e0640eb3636e53f9fed57
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6203bc394d4dde7dc0da98bd29ea42decf4ffff2159a7a0332bfde5defd326b6
[INFO] running `Command { std: "docker" "start" "-a" "6203bc394d4dde7dc0da98bd29ea42decf4ffff2159a7a0332bfde5defd326b6", kill_on_drop: false }`
[INFO] [stderr]     Checking broken-keyboard-rs v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `super::*`
[INFO] [stdout]   --> src/naive_solution.rs:57:9
[INFO] [stdout]    |
[INFO] [stdout] 57 |     use super::*;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `OptimizedSolution` is never constructed
[INFO] [stdout]  --> src/optimized.rs:3:8
[INFO] [stdout]   |
[INFO] [stdout] 3 | struct OptimizedSolution;
[INFO] [stdout]   |        ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/naive_solution.rs:40:16
[INFO] [stdout]    |
[INFO] [stdout] 40 |             if !lower_target.is_none() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `lower_target.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/naive_solution.rs:47:16
[INFO] [stdout]    |
[INFO] [stdout] 47 |             if !upper_target.is_none() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `upper_target.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `lower_target` after checking its variant with `is_none`
[INFO] [stdout]   --> src/naive_solution.rs:41:26
[INFO] [stdout]    |
[INFO] [stdout] 40 |             if !lower_target.is_none() {
[INFO] [stdout]    |                 ---------------------- the check is happening here
[INFO] [stdout] 41 |                 res.push(lower_target.unwrap().val);
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `upper_target` after checking its variant with `is_none`
[INFO] [stdout]   --> src/naive_solution.rs:48:26
[INFO] [stdout]    |
[INFO] [stdout] 47 |             if !upper_target.is_none() {
[INFO] [stdout]    |                 ---------------------- the check is happening here
[INFO] [stdout] 48 |                 res.push(upper_target.unwrap().val);
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `i` is used as a loop counter
[INFO] [stdout]   --> src/naive_solution.rs:17:9
[INFO] [stdout]    |
[INFO] [stdout] 17 |         for c in s.chars() {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, c) in s.chars().enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/optimized.rs:14:20
[INFO] [stdout]    |
[INFO] [stdout] 14 |                 if !j.is_none() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^ help: try: `j.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/optimized.rs:21:20
[INFO] [stdout]    |
[INFO] [stdout] 21 |                 if !j.is_none() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^ help: try: `j.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `j` after checking its variant with `is_none`
[INFO] [stdout]   --> src/optimized.rs:15:27
[INFO] [stdout]    |
[INFO] [stdout] 14 |                 if !j.is_none() {
[INFO] [stdout]    |                     ----------- the check is happening here
[INFO] [stdout] 15 |                     arr_s[j.unwrap()] = ' ';
[INFO] [stdout]    |                           ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `j` after checking its variant with `is_none`
[INFO] [stdout]   --> src/optimized.rs:22:27
[INFO] [stdout]    |
[INFO] [stdout] 21 |                 if !j.is_none() {
[INFO] [stdout]    |                     ----------- the check is happening here
[INFO] [stdout] 22 |                     arr_s[j.unwrap()] = ' ';
[INFO] [stdout]    |                           ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/optimized.rs:39:9
[INFO] [stdout]    |
[INFO] [stdout] 38 |         let res = arr_s.iter().filter(|&c| *c != ' ').collect::<String>();
[INFO] [stdout]    |         ------------------------------------------------------------------ unnecessary `let` binding
[INFO] [stdout] 39 |         res
[INFO] [stdout]    |         ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 38 ~         
[INFO] [stdout] 39 ~         arr_s.iter().filter(|&c| *c != ' ').collect::<String>()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/naive_solution.rs:40:16
[INFO] [stdout]    |
[INFO] [stdout] 40 |             if !lower_target.is_none() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `lower_target.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/naive_solution.rs:47:16
[INFO] [stdout]    |
[INFO] [stdout] 47 |             if !upper_target.is_none() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `upper_target.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `lower_target` after checking its variant with `is_none`
[INFO] [stdout]   --> src/naive_solution.rs:41:26
[INFO] [stdout]    |
[INFO] [stdout] 40 |             if !lower_target.is_none() {
[INFO] [stdout]    |                 ---------------------- the check is happening here
[INFO] [stdout] 41 |                 res.push(lower_target.unwrap().val);
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `upper_target` after checking its variant with `is_none`
[INFO] [stdout]   --> src/naive_solution.rs:48:26
[INFO] [stdout]    |
[INFO] [stdout] 47 |             if !upper_target.is_none() {
[INFO] [stdout]    |                 ---------------------- the check is happening here
[INFO] [stdout] 48 |                 res.push(upper_target.unwrap().val);
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `i` is used as a loop counter
[INFO] [stdout]   --> src/naive_solution.rs:17:9
[INFO] [stdout]    |
[INFO] [stdout] 17 |         for c in s.chars() {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, c) in s.chars().enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/optimized.rs:14:20
[INFO] [stdout]    |
[INFO] [stdout] 14 |                 if !j.is_none() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^ help: try: `j.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/optimized.rs:21:20
[INFO] [stdout]    |
[INFO] [stdout] 21 |                 if !j.is_none() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^ help: try: `j.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `j` after checking its variant with `is_none`
[INFO] [stdout]   --> src/optimized.rs:15:27
[INFO] [stdout]    |
[INFO] [stdout] 14 |                 if !j.is_none() {
[INFO] [stdout]    |                     ----------- the check is happening here
[INFO] [stdout] 15 |                     arr_s[j.unwrap()] = ' ';
[INFO] [stdout]    |                           ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `j` after checking its variant with `is_none`
[INFO] [stdout]   --> src/optimized.rs:22:27
[INFO] [stdout]    |
[INFO] [stdout] 21 |                 if !j.is_none() {
[INFO] [stdout]    |                     ----------- the check is happening here
[INFO] [stdout] 22 |                     arr_s[j.unwrap()] = ' ';
[INFO] [stdout]    |                           ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/optimized.rs:39:9
[INFO] [stdout]    |
[INFO] [stdout] 38 |         let res = arr_s.iter().filter(|&c| *c != ' ').collect::<String>();
[INFO] [stdout]    |         ------------------------------------------------------------------ unnecessary `let` binding
[INFO] [stdout] 39 |         res
[INFO] [stdout]    |         ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 38 ~         
[INFO] [stdout] 39 ~         arr_s.iter().filter(|&c| *c != ' ').collect::<String>()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s
[INFO] running `Command { std: "docker" "inspect" "6203bc394d4dde7dc0da98bd29ea42decf4ffff2159a7a0332bfde5defd326b6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6203bc394d4dde7dc0da98bd29ea42decf4ffff2159a7a0332bfde5defd326b6", kill_on_drop: false }`
[INFO] [stdout] 6203bc394d4dde7dc0da98bd29ea42decf4ffff2159a7a0332bfde5defd326b6