[INFO] cloning repository https://github.com/arod1213/csv-dsl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/arod1213/csv-dsl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farod1213%2Fcsv-dsl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farod1213%2Fcsv-dsl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 256b6f39292d4820e4b3a4dca403f9918225514e [INFO] linting arod1213/csv-dsl against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farod1213%2Fcsv-dsl" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/arod1213/csv-dsl [INFO] finished tweaking git repo https://github.com/arod1213/csv-dsl [INFO] tweaked toml for git repo https://github.com/arod1213/csv-dsl written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/arod1213/csv-dsl on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/arod1213/csv-dsl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dateparser v0.2.1 [INFO] [stderr] Downloaded clap v4.5.49 [INFO] [stderr] Downloaded clap_builder v4.5.49 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4fd9c0201e3b7207c09f104307f36f0956db3c0b8693f27f5a1daf12f7862a4c [INFO] running `Command { std: "docker" "start" "-a" "4fd9c0201e3b7207c09f104307f36f0956db3c0b8693f27f5a1daf12f7862a4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4fd9c0201e3b7207c09f104307f36f0956db3c0b8693f27f5a1daf12f7862a4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fd9c0201e3b7207c09f104307f36f0956db3c0b8693f27f5a1daf12f7862a4c", kill_on_drop: false }` [INFO] [stdout] 4fd9c0201e3b7207c09f104307f36f0956db3c0b8693f27f5a1daf12f7862a4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51cf578dbaafbaca2ab4896781b53aef4784800e8fe4b3c04f34bd7e2007f538 [INFO] running `Command { std: "docker" "start" "-a" "51cf578dbaafbaca2ab4896781b53aef4784800e8fe4b3c04f34bd7e2007f538", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking clap_builder v4.5.49 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking clap v4.5.49 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking dateparser v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking csvdsl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `field_name`, `field_type`, and `value` are never read [INFO] [stdout] --> src/parse/csv.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct FieldInfo { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 12 | field_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 13 | field_type: DataType, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 14 | value: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `BadField` is never constructed [INFO] [stdout] --> src/parse/csv.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum ParseError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 19 | BadField(FieldInfo), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/parse/csv.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse/csv.rs:34:45 [INFO] [stdout] | [INFO] [stdout] 34 | let headers = collect_fields(&line, &sep); [INFO] [stdout] | ^^^^ help: change this to: `sep` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/parse/csv.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | Ok(x) if x == 0 => return None, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 - Ok(x) if x == 0 => return None, [INFO] [stdout] 46 + Ok(0) => return None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/csv.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | .filter(|s| !obj.get(&s.name).is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `obj.get(&s.name).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `field_name`, `field_type`, and `value` are never read [INFO] [stdout] --> src/parse/csv.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct FieldInfo { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 12 | field_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 13 | field_type: DataType, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 14 | value: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `BadField` is never constructed [INFO] [stdout] --> src/parse/csv.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum ParseError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 19 | BadField(FieldInfo), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | return Some(Value::String(country_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return Some(Value::String(country_name)); [INFO] [stdout] 12 + Some(Value::String(country_name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | return Some(Value::String(date.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return Some(Value::String(date.to_string())); [INFO] [stdout] 26 + Some(Value::String(date.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | return Some(Value::String(field.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return Some(Value::String(field.to_string())); [INFO] [stdout] 35 + Some(Value::String(field.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | return Some(Value::Number(num)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Some(Value::Number(num)); [INFO] [stdout] 48 + Some(Value::Number(num)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return Some(Value::Number(num)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return Some(Value::Number(num)); [INFO] [stdout] 61 + Some(Value::Number(num)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | return Some(Value::Number(num)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Some(Value::Number(num)); [INFO] [stdout] 74 + Some(Value::Number(num)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:76:14 [INFO] [stdout] | [INFO] [stdout] 76 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - _ => return None, [INFO] [stdout] 76 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/parse/validate.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | if spec.optional && field == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/parse/validate.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | if field == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/parse/csv.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse/csv.rs:34:45 [INFO] [stdout] | [INFO] [stdout] 34 | let headers = collect_fields(&line, &sep); [INFO] [stdout] | ^^^^ help: change this to: `sep` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/parse/csv.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | Ok(x) if x == 0 => return None, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 - Ok(x) if x == 0 => return None, [INFO] [stdout] 46 + Ok(0) => return None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/csv.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | .filter(|s| !obj.get(&s.name).is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `obj.get(&s.name).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | return Some(Value::String(country_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return Some(Value::String(country_name)); [INFO] [stdout] 12 + Some(Value::String(country_name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | return Some(Value::String(date.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return Some(Value::String(date.to_string())); [INFO] [stdout] 26 + Some(Value::String(date.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | return Some(Value::String(field.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return Some(Value::String(field.to_string())); [INFO] [stdout] 35 + Some(Value::String(field.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | return Some(Value::Number(num)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Some(Value::Number(num)); [INFO] [stdout] 48 + Some(Value::Number(num)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return Some(Value::Number(num)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return Some(Value::Number(num)); [INFO] [stdout] 61 + Some(Value::Number(num)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | return Some(Value::Number(num)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Some(Value::Number(num)); [INFO] [stdout] 74 + Some(Value::Number(num)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parse/validate.rs:76:14 [INFO] [stdout] | [INFO] [stdout] 76 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - _ => return None, [INFO] [stdout] 76 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/parse/validate.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | if spec.optional && field == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/parse/validate.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | if field == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.09s [INFO] running `Command { std: "docker" "inspect" "51cf578dbaafbaca2ab4896781b53aef4784800e8fe4b3c04f34bd7e2007f538", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51cf578dbaafbaca2ab4896781b53aef4784800e8fe4b3c04f34bd7e2007f538", kill_on_drop: false }` [INFO] [stdout] 51cf578dbaafbaca2ab4896781b53aef4784800e8fe4b3c04f34bd7e2007f538