[INFO] cloning repository https://github.com/aploxhune/hayro [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aploxhune/hayro" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faploxhune%2Fhayro", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faploxhune%2Fhayro'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7e10d83989c932c59e0fc27627c67b4f2a4f5912 [INFO] linting aploxhune/hayro against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faploxhune%2Fhayro" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aploxhune/hayro [INFO] finished tweaking git repo https://github.com/aploxhune/hayro [INFO] tweaked toml for git repo https://github.com/aploxhune/hayro written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aploxhune/hayro on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aploxhune/hayro already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/LaurenzV/sitro` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.106 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.106 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.106 [INFO] [stderr] Downloaded wasm-bindgen v0.2.106 [INFO] [stderr] Downloaded font-types v0.11.0 [INFO] [stderr] Downloaded libz-rs-sys v0.5.4 [INFO] [stderr] Downloaded imagesize v0.12.0 [INFO] [stderr] Downloaded imagesize v0.14.0 [INFO] [stderr] Downloaded peniko v0.6.0 [INFO] [stderr] Downloaded md5 v0.8.0 [INFO] [stderr] Downloaded roxmltree v0.21.1 [INFO] [stderr] Downloaded color v0.3.2 [INFO] [stderr] Downloaded vello_common v0.0.6 [INFO] [stderr] Downloaded vello_cpu v0.0.6 [INFO] [stderr] Downloaded zerocopy-derive v0.8.31 [INFO] [stderr] Downloaded usvg v0.46.0 [INFO] [stderr] Downloaded fast_image_resize v6.0.0 [INFO] [stderr] Downloaded kurbo v0.13.0 [INFO] [stderr] Downloaded fearless_simd v0.3.0 [INFO] [stderr] Downloaded zlib-rs v0.5.4 [INFO] [stderr] Downloaded resvg v0.46.0 [INFO] [stderr] Downloaded zerocopy v0.8.31 [INFO] [stderr] Downloaded skrifa v0.40.0 [INFO] [stderr] Downloaded cc v1.2.50 [INFO] [stderr] Downloaded js-sys v0.3.83 [INFO] [stderr] Downloaded svgtypes v0.16.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.105 [INFO] [stderr] Downloaded read-fonts v0.37.0 [INFO] [stderr] Downloaded web-sys v0.3.83 [INFO] [stderr] Downloaded libc v0.2.178 [INFO] [stderr] Downloaded pdf-writer v0.14.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3106de8da0545e263d1dfe0b79b89d072448a8fd177d3a71a7987c77307fc76 [INFO] running `Command { std: "docker" "start" "-a" "f3106de8da0545e263d1dfe0b79b89d072448a8fd177d3a71a7987c77307fc76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3106de8da0545e263d1dfe0b79b89d072448a8fd177d3a71a7987c77307fc76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3106de8da0545e263d1dfe0b79b89d072448a8fd177d3a71a7987c77307fc76", kill_on_drop: false }` [INFO] [stdout] f3106de8da0545e263d1dfe0b79b89d072448a8fd177d3a71a7987c77307fc76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aae672a96d707f84a849b864cafcec2beefc9db45dad3b2f31e20a8259ebfea8 [INFO] running `Command { std: "docker" "start" "-a" "aae672a96d707f84a849b864cafcec2beefc9db45dad3b2f31e20a8259ebfea8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking zlib-rs v0.5.4 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Checking hayro-ccitt v0.2.0 (/opt/rustwide/workdir/hayro-ccitt) [INFO] [stderr] Checking kurbo v0.13.0 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling phf_shared v0.13.1 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Checking hayro-postscript v0.1.0 (/opt/rustwide/workdir/hayro-postscript) [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking linebender_resource_handle v0.1.1 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.106 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking hayro-jbig2 v0.1.0 (/opt/rustwide/workdir/hayro-jbig2) [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Checking zune-jpeg v0.5.11 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Compiling phf_generator v0.13.1 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Compiling slotmap v1.1.1 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling bumpalo v3.19.0 [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking libz-rs-sys v0.5.4 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling wasm-bindgen v0.2.106 [INFO] [stderr] Checking core_maths v0.1.1 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking unicode-ccc v0.4.0 [INFO] [stderr] Checking unicode-properties v0.1.4 [INFO] [stderr] Checking unicode-bidi-mirroring v0.4.0 [INFO] [stderr] Checking unicode-ident v1.0.22 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking fontconfig-parser v0.5.8 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking unicode-script v0.5.8 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Checking svgtypes v0.16.1 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking pdf-writer v0.14.0 [INFO] [stderr] Checking simplecss v0.2.2 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking roxmltree v0.21.1 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Checking unicode-vo v0.1.0 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking imagesize v0.14.0 [INFO] [stderr] Checking data-url v0.3.2 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking arbitrary v1.4.2 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Checking imagesize v0.12.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling cc v1.2.50 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking md5 v0.8.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking fontdb v0.23.0 [INFO] [stderr] Compiling libfuzzer-sys v0.4.10 [INFO] [stderr] Checking hayro-cmap v0.1.0 (/opt/rustwide/workdir/hayro-cmap) [INFO] [stderr] Checking regex v1.12.2 [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/bcmap/mod.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | cid_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - cid_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 185 + cid_ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/bcmap/mod.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | notdef_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 186 - notdef_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 186 + notdef_ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/bcmap/mod.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | bf_entries.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 187 - bf_entries.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 187 + bf_entries.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/parse.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 119 - ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 119 + ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/parse.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | notdef_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 120 - notdef_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 120 + notdef_ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/parse.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | bf_entries.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 121 - bf_entries.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 121 + bf_entries.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/lib.rs:446:9 [INFO] [stdout] | [INFO] [stdout] 446 | cid_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 446 - cid_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 446 + cid_ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/bcmap/mod.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | cid_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - cid_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 185 + cid_ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/bcmap/mod.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | notdef_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 186 - notdef_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 186 + notdef_ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/bcmap/mod.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | bf_entries.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 187 - bf_entries.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 187 + bf_entries.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/parse.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 119 - ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 119 + ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/parse.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | notdef_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 120 - notdef_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 120 + notdef_ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/parse.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | bf_entries.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 121 - bf_entries.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 121 + bf_entries.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-cmap/src/lib.rs:446:9 [INFO] [stdout] | [INFO] [stdout] 446 | cid_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 446 - cid_ranges.sort_by(|a, b| a.range.start.cmp(&b.range.start)); [INFO] [stdout] 446 + cid_ranges.sort_by_key(|a| a.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.106 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling phf_macros v0.13.1 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking hayro-font v0.4.0 (/opt/rustwide/workdir/hayro-font) [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking fast_image_resize v6.0.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking fearless_simd v0.3.0 [INFO] [stderr] Checking font-types v0.11.0 [INFO] [stderr] Checking color v0.3.2 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking rustybuzz v0.20.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.106 [INFO] [stderr] Checking read-fonts v0.37.0 [INFO] [stderr] Checking peniko v0.6.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking js-sys v0.3.83 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking usvg v0.46.0 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking hayro-jpeg2000 v0.3.2 (/opt/rustwide/workdir/hayro-jpeg2000) [INFO] [stderr] Checking vello_common v0.0.6 [INFO] [stderr] Checking resvg v0.46.0 [INFO] [stderr] Checking vello_cpu v0.0.6 [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-jpeg2000/src/j2c/codestream.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | ppm_markers.sort_by(|p0, p1| p0.sequence_idx.cmp(&p1.sequence_idx)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 165 - ppm_markers.sort_by(|p0, p1| p0.sequence_idx.cmp(&p1.sequence_idx)); [INFO] [stdout] 165 + ppm_markers.sort_by_key(|p0| p0.sequence_idx); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-jpeg2000/src/j2c/codestream.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | ppm_markers.sort_by(|p0, p1| p0.sequence_idx.cmp(&p1.sequence_idx)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 165 - ppm_markers.sort_by(|p0, p1| p0.sequence_idx.cmp(&p1.sequence_idx)); [INFO] [stdout] 165 + ppm_markers.sort_by_key(|p0| p0.sequence_idx); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-jpeg2000/src/j2c/tile.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | ppt_headers.sort_by(|p1, p2| p1.sequence_idx.cmp(&p2.sequence_idx)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 291 - ppt_headers.sort_by(|p1, p2| p1.sequence_idx.cmp(&p2.sequence_idx)); [INFO] [stdout] 291 + ppt_headers.sort_by_key(|p1| p1.sequence_idx); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-jpeg2000/src/jp2/cdef.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | definitions.sort_by(|a, b| a.channel_index.cmp(&b.channel_index)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 - definitions.sort_by(|a, b| a.channel_index.cmp(&b.channel_index)); [INFO] [stdout] 31 + definitions.sort_by_key(|a| a.channel_index); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking image v0.24.9 [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-jpeg2000/src/lib.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | components.sort_by(|c1, c2| c1.1.cmp(&c2.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 236 - components.sort_by(|c1, c2| c1.1.cmp(&c2.1)); [INFO] [stdout] 236 + components.sort_by_key(|c1| c1.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-jpeg2000/src/j2c/tile.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | ppt_headers.sort_by(|p1, p2| p1.sequence_idx.cmp(&p2.sequence_idx)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 291 - ppt_headers.sort_by(|p1, p2| p1.sequence_idx.cmp(&p2.sequence_idx)); [INFO] [stdout] 291 + ppt_headers.sort_by_key(|p1| p1.sequence_idx); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-jpeg2000/src/jp2/cdef.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | definitions.sort_by(|a, b| a.channel_index.cmp(&b.channel_index)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 - definitions.sort_by(|a, b| a.channel_index.cmp(&b.channel_index)); [INFO] [stdout] 31 + definitions.sort_by_key(|a| a.channel_index); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-jpeg2000/src/lib.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | components.sort_by(|c1, c2| c1.1.cmp(&c2.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 236 - components.sort_by(|c1, c2| c1.1.cmp(&c2.1)); [INFO] [stdout] 236 + components.sort_by_key(|c1| c1.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking hayro-syntax v0.5.0 (/opt/rustwide/workdir/hayro-syntax) [INFO] [stderr] Checking hayro-fuzz v0.0.0 (/opt/rustwide/workdir/hayro-fuzz) [INFO] [stderr] Checking web-sys v0.3.83 [INFO] [stderr] Checking skrifa v0.40.0 [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-syntax/src/xref.rs:417:17 [INFO] [stdout] | [INFO] [stdout] 417 | elements.sort_by(|e1, e2| e1.1.cmp(&e2.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 417 - elements.sort_by(|e1, e2| e1.1.cmp(&e2.1)); [INFO] [stdout] 417 + elements.sort_by_key(|e1| e1.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sitro v0.1.0 (https://github.com/LaurenzV/sitro?rev=fb804b3#fb804b36) [INFO] [stderr] Checking hayro-write v0.4.0 (/opt/rustwide/workdir/hayro-write) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> hayro-syntax/src/xref.rs:417:17 [INFO] [stdout] | [INFO] [stdout] 417 | elements.sort_by(|e1, e2| e1.1.cmp(&e2.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 417 - elements.sort_by(|e1, e2| e1.1.cmp(&e2.1)); [INFO] [stdout] 417 + elements.sort_by_key(|e1| e1.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking hayro-interpret v0.5.0 (/opt/rustwide/workdir/hayro-interpret) [INFO] [stderr] Checking hayro v0.5.0 (/opt/rustwide/workdir/hayro) [INFO] [stderr] Checking hayro-svg v0.3.0 (/opt/rustwide/workdir/hayro-svg) [INFO] [stderr] Checking hayro-demo v0.1.0 (/opt/rustwide/workdir/hayro-demo) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> hayro-demo/src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use console_error_panic_hook; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> hayro-demo/src/lib.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use js_sys; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> hayro-demo/src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use console_error_panic_hook; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> hayro-demo/src/lib.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use js_sys; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking hayro-tests v0.1.0 (/opt/rustwide/workdir/hayro-tests) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> hayro-demo/src/lib.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | / if let Some(window) = web_sys::window() { [INFO] [stdout] 40 | | if let Ok(add_log_entry) = js_sys::Reflect::get(&window, &"addLogEntry".into()) { [INFO] [stdout] 41 | | if add_log_entry.is_function() { [INFO] [stdout] 42 | | let function = js_sys::Function::from(add_log_entry); [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 39 ~ if let Some(window) = web_sys::window() [INFO] [stdout] 40 ~ && let Ok(add_log_entry) = js_sys::Reflect::get(&window, &"addLogEntry".into()) { [INFO] [stdout] 41 | if add_log_entry.is_function() { [INFO] [stdout] ... [INFO] [stdout] 44 | } [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> hayro-demo/src/lib.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | / if let Ok(add_log_entry) = js_sys::Reflect::get(&window, &"addLogEntry".into()) { [INFO] [stdout] 41 | | if add_log_entry.is_function() { [INFO] [stdout] 42 | | let function = js_sys::Function::from(add_log_entry); [INFO] [stdout] 43 | | let _ = function.call2(&window, &level_str.into(), &message.into()); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if let Ok(add_log_entry) = js_sys::Reflect::get(&window, &"addLogEntry".into()) [INFO] [stdout] 41 ~ && add_log_entry.is_function() { [INFO] [stdout] 42 | let function = js_sys::Function::from(add_log_entry); [INFO] [stdout] 43 | let _ = function.call2(&window, &level_str.into(), &message.into()); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PdfViewer` [INFO] [stdout] --> hayro-demo/src/lib.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | / pub fn new() -> Self { [INFO] [stdout] 66 | | console_error_panic_hook::set_once(); [INFO] [stdout] 67 | | [INFO] [stdout] 68 | | if log::set_logger(&LOGGER).is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 63 + impl Default for PdfViewer { [INFO] [stdout] 64 + fn default() -> Self { [INFO] [stdout] 65 + Self::new() [INFO] [stdout] 66 + } [INFO] [stdout] 67 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> hayro-demo/src/lib.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | / if let Some(window) = web_sys::window() { [INFO] [stdout] 40 | | if let Ok(add_log_entry) = js_sys::Reflect::get(&window, &"addLogEntry".into()) { [INFO] [stdout] 41 | | if add_log_entry.is_function() { [INFO] [stdout] 42 | | let function = js_sys::Function::from(add_log_entry); [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 39 ~ if let Some(window) = web_sys::window() [INFO] [stdout] 40 ~ && let Ok(add_log_entry) = js_sys::Reflect::get(&window, &"addLogEntry".into()) { [INFO] [stdout] 41 | if add_log_entry.is_function() { [INFO] [stdout] ... [INFO] [stdout] 44 | } [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> hayro-demo/src/lib.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | / if let Ok(add_log_entry) = js_sys::Reflect::get(&window, &"addLogEntry".into()) { [INFO] [stdout] 41 | | if add_log_entry.is_function() { [INFO] [stdout] 42 | | let function = js_sys::Function::from(add_log_entry); [INFO] [stdout] 43 | | let _ = function.call2(&window, &level_str.into(), &message.into()); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if let Ok(add_log_entry) = js_sys::Reflect::get(&window, &"addLogEntry".into()) [INFO] [stdout] 41 ~ && add_log_entry.is_function() { [INFO] [stdout] 42 | let function = js_sys::Function::from(add_log_entry); [INFO] [stdout] 43 | let _ = function.call2(&window, &level_str.into(), &message.into()); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PdfViewer` [INFO] [stdout] --> hayro-demo/src/lib.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | / pub fn new() -> Self { [INFO] [stdout] 66 | | console_error_panic_hook::set_once(); [INFO] [stdout] 67 | | [INFO] [stdout] 68 | | if log::set_logger(&LOGGER).is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 63 + impl Default for PdfViewer { [INFO] [stdout] 64 + fn default() -> Self { [INFO] [stdout] 65 + Self::new() [INFO] [stdout] 66 + } [INFO] [stdout] 67 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 56.70s [INFO] running `Command { std: "docker" "inspect" "aae672a96d707f84a849b864cafcec2beefc9db45dad3b2f31e20a8259ebfea8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aae672a96d707f84a849b864cafcec2beefc9db45dad3b2f31e20a8259ebfea8", kill_on_drop: false }` [INFO] [stdout] aae672a96d707f84a849b864cafcec2beefc9db45dad3b2f31e20a8259ebfea8