[INFO] cloning repository https://github.com/apederson94/rust_lox
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/apederson94/rust_lox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapederson94%2Frust_lox", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapederson94%2Frust_lox'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 95856d3e607dc6d0db945d1b74ce0b7d7dd20b7f
[INFO] linting apederson94/rust_lox against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fapederson94%2Frust_lox" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/apederson94/rust_lox
[INFO] finished tweaking git repo https://github.com/apederson94/rust_lox
[INFO] tweaked toml for git repo https://github.com/apederson94/rust_lox written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/apederson94/rust_lox on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/apederson94/rust_lox already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 83e0ab5b061b86dbd404bea8d9fca34183c317dac936e64088c14e317ffd17e7
[INFO] running `Command { std: "docker" "start" "-a" "83e0ab5b061b86dbd404bea8d9fca34183c317dac936e64088c14e317ffd17e7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "83e0ab5b061b86dbd404bea8d9fca34183c317dac936e64088c14e317ffd17e7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "83e0ab5b061b86dbd404bea8d9fca34183c317dac936e64088c14e317ffd17e7", kill_on_drop: false }`
[INFO] [stdout] 83e0ab5b061b86dbd404bea8d9fca34183c317dac936e64088c14e317ffd17e7
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] ef2193428ed21b687056ab41d2eb4fda54beac6941129c69ba44bf573cbd680c
[INFO] running `Command { std: "docker" "start" "-a" "ef2193428ed21b687056ab41d2eb4fda54beac6941129c69ba44bf573cbd680c", kill_on_drop: false }`
[INFO] [stderr]     Checking rust_lox v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `any::Any`
[INFO] [stdout]  --> src/environment.rs:1:11
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::{any::Any, collections::HashMap};
[INFO] [stdout]   |           ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/parser.rs:185:21
[INFO] [stdout]     |
[INFO] [stdout] 185 |                     operator: operator,
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `any::Any`
[INFO] [stdout]  --> src/environment.rs:1:11
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::{any::Any, collections::HashMap};
[INFO] [stdout]   |           ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/parser.rs:185:21
[INFO] [stdout]     |
[INFO] [stdout] 185 |                     operator: operator,
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `token`
[INFO] [stdout]   --> src/expr.rs:56:26
[INFO] [stdout]    |
[INFO] [stdout] 56 |         Expr::Variable { token } => todo!("implement variable evaluations"),
[INFO] [stdout]    |                          ^^^^^ help: try ignoring the field: `token: _`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/runner.rs:40:9
[INFO] [stdout]    |
[INFO] [stdout] 40 |     let mut environment = Environment::new();
[INFO] [stdout]    |         ----^^^^^^^^^^^
[INFO] [stdout]    |         |
[INFO] [stdout]    |         help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `environment`
[INFO] [stdout]   --> src/runner.rs:40:9
[INFO] [stdout]    |
[INFO] [stdout] 40 |     let mut environment = Environment::new();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_environment`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `name`
[INFO] [stdout]   --> src/stmt.rs:19:17
[INFO] [stdout]    |
[INFO] [stdout] 19 |                 name,
[INFO] [stdout]    |                 ^^^^ help: try ignoring the field: `name: _`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait `ASTPrintable` is never used
[INFO] [stdout]  --> src/ast_printable.rs:4:11
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub trait ASTPrintable {
[INFO] [stdout]   |           ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variants `Number`, `Str`, and `Boolean` are never constructed
[INFO] [stdout]  --> src/environment.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | pub enum EnvironmentValue {
[INFO] [stdout]   |          ---------------- variants in this enum
[INFO] [stdout] 7 |     Number(f64),
[INFO] [stdout]   |     ^^^^^^
[INFO] [stdout] 8 |     Str(String),
[INFO] [stdout]   |     ^^^
[INFO] [stdout] 9 |     Boolean(bool),
[INFO] [stdout]   |     ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `EnvironmentValue` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `EnvironmentError` is never used
[INFO] [stdout]   --> src/environment.rs:12:10
[INFO] [stdout]    |
[INFO] [stdout] 12 | pub enum EnvironmentError {
[INFO] [stdout]    |          ^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `values` is never read
[INFO] [stdout]   --> src/environment.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 16 | pub struct Environment {
[INFO] [stdout]    |            ----------- field in this struct
[INFO] [stdout] 17 |     values: HashMap<String, EnvironmentValue>,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `define` and `get` are never used
[INFO] [stdout]   --> src/environment.rs:26:12
[INFO] [stdout]    |
[INFO] [stdout] 20 | impl Environment {
[INFO] [stdout]    | ---------------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 26 |     pub fn define(&mut self, name: String, value: EnvironmentValue) {
[INFO] [stdout]    |            ^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 30 |     pub fn get(&self, name: Token) -> Result<EnvironmentValue, EnvironmentError> {
[INFO] [stdout]    |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `expression_list` is never used
[INFO] [stdout]    --> src/parser.rs:103:8
[INFO] [stdout]     |
[INFO] [stdout]  18 | impl Parser {
[INFO] [stdout]     | ----------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 103 |     fn expression_list(&mut self) -> Result<Expr, ParseError> {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/ast_printable.rs:22:49
[INFO] [stdout]    |
[INFO] [stdout] 22 |                 TokenType::Identifier(ident) => format!("{}", ident),
[INFO] [stdout]    |                                                 ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `ident.to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/ast_printable.rs:25:22
[INFO] [stdout]    |
[INFO] [stdout] 25 |                 _ => format!("Error: Unknown literal type!"),
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Error: Unknown literal type!".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `token`
[INFO] [stdout]   --> src/expr.rs:56:26
[INFO] [stdout]    |
[INFO] [stdout] 56 |         Expr::Variable { token } => todo!("implement variable evaluations"),
[INFO] [stdout]    |                          ^^^^^ help: try ignoring the field: `token: _`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/environment.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 37 |         return Err(EnvironmentError::UndefinedVariable);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 37 -         return Err(EnvironmentError::UndefinedVariable);
[INFO] [stdout] 37 +         Err(EnvironmentError::UndefinedVariable)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/errors.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     let value = HAD_ERROR.load(Ordering::Relaxed);
[INFO] [stdout]    |     ---------------------------------------------- unnecessary `let` binding
[INFO] [stdout] 11 |     value
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 10 ~     
[INFO] [stdout] 11 ~     HAD_ERROR.load(Ordering::Relaxed)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/errors.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 15 |     let value = HAD_RUNTIME_ERROR.load(Ordering::Relaxed);
[INFO] [stdout]    |     ------------------------------------------------------ unnecessary `let` binding
[INFO] [stdout] 16 |     value
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 15 ~     
[INFO] [stdout] 16 ~     HAD_RUNTIME_ERROR.load(Ordering::Relaxed)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stdout]   --> src/expr.rs:76:46
[INFO] [stdout]    |
[INFO] [stdout] 76 | fn evaluate_unary(operator: &Token, operand: &Box<Expr>) -> Result<LoxValue, RuntimeError> {
[INFO] [stdout]    |                                              ^^^^^^^^^^ help: try: `&Expr`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stdout]    = note: `#[warn(clippy::borrowed_box)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stdout]    --> src/expr.rs:107:11
[INFO] [stdout]     |
[INFO] [stdout] 107 |     left: &Box<Expr>,
[INFO] [stdout]     |           ^^^^^^^^^^ help: try: `&Expr`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stdout]    --> src/expr.rs:108:12
[INFO] [stdout]     |
[INFO] [stdout] 108 |     right: &Box<Expr>,
[INFO] [stdout]     |            ^^^^^^^^^^ help: try: `&Expr`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/runner.rs:40:9
[INFO] [stdout]    |
[INFO] [stdout] 40 |     let mut environment = Environment::new();
[INFO] [stdout]    |         ----^^^^^^^^^^^
[INFO] [stdout]    |         |
[INFO] [stdout]    |         help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `environment`
[INFO] [stdout]   --> src/runner.rs:40:9
[INFO] [stdout]    |
[INFO] [stdout] 40 |     let mut environment = Environment::new();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_environment`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parser.rs:35:9
[INFO] [stdout]    |
[INFO] [stdout] 35 |         return Some(statements);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 35 -         return Some(statements);
[INFO] [stdout] 35 +         Some(statements)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this block may be rewritten with the `?` operator
[INFO] [stdout]   --> src/parser.rs:66:17
[INFO] [stdout]    |
[INFO] [stdout] 66 | /                 if let Err(e) = self.consume(
[INFO] [stdout] 67 | |                     TokenType::Semicolon,
[INFO] [stdout] 68 | |                     "Expected ';' after variable declaration",
[INFO] [stdout] 69 | |                 ) {
[INFO] [stdout] 70 | |                     return Err(e);
[INFO] [stdout] 71 | |                 }
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout]    = note: `#[warn(clippy::question_mark)]` on by default
[INFO] [stdout] help: replace it with
[INFO] [stdout]    |
[INFO] [stdout] 66 ~                 self.consume(
[INFO] [stdout] 67 +                     TokenType::Semicolon,
[INFO] [stdout] 68 +                     "Expected ';' after variable declaration",
[INFO] [stdout] 69 +                 )?;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this block may be rewritten with the `?` operator
[INFO] [stdout]   --> src/parser.rs:88:9
[INFO] [stdout]    |
[INFO] [stdout] 88 | /         if let Err(e) = self.consume(TokenType::Semicolon, "Expect ';' after value") {
[INFO] [stdout] 89 | |             return Err(e);
[INFO] [stdout] 90 | |         };
[INFO] [stdout]    | |_________^ help: replace it with: `self.consume(TokenType::Semicolon, "Expect ';' after value")?;`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `name`
[INFO] [stdout]   --> src/stmt.rs:19:17
[INFO] [stdout]    |
[INFO] [stdout] 19 |                 name,
[INFO] [stdout]    |                 ^^^^ help: try ignoring the field: `name: _`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:100:9
[INFO] [stdout]     |
[INFO] [stdout] 100 |         return Ok(Stmt::Expression(expression?));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 100 -         return Ok(Stmt::Expression(expression?));
[INFO] [stdout] 100 +         Ok(Stmt::Expression(expression?))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this block may be rewritten with the `?` operator
[INFO] [stdout]   --> src/parser.rs:97:9
[INFO] [stdout]    |
[INFO] [stdout] 97 | /         if let Err(e) = self.consume(TokenType::Semicolon, "Expect ';' after expression") {
[INFO] [stdout] 98 | |             return Err(e);
[INFO] [stdout] 99 | |         };
[INFO] [stdout]    | |_________^ help: replace it with: `self.consume(TokenType::Semicolon, "Expect ';' after expression")?;`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:104:9
[INFO] [stdout]     |
[INFO] [stdout] 104 |         return self.parse_binary(|s| s.expression(), &[TokenType::Comma]);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 104 -         return self.parse_binary(|s| s.expression(), &[TokenType::Comma]);
[INFO] [stdout] 104 +         self.parse_binary(|s| s.expression(), &[TokenType::Comma])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:108:9
[INFO] [stdout]     |
[INFO] [stdout] 108 |         return self.conditional();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 108 -         return self.conditional();
[INFO] [stdout] 108 +         self.conditional()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait `ASTPrintable` is never used
[INFO] [stdout]  --> src/ast_printable.rs:4:11
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub trait ASTPrintable {
[INFO] [stdout]   |           ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variants `Number`, `Str`, and `Boolean` are never constructed
[INFO] [stdout]  --> src/environment.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | pub enum EnvironmentValue {
[INFO] [stdout]   |          ---------------- variants in this enum
[INFO] [stdout] 7 |     Number(f64),
[INFO] [stdout]   |     ^^^^^^
[INFO] [stdout] 8 |     Str(String),
[INFO] [stdout]   |     ^^^
[INFO] [stdout] 9 |     Boolean(bool),
[INFO] [stdout]   |     ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `EnvironmentValue` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `EnvironmentError` is never used
[INFO] [stdout]   --> src/environment.rs:12:10
[INFO] [stdout]    |
[INFO] [stdout] 12 | pub enum EnvironmentError {
[INFO] [stdout]    |          ^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `values` is never read
[INFO] [stdout]   --> src/environment.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 16 | pub struct Environment {
[INFO] [stdout]    |            ----------- field in this struct
[INFO] [stdout] 17 |     values: HashMap<String, EnvironmentValue>,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `define` and `get` are never used
[INFO] [stdout]   --> src/environment.rs:26:12
[INFO] [stdout]    |
[INFO] [stdout] 20 | impl Environment {
[INFO] [stdout]    | ---------------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 26 |     pub fn define(&mut self, name: String, value: EnvironmentValue) {
[INFO] [stdout]    |            ^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 30 |     pub fn get(&self, name: Token) -> Result<EnvironmentValue, EnvironmentError> {
[INFO] [stdout]    |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `expression_list` is never used
[INFO] [stdout]    --> src/parser.rs:103:8
[INFO] [stdout]     |
[INFO] [stdout]  18 | impl Parser {
[INFO] [stdout]     | ----------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 103 |     fn expression_list(&mut self) -> Result<Expr, ParseError> {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/ast_printable.rs:22:49
[INFO] [stdout]    |
[INFO] [stdout] 22 |                 TokenType::Identifier(ident) => format!("{}", ident),
[INFO] [stdout]    |                                                 ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `ident.to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: passing a unit value to a function
[INFO] [stdout]   --> src/runner.rs:14:23
[INFO] [stdout]    |
[INFO] [stdout] 14 |         Ok(script) => Ok(run(script)),
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stdout]    = note: `#[warn(clippy::unit_arg)]` on by default
[INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()`
[INFO] [stdout]    |
[INFO] [stdout] 14 ~         Ok(script) => {
[INFO] [stdout] 15 +             run(script);
[INFO] [stdout] 16 +             Ok(())
[INFO] [stdout] 17 ~         },
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/ast_printable.rs:25:22
[INFO] [stdout]    |
[INFO] [stdout] 25 |                 _ => format!("Error: Unknown literal type!"),
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Error: Unknown literal type!".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/runner.rs:49:5
[INFO] [stdout]    |
[INFO] [stdout] 49 | /     match expressions {
[INFO] [stdout] 50 | |         Some(exprs) => {
[INFO] [stdout] 51 | |             for expr in exprs {
[INFO] [stdout] 52 | |                 if let Err(e) = expr.interpret() {
[INFO] [stdout] ...  |
[INFO] [stdout] 57 | |         None => (),
[INFO] [stdout] 58 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 49 ~     if let Some(exprs) = expressions {
[INFO] [stdout] 50 +         for expr in exprs {
[INFO] [stdout] 51 +             if let Err(e) = expr.interpret() {
[INFO] [stdout] 52 +                 errors::runtime_error(&e)
[INFO] [stdout] 53 +             }
[INFO] [stdout] 54 +         }
[INFO] [stdout] 55 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/scanner.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         return &self.tokens;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 59 -         return &self.tokens;
[INFO] [stdout] 59 +         &self.tokens
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/environment.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 37 |         return Err(EnvironmentError::UndefinedVariable);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 37 -         return Err(EnvironmentError::UndefinedVariable);
[INFO] [stdout] 37 +         Err(EnvironmentError::UndefinedVariable)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/errors.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     let value = HAD_ERROR.load(Ordering::Relaxed);
[INFO] [stdout]    |     ---------------------------------------------- unnecessary `let` binding
[INFO] [stdout] 11 |     value
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 10 ~     
[INFO] [stdout] 11 ~     HAD_ERROR.load(Ordering::Relaxed)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]   --> src/scanner.rs:91:20
[INFO] [stdout]    |
[INFO] [stdout] 91 |                 if c.is_digit(10) {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout]    = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/errors.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 15 |     let value = HAD_RUNTIME_ERROR.load(Ordering::Relaxed);
[INFO] [stdout]    |     ------------------------------------------------------ unnecessary `let` binding
[INFO] [stdout] 16 |     value
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 15 ~     
[INFO] [stdout] 16 ~     HAD_RUNTIME_ERROR.load(Ordering::Relaxed)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]    --> src/scanner.rs:119:15
[INFO] [stdout]     |
[INFO] [stdout] 119 |         while self.peek().is_digit(10) {
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek().is_ascii_digit()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]    --> src/scanner.rs:123:34
[INFO] [stdout]     |
[INFO] [stdout] 123 |         if self.peek() == '.' && self.peek_next().is_digit(10) {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek_next().is_ascii_digit()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]    --> src/scanner.rs:126:19
[INFO] [stdout]     |
[INFO] [stdout] 126 |             while self.peek().is_digit(10) {
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek().is_ascii_digit()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/scanner.rs:170:15
[INFO] [stdout]     |
[INFO] [stdout] 170 |         while !self.is_at_end() && !(self.peek() == '*' && self.peek_next() == '/') {
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(self.is_at_end() || self.peek() == '*' && self.peek_next() == '/')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stdout]   --> src/expr.rs:76:46
[INFO] [stdout]    |
[INFO] [stdout] 76 | fn evaluate_unary(operator: &Token, operand: &Box<Expr>) -> Result<LoxValue, RuntimeError> {
[INFO] [stdout]    |                                              ^^^^^^^^^^ help: try: `&Expr`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stdout]    = note: `#[warn(clippy::borrowed_box)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stdout]    --> src/expr.rs:107:11
[INFO] [stdout]     |
[INFO] [stdout] 107 |     left: &Box<Expr>,
[INFO] [stdout]     |           ^^^^^^^^^^ help: try: `&Expr`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stdout]    --> src/expr.rs:108:12
[INFO] [stdout]     |
[INFO] [stdout] 108 |     right: &Box<Expr>,
[INFO] [stdout]     |            ^^^^^^^^^^ help: try: `&Expr`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parser.rs:35:9
[INFO] [stdout]    |
[INFO] [stdout] 35 |         return Some(statements);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 35 -         return Some(statements);
[INFO] [stdout] 35 +         Some(statements)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this block may be rewritten with the `?` operator
[INFO] [stdout]   --> src/parser.rs:66:17
[INFO] [stdout]    |
[INFO] [stdout] 66 | /                 if let Err(e) = self.consume(
[INFO] [stdout] 67 | |                     TokenType::Semicolon,
[INFO] [stdout] 68 | |                     "Expected ';' after variable declaration",
[INFO] [stdout] 69 | |                 ) {
[INFO] [stdout] 70 | |                     return Err(e);
[INFO] [stdout] 71 | |                 }
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout]    = note: `#[warn(clippy::question_mark)]` on by default
[INFO] [stdout] help: replace it with
[INFO] [stdout]    |
[INFO] [stdout] 66 ~                 self.consume(
[INFO] [stdout] 67 +                     TokenType::Semicolon,
[INFO] [stdout] 68 +                     "Expected ';' after variable declaration",
[INFO] [stdout] 69 +                 )?;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this block may be rewritten with the `?` operator
[INFO] [stdout]   --> src/parser.rs:88:9
[INFO] [stdout]    |
[INFO] [stdout] 88 | /         if let Err(e) = self.consume(TokenType::Semicolon, "Expect ';' after value") {
[INFO] [stdout] 89 | |             return Err(e);
[INFO] [stdout] 90 | |         };
[INFO] [stdout]    | |_________^ help: replace it with: `self.consume(TokenType::Semicolon, "Expect ';' after value")?;`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:100:9
[INFO] [stdout]     |
[INFO] [stdout] 100 |         return Ok(Stmt::Expression(expression?));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 100 -         return Ok(Stmt::Expression(expression?));
[INFO] [stdout] 100 +         Ok(Stmt::Expression(expression?))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this block may be rewritten with the `?` operator
[INFO] [stdout]   --> src/parser.rs:97:9
[INFO] [stdout]    |
[INFO] [stdout] 97 | /         if let Err(e) = self.consume(TokenType::Semicolon, "Expect ';' after expression") {
[INFO] [stdout] 98 | |             return Err(e);
[INFO] [stdout] 99 | |         };
[INFO] [stdout]    | |_________^ help: replace it with: `self.consume(TokenType::Semicolon, "Expect ';' after expression")?;`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:104:9
[INFO] [stdout]     |
[INFO] [stdout] 104 |         return self.parse_binary(|s| s.expression(), &[TokenType::Comma]);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 104 -         return self.parse_binary(|s| s.expression(), &[TokenType::Comma]);
[INFO] [stdout] 104 +         self.parse_binary(|s| s.expression(), &[TokenType::Comma])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:108:9
[INFO] [stdout]     |
[INFO] [stdout] 108 |         return self.conditional();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 108 -         return self.conditional();
[INFO] [stdout] 108 +         self.conditional()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: passing a unit value to a function
[INFO] [stdout]   --> src/runner.rs:14:23
[INFO] [stdout]    |
[INFO] [stdout] 14 |         Ok(script) => Ok(run(script)),
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stdout]    = note: `#[warn(clippy::unit_arg)]` on by default
[INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()`
[INFO] [stdout]    |
[INFO] [stdout] 14 ~         Ok(script) => {
[INFO] [stdout] 15 +             run(script);
[INFO] [stdout] 16 +             Ok(())
[INFO] [stdout] 17 ~         },
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/runner.rs:49:5
[INFO] [stdout]    |
[INFO] [stdout] 49 | /     match expressions {
[INFO] [stdout] 50 | |         Some(exprs) => {
[INFO] [stdout] 51 | |             for expr in exprs {
[INFO] [stdout] 52 | |                 if let Err(e) = expr.interpret() {
[INFO] [stdout] ...  |
[INFO] [stdout] 57 | |         None => (),
[INFO] [stdout] 58 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 49 ~     if let Some(exprs) = expressions {
[INFO] [stdout] 50 +         for expr in exprs {
[INFO] [stdout] 51 +             if let Err(e) = expr.interpret() {
[INFO] [stdout] 52 +                 errors::runtime_error(&e)
[INFO] [stdout] 53 +             }
[INFO] [stdout] 54 +         }
[INFO] [stdout] 55 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/scanner.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         return &self.tokens;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 59 -         return &self.tokens;
[INFO] [stdout] 59 +         &self.tokens
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]   --> src/scanner.rs:91:20
[INFO] [stdout]    |
[INFO] [stdout] 91 |                 if c.is_digit(10) {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout]    = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]    --> src/scanner.rs:119:15
[INFO] [stdout]     |
[INFO] [stdout] 119 |         while self.peek().is_digit(10) {
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek().is_ascii_digit()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]    --> src/scanner.rs:123:34
[INFO] [stdout]     |
[INFO] [stdout] 123 |         if self.peek() == '.' && self.peek_next().is_digit(10) {
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek_next().is_ascii_digit()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]    --> src/scanner.rs:126:19
[INFO] [stdout]     |
[INFO] [stdout] 126 |             while self.peek().is_digit(10) {
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek().is_ascii_digit()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/scanner.rs:170:15
[INFO] [stdout]     |
[INFO] [stdout] 170 |         while !self.is_at_end() && !(self.peek() == '*' && self.peek_next() == '/') {
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(self.is_at_end() || self.peek() == '*' && self.peek_next() == '/')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s
[INFO] running `Command { std: "docker" "inspect" "ef2193428ed21b687056ab41d2eb4fda54beac6941129c69ba44bf573cbd680c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ef2193428ed21b687056ab41d2eb4fda54beac6941129c69ba44bf573cbd680c", kill_on_drop: false }`
[INFO] [stdout] ef2193428ed21b687056ab41d2eb4fda54beac6941129c69ba44bf573cbd680c