[INFO] cloning repository https://github.com/anuragRusty/todo-cli
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/anuragRusty/todo-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FanuragRusty%2Ftodo-cli", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FanuragRusty%2Ftodo-cli'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 6507b11632d229a35ee92524be60e33b2bf542e4
[INFO] linting anuragRusty/todo-cli against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FanuragRusty%2Ftodo-cli" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/anuragRusty/todo-cli
[INFO] finished tweaking git repo https://github.com/anuragRusty/todo-cli
[INFO] tweaked toml for git repo https://github.com/anuragRusty/todo-cli written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/anuragRusty/todo-cli on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/anuragRusty/todo-cli already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 7f1994a4a6da3d1706abd6becdb2ffae2ed55289e3b5e0a27689999c92d42a58
[INFO] running `Command { std: "docker" "start" "-a" "7f1994a4a6da3d1706abd6becdb2ffae2ed55289e3b5e0a27689999c92d42a58", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "7f1994a4a6da3d1706abd6becdb2ffae2ed55289e3b5e0a27689999c92d42a58", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7f1994a4a6da3d1706abd6becdb2ffae2ed55289e3b5e0a27689999c92d42a58", kill_on_drop: false }`
[INFO] [stdout] 7f1994a4a6da3d1706abd6becdb2ffae2ed55289e3b5e0a27689999c92d42a58
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 75bf3ab464afa35c9e361e8e41517ec4ef0d9b53b22f8eff1d5a1330e245f54f
[INFO] running `Command { std: "docker" "start" "-a" "75bf3ab464afa35c9e361e8e41517ec4ef0d9b53b22f8eff1d5a1330e245f54f", kill_on_drop: false }`
[INFO] [stderr]     Checking todo-cli v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]  --> src/title.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | /     return "
[INFO] [stdout] 3 | | ▀█▀ █▀█ █▀▄ █▀█ ▄▄ █▀▀ █░░ █
[INFO] [stdout] 4 | | ░█░ █▄█ █▄▀ █▄█ ░░ █▄▄ █▄▄ █"
[INFO] [stdout] 5 | |         .to_string();
[INFO] [stdout]   | |____________________^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]   = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]   |
[INFO] [stdout] 2 ~     "
[INFO] [stdout] 3 ~ ▀█▀ █▀█ █▀▄ █▀█ ▄▄ █▀▀ █░░ █
[INFO] [stdout] 4 ~ ░█░ █▄█ █▄▀ █▄█ ░░ █▄▄ █▄▄ █"
[INFO] [stdout] 5 ~         .to_string()
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]  --> src/update.rs:8:12
[INFO] [stdout]   |
[INFO] [stdout] 8 |         if !check[i].to_string().parse::<i32>().is_ok() {
[INFO] [stdout]   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check[i].to_string().parse::<i32>().is_err()`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]   = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]  --> src/update.rs:1:24
[INFO] [stdout]   |
[INFO] [stdout] 1 | pub fn check_in(strng: &String, str1: String) -> bool {
[INFO] [stdout]   |                        ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 1 - pub fn check_in(strng: &String, str1: String) -> bool {
[INFO] [stdout] 1 + pub fn check_in(strng: &str, str1: String) -> bool {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]  --> src/title.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | /     return "
[INFO] [stdout] 3 | | ▀█▀ █▀█ █▀▄ █▀█ ▄▄ █▀▀ █░░ █
[INFO] [stdout] 4 | | ░█░ █▄█ █▄▀ █▄█ ░░ █▄▄ █▄▄ █"
[INFO] [stdout] 5 | |         .to_string();
[INFO] [stdout]   | |____________________^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]   = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]   |
[INFO] [stdout] 2 ~     "
[INFO] [stdout] 3 ~ ▀█▀ █▀█ █▀▄ █▀█ ▄▄ █▀▀ █░░ █
[INFO] [stdout] 4 ~ ░█░ █▄█ █▄▀ █▄█ ░░ █▄▄ █▄▄ █"
[INFO] [stdout] 5 ~         .to_string()
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]  --> src/update.rs:8:12
[INFO] [stdout]   |
[INFO] [stdout] 8 |         if !check[i].to_string().parse::<i32>().is_ok() {
[INFO] [stdout]   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check[i].to_string().parse::<i32>().is_err()`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]   = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `check`
[INFO] [stdout]  --> src/update.rs:7:14
[INFO] [stdout]   |
[INFO] [stdout] 7 |     for i in 1_usize..check.len() {
[INFO] [stdout]   |              ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]   = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]   |
[INFO] [stdout] 7 -     for i in 1_usize..check.len() {
[INFO] [stdout] 7 +     for <item> in check.iter().skip(1_usize) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]  --> src/update.rs:1:24
[INFO] [stdout]   |
[INFO] [stdout] 1 | pub fn check_in(strng: &String, str1: String) -> bool {
[INFO] [stdout]   |                        ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 1 - pub fn check_in(strng: &String, str1: String) -> bool {
[INFO] [stdout] 1 + pub fn check_in(strng: &str, str1: String) -> bool {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `get`
[INFO] [stdout]   --> src/update.rs:19:14
[INFO] [stdout]    |
[INFO] [stdout] 19 |     for i in 1_usize..get.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 19 -     for i in 1_usize..get.len() {
[INFO] [stdout] 19 +     for <item> in get.iter().skip(1_usize) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `check`
[INFO] [stdout]  --> src/update.rs:7:14
[INFO] [stdout]   |
[INFO] [stdout] 7 |     for i in 1_usize..check.len() {
[INFO] [stdout]   |              ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]   = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]   |
[INFO] [stdout] 7 -     for i in 1_usize..check.len() {
[INFO] [stdout] 7 +     for <item> in check.iter().skip(1_usize) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `get`
[INFO] [stdout]   --> src/update.rs:19:14
[INFO] [stdout]    |
[INFO] [stdout] 19 |     for i in 1_usize..get.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 19 -     for i in 1_usize..get.len() {
[INFO] [stdout] 19 +     for <item> in get.iter().skip(1_usize) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/main.rs:38:12
[INFO] [stdout]    |
[INFO] [stdout] 38 |         if input.trim().to_string() != "" {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input.trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/main.rs:82:51
[INFO] [stdout]    |
[INFO] [stdout] 82 |         if input.to_lowercase().trim() == "!r" && redo_stack.len() >= 1 {
[INFO] [stdout]    |                                                   ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!redo_stack.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/main.rs:38:12
[INFO] [stdout]    |
[INFO] [stdout] 38 |         if input.trim().to_string() != "" {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input.trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/main.rs:82:51
[INFO] [stdout]    |
[INFO] [stdout] 82 |         if input.to_lowercase().trim() == "!r" && redo_stack.len() >= 1 {
[INFO] [stdout]    |                                                   ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!redo_stack.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s
[INFO] running `Command { std: "docker" "inspect" "75bf3ab464afa35c9e361e8e41517ec4ef0d9b53b22f8eff1d5a1330e245f54f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "75bf3ab464afa35c9e361e8e41517ec4ef0d9b53b22f8eff1d5a1330e245f54f", kill_on_drop: false }`
[INFO] [stdout] 75bf3ab464afa35c9e361e8e41517ec4ef0d9b53b22f8eff1d5a1330e245f54f