[INFO] cloning repository https://github.com/antoyo/rust-parse-url
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/antoyo/rust-parse-url" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantoyo%2Frust-parse-url", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantoyo%2Frust-parse-url'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] ea1cd3fc3bd2b5cc2b4d8f68685a7987bd486769
[INFO] linting antoyo/rust-parse-url against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fantoyo%2Frust-parse-url" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/antoyo/rust-parse-url
[INFO] finished tweaking git repo https://github.com/antoyo/rust-parse-url
[INFO] tweaked toml for git repo https://github.com/antoyo/rust-parse-url written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/antoyo/rust-parse-url on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/antoyo/rust-parse-url already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 7e0ebf08d8f306019b0cb4d04a42de642f6c67658b9310791086c15de21cb7f6
[INFO] running `Command { std: "docker" "start" "-a" "7e0ebf08d8f306019b0cb4d04a42de642f6c67658b9310791086c15de21cb7f6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "7e0ebf08d8f306019b0cb4d04a42de642f6c67658b9310791086c15de21cb7f6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7e0ebf08d8f306019b0cb4d04a42de642f6c67658b9310791086c15de21cb7f6", kill_on_drop: false }`
[INFO] [stdout] 7e0ebf08d8f306019b0cb4d04a42de642f6c67658b9310791086c15de21cb7f6
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 470725a47c2f5555894455d275f9ae6a15a537c9ccc372028f7fa2efd021b3bc
[INFO] running `Command { std: "docker" "start" "-a" "470725a47c2f5555894455d275f9ae6a15a537c9ccc372028f7fa2efd021b3bc", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking parse_url v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/utils.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     return None
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 12 -     return None
[INFO] [stdout] 12 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `protocol` after checking its variant with `is_some`
[INFO] [stdout]   --> src/lib.rs:37:29
[INFO] [stdout]    |
[INFO] [stdout] 36 |     if protocol.is_some() {
[INFO] [stdout]    |     --------------------- help: try: `if let Some(<item>) = protocol`
[INFO] [stdout] 37 |         let protocol_type = protocol.unwrap();
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:34:50
[INFO] [stdout]    |
[INFO] [stdout] 34 |     let protocol: Option<&str> = utils::truncate(&url, "://", 0);
[INFO] [stdout]    |                                                  ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:48:34
[INFO] [stdout]    |
[INFO] [stdout] 48 |     let result = utils::truncate(&url, "://", 1);
[INFO] [stdout]    |                                  ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:51:32
[INFO] [stdout]    |
[INFO] [stdout] 51 |         return utils::truncate(&url, "/", 0)
[INFO] [stdout]    |                                ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:54:21
[INFO] [stdout]    |
[INFO] [stdout] 54 |     utils::truncate(&result.unwrap(), "/", 0) // strip path
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^ help: change this to: `result.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_none`
[INFO] [stdout]   --> src/lib.rs:64:33
[INFO] [stdout]    |
[INFO] [stdout] 61 |     if result.is_none() {
[INFO] [stdout]    |     ------------------- help: try: `if let Some(<item>) = result`
[INFO] [stdout] ...
[INFO] [stdout] 64 |         path = utils::truncate(&result.unwrap(), "/", 1);
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:58:34
[INFO] [stdout]    |
[INFO] [stdout] 58 |     let result = utils::truncate(&url, "://", 1);
[INFO] [stdout]    |                                  ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:62:32
[INFO] [stdout]    |
[INFO] [stdout] 62 |         path = utils::truncate(&url, "/", 1);
[INFO] [stdout]    |                                ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:64:32
[INFO] [stdout]    |
[INFO] [stdout] 64 |         path = utils::truncate(&result.unwrap(), "/", 1);
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^ help: change this to: `result.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:68:32
[INFO] [stdout]    |
[INFO] [stdout] 68 |         path = utils::truncate(&path.unwrap(), "?", 0);
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^ help: change this to: `path.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:69:32
[INFO] [stdout]    |
[INFO] [stdout] 69 |         return utils::truncate(&path.unwrap(), "#", 0);
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^ help: change this to: `path.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/lib.rs:78:8
[INFO] [stdout]    |
[INFO] [stdout] 78 |     if !search.is_none() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^ help: try: `search.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `search` after checking its variant with `is_none`
[INFO] [stdout]   --> src/lib.rs:79:33
[INFO] [stdout]    |
[INFO] [stdout] 78 |     if !search.is_none() {
[INFO] [stdout]    |         ---------------- the check is happening here
[INFO] [stdout] 79 |         return utils::truncate(&search.unwrap(), "#", 0) // strip hash
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:76:48
[INFO] [stdout]    |
[INFO] [stdout] 76 |     let search: Option<&str> = utils::truncate(&url, "?", 1);
[INFO] [stdout]    |                                                ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:79:32
[INFO] [stdout]    |
[INFO] [stdout] 79 |         return utils::truncate(&search.unwrap(), "#", 0) // strip hash
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^ help: change this to: `search.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:86:21
[INFO] [stdout]    |
[INFO] [stdout] 86 |     utils::truncate(&url, "#", 1)
[INFO] [stdout]    |                     ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/lib.rs:93:8
[INFO] [stdout]    |
[INFO] [stdout] 93 |     if !search.is_none() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^ help: try: `search.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `search` after checking its variant with `is_none`
[INFO] [stdout]   --> src/lib.rs:94:33
[INFO] [stdout]    |
[INFO] [stdout] 93 |     if !search.is_none() {
[INFO] [stdout]    |         ---------------- the check is happening here
[INFO] [stdout] 94 |         let params: Vec<&str> = search.unwrap().split("&").collect();
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:90:36
[INFO] [stdout]    |
[INFO] [stdout] 90 |     let search = get_search_string(&url);
[INFO] [stdout]    |                                    ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:114:32
[INFO] [stdout]     |
[INFO] [stdout] 114 |         protocol: get_protocol(&url),
[INFO] [stdout]     |                                ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:115:24
[INFO] [stdout]     |
[INFO] [stdout] 115 |         host: get_host(&url),
[INFO] [stdout]     |                        ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:116:24
[INFO] [stdout]     |
[INFO] [stdout] 116 |         path: get_path(&url),
[INFO] [stdout]     |                        ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:117:35
[INFO] [stdout]     |
[INFO] [stdout] 117 |         search: get_search_string(&url),
[INFO] [stdout]     |                                   ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:118:32
[INFO] [stdout]     |
[INFO] [stdout] 118 |         fragment: get_fragment(&url),
[INFO] [stdout]     |                                ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:119:28
[INFO] [stdout]     |
[INFO] [stdout] 119 |         params: get_params(&url)
[INFO] [stdout]     |                            ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/lib.rs:100:33
[INFO] [stdout]     |
[INFO] [stdout] 100 |                 let k = param[0].clone();
[INFO] [stdout]     |                                 ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/lib.rs:101:33
[INFO] [stdout]     |
[INFO] [stdout] 101 |                 let v = param[1].clone();
[INFO] [stdout]     |                                 ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/lib.rs:110:23
[INFO] [stdout]     |
[INFO] [stdout] 110 | pub fn parse_url(url: &str) -> URLParts {
[INFO] [stdout]     |                       ^^^^     ^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                       |
[INFO] [stdout]     |                       the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 110 | pub fn parse_url(url: &str) -> URLParts<'_> {
[INFO] [stdout]     |                                        ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/utils.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     return None
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 12 -     return None
[INFO] [stdout] 12 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `protocol` after checking its variant with `is_some`
[INFO] [stdout]   --> src/lib.rs:37:29
[INFO] [stdout]    |
[INFO] [stdout] 36 |     if protocol.is_some() {
[INFO] [stdout]    |     --------------------- help: try: `if let Some(<item>) = protocol`
[INFO] [stdout] 37 |         let protocol_type = protocol.unwrap();
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:34:50
[INFO] [stdout]    |
[INFO] [stdout] 34 |     let protocol: Option<&str> = utils::truncate(&url, "://", 0);
[INFO] [stdout]    |                                                  ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:48:34
[INFO] [stdout]    |
[INFO] [stdout] 48 |     let result = utils::truncate(&url, "://", 1);
[INFO] [stdout]    |                                  ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:51:32
[INFO] [stdout]    |
[INFO] [stdout] 51 |         return utils::truncate(&url, "/", 0)
[INFO] [stdout]    |                                ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:54:21
[INFO] [stdout]    |
[INFO] [stdout] 54 |     utils::truncate(&result.unwrap(), "/", 0) // strip path
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^ help: change this to: `result.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_none`
[INFO] [stdout]   --> src/lib.rs:64:33
[INFO] [stdout]    |
[INFO] [stdout] 61 |     if result.is_none() {
[INFO] [stdout]    |     ------------------- help: try: `if let Some(<item>) = result`
[INFO] [stdout] ...
[INFO] [stdout] 64 |         path = utils::truncate(&result.unwrap(), "/", 1);
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:58:34
[INFO] [stdout]    |
[INFO] [stdout] 58 |     let result = utils::truncate(&url, "://", 1);
[INFO] [stdout]    |                                  ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:62:32
[INFO] [stdout]    |
[INFO] [stdout] 62 |         path = utils::truncate(&url, "/", 1);
[INFO] [stdout]    |                                ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:64:32
[INFO] [stdout]    |
[INFO] [stdout] 64 |         path = utils::truncate(&result.unwrap(), "/", 1);
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^ help: change this to: `result.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:68:32
[INFO] [stdout]    |
[INFO] [stdout] 68 |         path = utils::truncate(&path.unwrap(), "?", 0);
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^ help: change this to: `path.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:69:32
[INFO] [stdout]    |
[INFO] [stdout] 69 |         return utils::truncate(&path.unwrap(), "#", 0);
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^ help: change this to: `path.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/lib.rs:78:8
[INFO] [stdout]    |
[INFO] [stdout] 78 |     if !search.is_none() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^ help: try: `search.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `search` after checking its variant with `is_none`
[INFO] [stdout]   --> src/lib.rs:79:33
[INFO] [stdout]    |
[INFO] [stdout] 78 |     if !search.is_none() {
[INFO] [stdout]    |         ---------------- the check is happening here
[INFO] [stdout] 79 |         return utils::truncate(&search.unwrap(), "#", 0) // strip hash
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:76:48
[INFO] [stdout]    |
[INFO] [stdout] 76 |     let search: Option<&str> = utils::truncate(&url, "?", 1);
[INFO] [stdout]    |                                                ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:79:32
[INFO] [stdout]    |
[INFO] [stdout] 79 |         return utils::truncate(&search.unwrap(), "#", 0) // strip hash
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^ help: change this to: `search.unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:86:21
[INFO] [stdout]    |
[INFO] [stdout] 86 |     utils::truncate(&url, "#", 1)
[INFO] [stdout]    |                     ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/lib.rs:93:8
[INFO] [stdout]    |
[INFO] [stdout] 93 |     if !search.is_none() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^ help: try: `search.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `search` after checking its variant with `is_none`
[INFO] [stdout]   --> src/lib.rs:94:33
[INFO] [stdout]    |
[INFO] [stdout] 93 |     if !search.is_none() {
[INFO] [stdout]    |         ---------------- the check is happening here
[INFO] [stdout] 94 |         let params: Vec<&str> = search.unwrap().split("&").collect();
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lib.rs:90:36
[INFO] [stdout]    |
[INFO] [stdout] 90 |     let search = get_search_string(&url);
[INFO] [stdout]    |                                    ^^^^ help: change this to: `url`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:114:32
[INFO] [stdout]     |
[INFO] [stdout] 114 |         protocol: get_protocol(&url),
[INFO] [stdout]     |                                ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:115:24
[INFO] [stdout]     |
[INFO] [stdout] 115 |         host: get_host(&url),
[INFO] [stdout]     |                        ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:116:24
[INFO] [stdout]     |
[INFO] [stdout] 116 |         path: get_path(&url),
[INFO] [stdout]     |                        ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:117:35
[INFO] [stdout]     |
[INFO] [stdout] 117 |         search: get_search_string(&url),
[INFO] [stdout]     |                                   ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:118:32
[INFO] [stdout]     |
[INFO] [stdout] 118 |         fragment: get_fragment(&url),
[INFO] [stdout]     |                                ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:119:28
[INFO] [stdout]     |
[INFO] [stdout] 119 |         params: get_params(&url)
[INFO] [stdout]     |                            ^^^^ help: change this to: `url`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/lib.rs:100:33
[INFO] [stdout]     |
[INFO] [stdout] 100 |                 let k = param[0].clone();
[INFO] [stdout]     |                                 ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/lib.rs:101:33
[INFO] [stdout]     |
[INFO] [stdout] 101 |                 let v = param[1].clone();
[INFO] [stdout]     |                                 ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/lib.rs:110:23
[INFO] [stdout]     |
[INFO] [stdout] 110 | pub fn parse_url(url: &str) -> URLParts {
[INFO] [stdout]     |                       ^^^^     ^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                       |
[INFO] [stdout]     |                       the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 110 | pub fn parse_url(url: &str) -> URLParts<'_> {
[INFO] [stdout]     |                                        ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s
[INFO] running `Command { std: "docker" "inspect" "470725a47c2f5555894455d275f9ae6a15a537c9ccc372028f7fa2efd021b3bc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "470725a47c2f5555894455d275f9ae6a15a537c9ccc372028f7fa2efd021b3bc", kill_on_drop: false }`
[INFO] [stdout] 470725a47c2f5555894455d275f9ae6a15a537c9ccc372028f7fa2efd021b3bc