[INFO] cloning repository https://github.com/aniket0951/k_admin_backend [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aniket0951/k_admin_backend" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faniket0951%2Fk_admin_backend", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faniket0951%2Fk_admin_backend'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6bf8d9d2a431c8747d40efbb4d1cf51d81a389d7 [INFO] linting aniket0951/k_admin_backend against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faniket0951%2Fk_admin_backend" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/aniket0951/k_admin_backend [INFO] finished tweaking git repo https://github.com/aniket0951/k_admin_backend [INFO] tweaked toml for git repo https://github.com/aniket0951/k_admin_backend written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/aniket0951/k_admin_backend on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/aniket0951/k_admin_backend already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.mongodb.static-files [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded path-matchers v1.0.2 [INFO] [stderr] Downloaded path-slash v0.1.5 [INFO] [stderr] Downloaded validator_types v0.14.0 [INFO] [stderr] Downloaded validator v0.14.0 [INFO] [stderr] Downloaded change-detection v1.2.0 [INFO] [stderr] Downloaded value-bag v1.8.1 [INFO] [stderr] Downloaded validator_derive v0.14.0 [INFO] [stderr] Downloaded actix-multipart-derive v0.6.1 [INFO] [stderr] Downloaded static-files v0.2.3 [INFO] [stderr] Downloaded actix-web-static-files v4.0.1 [INFO] [stderr] Downloaded async-std-resolver v0.21.2 [INFO] [stderr] Downloaded async-signal v0.2.6 [INFO] [stderr] Downloaded actix-multipart v0.6.1 [INFO] [stderr] Downloaded async-io v2.3.2 [INFO] [stderr] Downloaded rustls v0.21.11 [INFO] [stderr] Downloaded bson v2.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 652ac755c9fb22a0e05780130dcce9ea411844f3819389e7e5d62078b7a17545 [INFO] running `Command { std: "docker" "start" "-a" "652ac755c9fb22a0e05780130dcce9ea411844f3819389e7e5d62078b7a17545", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "652ac755c9fb22a0e05780130dcce9ea411844f3819389e7e5d62078b7a17545", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "652ac755c9fb22a0e05780130dcce9ea411844f3819389e7e5d62078b7a17545", kill_on_drop: false }` [INFO] [stdout] 652ac755c9fb22a0e05780130dcce9ea411844f3819389e7e5d62078b7a17545 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f75ab9dad43c65db9be4a4e138b195ef6a743897ee7e62e28dea9fd7e98754ac [INFO] running `Command { std: "docker" "start" "-a" "f75ab9dad43c65db9be4a4e138b195ef6a743897ee7e62e28dea9fd7e98754ac", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.mongodb.static-files [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking value-bag v1.8.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling path-matchers v1.0.2 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Compiling path-slash v0.1.5 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling change-detection v1.2.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Compiling bytestring v1.3.1 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking event-listener v5.3.0 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rustix v0.37.27 [INFO] [stderr] Checking thiserror v1.0.59 [INFO] [stderr] Compiling actix-router v0.5.2 [INFO] [stderr] Checking polling v3.7.0 [INFO] [stderr] Checking event-listener-strategy v0.5.1 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling actix-web-codegen v4.2.2 [INFO] [stderr] Checking async-io v2.3.2 [INFO] [stderr] Checking async-channel v2.2.1 [INFO] [stderr] Checking cookie v0.16.2 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling static-files v0.2.3 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Compiling enum-as-inner v0.4.0 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking async-signal v0.2.6 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking async-executor v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking actix-rt v2.9.0 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Checking actix-server v2.3.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling rustls v0.21.11 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking resolv-conf v0.7.0 [INFO] [stderr] Checking trust-dns-proto v0.21.2 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking async-global-executor v2.3.1 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling rustc_version_runtime v0.2.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling v_htmlescape v0.15.8 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking trust-dns-resolver v0.21.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Compiling actix-web-static-files v4.0.1 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking rustc_version v0.2.3 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking serde_bytes v0.11.14 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling validator_types v0.14.0 [INFO] [stderr] Compiling parse-size v1.0.0 [INFO] [stderr] Checking finl_unicode v1.2.0 [INFO] [stderr] Compiling if_chain v1.0.2 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking bson v2.10.0 [INFO] [stderr] Compiling validator_derive v0.14.0 [INFO] [stderr] Checking stringprep v0.1.4 [INFO] [stderr] Compiling actix-multipart-derive v0.6.1 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking actix-http v3.6.0 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking async-std-resolver v0.21.2 [INFO] [stderr] Checking serde_plain v1.0.2 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling typed-builder v0.10.0 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking http-range v0.1.5 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking bcrypt v0.15.1 [INFO] [stderr] Checking validator v0.14.0 [INFO] [stderr] Checking jsonwebtoken v9.3.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking sanitize-filename v0.5.0 [INFO] [stderr] Checking mongodb v2.8.2 [INFO] [stderr] Checking actix-web v4.5.1 [INFO] [stderr] Checking actix-multipart v0.6.1 [INFO] [stderr] Checking actix-cors v0.7.0 [INFO] [stderr] Checking actix-files v0.6.5 [INFO] [stderr] Checking k_admin v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `chrono::prelude::*` [INFO] [stdout] --> src/dto/app_dto.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use chrono::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::prelude::*` [INFO] [stdout] --> src/dto/app_dto.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use chrono::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `actix_web::App` [INFO] [stdout] --> src/repo/student_repo.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use actix_web::App; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::sync` [INFO] [stdout] --> src/repo/events_repo.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::sync; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sync::Collection as syncCollection` [INFO] [stdout] --> src/repo/events_repo.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | sync::Collection as syncCollection [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mongoRepo::mongorepos::MongoRepo` [INFO] [stdout] --> src/repo/events_repo.rs:16:43 [INFO] [stdout] | [INFO] [stdout] 16 | models::events::{ Events, FileData }, mongoRepo::mongorepos::MongoRepo, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::result` [INFO] [stdout] --> src/repo/app_repo.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `actix_web::App` [INFO] [stdout] --> src/repo/app_repo.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use actix_web::App; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `document` [INFO] [stdout] --> src/repo/app_repo.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use bson::{doc, document, oid::ObjectId, Document}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `dto::event_dto::CreateEventDTO` [INFO] [stdout] --> src/router/event_router.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{dto::event_dto::CreateEventDTO, service::event_service::*}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/service/jwt_service.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / #[allow(non_camel_case_types, non_snake_case)] [INFO] [stdout] 21 | | [INFO] [stdout] | |_^ [INFO] [stdout] 22 | impl JwtService { [INFO] [stdout] | - the attribute applies to this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Handler` [INFO] [stdout] --> src/service/event_service.rs:3:42 [INFO] [stdout] | [INFO] [stdout] 3 | use actix_web::{web::{Data, Json, Path}, Handler, HttpResponse, Responder}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ser::SerializeStruct` [INFO] [stdout] --> src/service/app_service.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | use serde::{ser::SerializeStruct, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures::TryFutureExt` [INFO] [stdout] --> src/mongoRepo/mongorepos.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use futures::TryFutureExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `actix_web::App` [INFO] [stdout] --> src/repo/student_repo.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use actix_web::App; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::sync` [INFO] [stdout] --> src/repo/events_repo.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::sync; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sync::Collection as syncCollection` [INFO] [stdout] --> src/repo/events_repo.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | sync::Collection as syncCollection [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mongoRepo::mongorepos::MongoRepo` [INFO] [stdout] --> src/repo/events_repo.rs:16:43 [INFO] [stdout] | [INFO] [stdout] 16 | models::events::{ Events, FileData }, mongoRepo::mongorepos::MongoRepo, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::result` [INFO] [stdout] --> src/repo/app_repo.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `actix_web::App` [INFO] [stdout] --> src/repo/app_repo.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use actix_web::App; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `document` [INFO] [stdout] --> src/repo/app_repo.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use bson::{doc, document, oid::ObjectId, Document}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `dto::event_dto::CreateEventDTO` [INFO] [stdout] --> src/router/event_router.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{dto::event_dto::CreateEventDTO, service::event_service::*}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/service/jwt_service.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / #[allow(non_camel_case_types, non_snake_case)] [INFO] [stdout] 21 | | [INFO] [stdout] | |_^ [INFO] [stdout] 22 | impl JwtService { [INFO] [stdout] | - the attribute applies to this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Handler` [INFO] [stdout] --> src/service/event_service.rs:3:42 [INFO] [stdout] | [INFO] [stdout] 3 | use actix_web::{web::{Data, Json, Path}, Handler, HttpResponse, Responder}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ser::SerializeStruct` [INFO] [stdout] --> src/service/app_service.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | use serde::{ser::SerializeStruct, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures::TryFutureExt` [INFO] [stdout] --> src/mongoRepo/mongorepos.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use futures::TryFutureExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end_date` [INFO] [stdout] --> src/repo/events_repo.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | if let Some(end_date) = event.get("end_date").and_then(|bson| bson.as_datetime()) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_end_date` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end_date` [INFO] [stdout] --> src/repo/events_repo.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | if let Some(end_date) = event.get("end_date").and_then(|bson| bson.as_datetime()) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_end_date` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MongoRepo` is never constructed [INFO] [stdout] --> src/mongoRepo/mongorepos.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct MongoRepo {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `insert_one` is never used [INFO] [stdout] --> src/mongoRepo/mongorepos.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 7 | impl MongoRepo { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 8 | pub async fn insert_one(collection:Collection, bson_document:Document) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/models/user_models.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | / impl Default for UserTypes { [INFO] [stdout] 52 | | fn default() -> Self { [INFO] [stdout] 53 | | UserTypes::ENDUSER [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 45 + #[derive(Default)] [INFO] [stdout] 46 | pub enum UserTypes { [INFO] [stdout] 47 | ADMIN, [INFO] [stdout] 48 | SUBADMIN, [INFO] [stdout] 49 ~ #[default] [INFO] [stdout] 50 ~ ENDUSER [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/models/user_models.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | / impl ToString for UserTypes { [INFO] [stdout] 58 | | fn to_string(&self) -> String { [INFO] [stdout] 59 | | match self { [INFO] [stdout] 60 | | UserTypes::ADMIN => String::from("Admin"), [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MongoRepo` is never constructed [INFO] [stdout] --> src/mongoRepo/mongorepos.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct MongoRepo {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `insert_one` is never used [INFO] [stdout] --> src/mongoRepo/mongorepos.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 7 | impl MongoRepo { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 8 | pub async fn insert_one(collection:Collection, bson_document:Document) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/models/user_models.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | / impl Default for UserTypes { [INFO] [stdout] 52 | | fn default() -> Self { [INFO] [stdout] 53 | | UserTypes::ENDUSER [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 45 + #[derive(Default)] [INFO] [stdout] 46 | pub enum UserTypes { [INFO] [stdout] 47 | ADMIN, [INFO] [stdout] 48 | SUBADMIN, [INFO] [stdout] 49 ~ #[default] [INFO] [stdout] 50 ~ ENDUSER [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/models/user_models.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | / impl ToString for UserTypes { [INFO] [stdout] 58 | | fn to_string(&self) -> String { [INFO] [stdout] 59 | | match self { [INFO] [stdout] 60 | | UserTypes::ADMIN => String::from("Admin"), [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/dto/student_dto.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | / impl Default for StudentLevels { [INFO] [stdout] 80 | | fn default() -> Self { [INFO] [stdout] 81 | | StudentLevels::OFFWHITE [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 28 + #[derive(Default)] [INFO] [stdout] 29 | pub enum StudentLevels { [INFO] [stdout] 30 ~ #[default] [INFO] [stdout] 31 ~ OFFWHITE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/dto/student_dto.rs:86:1 [INFO] [stdout] | [INFO] [stdout] 86 | / impl ToString for StudentLevels { [INFO] [stdout] 87 | | fn to_string(&self) -> String { [INFO] [stdout] 88 | | match self { [INFO] [stdout] 89 | | StudentLevels::OFFWHITE => String::from("OFFWHITE"), [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dto/student_dto.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 164 | if !student.parent.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `student.parent.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dto/student_dto.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 168 | if !s.profile_pic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.profile_pic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `student.parent` after checking its variant with `is_none` [INFO] [stdout] --> src/dto/student_dto.rs:165:48 [INFO] [stdout] | [INFO] [stdout] 164 | if !student.parent.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 165 | s.parent = Some(GetParentDTO::init(student.parent.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dto/event_dto.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | if !event.file_data.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `event.file_data.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `event.file_data` after checking its variant with `is_none` [INFO] [stdout] --> src/dto/event_dto.rs:67:22 [INFO] [stdout] | [INFO] [stdout] 65 | if !event.file_data.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 66 | let mut data:Vec = Vec::new(); [INFO] [stdout] 67 | for i in event.file_data.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/dto/app_dto.rs:94:1 [INFO] [stdout] | [INFO] [stdout] 94 | / impl Default for FeeTypes { [INFO] [stdout] 95 | | fn default() -> Self { [INFO] [stdout] 96 | | FeeTypes::MONTHLY [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 56 + #[derive(Default)] [INFO] [stdout] 57 | pub enum FeeTypes { [INFO] [stdout] 58 ~ #[default] [INFO] [stdout] 59 ~ MONTHLY, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/dto/app_dto.rs:101:1 [INFO] [stdout] | [INFO] [stdout] 101 | / impl ToString for FeeTypes { [INFO] [stdout] 102 | | fn to_string(&self) -> String { [INFO] [stdout] 103 | | match self { [INFO] [stdout] 104 | | FeeTypes::MONTHLY => String::from("MONTHLY"), [INFO] [stdout] ... | [INFO] [stdout] 110 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dto/app_dto.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 215 | if !facilities.imageUrl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `facilities.imageUrl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `facilities.imageUrl` after checking its variant with `is_none` [INFO] [stdout] --> src/dto/app_dto.rs:216:69 [INFO] [stdout] | [INFO] [stdout] 215 | if !facilities.imageUrl.is_none() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 216 | f.imageUrl = Some(format!("http://192.168.0.119:8000{}",facilities.imageUrl.unwrap().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/dto/app_dto.rs:216:97 [INFO] [stdout] | [INFO] [stdout] 216 | f.imageUrl = Some(format!("http://192.168.0.119:8000{}",facilities.imageUrl.unwrap().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/user_repo.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 30 | Ok(result_id) => return Ok(result_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - Ok(result_id) => return Ok(result_id), [INFO] [stdout] 30 + Ok(result_id) => Ok(result_id), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/user_repo.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 57 | while let Some(user) = result [INFO] [stdout] | ________________________________^ [INFO] [stdout] 58 | | .try_next() [INFO] [stdout] 59 | | .await [INFO] [stdout] 60 | | .ok() [INFO] [stdout] 61 | | .expect("Error mapping through the cursor") [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 59 - .await [INFO] [stdout] 60 - .ok() [INFO] [stdout] 61 - .expect("Error mapping through the cursor") [INFO] [stdout] 59 + .await.expect("Error mapping through the cursor") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/user_repo.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | return Err(AppError::CustomError(e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Err(AppError::CustomError(e.to_string())) [INFO] [stdout] 83 + Err(AppError::CustomError(e.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/student_repo.rs:75:35 [INFO] [stdout] | [INFO] [stdout] 75 | while let Some(student) = cursor [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 76 | | .try_next() [INFO] [stdout] 77 | | .await [INFO] [stdout] 78 | | .ok() [INFO] [stdout] 79 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 77 - .await [INFO] [stdout] 78 - .ok() [INFO] [stdout] 79 - .expect("Mapping Error") [INFO] [stdout] 77 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/repo/student_repo.rs:109:22 [INFO] [stdout] | [INFO] [stdout] 109 | let result = match self.student_col.count_documents(None, None).await{ [INFO] [stdout] | ______________________^ [INFO] [stdout] 110 | | Ok(count) => count, [INFO] [stdout] 111 | | Err(_) => 0, [INFO] [stdout] 112 | | }; [INFO] [stdout] | |_________^ help: ascribe the type u64 and replace your expression with: `self.student_col.count_documents(None, None).await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/student_repo.rs:168:35 [INFO] [stdout] | [INFO] [stdout] 168 | while let Some(student) = cursor [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 169 | | .try_next() [INFO] [stdout] 170 | | .await [INFO] [stdout] 171 | | .ok() [INFO] [stdout] 172 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 170 - .await [INFO] [stdout] 171 - .ok() [INFO] [stdout] 172 - .expect("Mapping Error") [INFO] [stdout] 170 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/student_repo.rs:185:25 [INFO] [stdout] | [INFO] [stdout] 185 | Ok(None) => return Err(AppError::DataNotFoundError) , [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - Ok(None) => return Err(AppError::DataNotFoundError) , [INFO] [stdout] 185 + Ok(None) => Err(AppError::DataNotFoundError) , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/events_repo.rs:95:33 [INFO] [stdout] | [INFO] [stdout] 95 | while let Some(event) = cursor.try_next().await.ok().expect("Mapping Error") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 95 - while let Some(event) = cursor.try_next().await.ok().expect("Mapping Error") { [INFO] [stdout] 95 + while let Some(event) = cursor.try_next().await.expect("Mapping Error") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:74:34 [INFO] [stdout] | [INFO] [stdout] 74 | while let Some(branch) = cursor [INFO] [stdout] | __________________________________^ [INFO] [stdout] 75 | | .try_next() [INFO] [stdout] 76 | | .await [INFO] [stdout] 77 | | .ok() [INFO] [stdout] 78 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 76 - .await [INFO] [stdout] 77 - .ok() [INFO] [stdout] 78 - .expect("Mapping Error") [INFO] [stdout] 76 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:166:31 [INFO] [stdout] | [INFO] [stdout] 166 | while let Some(fee) = cursor [INFO] [stdout] | _______________________________^ [INFO] [stdout] 167 | | .try_next() [INFO] [stdout] 168 | | .await [INFO] [stdout] 169 | | .ok() [INFO] [stdout] 170 | | .expect("Mapping Error") [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 168 - .await [INFO] [stdout] 169 - .ok() [INFO] [stdout] 170 - .expect("Mapping Error") [INFO] [stdout] 168 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/app_repo.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 213 | return Err(AppError::CustomError("course already exists".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Err(AppError::CustomError("course already exists".to_string())); [INFO] [stdout] 213 + Err(AppError::CustomError("course already exists".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:234:34 [INFO] [stdout] | [INFO] [stdout] 234 | while let Some(course) = cursor [INFO] [stdout] | __________________________________^ [INFO] [stdout] 235 | | .try_next() [INFO] [stdout] 236 | | .await [INFO] [stdout] 237 | | .ok() [INFO] [stdout] 238 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 236 - .await [INFO] [stdout] 237 - .ok() [INFO] [stdout] 238 - .expect("Mapping Error") [INFO] [stdout] 236 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/app_repo.rs:277:21 [INFO] [stdout] | [INFO] [stdout] 277 | return Err(AppError::CustomError("failed to update duplicate course".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return Err(AppError::CustomError("failed to update duplicate course".to_string())); [INFO] [stdout] 277 + Err(AppError::CustomError("failed to update duplicate course".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/app_repo.rs:323:25 [INFO] [stdout] | [INFO] [stdout] 323 | Ok(None) => return Err(AppError::DataNotFoundError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 323 - Ok(None) => return Err(AppError::DataNotFoundError), [INFO] [stdout] 323 + Ok(None) => Err(AppError::DataNotFoundError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:339:38 [INFO] [stdout] | [INFO] [stdout] 339 | while let Some(facilitie) = cursor [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 340 | | .try_next() [INFO] [stdout] 341 | | .await [INFO] [stdout] 342 | | .ok() [INFO] [stdout] 343 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 341 - .await [INFO] [stdout] 342 - .ok() [INFO] [stdout] 343 - .expect("Mapping Error") [INFO] [stdout] 341 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:411:36 [INFO] [stdout] | [INFO] [stdout] 411 | while let Some(enquire) = cursor [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 412 | | .try_next() [INFO] [stdout] 413 | | .await [INFO] [stdout] 414 | | .ok() [INFO] [stdout] 415 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 413 - .await [INFO] [stdout] 414 - .ok() [INFO] [stdout] 415 - .expect("Mapping Error") [INFO] [stdout] 413 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/service/user_service.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | let user_type = match user.user_type { [INFO] [stdout] | _____________________^ [INFO] [stdout] 34 | | UserTypes::ADMIN => UserTypes::ADMIN, [INFO] [stdout] 35 | | UserTypes::SUBADMIN => UserTypes::SUBADMIN, [INFO] [stdout] 36 | | UserTypes::ENDUSER => UserTypes::ENDUSER [INFO] [stdout] 37 | | }; [INFO] [stdout] | |_____^ help: replace it with: `user.user_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] = note: `#[warn(clippy::needless_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/service/user_service.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 169 | match verify(request.password.to_string(), &user.password) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&request.password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/service/jwt_service.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | decode::(&token, &DecodingKey::from_secret(self_obj.secret_key.as_ref()), &Validation::default()) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/student_service.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if !request.class_branch.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request.class_branch.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `request.class_branch` after checking its variant with `is_none` [INFO] [stdout] --> src/service/student_service.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 30 | if !request.class_branch.is_none() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] 31 | class_branch = request.class_branch.as_ref().unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/service/student_service.rs:48:22 [INFO] [stdout] | [INFO] [stdout] 48 | weight: Some(request.weight.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `request.weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/student_service.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if students.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `students.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/service/student_service.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | format!("Total Count fetched"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Total Count fetched".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/student_service.rs:216:32 [INFO] [stdout] | [INFO] [stdout] 216 | ... if !student.profile_pic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `student.profile_pic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `student.profile_pic` after checking its variant with `is_none` [INFO] [stdout] --> src/service/student_service.rs:217:78 [INFO] [stdout] | [INFO] [stdout] 216 | ... if !student.profile_pic.is_none() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 217 | ... let res = std::fs::remove_file(format!(".{}",student.profile_pic.unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/service/student_service.rs:238:27 [INFO] [stdout] | [INFO] [stdout] 238 | Err(e) => return HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - Err(e) => return HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] 238 + Err(e) => HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/service/student_service.rs:181:31 [INFO] [stdout] | [INFO] [stdout] 181 | let f_file_path = format!("/static/student/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/static/student/".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/service/student_service.rs:192:28 [INFO] [stdout] | [INFO] [stdout] 192 | file_path.push(&sanitize_filename::sanitize(&file_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `sanitize_filename::sanitize(&file_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/service/student_service.rs:192:57 [INFO] [stdout] | [INFO] [stdout] 192 | file_path.push(&sanitize_filename::sanitize(&file_name)); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/student_service.rs:217:106 [INFO] [stdout] | [INFO] [stdout] 217 | ... let res = std::fs::remove_file(format!(".{}",student.profile_pic.unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/student_service.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 264 | if !request.email.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request.email.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `request.email` after checking its variant with `is_none` [INFO] [stdout] --> src/service/student_service.rs:265:28 [INFO] [stdout] | [INFO] [stdout] 264 | if !request.email.is_none() { [INFO] [stdout] | ----------------------- the check is happening here [INFO] [stdout] 265 | if !validate_email(request.email.as_ref().unwrap().to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/service/student_service.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 264 | / if !request.email.is_none() { [INFO] [stdout] 265 | | if !validate_email(request.email.as_ref().unwrap().to_string()) { [INFO] [stdout] 266 | | return HttpResponse::BadRequest().json( [INFO] [stdout] 267 | | ResponseBuilder::<()>::FailedResponse("Invalid email".to_string()) [INFO] [stdout] ... | [INFO] [stdout] 270 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 264 ~ if !request.email.is_none() [INFO] [stdout] 265 ~ && !validate_email(request.email.as_ref().unwrap().to_string()) { [INFO] [stdout] 266 | return HttpResponse::BadRequest().json( [INFO] [stdout] 267 | ResponseBuilder::<()>::FailedResponse("Invalid email".to_string()) [INFO] [stdout] 268 | ); [INFO] [stdout] 269 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/dto/student_dto.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | / impl Default for StudentLevels { [INFO] [stdout] 80 | | fn default() -> Self { [INFO] [stdout] 81 | | StudentLevels::OFFWHITE [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 28 + #[derive(Default)] [INFO] [stdout] 29 | pub enum StudentLevels { [INFO] [stdout] 30 ~ #[default] [INFO] [stdout] 31 ~ OFFWHITE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/service/student_service.rs:272:31 [INFO] [stdout] | [INFO] [stdout] 272 | match ObjectId::parse_str(request.student_id.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&request.student_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/student_service.rs:289:82 [INFO] [stdout] | [INFO] [stdout] 289 | ... format!("Student {}", AppError::DataNotFoundError.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/dto/student_dto.rs:86:1 [INFO] [stdout] | [INFO] [stdout] 86 | / impl ToString for StudentLevels { [INFO] [stdout] 87 | | fn to_string(&self) -> String { [INFO] [stdout] 88 | | match self { [INFO] [stdout] 89 | | StudentLevels::OFFWHITE => String::from("OFFWHITE"), [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/student_service.rs:295:76 [INFO] [stdout] | [INFO] [stdout] 295 | ... format!("Parent {}",Messages::DataUpdateSuccess.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/student_service.rs:356:16 [INFO] [stdout] | [INFO] [stdout] 356 | if students.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `students.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/service/event_service.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 14 | ... let bd = mongodb::bson::DateTime::builder().year(datetime_utc.year()).month(datetime_utc.month().try_into().unwrap()).day(datetime_utc.day().try_into().unwrap()).build().unwrap(); [INFO] [stdout] | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 15 | ... bd [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 14 ~ [INFO] [stdout] 15 ~ mongodb::bson::DateTime::builder().year(datetime_utc.year()).month(datetime_utc.month().try_into().unwrap()).day(datetime_utc.day().try_into().unwrap()).build().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/service/event_service.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 27 | ... let bd = mongodb::bson::DateTime::builder().year(datetime_utc.year()).month(datetime_utc.month().try_into().unwrap()).day(datetime_utc.day().try_into().unwrap()).build().unwrap(); [INFO] [stdout] | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 28 | ... bd [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 27 ~ [INFO] [stdout] 28 ~ mongodb::bson::DateTime::builder().year(datetime_utc.year()).month(datetime_utc.month().try_into().unwrap()).day(datetime_utc.day().try_into().unwrap()).build().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/event_service.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | if events.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `events.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/event_service.rs:163:106 [INFO] [stdout] | [INFO] [stdout] 163 | ResponseBuilder::<()>::FailedResponse(format!("Event {}", AppError::DataNotFoundError.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/event_service.rs:327:114 [INFO] [stdout] | [INFO] [stdout] 327 | ... ResponseBuilder::<()>::FailedResponse(format!("Event {}", AppError::DataNotFoundError.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | if branches.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `branches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/app_service.rs:52:109 [INFO] [stdout] | [INFO] [stdout] 52 | ResponseBuilder::<()>::FailedResponse(format!("Branches {}", AppError::DataNotFoundError.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | let totalStudent = match db.total_students().await { [INFO] [stdout] | _________________________^ [INFO] [stdout] 151 | | Ok(count) => count, [INFO] [stdout] 152 | | Err(_) => 0, [INFO] [stdout] 153 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.total_students().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:155:30 [INFO] [stdout] | [INFO] [stdout] 155 | let lastMonthAdmission = match db.last_month_admission_count().await { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 156 | | Ok(count) => count, [INFO] [stdout] 157 | | Err(_) => 0, [INFO] [stdout] 158 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.last_month_admission_count().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:160:25 [INFO] [stdout] | [INFO] [stdout] 160 | let totalBranches = match db.total_branches().await { [INFO] [stdout] | _________________________^ [INFO] [stdout] 161 | | Ok(count) => count, [INFO] [stdout] 162 | | Err(_) => 0, [INFO] [stdout] 163 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.total_branches().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:165:23 [INFO] [stdout] | [INFO] [stdout] 165 | let totalEvents = match db.total_events().await { [INFO] [stdout] | _______________________^ [INFO] [stdout] 166 | | Ok(count) => count, [INFO] [stdout] 167 | | Err(_) => 0, [INFO] [stdout] 168 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.total_events().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:170:32 [INFO] [stdout] | [INFO] [stdout] 170 | let totalUpCommingEvents = match db.upcommint_event_count().await { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 171 | | Ok(count) => count, [INFO] [stdout] 172 | | Err(_) => 0, [INFO] [stdout] 173 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.upcommint_event_count().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/service/app_service.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | fee_amount: fee.fee_amount.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `fee.fee_amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/service/app_service.rs:254:23 [INFO] [stdout] | [INFO] [stdout] 254 | fee_discount: fee.fee_discount.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `fee.fee_discount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:280:16 [INFO] [stdout] | [INFO] [stdout] 280 | if fees.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fees.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:422:16 [INFO] [stdout] | [INFO] [stdout] 422 | if courses.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `courses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/service/app_service.rs:453:39 [INFO] [stdout] | [INFO] [stdout] 453 | match ObjectId::parse_str(args.id.as_ref().unwrap().to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `args.id.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:662:16 [INFO] [stdout] | [INFO] [stdout] 662 | if facilities.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `facilities.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/app_service.rs:691:27 [INFO] [stdout] | [INFO] [stdout] 691 | let isImage = !facility.image_url.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `facility.image_url.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/app_service.rs:766:32 [INFO] [stdout] | [INFO] [stdout] 766 | ... if !student.imageUrl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `student.imageUrl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `student.imageUrl` after checking its variant with `is_none` [INFO] [stdout] --> src/service/app_service.rs:767:78 [INFO] [stdout] | [INFO] [stdout] 766 | ... if !student.imageUrl.is_none() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] 767 | ... let res = std::fs::remove_file(format!(".{}",student.imageUrl.unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/service/app_service.rs:788:27 [INFO] [stdout] | [INFO] [stdout] 788 | Err(e) => return HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 788 - Err(e) => return HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] 788 + Err(e) => HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/service/app_service.rs:727:31 [INFO] [stdout] | [INFO] [stdout] 727 | let f_file_path = format!("/static/facilities/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/static/facilities/".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/service/app_service.rs:738:28 [INFO] [stdout] | [INFO] [stdout] 738 | file_path.push(&sanitize_filename::sanitize(&file_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `sanitize_filename::sanitize(&file_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/service/app_service.rs:738:57 [INFO] [stdout] | [INFO] [stdout] 738 | file_path.push(&sanitize_filename::sanitize(&file_name)); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/app_service.rs:767:103 [INFO] [stdout] | [INFO] [stdout] 767 | ... let res = std::fs::remove_file(format!(".{}",student.imageUrl.unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:879:16 [INFO] [stdout] | [INFO] [stdout] 879 | if enquires.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `enquires.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dto/student_dto.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 164 | if !student.parent.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `student.parent.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dto/student_dto.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 168 | if !s.profile_pic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.profile_pic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `student.parent` after checking its variant with `is_none` [INFO] [stdout] --> src/dto/student_dto.rs:165:48 [INFO] [stdout] | [INFO] [stdout] 164 | if !student.parent.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 165 | s.parent = Some(GetParentDTO::init(student.parent.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/helper/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod helper; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/middleware/auth_middeleware.rs:63:42 [INFO] [stdout] | [INFO] [stdout] 63 | let header_val = format!("{}", auth_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `auth_val.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `mongoRepo` should have a snake case name [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | mod mongoRepo; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `mongo_repo` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/helper/helper.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if USED_NUMBERS.contains(&number) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/helper/helper.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | USED_NUMBERS.push(number); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dto/event_dto.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | if !event.file_data.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `event.file_data.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `event.file_data` after checking its variant with `is_none` [INFO] [stdout] --> src/dto/event_dto.rs:67:22 [INFO] [stdout] | [INFO] [stdout] 65 | if !event.file_data.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 66 | let mut data:Vec = Vec::new(); [INFO] [stdout] 67 | for i in event.file_data.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/dto/app_dto.rs:94:1 [INFO] [stdout] | [INFO] [stdout] 94 | / impl Default for FeeTypes { [INFO] [stdout] 95 | | fn default() -> Self { [INFO] [stdout] 96 | | FeeTypes::MONTHLY [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 56 + #[derive(Default)] [INFO] [stdout] 57 | pub enum FeeTypes { [INFO] [stdout] 58 ~ #[default] [INFO] [stdout] 59 ~ MONTHLY, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/dto/app_dto.rs:101:1 [INFO] [stdout] | [INFO] [stdout] 101 | / impl ToString for FeeTypes { [INFO] [stdout] 102 | | fn to_string(&self) -> String { [INFO] [stdout] 103 | | match self { [INFO] [stdout] 104 | | FeeTypes::MONTHLY => String::from("MONTHLY"), [INFO] [stdout] ... | [INFO] [stdout] 110 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dto/app_dto.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 215 | if !facilities.imageUrl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `facilities.imageUrl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `facilities.imageUrl` after checking its variant with `is_none` [INFO] [stdout] --> src/dto/app_dto.rs:216:69 [INFO] [stdout] | [INFO] [stdout] 215 | if !facilities.imageUrl.is_none() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 216 | f.imageUrl = Some(format!("http://192.168.0.119:8000{}",facilities.imageUrl.unwrap().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/dto/app_dto.rs:216:97 [INFO] [stdout] | [INFO] [stdout] 216 | f.imageUrl = Some(format!("http://192.168.0.119:8000{}",facilities.imageUrl.unwrap().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/user_repo.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 30 | Ok(result_id) => return Ok(result_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - Ok(result_id) => return Ok(result_id), [INFO] [stdout] 30 + Ok(result_id) => Ok(result_id), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/user_repo.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 57 | while let Some(user) = result [INFO] [stdout] | ________________________________^ [INFO] [stdout] 58 | | .try_next() [INFO] [stdout] 59 | | .await [INFO] [stdout] 60 | | .ok() [INFO] [stdout] 61 | | .expect("Error mapping through the cursor") [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 59 - .await [INFO] [stdout] 60 - .ok() [INFO] [stdout] 61 - .expect("Error mapping through the cursor") [INFO] [stdout] 59 + .await.expect("Error mapping through the cursor") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/user_repo.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | return Err(AppError::CustomError(e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Err(AppError::CustomError(e.to_string())) [INFO] [stdout] 83 + Err(AppError::CustomError(e.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/student_repo.rs:75:35 [INFO] [stdout] | [INFO] [stdout] 75 | while let Some(student) = cursor [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 76 | | .try_next() [INFO] [stdout] 77 | | .await [INFO] [stdout] 78 | | .ok() [INFO] [stdout] 79 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 77 - .await [INFO] [stdout] 78 - .ok() [INFO] [stdout] 79 - .expect("Mapping Error") [INFO] [stdout] 77 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/repo/student_repo.rs:109:22 [INFO] [stdout] | [INFO] [stdout] 109 | let result = match self.student_col.count_documents(None, None).await{ [INFO] [stdout] | ______________________^ [INFO] [stdout] 110 | | Ok(count) => count, [INFO] [stdout] 111 | | Err(_) => 0, [INFO] [stdout] 112 | | }; [INFO] [stdout] | |_________^ help: ascribe the type u64 and replace your expression with: `self.student_col.count_documents(None, None).await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/student_repo.rs:168:35 [INFO] [stdout] | [INFO] [stdout] 168 | while let Some(student) = cursor [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 169 | | .try_next() [INFO] [stdout] 170 | | .await [INFO] [stdout] 171 | | .ok() [INFO] [stdout] 172 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 170 - .await [INFO] [stdout] 171 - .ok() [INFO] [stdout] 172 - .expect("Mapping Error") [INFO] [stdout] 170 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/student_repo.rs:185:25 [INFO] [stdout] | [INFO] [stdout] 185 | Ok(None) => return Err(AppError::DataNotFoundError) , [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - Ok(None) => return Err(AppError::DataNotFoundError) , [INFO] [stdout] 185 + Ok(None) => Err(AppError::DataNotFoundError) , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/events_repo.rs:95:33 [INFO] [stdout] | [INFO] [stdout] 95 | while let Some(event) = cursor.try_next().await.ok().expect("Mapping Error") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 95 - while let Some(event) = cursor.try_next().await.ok().expect("Mapping Error") { [INFO] [stdout] 95 + while let Some(event) = cursor.try_next().await.expect("Mapping Error") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:74:34 [INFO] [stdout] | [INFO] [stdout] 74 | while let Some(branch) = cursor [INFO] [stdout] | __________________________________^ [INFO] [stdout] 75 | | .try_next() [INFO] [stdout] 76 | | .await [INFO] [stdout] 77 | | .ok() [INFO] [stdout] 78 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 76 - .await [INFO] [stdout] 77 - .ok() [INFO] [stdout] 78 - .expect("Mapping Error") [INFO] [stdout] 76 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:166:31 [INFO] [stdout] | [INFO] [stdout] 166 | while let Some(fee) = cursor [INFO] [stdout] | _______________________________^ [INFO] [stdout] 167 | | .try_next() [INFO] [stdout] 168 | | .await [INFO] [stdout] 169 | | .ok() [INFO] [stdout] 170 | | .expect("Mapping Error") [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 168 - .await [INFO] [stdout] 169 - .ok() [INFO] [stdout] 170 - .expect("Mapping Error") [INFO] [stdout] 168 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/app_repo.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 213 | return Err(AppError::CustomError("course already exists".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Err(AppError::CustomError("course already exists".to_string())); [INFO] [stdout] 213 + Err(AppError::CustomError("course already exists".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:234:34 [INFO] [stdout] | [INFO] [stdout] 234 | while let Some(course) = cursor [INFO] [stdout] | __________________________________^ [INFO] [stdout] 235 | | .try_next() [INFO] [stdout] 236 | | .await [INFO] [stdout] 237 | | .ok() [INFO] [stdout] 238 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 236 - .await [INFO] [stdout] 237 - .ok() [INFO] [stdout] 238 - .expect("Mapping Error") [INFO] [stdout] 236 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/app_repo.rs:277:21 [INFO] [stdout] | [INFO] [stdout] 277 | return Err(AppError::CustomError("failed to update duplicate course".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return Err(AppError::CustomError("failed to update duplicate course".to_string())); [INFO] [stdout] 277 + Err(AppError::CustomError("failed to update duplicate course".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/repo/app_repo.rs:323:25 [INFO] [stdout] | [INFO] [stdout] 323 | Ok(None) => return Err(AppError::DataNotFoundError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 323 - Ok(None) => return Err(AppError::DataNotFoundError), [INFO] [stdout] 323 + Ok(None) => Err(AppError::DataNotFoundError), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:339:38 [INFO] [stdout] | [INFO] [stdout] 339 | while let Some(facilitie) = cursor [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 340 | | .try_next() [INFO] [stdout] 341 | | .await [INFO] [stdout] 342 | | .ok() [INFO] [stdout] 343 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 341 - .await [INFO] [stdout] 342 - .ok() [INFO] [stdout] 343 - .expect("Mapping Error") [INFO] [stdout] 341 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/repo/app_repo.rs:411:36 [INFO] [stdout] | [INFO] [stdout] 411 | while let Some(enquire) = cursor [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 412 | | .try_next() [INFO] [stdout] 413 | | .await [INFO] [stdout] 414 | | .ok() [INFO] [stdout] 415 | | .expect("Mapping Error") [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 413 - .await [INFO] [stdout] 414 - .ok() [INFO] [stdout] 415 - .expect("Mapping Error") [INFO] [stdout] 413 + .await.expect("Mapping Error") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/service/user_service.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | let user_type = match user.user_type { [INFO] [stdout] | _____________________^ [INFO] [stdout] 34 | | UserTypes::ADMIN => UserTypes::ADMIN, [INFO] [stdout] 35 | | UserTypes::SUBADMIN => UserTypes::SUBADMIN, [INFO] [stdout] 36 | | UserTypes::ENDUSER => UserTypes::ENDUSER [INFO] [stdout] 37 | | }; [INFO] [stdout] | |_____^ help: replace it with: `user.user_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] = note: `#[warn(clippy::needless_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/service/user_service.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 169 | match verify(request.password.to_string(), &user.password) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&request.password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/service/jwt_service.rs:62:37 [INFO] [stdout] | [INFO] [stdout] 62 | decode::(&token, &DecodingKey::from_secret(self_obj.secret_key.as_ref()), &Validation::default()) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/student_service.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if !request.class_branch.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request.class_branch.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `request.class_branch` after checking its variant with `is_none` [INFO] [stdout] --> src/service/student_service.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 30 | if !request.class_branch.is_none() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] 31 | class_branch = request.class_branch.as_ref().unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/service/student_service.rs:48:22 [INFO] [stdout] | [INFO] [stdout] 48 | weight: Some(request.weight.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `request.weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/student_service.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if students.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `students.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/service/student_service.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | format!("Total Count fetched"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Total Count fetched".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/student_service.rs:216:32 [INFO] [stdout] | [INFO] [stdout] 216 | ... if !student.profile_pic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `student.profile_pic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `student.profile_pic` after checking its variant with `is_none` [INFO] [stdout] --> src/service/student_service.rs:217:78 [INFO] [stdout] | [INFO] [stdout] 216 | ... if !student.profile_pic.is_none() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 217 | ... let res = std::fs::remove_file(format!(".{}",student.profile_pic.unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/service/student_service.rs:238:27 [INFO] [stdout] | [INFO] [stdout] 238 | Err(e) => return HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - Err(e) => return HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] 238 + Err(e) => HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/service/student_service.rs:181:31 [INFO] [stdout] | [INFO] [stdout] 181 | let f_file_path = format!("/static/student/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/static/student/".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/service/student_service.rs:192:28 [INFO] [stdout] | [INFO] [stdout] 192 | file_path.push(&sanitize_filename::sanitize(&file_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `sanitize_filename::sanitize(&file_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/service/student_service.rs:192:57 [INFO] [stdout] | [INFO] [stdout] 192 | file_path.push(&sanitize_filename::sanitize(&file_name)); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/student_service.rs:217:106 [INFO] [stdout] | [INFO] [stdout] 217 | ... let res = std::fs::remove_file(format!(".{}",student.profile_pic.unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/student_service.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 264 | if !request.email.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request.email.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `request.email` after checking its variant with `is_none` [INFO] [stdout] --> src/service/student_service.rs:265:28 [INFO] [stdout] | [INFO] [stdout] 264 | if !request.email.is_none() { [INFO] [stdout] | ----------------------- the check is happening here [INFO] [stdout] 265 | if !validate_email(request.email.as_ref().unwrap().to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/service/student_service.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 264 | / if !request.email.is_none() { [INFO] [stdout] 265 | | if !validate_email(request.email.as_ref().unwrap().to_string()) { [INFO] [stdout] 266 | | return HttpResponse::BadRequest().json( [INFO] [stdout] 267 | | ResponseBuilder::<()>::FailedResponse("Invalid email".to_string()) [INFO] [stdout] ... | [INFO] [stdout] 270 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 264 ~ if !request.email.is_none() [INFO] [stdout] 265 ~ && !validate_email(request.email.as_ref().unwrap().to_string()) { [INFO] [stdout] 266 | return HttpResponse::BadRequest().json( [INFO] [stdout] 267 | ResponseBuilder::<()>::FailedResponse("Invalid email".to_string()) [INFO] [stdout] 268 | ); [INFO] [stdout] 269 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/service/student_service.rs:272:31 [INFO] [stdout] | [INFO] [stdout] 272 | match ObjectId::parse_str(request.student_id.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&request.student_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/student_service.rs:289:82 [INFO] [stdout] | [INFO] [stdout] 289 | ... format!("Student {}", AppError::DataNotFoundError.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/student_service.rs:295:76 [INFO] [stdout] | [INFO] [stdout] 295 | ... format!("Parent {}",Messages::DataUpdateSuccess.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/student_service.rs:356:16 [INFO] [stdout] | [INFO] [stdout] 356 | if students.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `students.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/service/event_service.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 14 | ... let bd = mongodb::bson::DateTime::builder().year(datetime_utc.year()).month(datetime_utc.month().try_into().unwrap()).day(datetime_utc.day().try_into().unwrap()).build().unwrap(); [INFO] [stdout] | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 15 | ... bd [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 14 ~ [INFO] [stdout] 15 ~ mongodb::bson::DateTime::builder().year(datetime_utc.year()).month(datetime_utc.month().try_into().unwrap()).day(datetime_utc.day().try_into().unwrap()).build().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/service/event_service.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 27 | ... let bd = mongodb::bson::DateTime::builder().year(datetime_utc.year()).month(datetime_utc.month().try_into().unwrap()).day(datetime_utc.day().try_into().unwrap()).build().unwrap(); [INFO] [stdout] | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 28 | ... bd [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 27 ~ [INFO] [stdout] 28 ~ mongodb::bson::DateTime::builder().year(datetime_utc.year()).month(datetime_utc.month().try_into().unwrap()).day(datetime_utc.day().try_into().unwrap()).build().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/event_service.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | if events.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `events.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/event_service.rs:163:106 [INFO] [stdout] | [INFO] [stdout] 163 | ResponseBuilder::<()>::FailedResponse(format!("Event {}", AppError::DataNotFoundError.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/event_service.rs:327:114 [INFO] [stdout] | [INFO] [stdout] 327 | ... ResponseBuilder::<()>::FailedResponse(format!("Event {}", AppError::DataNotFoundError.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | if branches.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `branches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/app_service.rs:52:109 [INFO] [stdout] | [INFO] [stdout] 52 | ResponseBuilder::<()>::FailedResponse(format!("Branches {}", AppError::DataNotFoundError.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | let totalStudent = match db.total_students().await { [INFO] [stdout] | _________________________^ [INFO] [stdout] 151 | | Ok(count) => count, [INFO] [stdout] 152 | | Err(_) => 0, [INFO] [stdout] 153 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.total_students().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:155:30 [INFO] [stdout] | [INFO] [stdout] 155 | let lastMonthAdmission = match db.last_month_admission_count().await { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 156 | | Ok(count) => count, [INFO] [stdout] 157 | | Err(_) => 0, [INFO] [stdout] 158 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.last_month_admission_count().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:160:25 [INFO] [stdout] | [INFO] [stdout] 160 | let totalBranches = match db.total_branches().await { [INFO] [stdout] | _________________________^ [INFO] [stdout] 161 | | Ok(count) => count, [INFO] [stdout] 162 | | Err(_) => 0, [INFO] [stdout] 163 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.total_branches().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:165:23 [INFO] [stdout] | [INFO] [stdout] 165 | let totalEvents = match db.total_events().await { [INFO] [stdout] | _______________________^ [INFO] [stdout] 166 | | Ok(count) => count, [INFO] [stdout] 167 | | Err(_) => 0, [INFO] [stdout] 168 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.total_events().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/service/app_service.rs:170:32 [INFO] [stdout] | [INFO] [stdout] 170 | let totalUpCommingEvents = match db.upcommint_event_count().await { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 171 | | Ok(count) => count, [INFO] [stdout] 172 | | Err(_) => 0, [INFO] [stdout] 173 | | }; [INFO] [stdout] | |_____^ help: ascribe the type u64 and replace your expression with: `db.upcommint_event_count().await.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/service/app_service.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | fee_amount: fee.fee_amount.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `fee.fee_amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/service/app_service.rs:254:23 [INFO] [stdout] | [INFO] [stdout] 254 | fee_discount: fee.fee_discount.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `fee.fee_discount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:280:16 [INFO] [stdout] | [INFO] [stdout] 280 | if fees.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fees.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:422:16 [INFO] [stdout] | [INFO] [stdout] 422 | if courses.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `courses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/service/app_service.rs:453:39 [INFO] [stdout] | [INFO] [stdout] 453 | match ObjectId::parse_str(args.id.as_ref().unwrap().to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `args.id.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:662:16 [INFO] [stdout] | [INFO] [stdout] 662 | if facilities.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `facilities.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/app_service.rs:691:27 [INFO] [stdout] | [INFO] [stdout] 691 | let isImage = !facility.image_url.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `facility.image_url.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/service/app_service.rs:766:32 [INFO] [stdout] | [INFO] [stdout] 766 | ... if !student.imageUrl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `student.imageUrl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `student.imageUrl` after checking its variant with `is_none` [INFO] [stdout] --> src/service/app_service.rs:767:78 [INFO] [stdout] | [INFO] [stdout] 766 | ... if !student.imageUrl.is_none() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] 767 | ... let res = std::fs::remove_file(format!(".{}",student.imageUrl.unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/service/app_service.rs:788:27 [INFO] [stdout] | [INFO] [stdout] 788 | Err(e) => return HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 788 - Err(e) => return HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] 788 + Err(e) => HttpResponse::InternalServerError().json(e.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/service/app_service.rs:727:31 [INFO] [stdout] | [INFO] [stdout] 727 | let f_file_path = format!("/static/facilities/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/static/facilities/".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/service/app_service.rs:738:28 [INFO] [stdout] | [INFO] [stdout] 738 | file_path.push(&sanitize_filename::sanitize(&file_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `sanitize_filename::sanitize(&file_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/service/app_service.rs:738:57 [INFO] [stdout] | [INFO] [stdout] 738 | file_path.push(&sanitize_filename::sanitize(&file_name)); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/service/app_service.rs:767:103 [INFO] [stdout] | [INFO] [stdout] 767 | ... let res = std::fs::remove_file(format!(".{}",student.imageUrl.unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/service/app_service.rs:879:16 [INFO] [stdout] | [INFO] [stdout] 879 | if enquires.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `enquires.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/helper/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod helper; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/middleware/auth_middeleware.rs:63:42 [INFO] [stdout] | [INFO] [stdout] 63 | let header_val = format!("{}", auth_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `auth_val.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `mongoRepo` should have a snake case name [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | mod mongoRepo; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `mongo_repo` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/helper/helper.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if USED_NUMBERS.contains(&number) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/helper/helper.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | USED_NUMBERS.push(number); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 34s [INFO] running `Command { std: "docker" "inspect" "f75ab9dad43c65db9be4a4e138b195ef6a743897ee7e62e28dea9fd7e98754ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f75ab9dad43c65db9be4a4e138b195ef6a743897ee7e62e28dea9fd7e98754ac", kill_on_drop: false }` [INFO] [stdout] f75ab9dad43c65db9be4a4e138b195ef6a743897ee7e62e28dea9fd7e98754ac