[INFO] cloning repository https://github.com/andribergs/tinyserde [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andribergs/tinyserde" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandribergs%2Ftinyserde", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandribergs%2Ftinyserde'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b5540b530892ae08d172ee88106a53f23aa49d40 [INFO] linting andribergs/tinyserde against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandribergs%2Ftinyserde" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/andribergs/tinyserde [INFO] finished tweaking git repo https://github.com/andribergs/tinyserde [INFO] tweaked toml for git repo https://github.com/andribergs/tinyserde written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/andribergs/tinyserde on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/andribergs/tinyserde already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 276d7ca9b58d1910b454f503d3350e402272af26140494545313a1ee3b68fcfd [INFO] running `Command { std: "docker" "start" "-a" "276d7ca9b58d1910b454f503d3350e402272af26140494545313a1ee3b68fcfd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "276d7ca9b58d1910b454f503d3350e402272af26140494545313a1ee3b68fcfd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "276d7ca9b58d1910b454f503d3350e402272af26140494545313a1ee3b68fcfd", kill_on_drop: false }` [INFO] [stdout] 276d7ca9b58d1910b454f503d3350e402272af26140494545313a1ee3b68fcfd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e9ccc26c4f05a26bf3b7f79ebd48eabf5fa160025447ce81bf704c54c3dfdac0 [INFO] running `Command { std: "docker" "start" "-a" "e9ccc26c4f05a26bf3b7f79ebd48eabf5fa160025447ce81bf704c54c3dfdac0", kill_on_drop: false }` [INFO] [stderr] Checking tinyserde v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/parser.rs:23:53 [INFO] [stdout] | [INFO] [stdout] 23 | JsonValue::Bool(val) => JsonValue::Bool(val.clone()), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/parser.rs:24:57 [INFO] [stdout] | [INFO] [stdout] 24 | JsonValue::Number(val) => JsonValue::Number(val.clone()), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / return match c { [INFO] [stdout] 50 | | '\t' => true, [INFO] [stdout] 51 | | '\n' => true, [INFO] [stdout] 52 | | '\r' => true, [INFO] [stdout] 53 | | ' ' => true, [INFO] [stdout] 54 | | _ => false, [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ match c { [INFO] [stdout] 50 + '\t' => true, [INFO] [stdout] 51 + '\n' => true, [INFO] [stdout] 52 + '\r' => true, [INFO] [stdout] 53 + ' ' => true, [INFO] [stdout] 54 + _ => false, [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/parser.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | return match c { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | '\t' => true, [INFO] [stdout] 51 | | '\n' => true, [INFO] [stdout] 52 | | '\r' => true, [INFO] [stdout] 53 | | ' ' => true, [INFO] [stdout] 54 | | _ => false, [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 49 - return match c { [INFO] [stdout] 50 - '\t' => true, [INFO] [stdout] 51 - '\n' => true, [INFO] [stdout] 52 - '\r' => true, [INFO] [stdout] 53 - ' ' => true, [INFO] [stdout] 54 - _ => false, [INFO] [stdout] 55 - } [INFO] [stdout] 49 + return matches!(c, '\t' | '\n' | '\r' | ' ') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / return match c { [INFO] [stdout] 60 | | '}' => true, [INFO] [stdout] 61 | | ']' => true, [INFO] [stdout] 62 | | ':' => true, [INFO] [stdout] 63 | | ',' => true, [INFO] [stdout] 64 | | _ => false, [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ match c { [INFO] [stdout] 60 + '}' => true, [INFO] [stdout] 61 + ']' => true, [INFO] [stdout] 62 + ':' => true, [INFO] [stdout] 63 + ',' => true, [INFO] [stdout] 64 + _ => false, [INFO] [stdout] 65 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/parser.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | return match c { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | '}' => true, [INFO] [stdout] 61 | | ']' => true, [INFO] [stdout] 62 | | ':' => true, [INFO] [stdout] 63 | | ',' => true, [INFO] [stdout] 64 | | _ => false, [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 59 - return match c { [INFO] [stdout] 60 - '}' => true, [INFO] [stdout] 61 - ']' => true, [INFO] [stdout] 62 - ':' => true, [INFO] [stdout] 63 - ',' => true, [INFO] [stdout] 64 - _ => false, [INFO] [stdout] 65 - } [INFO] [stdout] 59 + return matches!(c, '}' | ']' | ':' | ',') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / return match c { [INFO] [stdout] 70 | | '-' => true, [INFO] [stdout] 71 | | '0' => true, [INFO] [stdout] 72 | | '1' => true, [INFO] [stdout] ... | [INFO] [stdout] 81 | | _ => false, [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ match c { [INFO] [stdout] 70 + '-' => true, [INFO] [stdout] 71 + '0' => true, [INFO] [stdout] 72 + '1' => true, [INFO] [stdout] 73 + '2' => true, [INFO] [stdout] 74 + '3' => true, [INFO] [stdout] 75 + '4' => true, [INFO] [stdout] 76 + '5' => true, [INFO] [stdout] 77 + '6' => true, [INFO] [stdout] 78 + '7' => true, [INFO] [stdout] 79 + '8' => true, [INFO] [stdout] 80 + '9' => true, [INFO] [stdout] 81 + _ => false, [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/parser.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | return match c { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | '-' => true, [INFO] [stdout] 71 | | '0' => true, [INFO] [stdout] 72 | | '1' => true, [INFO] [stdout] ... | [INFO] [stdout] 81 | | _ => false, [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 69 - return match c { [INFO] [stdout] 70 - '-' => true, [INFO] [stdout] 71 - '0' => true, [INFO] [stdout] 72 - '1' => true, [INFO] [stdout] 73 - '2' => true, [INFO] [stdout] 74 - '3' => true, [INFO] [stdout] 75 - '4' => true, [INFO] [stdout] 76 - '5' => true, [INFO] [stdout] 77 - '6' => true, [INFO] [stdout] 78 - '7' => true, [INFO] [stdout] 79 - '8' => true, [INFO] [stdout] 80 - '9' => true, [INFO] [stdout] 81 - _ => false, [INFO] [stdout] 82 - } [INFO] [stdout] 69 + return matches!(c, '-' | '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parser.rs:111:73 [INFO] [stdout] | [INFO] [stdout] 111 | return Err(ParserError::ParseError("Could not parse JSON.", self.cursor.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return self.cursor >= self.input.chars().count(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return self.cursor >= self.input.chars().count(); [INFO] [stdout] 117 + self.cursor >= self.input.chars().count() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parser.rs:134:31 [INFO] [stdout] | [INFO] [stdout] 134 | let mut temp_cursor = self.cursor.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | / return match type_to_parse { [INFO] [stdout] 193 | | ParseType::Object => self.parse_object(), [INFO] [stdout] 194 | | ParseType::Number => self.parse_number(), [INFO] [stdout] 195 | | ParseType::String => self.parse_string(), [INFO] [stdout] ... | [INFO] [stdout] 199 | | _ => Err(ParserError::ParseError("parse_helper failed", self.cursor)), [INFO] [stdout] 200 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 ~ match type_to_parse { [INFO] [stdout] 193 + ParseType::Object => self.parse_object(), [INFO] [stdout] 194 + ParseType::Number => self.parse_number(), [INFO] [stdout] 195 + ParseType::String => self.parse_string(), [INFO] [stdout] 196 + ParseType::Boolean => self.parse_bool(), [INFO] [stdout] 197 + ParseType::Null => self.parse_null(), [INFO] [stdout] 198 + ParseType::Array => self.parse_array(), [INFO] [stdout] 199 + _ => Err(ParserError::ParseError("parse_helper failed", self.cursor)), [INFO] [stdout] 200 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:256:47 [INFO] [stdout] | [INFO] [stdout] 256 | if !self.consume_specific(',') && !(self.peek() == ']') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.peek() != ']')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parser.rs:319:19 [INFO] [stdout] | [INFO] [stdout] 319 | Err(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/parser.rs:23:53 [INFO] [stdout] | [INFO] [stdout] 23 | JsonValue::Bool(val) => JsonValue::Bool(val.clone()), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/parser.rs:24:57 [INFO] [stdout] | [INFO] [stdout] 24 | JsonValue::Number(val) => JsonValue::Number(val.clone()), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parser.rs:333:19 [INFO] [stdout] | [INFO] [stdout] 333 | Err(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parser.rs:347:19 [INFO] [stdout] | [INFO] [stdout] 347 | Err(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / return match c { [INFO] [stdout] 50 | | '\t' => true, [INFO] [stdout] 51 | | '\n' => true, [INFO] [stdout] 52 | | '\r' => true, [INFO] [stdout] 53 | | ' ' => true, [INFO] [stdout] 54 | | _ => false, [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ match c { [INFO] [stdout] 50 + '\t' => true, [INFO] [stdout] 51 + '\n' => true, [INFO] [stdout] 52 + '\r' => true, [INFO] [stdout] 53 + ' ' => true, [INFO] [stdout] 54 + _ => false, [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/parser.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | return match c { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | '\t' => true, [INFO] [stdout] 51 | | '\n' => true, [INFO] [stdout] 52 | | '\r' => true, [INFO] [stdout] 53 | | ' ' => true, [INFO] [stdout] 54 | | _ => false, [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 49 - return match c { [INFO] [stdout] 50 - '\t' => true, [INFO] [stdout] 51 - '\n' => true, [INFO] [stdout] 52 - '\r' => true, [INFO] [stdout] 53 - ' ' => true, [INFO] [stdout] 54 - _ => false, [INFO] [stdout] 55 - } [INFO] [stdout] 49 + return matches!(c, '\t' | '\n' | '\r' | ' ') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / return match c { [INFO] [stdout] 60 | | '}' => true, [INFO] [stdout] 61 | | ']' => true, [INFO] [stdout] 62 | | ':' => true, [INFO] [stdout] 63 | | ',' => true, [INFO] [stdout] 64 | | _ => false, [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ match c { [INFO] [stdout] 60 + '}' => true, [INFO] [stdout] 61 + ']' => true, [INFO] [stdout] 62 + ':' => true, [INFO] [stdout] 63 + ',' => true, [INFO] [stdout] 64 + _ => false, [INFO] [stdout] 65 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/parser.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | return match c { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | '}' => true, [INFO] [stdout] 61 | | ']' => true, [INFO] [stdout] 62 | | ':' => true, [INFO] [stdout] 63 | | ',' => true, [INFO] [stdout] 64 | | _ => false, [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 59 - return match c { [INFO] [stdout] 60 - '}' => true, [INFO] [stdout] 61 - ']' => true, [INFO] [stdout] 62 - ':' => true, [INFO] [stdout] 63 - ',' => true, [INFO] [stdout] 64 - _ => false, [INFO] [stdout] 65 - } [INFO] [stdout] 59 + return matches!(c, '}' | ']' | ':' | ',') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parser.rs:361:19 [INFO] [stdout] | [INFO] [stdout] 361 | Err(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / return match c { [INFO] [stdout] 70 | | '-' => true, [INFO] [stdout] 71 | | '0' => true, [INFO] [stdout] 72 | | '1' => true, [INFO] [stdout] ... | [INFO] [stdout] 81 | | _ => false, [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ match c { [INFO] [stdout] 70 + '-' => true, [INFO] [stdout] 71 + '0' => true, [INFO] [stdout] 72 + '1' => true, [INFO] [stdout] 73 + '2' => true, [INFO] [stdout] 74 + '3' => true, [INFO] [stdout] 75 + '4' => true, [INFO] [stdout] 76 + '5' => true, [INFO] [stdout] 77 + '6' => true, [INFO] [stdout] 78 + '7' => true, [INFO] [stdout] 79 + '8' => true, [INFO] [stdout] 80 + '9' => true, [INFO] [stdout] 81 + _ => false, [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/parser.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | return match c { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | '-' => true, [INFO] [stdout] 71 | | '0' => true, [INFO] [stdout] 72 | | '1' => true, [INFO] [stdout] ... | [INFO] [stdout] 81 | | _ => false, [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 69 - return match c { [INFO] [stdout] 70 - '-' => true, [INFO] [stdout] 71 - '0' => true, [INFO] [stdout] 72 - '1' => true, [INFO] [stdout] 73 - '2' => true, [INFO] [stdout] 74 - '3' => true, [INFO] [stdout] 75 - '4' => true, [INFO] [stdout] 76 - '5' => true, [INFO] [stdout] 77 - '6' => true, [INFO] [stdout] 78 - '7' => true, [INFO] [stdout] 79 - '8' => true, [INFO] [stdout] 80 - '9' => true, [INFO] [stdout] 81 - _ => false, [INFO] [stdout] 82 - } [INFO] [stdout] 69 + return matches!(c, '-' | '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parser.rs:399:19 [INFO] [stdout] | [INFO] [stdout] 399 | Err(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parser.rs:111:73 [INFO] [stdout] | [INFO] [stdout] 111 | return Err(ParserError::ParseError("Could not parse JSON.", self.cursor.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return self.cursor >= self.input.chars().count(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return self.cursor >= self.input.chars().count(); [INFO] [stdout] 117 + self.cursor >= self.input.chars().count() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parser.rs:413:19 [INFO] [stdout] | [INFO] [stdout] 413 | Err(_) => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parser.rs:134:31 [INFO] [stdout] | [INFO] [stdout] 134 | let mut temp_cursor = self.cursor.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserializer.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return match value { [INFO] [stdout] 16 | | JsonValue::String(value) => value, [INFO] [stdout] 17 | | JsonValue::Object(map) => self.deserialize_object(map), [INFO] [stdout] 18 | | JsonValue::Array(array) => self.deserialize_array(array), [INFO] [stdout] 19 | | _ => "".to_string(), [INFO] [stdout] 20 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ match value { [INFO] [stdout] 16 + JsonValue::String(value) => value, [INFO] [stdout] 17 + JsonValue::Object(map) => self.deserialize_object(map), [INFO] [stdout] 18 + JsonValue::Array(array) => self.deserialize_array(array), [INFO] [stdout] 19 + _ => "".to_string(), [INFO] [stdout] 20 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | / return match type_to_parse { [INFO] [stdout] 193 | | ParseType::Object => self.parse_object(), [INFO] [stdout] 194 | | ParseType::Number => self.parse_number(), [INFO] [stdout] 195 | | ParseType::String => self.parse_string(), [INFO] [stdout] ... | [INFO] [stdout] 199 | | _ => Err(ParserError::ParseError("parse_helper failed", self.cursor)), [INFO] [stdout] 200 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 ~ match type_to_parse { [INFO] [stdout] 193 + ParseType::Object => self.parse_object(), [INFO] [stdout] 194 + ParseType::Number => self.parse_number(), [INFO] [stdout] 195 + ParseType::String => self.parse_string(), [INFO] [stdout] 196 + ParseType::Boolean => self.parse_bool(), [INFO] [stdout] 197 + ParseType::Null => self.parse_null(), [INFO] [stdout] 198 + ParseType::Array => self.parse_array(), [INFO] [stdout] 199 + _ => Err(ParserError::ParseError("parse_helper failed", self.cursor)), [INFO] [stdout] 200 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:256:47 [INFO] [stdout] | [INFO] [stdout] 256 | if !self.consume_specific(',') && !(self.peek() == ']') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.peek() != ']')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserializer.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return match value { [INFO] [stdout] 16 | | JsonValue::String(value) => value, [INFO] [stdout] 17 | | JsonValue::Object(map) => self.deserialize_object(map), [INFO] [stdout] 18 | | JsonValue::Array(array) => self.deserialize_array(array), [INFO] [stdout] 19 | | _ => "".to_string(), [INFO] [stdout] 20 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ match value { [INFO] [stdout] 16 + JsonValue::String(value) => value, [INFO] [stdout] 17 + JsonValue::Object(map) => self.deserialize_object(map), [INFO] [stdout] 18 + JsonValue::Array(array) => self.deserialize_array(array), [INFO] [stdout] 19 + _ => "".to_string(), [INFO] [stdout] 20 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | fn combine_json(path: &str) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | fn combine_json(path: &str) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `Command { std: "docker" "inspect" "e9ccc26c4f05a26bf3b7f79ebd48eabf5fa160025447ce81bf704c54c3dfdac0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9ccc26c4f05a26bf3b7f79ebd48eabf5fa160025447ce81bf704c54c3dfdac0", kill_on_drop: false }` [INFO] [stdout] e9ccc26c4f05a26bf3b7f79ebd48eabf5fa160025447ce81bf704c54c3dfdac0