[INFO] cloning repository https://github.com/andreimatveyeu/rmixer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andreimatveyeu/rmixer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandreimatveyeu%2Frmixer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandreimatveyeu%2Frmixer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f494121e91fc4e8e55bad4e474cf712e7f2d470a [INFO] linting andreimatveyeu/rmixer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandreimatveyeu%2Frmixer" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/andreimatveyeu/rmixer [INFO] finished tweaking git repo https://github.com/andreimatveyeu/rmixer [INFO] tweaked toml for git repo https://github.com/andreimatveyeu/rmixer written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/andreimatveyeu/rmixer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/andreimatveyeu/rmixer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jack-sys v0.5.1 [INFO] [stderr] Downloaded rtrb v0.3.2 [INFO] [stderr] Downloaded jiff-static v0.2.17 [INFO] [stderr] Downloaded jack v0.13.3 [INFO] [stderr] Downloaded jiff v0.2.17 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 99a271eb1c68eea5a069ad9485cc36147b7e8ae21ce28c6a484097bbea080a60 [INFO] running `Command { std: "docker" "start" "-a" "99a271eb1c68eea5a069ad9485cc36147b7e8ae21ce28c6a484097bbea080a60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "99a271eb1c68eea5a069ad9485cc36147b7e8ae21ce28c6a484097bbea080a60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99a271eb1c68eea5a069ad9485cc36147b7e8ae21ce28c6a484097bbea080a60", kill_on_drop: false }` [INFO] [stdout] 99a271eb1c68eea5a069ad9485cc36147b7e8ae21ce28c6a484097bbea080a60 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 326f57655d8fee0221be85b85ae70e7fc8ea1441e723a774dcf76f0e7b57a651 [INFO] running `Command { std: "docker" "start" "-a" "326f57655d8fee0221be85b85ae70e7fc8ea1441e723a774dcf76f0e7b57a651", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling jack-sys v0.5.1 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Compiling jack v0.13.3 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking jiff v0.2.17 [INFO] [stderr] Checking rtrb v0.3.2 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling instability v0.3.10 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking rmixer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `is_stereo` is never used [INFO] [stdout] --> src/config.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | impl ChannelConfig { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] 44 | /// Returns true if this is a stereo channel (2 ports) [INFO] [stdout] 45 | pub fn is_stereo(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `total_input_ports` and `total_output_ports` are never used [INFO] [stdout] --> src/config.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 55 | impl Config { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 145 | pub fn total_input_ports(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | pub fn total_output_ports(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `port_count` and `timestamp` are never read [INFO] [stdout] --> src/ipc.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct MeterData { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 27 | pub port_count: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub timestamp: Instant, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MeterData` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `mono`, `stereo`, and `linear_to_db` are never used [INFO] [stdout] --> src/ipc.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 33 | impl MeterData { [INFO] [stdout] | -------------- associated functions in this implementation [INFO] [stdout] 34 | /// Create new meter data for a mono channel [INFO] [stdout] 35 | pub fn mono(channel_index: usize, peak: f32) -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn stereo(channel_index: usize, peak_l: f32, peak_r: f32) -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn linear_to_db(linear: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_input_effective_gain` is never used [INFO] [stdout] --> src/ipc.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 178 | impl MixerState { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 185 | pub fn get_input_effective_gain(&self, index: usize) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `METER_CHARS` is never used [INFO] [stdout] --> src/ui/widgets/meter.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const METER_CHARS: &[char] = &[' ', '▁', '▂', '▃', '▄', '▅', '▆', '▇', '█']; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HorizontalMeter` is never constructed [INFO] [stdout] --> src/ui/widgets/meter.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub struct HorizontalMeter { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `peak_hold`, `linear_to_db`, `db_to_position`, and `color_for_db` are never used [INFO] [stdout] --> src/ui/widgets/meter.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 155 | impl HorizontalMeter { [INFO] [stdout] | -------------------- associated items in this implementation [INFO] [stdout] 156 | pub fn new(level: f32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 165 | pub fn peak_hold(mut self, peak: f32) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 170 | fn linear_to_db(linear: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 178 | fn db_to_position(&self, db: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 183 | fn color_for_db(db: f32) -> Color { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `total_input_ports` and `total_output_ports` are never used [INFO] [stdout] --> src/config.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 55 | impl Config { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 145 | pub fn total_input_ports(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | pub fn total_output_ports(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `port_count` and `timestamp` are never read [INFO] [stdout] --> src/ipc.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct MeterData { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 27 | pub port_count: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub timestamp: Instant, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MeterData` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `mono`, `stereo`, and `linear_to_db` are never used [INFO] [stdout] --> src/ipc.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 33 | impl MeterData { [INFO] [stdout] | -------------- associated functions in this implementation [INFO] [stdout] 34 | /// Create new meter data for a mono channel [INFO] [stdout] 35 | pub fn mono(channel_index: usize, peak: f32) -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn stereo(channel_index: usize, peak_l: f32, peak_r: f32) -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn linear_to_db(linear: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_input_effective_gain` is never used [INFO] [stdout] --> src/ipc.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 178 | impl MixerState { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 185 | pub fn get_input_effective_gain(&self, index: usize) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `METER_CHARS` is never used [INFO] [stdout] --> src/ui/widgets/meter.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const METER_CHARS: &[char] = &[' ', '▁', '▂', '▃', '▄', '▅', '▆', '▇', '█']; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HorizontalMeter` is never constructed [INFO] [stdout] --> src/ui/widgets/meter.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub struct HorizontalMeter { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `peak_hold`, `linear_to_db`, `db_to_position`, and `color_for_db` are never used [INFO] [stdout] --> src/ui/widgets/meter.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 155 | impl HorizontalMeter { [INFO] [stdout] | -------------------- associated items in this implementation [INFO] [stdout] 156 | pub fn new(level: f32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 165 | pub fn peak_hold(mut self, peak: f32) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 170 | fn linear_to_db(linear: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 178 | fn db_to_position(&self, db: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 183 | fn color_for_db(db: f32) -> Color { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/audio/engine.rs:279:51 [INFO] [stdout] | [INFO] [stdout] 279 | let input_gain = if input_state.muted { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 280 | | 0.0 [INFO] [stdout] 281 | | } else if any_soloed && !input_state.soloed { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/audio/engine.rs:281:57 [INFO] [stdout] | [INFO] [stdout] 281 | } else if any_soloed && !input_state.soloed { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 282 | | 0.0 [INFO] [stdout] 283 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/audio/engine.rs:279:51 [INFO] [stdout] | [INFO] [stdout] 279 | let input_gain = if input_state.muted { [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 280 | | 0.0 [INFO] [stdout] 281 | | } else if any_soloed && !input_state.soloed { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/audio/engine.rs:281:57 [INFO] [stdout] | [INFO] [stdout] 281 | } else if any_soloed && !input_state.soloed { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 282 | | 0.0 [INFO] [stdout] 283 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `p` is used to index `peaks` [INFO] [stdout] --> src/audio/engine.rs:290:22 [INFO] [stdout] | [INFO] [stdout] 290 | for p in 0..port_count { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 290 - for p in 0..port_count { [INFO] [stdout] 290 + for (p, ) in peaks.iter_mut().enumerate().take(port_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `p` is used to index `peaks` [INFO] [stdout] --> src/audio/engine.rs:290:22 [INFO] [stdout] | [INFO] [stdout] 290 | for p in 0..port_count { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 290 - for p in 0..port_count { [INFO] [stdout] 290 + for (p, ) in peaks.iter_mut().enumerate().take(port_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `p` is only used to index `peaks` [INFO] [stdout] --> src/audio/engine.rs:343:22 [INFO] [stdout] | [INFO] [stdout] 343 | for p in 0..port_count { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 343 - for p in 0..port_count { [INFO] [stdout] 343 + for in peaks.iter_mut().take(port_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `p` is only used to index `peaks` [INFO] [stdout] --> src/audio/engine.rs:343:22 [INFO] [stdout] | [INFO] [stdout] 343 | for p in 0..port_count { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 343 - for p in 0..port_count { [INFO] [stdout] 343 + for in peaks.iter_mut().take(port_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `peaks` [INFO] [stdout] --> src/ipc.rs:139:18 [INFO] [stdout] | [INFO] [stdout] 139 | for i in 0..self.port_count { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 139 - for i in 0..self.port_count { [INFO] [stdout] 139 + for (i, ) in peaks.iter().enumerate().take(self.port_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `peaks` [INFO] [stdout] --> src/ipc.rs:139:18 [INFO] [stdout] | [INFO] [stdout] 139 | for i in 0..self.port_count { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 139 - for i in 0..self.port_count { [INFO] [stdout] 139 + for (i, ) in peaks.iter().enumerate().take(self.port_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/app.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 395 | / if self.selection_type == SelectionType::Input { [INFO] [stdout] 396 | | if self.selected_channel < self.mixer_state.inputs.len() { [INFO] [stdout] 397 | | self.mixer_state.inputs[self.selected_channel].soloed = [INFO] [stdout] 398 | | !self.mixer_state.inputs[self.selected_channel].soloed; [INFO] [stdout] ... | [INFO] [stdout] 403 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 395 ~ if self.selection_type == SelectionType::Input [INFO] [stdout] 396 ~ && self.selected_channel < self.mixer_state.inputs.len() { [INFO] [stdout] 397 | self.mixer_state.inputs[self.selected_channel].soloed = [INFO] [stdout] ... [INFO] [stdout] 401 | })?; [INFO] [stdout] 402 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/app.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 395 | / if self.selection_type == SelectionType::Input { [INFO] [stdout] 396 | | if self.selected_channel < self.mixer_state.inputs.len() { [INFO] [stdout] 397 | | self.mixer_state.inputs[self.selected_channel].soloed = [INFO] [stdout] 398 | | !self.mixer_state.inputs[self.selected_channel].soloed; [INFO] [stdout] ... | [INFO] [stdout] 403 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 395 ~ if self.selection_type == SelectionType::Input [INFO] [stdout] 396 ~ && self.selected_channel < self.mixer_state.inputs.len() { [INFO] [stdout] 397 | self.mixer_state.inputs[self.selected_channel].soloed = [INFO] [stdout] ... [INFO] [stdout] 401 | })?; [INFO] [stdout] 402 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/app.rs:567:17 [INFO] [stdout] | [INFO] [stdout] 567 | / is_selected_section && is_input == (self.selection_type == SelectionType::Input) [INFO] [stdout] 568 | | && i == self.selected_channel [INFO] [stdout] 569 | | && is_selected_section; [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 567 - is_selected_section && is_input == (self.selection_type == SelectionType::Input) [INFO] [stdout] 568 - && i == self.selected_channel [INFO] [stdout] 569 - && is_selected_section; [INFO] [stdout] 567 + !(!is_selected_section || is_input != (self.selection_type == SelectionType::Input) || i != self.selected_channel); [INFO] [stdout] | [INFO] [stdout] 567 - is_selected_section && is_input == (self.selection_type == SelectionType::Input) [INFO] [stdout] 568 - && i == self.selected_channel [INFO] [stdout] 569 - && is_selected_section; [INFO] [stdout] 567 + is_selected_section && is_input == (self.selection_type == SelectionType::Input) && i == self.selected_channel; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/app.rs:567:17 [INFO] [stdout] | [INFO] [stdout] 567 | / is_selected_section && is_input == (self.selection_type == SelectionType::Input) [INFO] [stdout] 568 | | && i == self.selected_channel [INFO] [stdout] 569 | | && is_selected_section; [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 567 - is_selected_section && is_input == (self.selection_type == SelectionType::Input) [INFO] [stdout] 568 - && i == self.selected_channel [INFO] [stdout] 569 - && is_selected_section; [INFO] [stdout] 567 + !(!is_selected_section || is_input != (self.selection_type == SelectionType::Input) || i != self.selected_channel); [INFO] [stdout] | [INFO] [stdout] 567 - is_selected_section && is_input == (self.selection_type == SelectionType::Input) [INFO] [stdout] 568 - && i == self.selected_channel [INFO] [stdout] 569 - && is_selected_section; [INFO] [stdout] 567 + is_selected_section && is_input == (self.selection_type == SelectionType::Input) && i == self.selected_channel; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.33s [INFO] running `Command { std: "docker" "inspect" "326f57655d8fee0221be85b85ae70e7fc8ea1441e723a774dcf76f0e7b57a651", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "326f57655d8fee0221be85b85ae70e7fc8ea1441e723a774dcf76f0e7b57a651", kill_on_drop: false }` [INFO] [stdout] 326f57655d8fee0221be85b85ae70e7fc8ea1441e723a774dcf76f0e7b57a651