[INFO] cloning repository https://github.com/andjnewb/rust_game_of_life [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/andjnewb/rust_game_of_life" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandjnewb%2Frust_game_of_life", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandjnewb%2Frust_game_of_life'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 422b277c0943498ad1aa89777c98b6221d569f5e [INFO] linting andjnewb/rust_game_of_life against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fandjnewb%2Frust_game_of_life" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/andjnewb/rust_game_of_life [INFO] finished tweaking git repo https://github.com/andjnewb/rust_game_of_life [INFO] tweaked toml for git repo https://github.com/andjnewb/rust_game_of_life written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/andjnewb/rust_game_of_life on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/andjnewb/rust_game_of_life already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded terminfo v0.8.0 [INFO] [stderr] Downloaded clearscreen v2.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5093a8df2e96e14a6a8cc966116ec72a3dec4366a85c36cd25960ce4c60e7d6d [INFO] running `Command { std: "docker" "start" "-a" "5093a8df2e96e14a6a8cc966116ec72a3dec4366a85c36cd25960ce4c60e7d6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5093a8df2e96e14a6a8cc966116ec72a3dec4366a85c36cd25960ce4c60e7d6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5093a8df2e96e14a6a8cc966116ec72a3dec4366a85c36cd25960ce4c60e7d6d", kill_on_drop: false }` [INFO] [stdout] 5093a8df2e96e14a6a8cc966116ec72a3dec4366a85c36cd25960ce4c60e7d6d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b785b4108703d7103188d109fd7b053f95a74620df37d51ca57a0ef2e4d93efd [INFO] running `Command { std: "docker" "start" "-a" "b785b4108703d7103188d109fd7b053f95a74620df37d51ca57a0ef2e4d93efd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling terminfo v0.8.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking thiserror v1.0.56 [INFO] [stderr] Checking clearscreen v2.0.1 [INFO] [stderr] Checking rust_game_of_life v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufReader` [INFO] [stdout] --> src/main.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{prelude::*, BufReader}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::num::ParseIntError` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::num::ParseIntError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `coord` should have an upper camel case name [INFO] [stdout] --> src/main.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | struct coord [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Coord` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:131:11 [INFO] [stdout] | [INFO] [stdout] 131 | if(test.unwrap().0 >= self.dims.0 || test.unwrap().1 >= self.dims.1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 131 - if(test.unwrap().0 >= self.dims.0 || test.unwrap().1 >= self.dims.1) [INFO] [stdout] 131 + if test.unwrap().0 >= self.dims.0 || test.unwrap().1 >= self.dims.1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | if(self.cells[res.unwrap().0][res.unwrap().1]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 160 - if(self.cells[res.unwrap().0][res.unwrap().1]) [INFO] [stdout] 160 + if self.cells[res.unwrap().0][res.unwrap().1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `prelude` [INFO] [stdout] --> src/main.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{prelude::*, BufReader}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufReader` [INFO] [stdout] --> src/main.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{prelude::*, BufReader}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::num::ParseIntError` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::num::ParseIntError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `coord` should have an upper camel case name [INFO] [stdout] --> src/main.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | struct coord [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Coord` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:131:11 [INFO] [stdout] | [INFO] [stdout] 131 | if(test.unwrap().0 >= self.dims.0 || test.unwrap().1 >= self.dims.1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 131 - if(test.unwrap().0 >= self.dims.0 || test.unwrap().1 >= self.dims.1) [INFO] [stdout] 131 + if test.unwrap().0 >= self.dims.0 || test.unwrap().1 >= self.dims.1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | if(self.cells[res.unwrap().0][res.unwrap().1]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 160 - if(self.cells[res.unwrap().0][res.unwrap().1]) [INFO] [stdout] 160 + if self.cells[res.unwrap().0][res.unwrap().1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/main.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | let args: Vec = env::args().collect(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `grid` is never read [INFO] [stdout] --> src/main.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | grid = Grid { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `WALL` is never used [INFO] [stdout] --> src/main.rs:30:7 [INFO] [stdout] | [INFO] [stdout] 30 | const WALL: char = '+'; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::isize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `isize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return true; [INFO] [stdout] 144 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | return neighbors; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return neighbors; [INFO] [stdout] 168 + neighbors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:153:38 [INFO] [stdout] | [INFO] [stdout] 153 | if Self::check_valid_dir(&self, cell, direction) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/main.rs:156:38 [INFO] [stdout] | [INFO] [stdout] 156 | let d = coord {loc: (direction.0 as isize, direction.1 as isize)}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `direction.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/main.rs:156:60 [INFO] [stdout] | [INFO] [stdout] 156 | let d = coord {loc: (direction.0 as isize, direction.1 as isize)}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `direction.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:185:20 [INFO] [stdout] | [INFO] [stdout] 185 | if *col == true { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:211:12 [INFO] [stdout] | [INFO] [stdout] 211 | if ( live && (num_living_neighbors == 2)) || ( live && (num_living_neighbors == 3)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 211 - if ( live && (num_living_neighbors == 2)) || ( live && (num_living_neighbors == 3)) [INFO] [stdout] 211 + if !(!live || num_living_neighbors != 2 && num_living_neighbors != 3) [INFO] [stdout] | [INFO] [stdout] 211 - if ( live && (num_living_neighbors == 2)) || ( live && (num_living_neighbors == 3)) [INFO] [stdout] 211 + if ((num_living_neighbors == 3) || (num_living_neighbors == 2)) && live [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | return live; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return live; [INFO] [stdout] 227 + live [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: expression with side effects as the initial value in a zero-sized array initializer [INFO] [stdout] --> src/main.rs:258:16 [INFO] [stdout] | [INFO] [stdout] 258 | cells: vec![vec![false; 0]; 0], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_repeat_side_effects [INFO] [stdout] = note: `#[warn(clippy::zero_repeat_side_effects)]` on by default [INFO] [stdout] help: consider performing the side effect separately [INFO] [stdout] | [INFO] [stdout] 258 ~ cells: { [INFO] [stdout] 259 + vec![false; 0]; [INFO] [stdout] 260 + vec![] as std::vec::Vec> [INFO] [stdout] 261 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dimY` should have a snake case name [INFO] [stdout] --> src/main.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | let dimY = cells.len(); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `dim_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dimX` should have a snake case name [INFO] [stdout] --> src/main.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | let dimX = cells[0].len(); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `dim_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `prelude` [INFO] [stdout] --> src/main.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{prelude::*, BufReader}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/main.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | let args: Vec = env::args().collect(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `grid` is never read [INFO] [stdout] --> src/main.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | grid = Grid { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `WALL` is never used [INFO] [stdout] --> src/main.rs:30:7 [INFO] [stdout] | [INFO] [stdout] 30 | const WALL: char = '+'; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::isize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `isize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return true; [INFO] [stdout] 144 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | return neighbors; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return neighbors; [INFO] [stdout] 168 + neighbors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:153:38 [INFO] [stdout] | [INFO] [stdout] 153 | if Self::check_valid_dir(&self, cell, direction) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/main.rs:156:38 [INFO] [stdout] | [INFO] [stdout] 156 | let d = coord {loc: (direction.0 as isize, direction.1 as isize)}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `direction.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/main.rs:156:60 [INFO] [stdout] | [INFO] [stdout] 156 | let d = coord {loc: (direction.0 as isize, direction.1 as isize)}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `direction.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:185:20 [INFO] [stdout] | [INFO] [stdout] 185 | if *col == true { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:211:12 [INFO] [stdout] | [INFO] [stdout] 211 | if ( live && (num_living_neighbors == 2)) || ( live && (num_living_neighbors == 3)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 211 - if ( live && (num_living_neighbors == 2)) || ( live && (num_living_neighbors == 3)) [INFO] [stdout] 211 + if !(!live || num_living_neighbors != 2 && num_living_neighbors != 3) [INFO] [stdout] | [INFO] [stdout] 211 - if ( live && (num_living_neighbors == 2)) || ( live && (num_living_neighbors == 3)) [INFO] [stdout] 211 + if ((num_living_neighbors == 3) || (num_living_neighbors == 2)) && live [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | return live; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return live; [INFO] [stdout] 227 + live [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: expression with side effects as the initial value in a zero-sized array initializer [INFO] [stdout] --> src/main.rs:258:16 [INFO] [stdout] | [INFO] [stdout] 258 | cells: vec![vec![false; 0]; 0], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_repeat_side_effects [INFO] [stdout] = note: `#[warn(clippy::zero_repeat_side_effects)]` on by default [INFO] [stdout] help: consider performing the side effect separately [INFO] [stdout] | [INFO] [stdout] 258 ~ cells: { [INFO] [stdout] 259 + vec![false; 0]; [INFO] [stdout] 260 + vec![] as std::vec::Vec> [INFO] [stdout] 261 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dimY` should have a snake case name [INFO] [stdout] --> src/main.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | let dimY = cells.len(); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `dim_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dimX` should have a snake case name [INFO] [stdout] --> src/main.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | let dimX = cells[0].len(); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `dim_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.37s [INFO] running `Command { std: "docker" "inspect" "b785b4108703d7103188d109fd7b053f95a74620df37d51ca57a0ef2e4d93efd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b785b4108703d7103188d109fd7b053f95a74620df37d51ca57a0ef2e4d93efd", kill_on_drop: false }` [INFO] [stdout] b785b4108703d7103188d109fd7b053f95a74620df37d51ca57a0ef2e4d93efd